fix(gha): add auto-approve + update codeowners #49
Conversation
WalkthroughThis change updates repository metadata and workflow automation. In the Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
.github/workflows/trunk-upgrade.yaml (1)
44-67: Infinite loop risk – add an upper bound or usegh pr checks --watch
while truepolls every 30 s with no escape hatch. If a required check is stuck in the “pending” state the job will run until the 6-hour GitHub Actions hard timeout, wasting CI minutes.Suggested minimal safety net:
-while true; do +MAX_ATTEMPTS=120 # 1 hour at 30 s intervals +ATTEMPT=0 +while [ "$ATTEMPT" -lt "$MAX_ATTEMPTS" ]; do ... - else - echo "Some required checks are still running or pending. Retrying in 30s..." - sleep 30 - fi + else + echo "Some required checks are still running or pending. Retrying in 30 s..." + sleep 30 + ATTEMPT=$((ATTEMPT + 1)) + fi done + +echo "Timeout waiting for status checks (> $((MAX_ATTEMPTS*30/60)) min)." +exit 1Alternatively, replace the whole loop with:
gh pr checks "$PR_NUMBER" --watch --requiredwhich blocks until all required checks succeed or fail and exits appropriately.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/CODEOWNERS(1 hunks).github/workflows/trunk-upgrade.yaml(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: Gowiem
PR: masterpointio/terraform-spacelift-automation#19
File: .github/workflows/renovate.json5:7-7
Timestamp: 2024-12-22T19:36:59.636Z
Learning: Some of Gowiem's repositories still use 'master' as the primary branch, so they intentionally keep "master" in Renovate's baseBranches for a shared configuration.
🔇 Additional comments (1)
.github/workflows/trunk-upgrade.yaml (1)
40-42: Double-check secret & scopes forMASTERPOINT_TEAM_PAT
ghwill perform both a review and a merge. The token therefore needs repo → pull_request:write + contents:write scopes (and ideally nothing more).
Please verify that the secret exists at the org level and has the minimal scopes required; otherwise this step will still fail even though the workflow now passes status checks.
|
|
||
| # These owners will be the default owners for everything | ||
| * @masterpointio/masterpoint-open-source | ||
| * @masterpointio/masterpoint-open-source @masterpoint-team |
There was a problem hiding this comment.
Invalid team slug – missing organization prefix
@masterpoint-team lacks the @org/ prefix required by GitHub CODEOWNERS. As-is, ownership resolution will silently fail and PRs will still demand a manual review.
-* @masterpointio/masterpoint-open-source @masterpoint-team
+* @masterpointio/masterpoint-open-source @masterpointio/masterpoint-team📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * @masterpointio/masterpoint-open-source @masterpoint-team | |
| * @masterpointio/masterpoint-open-source @masterpointio/masterpoint-team |
🤖 Prompt for AI Agents
In the .github/CODEOWNERS file at line 7, the team slug '@masterpoint-team' is
missing the required organization prefix. Update '@masterpoint-team' to include
the organization prefix, changing it to '@masterpointio/masterpoint-team' to
ensure proper ownership resolution by GitHub.
🤖 I have created a release *beep* *boop* --- ## [0.8.1](v0.8.0...v0.8.1) (2025-07-01) ### Bug Fixes * add cursor to ignored ai code gen ([#46](#46)) ([57f59b8](57f59b8)) * **gha:** add auto-approve + update codeowners ([#49](#49)) ([da097cc](da097cc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: masterpointbot[bot] <177651640+masterpointbot[bot]@users.noreply.github.com>
what
why
references
Summary by CodeRabbit