-
Notifications
You must be signed in to change notification settings - Fork 2
fix(gha): use app–generated token to create release-please PRs #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new step has been added to the GitHub Actions workflow for the Suggested reviewers
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/release-please.yaml (2)
17-23
: Pin and update the GitHub App Token action responsibly
You’ve pinnedtibdex/github-app-token
to a specific commit which ensures reproducibility—nice! Consider using a stable release tag (e.g.,@v3
) or periodically updating the SHA to pick up bug fixes and security patches.
26-26
: Lock down default GITHUB_TOKEN scopes
Now that you’re supplying an App-generated token for PR operations, you can tighten the workflow’s defaultpermissions
(e.g.,contents: read
andpull-requests: none
) to follow least-privilege practices.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/release-please.yaml
(1 hunks)
🔇 Additional comments (1)
.github/workflows/release-please.yaml (1)
17-23
: Verify App installation permissions
Ensure theMP_BOT
GitHub App is installed with the correct repository scopes (write access to contents and pull-requests) so the generated token can create and update your release-please PRs.
🤖 I have created a release *beep* *boop* --- ## [0.8.0](v0.7.1...v0.8.0) (2025-06-17) ### Features * **INT-83:** dial in configs for tflint ([#39](#39)) ([60c58f4](60c58f4)) ### Bug Fixes * **gha-trunk-upgrade:** wait for checks and merge with admin ([#42](#42)) ([0c399bc](0c399bc)) * **gha:** use app–generated token to create release-please PRs ([#45](#45)) ([a0c0d46](a0c0d46)) * linter configs to root folder ([#44](#44)) ([7aacf9f](7aacf9f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: masterpointbot[bot] <177651640+masterpointbot[bot]@users.noreply.github.com>
what
why
When use the repository’s GITHUB_TOKEN to perform tasks on behalf of the GitHub Actions app (the github-actions[bot]), events triggered by that token will not create new workflow runs, with the sole exceptions of workflow_dispatch and repository_dispatch. This is an intentional safeguard to avoid accidental infinite loops of workflows triggering themselves
github.com.
Pull requests created programmatically by the github-actions[bot] (i.e., using GITHUB_TOKEN) do not fire the pull_request event, so any workflow with on: pull_request will not start. Even though the PR appears normally, downstream checks see no trigger and remain stuck, see chore(main): release 0.8.0 #43
references
Summary by CodeRabbit