Skip to content

fix(gha-lint): allow lint workflow to be triggered by github-actions[bot] #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

gberenice
Copy link
Member

@gberenice gberenice commented Jun 10, 2025

what

  • Use the on: pull_request_target event in lint workflow.

why

  • GitHub Actions workflows configured with on: pull_request do not trigger for Pull Requests created by the default github-actions[bot] user. This leads to PRs being "blocked" or "pending checks" indefinitely, if repository rulesets require those checks.
  • pull_request_target runs from the base repository's context, allowing it to be triggered by github-actions[bot].

references

Summary by CodeRabbit

  • Chores
    • Updated the trigger for the lint workflow to improve how and when it runs on pull requests.

@gberenice gberenice requested a review from a team as a code owner June 10, 2025 16:12
Copy link

coderabbitai bot commented Jun 10, 2025

Walkthrough

The workflow configuration for linting in the GitHub Actions setup was updated to change its trigger event from pull_request to pull_request_target. This adjustment alters the event context in which the lint workflow runs, but no modifications were made to the workflow's logic, permissions, or job steps. No exported or public entities in the codebase were affected by this change.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/lint.yaml (1)

7-7: Ensure security when using pull_request_target
This switch correctly allows the lint workflow to run on PRs by github-actions[bot]. However, pull_request_target grants elevated privileges and can expose secrets when checking out PR code. Since this is purely a lint job:

  • Use actions/checkout@v4 with persist-credentials: false.
  • Remove any unnecessary permissions or secrets.
  • Optionally add an if: github.actor == 'github-actions[bot]' guard to restrict execution.
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 547db0e and be66cd8.

📒 Files selected for processing (1)
  • .github/workflows/lint.yaml (1 hunks)

Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gberenice gberenice merged commit d68ff09 into main Jun 11, 2025
2 checks passed
@gberenice gberenice deleted the fix/allow-lint-workflow-for-bots branch June 11, 2025 10:18
gberenice pushed a commit that referenced this pull request Jun 11, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.7.1](v0.7.0...v0.7.1)
(2025-06-11)


### Bug Fixes

* **gha-lint:** allow lint workflow to be triggered by
github-actions[bot]
([#41](#41))
([d68ff09](d68ff09))
* use `pull_request_target` to allow permissions
([#37](#37))
([5292ae3](5292ae3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants