-
Notifications
You must be signed in to change notification settings - Fork 2
chore: trunk ignore changelog due to release-plz #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes in this pull request involve modifications to the Changes
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (1).trunk/trunk.yaml (1)
The implementation correctly excludes the CHANGELOG.md file from prettier and markdownlint checks, which aligns with the PR objective since release-please manages this file with its own formatting. Let's verify the configuration: ✅ Verification successfulConfiguration verified and correctly implemented The trunk.yaml configuration is properly structured with the ignore rule for CHANGELOG.md, and the CHANGELOG.md file exists in the repository. The configuration will successfully prevent prettier and markdownlint from processing the changelog, allowing release-please to manage it independently. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify trunk configuration and ensure CHANGELOG.md is properly ignored
# Check if the ignore rule is properly parsed
trunk check --config-only 2>&1 | grep -A 2 "ignore:"
# Verify CHANGELOG.md is listed in ignored files
trunk list-files --ignored-files 2>&1 | grep "CHANGELOG.md"
Length of output: 102 Script: #!/bin/bash
# Let's verify the trunk configuration structure and CHANGELOG.md handling differently
# Check if trunk.yaml exists and view its content
cat .trunk/trunk.yaml
# Check if CHANGELOG.md exists
ls CHANGELOG.md 2>/dev/null
# Look for any other trunk ignore configurations
rg -l "ignore.*CHANGELOG.md" .trunk/
Length of output: 1424 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title release-"plz" looks so funny to me 😆
@oycyc haha yeah, I had it written as |
what
why
references
Summary by CodeRabbit
New Features
CHANGELOG.md
file to streamline management.Documentation