Skip to content

feat: revised tests while writing article about the tests we added in this module #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2025
Merged

feat: revised tests while writing article about the tests we added in this module #15

merged 2 commits into from
Jun 20, 2025

Conversation

westonplatter
Copy link
Member

what

  • I previously wrote some vauge tests in the repo and am updating them to test things (I think) better.
  • add assertions in tests - testing for just success is less helpful
  • removed un-useful data in group_member_type_invalid

@westonplatter westonplatter requested a review from a team as a code owner June 19, 2025 18:41
@westonplatter westonplatter merged commit 933242a into main Jun 20, 2025
5 checks passed
@westonplatter westonplatter deleted the feat/better-tests branch June 20, 2025 15:01
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gberenice gberenice gberenice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@westonplatter @gberenice