-
Notifications
You must be signed in to change notification settings - Fork 0
fix: docs, polish readme to include user custom_schemas for the SSO setup #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update the documentation and example configuration for Google Workspace user management. The README.md was revised for improved clarity, including a reformatted provider block and a new example demonstrating the use of the custom_schemas attribute to assign complex role information to users. In the examples/import-existing-org/users.yaml file, the schema names in the custom_schemas section for a specific user were renamed for consistency, while the schema values themselves remained unchanged. No exported or public entities were altered. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
examples/import-existing-org/users.yaml (1)
13-16
: Schema names simplified for clarity
Nice cleanup—AWS_SSO_for_Client1
andAWS_SSO_for_Client2
are more concise. To prevent any confusion, consider aligning these with the HCL example inREADME.md
(which usesClient1
/Client2
), or add a brief note explaining why the prefix is included here.README.md (1)
69-82
: Great addition:custom_schemas
example
This HCL snippet effectively shows how to pass complex user attributes. To help users avoid common pitfalls, you might add a note that theschema_name
must match an existing Google Workspace schema and thatschema_values
should be valid JSON strings.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
README.md
(2 hunks)examples/import-existing-org/users.yaml
(1 hunks)
🔇 Additional comments (1)
README.md (1)
32-35
: Provider comment reformatted for readability
The inline comments aroundcustomer_id
are now well-wrapped and clearly reference the Google API behavior. This enhances maintainability.
what
why
Summary by CodeRabbit
Documentation
Style