Skip to content

Fix naming KeyboardAzertyFr_ from the integration of 1.0.2 of the ori… #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

Annubis45
Copy link

…ginal lib

There was a typo in the integration of the version 1.0.2. A renaming from Keyboard_ to KeyboardAzertyFr_ was forgotten.

@martin-leo martin-leo merged commit 8dfc3ad into martin-leo:master Jun 1, 2021
@martin-leo
Copy link
Owner

Thanks for the request. I updated the 1.0.2 release and asked it to be updated, hope it will be done soon.

@ysard
Copy link

ysard commented Sep 22, 2022

Hi @martin-leo , could you sync your repository status with the Arduino one by making a new release (1.0.2.a for example) ?
This current issue is not included in the 1.0.2 version. So the lib can't be compiled for now.
Thanks for your work :)

@martin-leo
Copy link
Owner

I do not have much time to work on this at the moment, I send you an invitation if you want to do this yourself.

By the way it seems that the original library now support french keyboards ?

@ysard
Copy link

ysard commented Sep 25, 2022

Indeed, I checked the original library, the fr layout is well supported (as well as other languages).
KeyboardAzertyFr is a bit late/behind but after some short tests I don't see any obvious difference;
except :

  • a regression for both in the management of ^ and ¨ accents since last commits, inherited from the original version (Fix French circumflex & umlaut accents arduino-libraries/Keyboard#73) ; KeyboardAzertyFr uses in 1.0.2 the 0x2f key and it's correct.
  • a quite heavier lib on a test project :
    • FR layout + Arduino Keyboard = 8890 bytes for sketch + 478 bytes for variables
    • KeyboardAzertyFr 1.0.2 = 8150 + 468
    • Default layout + Arduino Keyboard = 8762 + 478
    • KeyboardAzertyFr synced with master = 8210 + 468

So KeyboardAzertyFr is still useful if you are out of memory.

Short test:

char alphanum [] = "abcdefghijklmnopqrstuvwxyz1234567890-=";
char extra [] = "&\"'(-_)=^ $*<,;:!";
char extra_altgr [] = "~#{[|\\@]}";
char extra_shift [] = "+%>?./]^i_";

Keyboard.println("un oiseau : ^ o^ ");

Keyboard.println(alphanum);
Keyboard.println(extra);
Keyboard.println(extra_altgr);
Keyboard.println(extra_shift);

Keyboard.press(KEY_LEFT_SHIFT);
Keyboard.press('^');
Keyboard.releaseAll();
Keyboard.write('i');

Should give:

un oiseau : ^o^
abcdefghijklmnopqrstuvwxyz1234567890-=
&"'(-_)=^$*<,;:!
~#{[|\@]}
+%>?./]î_
ï
ö

Thank you for your confidence.
I could at least push a 1.0.2.a tag to fix the current pb.
However I don't have time to make an fully exhaustive comparison between the last added commit here and the original lib to identify the version number closest to the state of KeyboardAzertyFr.
At the moment it seems to be at least version 1.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants