feat(#305): add support for PostGIS's types of GEOGRAPHY, GEOMETRY and their array variations
#421
Conversation
|
Warning Rate limit exceeded@martin-georgiev has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 9 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughAdds PostGIS support across CI, dev, and docs; introduces Geography/Geometry DBAL types and their array counterparts; adds WKT/EWKT value object, enums, and exceptions; extends unit/integration tests including new array test utilities; reworks integration test harness; updates type registration and mappings. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Test as Test/Client
participant DBAL as Doctrine DBAL
participant Type as Geometry/Geography Type
participant VO as WktSpatialData
participant PG as PostgreSQL+PostGIS
Test->>DBAL: bind parameter (VO|string) with custom type
alt PHP -> DB
DBAL->>Type: convertToDatabaseValue(VO)
Type->>Type: validate instance
Type->>VO: __toString() (WKT/EWKT)
Type-->>DBAL: WKT/EWKT string
DBAL->>PG: INSERT ... (value)
else DB -> PHP
DBAL->>PG: SELECT ...
PG-->>DBAL: text geometry/geography
DBAL->>Type: convertToPHPValue(text)
Type->>Type: validate string
Type->>VO: fromWkt(text)
VO-->>Type: WktSpatialData
Type-->>DBAL: VO
end
sequenceDiagram
autonumber
actor Test as Test/Client
participant DBAL as Doctrine DBAL
participant SAT as SpatialArrayType (GeometryArray/GeographyArray)
participant VO as WktSpatialData
participant PG as PostgreSQL+PostGIS
Test->>DBAL: execute INSERT using ARRAY[?::GEOMETRY,...]
loop per element
DBAL->>SAT: transformArrayItemForPostgres(VO)
SAT->>SAT: validate item (VO)
SAT-->>DBAL: element text (WKT/EWKT)
end
DBAL->>PG: INSERT ... ARRAY[...]
DBAL->>PG: SELECT ... (custom ST_AsText/SRID rendering)
PG-->>DBAL: array literal
DBAL->>SAT: transformPostgresArrayToPHPArray(array text)
SAT->>SAT: split items, normalize modifiers
SAT->>VO: fromWkt(item text)
SAT-->>DBAL: VO[]
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (10)
docker-compose.yml (2)
3-3: Parameterize the PostGIS version in the image tag for parity with CI and docsCI appears to test multiple PostGIS versions (e.g., 3.4, 3.5). Making the PostGIS version configurable avoids drift and eases local repros.
- image: postgis/postgis:${POSTGRES_VERSION:-17}-3.4 + image: postgis/postgis:${POSTGRES_VERSION:-17}-${POSTGIS_VERSION:-3.4}
8-8: Confirm whether setting TZ here is necessary for your use caseSetting TZ at the container level may not affect PostgreSQL's runtime timezone (which is controlled via the GUC
timezone). If your goal is DB timestamps in UTC, consider verifying PostgresSHOW timezoneor configuring it explicitly.Would you like me to propose a minimal
postgresql.confoverride or init script to enforcetimezone = 'UTC'at the database level?docs/CONTRIBUTING.md (1)
120-120: Avoid hardcoding the PostGIS minor version to reduce future driftDevenv uses
extensions.postgisfrom Nixpkgs, which may resolve to 3.4, 3.5, etc., depending on the channel. Either pin it in Nix or generalize the wording.-- PostgreSQL 17 with PostGIS 3.4, started by `devenv up`. +- PostgreSQL 17 with PostGIS, started by `devenv up`.If you prefer pinning to 3.4, we can adjust
devenv.nixto lock the extension version.README.md (1)
58-60: List array variants for PostGIS types for consistency with other type bulletsOther bullets include array variants (e.g.,
point[]). If arrays are supported (they are mentioned in docs), reflecting them here improves consistency.- - PostGIS Geometry (`geometry`) - - PostGIS Geography (`geography`) + - PostGIS Geometry (`geometry`, `geometry[]`) + - PostGIS Geography (`geography`, `geography[]`)tests/Integration/README.md (2)
24-24: Parameterize the image and port in the plain Docker example for consistencyMirror the docker-compose flexibility so users can easily try different PG/PostGIS versions and host ports.
-docker run --name postgres-doctrine-test -e POSTGRES_PASSWORD=postgres -e POSTGRES_USER=postgres -e POSTGRES_DB=postgres_doctrine_test -p 5432:5432 -d postgis/postgis:17-3.4 +docker run --name postgres-doctrine-test \ + -e POSTGRES_PASSWORD=postgres \ + -e POSTGRES_USER=postgres \ + -e POSTGRES_DB=postgres_doctrine_test \ + -p ${POSTGRES_PORT:-5432}:5432 \ + -d postgis/postgis:${POSTGRES_VERSION:-17}-${POSTGIS_VERSION:-3.4}
69-69: Align README PostGIS versions with CI matrixThe integration-tests README currently mentions only PostGIS 3.4, but the GitHub Actions matrix runs against both 3.4 and 3.5. Update the text for consistency:
File: tests/Integration/README.md:69
-These tests are automatically run in GitHub Actions against PostgreSQL 16 and 17 with PostGIS 3.4 for all supported PHP versions. +These tests are automatically run in GitHub Actions against PostgreSQL 16 and 17 with PostGIS 3.4 and 3.5 for all supported PHP versions.docs/USE-CASES-AND-EXAMPLES.md (3)
144-156: DDL: Recommend specifying subtype + SRID and ensuring the PostGIS extension is createdFor real-world PostGIS usage, it’s better to declare geometry/geography with explicit subtype and SRID, and to ensure the extension is enabled in the target database. This avoids implicit defaults and surprises with spatial indexes/functions.
Apply this doc tweak to the SQL snippet:
-```sql -CREATE TABLE places ( - id SERIAL PRIMARY KEY, - location GEOMETRY, - boundary GEOGRAPHY -); -``` +```sql +-- Ensure PostGIS is enabled in the database +CREATE EXTENSION IF NOT EXISTS postgis; + +CREATE TABLE places ( + id SERIAL PRIMARY KEY, + -- Explicit subtype and SRID recommended for correctness and indexing + location geometry(Point, 4326), + boundary geography(Polygon, 4326) +); +```
158-166: PHP example: clarify type registration/mapping and value object constructor
- Type::addType is fine, but many setups also require mapping the PostgreSQL types to the Doctrine platform (depending on integration). Consider showing that explicitly.
- The sample constructs EWKT (SRID=…;POINT …). Please verify the constructor name accepts EWKT. If the method is strictly “fromWKT”, either use pure WKT or switch to a “fromEwkt” helper if available.
Proposed doc tweak for the PHP example to be more complete:
```php use Doctrine\DBAL\Types\Type; use MartinGeorgiev\Doctrine\DBAL\Types\ValueObject\Geometry as GeometryValueObject; Type::addType('geography', MartinGeorgiev\Doctrine\DBAL\Types\Geography::class); Type::addType('geometry', MartinGeorgiev\Doctrine\DBAL\Types\Geometry::class); -$location = GeometryValueObject::fromWKT('SRID=4326;POINT(-122.4194 37.7749)'); +// If your bootstrapping does not auto-map DB types, explicitly map them: +// $platform = $conn->getDatabasePlatform(); +// $platform->registerDoctrineTypeMapping('geography', 'geography'); +// $platform->registerDoctrineTypeMapping('geometry', 'geometry'); + +// Verify whether the constructor expects WKT or EWKT: +// - If EWKT is supported, keep the SRID prefix: +$location = GeometryValueObject::fromWKT('SRID=4326;POINT(-122.4194 37.7749)'); +// - Otherwise, use pure WKT and set SRID separately if the API supports it: +// $location = GeometryValueObject::fromWKT('POINT(-122.4194 37.7749)'); +// $location = $location->withSrid(4326); $entity->setLocation($location);If you’d like, I can adjust this snippet to match the exact API of your Geometry value object once confirmed. --- `168-170`: **Clarify EWKT/WKT note for geography/geometry** Consider clarifying that geography is inherently lon/lat (WGS84) and effectively SRID 4326, while geometry can use arbitrary SRIDs. This helps set expectations for round-trips and validations. </blockquote></details> <details> <summary>docs/AVAILABLE-TYPES.md (1)</summary><blockquote> `11-11`: **Separator rows render as literal table content** Rows with |---|---|---| inside the body will show as a normal row, not as a visual separator. Consider removing them, or split the catalog into subsections with headings and repeated headers. If you prefer to keep a single table, remove the separator rows: ```diff -|---|---|---| ... -|---|---|---| ... -|---|---|---| ... -|---|---|---|Alternatively, split into titled sections (e.g., JSON/arrays, network, ranges, geospatial) and repeat the header for each table.
Also applies to: 15-15, 22-22, 29-29
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (8)
.github/workflows/integration-tests.yml(2 hunks)README.md(3 hunks)devenv.nix(1 hunks)docker-compose.yml(1 hunks)docs/AVAILABLE-TYPES.md(1 hunks)docs/CONTRIBUTING.md(1 hunks)docs/USE-CASES-AND-EXAMPLES.md(1 hunks)tests/Integration/README.md(2 hunks)
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-05-07T02:15:24.181Z
Learnt from: janklan
PR: martin-georgiev/postgresql-for-doctrine#370
File: docker-compose.yml:0-0
Timestamp: 2025-05-07T02:15:24.181Z
Learning: When working with the official PostgreSQL Docker image, port configuration should be done via the Docker Compose `ports` mapping rather than through a `POSTGRES_PORT` environment variable. The official image only consumes specific environment variables like `POSTGRES_USER`, `POSTGRES_PASSWORD`, and `POSTGRES_DB`, but not port configuration.
Applied to files:
docker-compose.ymldevenv.nix
📚 Learning: 2025-04-20T11:24:18.300Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#352
File: tests/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/RegexpInstrTest.php:1-67
Timestamp: 2025-04-20T11:24:18.300Z
Learning: This PostgreSQL-for-Doctrine project is a translation layer only, focusing on correctly converting Doctrine DQL to PostgreSQL SQL syntax. It ensures arguments are passed in the expected format but does not test or handle PostgreSQL's actual function behavior or data handling. Test cases should focus on DQL-to-SQL translation and argument validation, not on PostgreSQL-specific behaviors.
Applied to files:
tests/Integration/README.md
📚 Learning: 2025-04-22T00:03:37.733Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#357
File: tests/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/RegexpMatchTest.php:28-62
Timestamp: 2025-04-22T00:03:37.733Z
Learning: This project focuses on providing Doctrine ORM interfaces to PostgreSQL functions. Tests should validate correct DQL-to-SQL translation rather than PostgreSQL functionality itself. Test cases should focus on parameter passing and SQL generation, not on testing specific PostgreSQL regex pattern behaviors.
Applied to files:
tests/Integration/README.md
📚 Learning: 2025-03-11T12:32:10.726Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#263
File: src/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/Numrange.php:19-21
Timestamp: 2025-03-11T12:32:10.726Z
Learning: In the postgresql-for-doctrine repository, PostgreSQL range functions have distinct implementations for different data types. The `Numrange` function works with numeric/decimal values and is tested using the `ContainsDecimals` fixture with properties typed as `float`. In contrast, the `Int4range` function works with 32-bit integers and is tested using the `ContainsIntegers` fixture with properties typed as `int`. While the PHP implementations share a similar structure (extending `BaseFunction`), they are semantically different as they handle different PostgreSQL data types.
Applied to files:
docs/USE-CASES-AND-EXAMPLES.md
🪛 LanguageTool
README.md
[grammar] ~58-~58: There might be a mistake here.
Context: ...nt[]) - PostGIS Geometry (geometry) - PostGIS Geography (geography`) - **Rang...
(QB_NEW_EN)
[grammar] ~59-~59: There might be a mistake here.
Context: ...ry) - PostGIS Geography (geography`) - Range Types - Date and time ranges (...
(QB_NEW_EN)
tests/Integration/README.md
[grammar] ~9-~9: There might be a mistake here.
Context: ...er (for running PostgreSQL with PostGIS) - PHP 8.1+ with the pdo_pgsql extension ...
(QB_NEW_EN)
🔇 Additional comments (6)
README.md (2)
127-138: LGTM: Clear guidance for PostGIS-backed integration testsDocs accurately reflect PostGIS usage and align with the docker-compose setup. Nice.
140-140: LGTM: Corrected integration tests doc pathThe link to tests/Integration/README.md is accurate and matches the repo structure.
devenv.nix (2)
63-65: LGTM: Pinning PostgreSQL 17 in devenvGood match with docker-compose and CI. Keeps local/dev/test consistent.
71-75: LGTM: PostGIS extension package enabledEnsures the extension is available for CREATE EXTENSION. Good.
.github/workflows/integration-tests.yml (2)
48-48: Good switch to PostGIS-enabled imageUsing postgis/postgis with matrixed versions aligns CI with the new docs and local env. Looks good.
44-45: Matrix expansion impact and compatibility (tags verified)
All required Docker-Hub tags (16-3.4, 16-3.5, 17-3.4, 17-3.5) exist upstream, so there’s no risk of pull failures. The PostGIS axis still doubles your matrix; if CI duration becomes a concern, consider:
- Pinning to a single PostGIS version per Postgres (e.g. only the latest),
- Or running the full expanded matrix on a nightly schedule instead of on every PR.
| echo "\nVerifying PostGIS installation:" | ||
| PGPASSWORD=postgres psql -h localhost -U postgres -d postgres_doctrine_test -c "SELECT PostGIS_Version();" | ||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Create the extension before querying PostGIS_Version()
On some images/databases, PostGIS is installed but not enabled in the target DB. Explicitly creating the extension avoids flakiness.
Apply this tweak to the verification step:
-echo "\nVerifying PostGIS installation:"
-PGPASSWORD=postgres psql -h localhost -U postgres -d postgres_doctrine_test -c "SELECT PostGIS_Version();"
+echo "Enabling PostGIS extension (idempotent):"
+PGPASSWORD=postgres psql -h localhost -U postgres -d postgres_doctrine_test -c "CREATE EXTENSION IF NOT EXISTS postgis;"
+
+echo "\nVerifying PostGIS installation:"
+PGPASSWORD=postgres psql -h localhost -U postgres -d postgres_doctrine_test -c "SELECT PostGIS_Version();"
+# Optionally check a canonical function/view to ensure the schema is present
+PGPASSWORD=postgres psql -h localhost -U postgres -d postgres_doctrine_test -c "SELECT COUNT(*) FROM pg_proc WHERE proname = 'st_astext';"Minor: the earlier echo lines use "\n", which many shells won’t interpret without -e. Consider printf for consistent newlines.
🏁 Script executed:
#!/usr/bin/env bash
set -e
# Show context around the PostGIS version check
grep -R -n -C3 "PostGIS_Version" .github/workflows/integration-tests.yml || echo "No PostGIS_Version found"
# Check whether the workflow already creates the PostGIS extension
grep -R -n -C3 "CREATE EXTENSION" .github/workflows/integration-tests.yml || echo "No CREATE EXTENSION found"Length of output: 631
Enable PostGIS extension before querying its version
The workflow currently lists available extensions but never creates/enables PostGIS in the test database, which can lead to flakiness on images where PostGIS isn’t auto-enabled.
• File: .github/workflows/integration-tests.yml
• Around lines 108–112
Apply this diff:
- name: Verify available PostGIS extensions
run: |
echo "Available extensions:"
PGPASSWORD=postgres psql -h localhost -U postgres -d postgres_doctrine_test -c "SELECT * FROM pg_available_extensions;"
+ echo "Enabling PostGIS extension (idempotent):"
+ PGPASSWORD=postgres psql -h localhost -U postgres -d postgres_doctrine_test -c "CREATE EXTENSION IF NOT EXISTS postgis;"
- name: Verify PostGIS installation
run: |
- echo "\nVerifying PostGIS installation:"
- PGPASSWORD=postgres psql -h localhost -U postgres -d postgres_doctrine_test -c "SELECT PostGIS_Version();"
+ # Use printf or echo -e for consistent newlines
+ printf "\nVerifying PostGIS installation:\n"
+ PGPASSWORD=postgres psql -h localhost -U postgres -d postgres_doctrine_test -c "SELECT PostGIS_Version();"
+ # Optional sanity check for a PostGIS function
+ PGPASSWORD=postgres psql -h localhost -U postgres -d postgres_doctrine_test -c "SELECT COUNT(*) FROM pg_proc WHERE proname='st_astext';"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| echo "\nVerifying PostGIS installation:" | |
| PGPASSWORD=postgres psql -h localhost -U postgres -d postgres_doctrine_test -c "SELECT PostGIS_Version();" | |
| - name: Verify available PostGIS extensions | |
| run: | | |
| echo "Available extensions:" | |
| PGPASSWORD=postgres psql -h localhost -U postgres -d postgres_doctrine_test -c "SELECT * FROM pg_available_extensions;" | |
| echo "Enabling PostGIS extension (idempotent):" | |
| PGPASSWORD=postgres psql -h localhost -U postgres -d postgres_doctrine_test -c "CREATE EXTENSION IF NOT EXISTS postgis;" | |
| - name: Verify PostGIS installation | |
| run: | | |
| # Use printf or echo -e for consistent newlines | |
| printf "\nVerifying PostGIS installation:\n" | |
| PGPASSWORD=postgres psql -h localhost -U postgres -d postgres_doctrine_test -c "SELECT PostGIS_Version();" | |
| # Optional sanity check for a PostGIS function | |
| PGPASSWORD=postgres psql -h localhost -U postgres -d postgres_doctrine_test -c "SELECT COUNT(*) FROM pg_proc WHERE proname='st_astext';" |
🤖 Prompt for AI Agents
In .github/workflows/integration-tests.yml around lines 110 to 112, the job
queries PostGIS version but never ensures the extension is enabled; before
running the version check, run a psql command to create/enable the postgis
extension in the test database (e.g., execute "CREATE EXTENSION IF NOT EXISTS
postgis;" against postgres_doctrine_test using the same PGPASSWORD/psql
invocation) so the version query won't fail on images where PostGIS isn't
auto-enabled.
| initialScript = '' | ||
| CREATE ROLE "${config.env.POSTGRES_USER}" | ||
| WITH SUPERUSER LOGIN PASSWORD '${config.env.POSTGRES_PASSWORD}'; | ||
| -- Enable PostGIS extension in the database | ||
| \c ${config.env.POSTGRES_DB} | ||
| CREATE EXTENSION IF NOT EXISTS postgis; | ||
| ''; |
There was a problem hiding this comment.
Idempotency issue: creating the default 'postgres' role will fail
postgres role exists by default; CREATE ROLE "${config.env.POSTGRES_USER}" ... will error if POSTGRES_USER is postgres (the default). Make this idempotent and update the password if the role already exists.
- initialScript = ''
- CREATE ROLE "${config.env.POSTGRES_USER}"
- WITH SUPERUSER LOGIN PASSWORD '${config.env.POSTGRES_PASSWORD}';
-
- -- Enable PostGIS extension in the database
- \c ${config.env.POSTGRES_DB}
- CREATE EXTENSION IF NOT EXISTS postgis;
- '';
+ initialScript = ''
+ DO $$
+ BEGIN
+ IF NOT EXISTS (SELECT 1 FROM pg_roles WHERE rolname = '${config.env.POSTGRES_USER}') THEN
+ CREATE ROLE "${config.env.POSTGRES_USER}" WITH SUPERUSER LOGIN PASSWORD '${config.env.POSTGRES_PASSWORD}';
+ ELSE
+ ALTER ROLE "${config.env.POSTGRES_USER}" WITH LOGIN PASSWORD '${config.env.POSTGRES_PASSWORD}';
+ END IF;
+ END
+ $$;
+
+ -- Enable PostGIS extension in the target database
+ \c ${config.env.POSTGRES_DB}
+ CREATE EXTENSION IF NOT EXISTS postgis;
+ '';Optionally, if you want the custom user to own the database:
- Add:
ALTER DATABASE "${config.env.POSTGRES_DB}" OWNER TO "${config.env.POSTGRES_USER}";
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| initialScript = '' | |
| CREATE ROLE "${config.env.POSTGRES_USER}" | |
| WITH SUPERUSER LOGIN PASSWORD '${config.env.POSTGRES_PASSWORD}'; | |
| -- Enable PostGIS extension in the database | |
| \c ${config.env.POSTGRES_DB} | |
| CREATE EXTENSION IF NOT EXISTS postgis; | |
| ''; | |
| initialScript = '' | |
| DO $$ | |
| BEGIN | |
| IF NOT EXISTS (SELECT 1 FROM pg_roles WHERE rolname = '${config.env.POSTGRES_USER}') THEN | |
| CREATE ROLE "${config.env.POSTGRES_USER}" WITH SUPERUSER LOGIN PASSWORD '${config.env.POSTGRES_PASSWORD}'; | |
| ELSE | |
| ALTER ROLE "${config.env.POSTGRES_USER}" WITH LOGIN PASSWORD '${config.env.POSTGRES_PASSWORD}'; | |
| END IF; | |
| END | |
| $$; | |
| -- Enable PostGIS extension in the target database | |
| \c ${config.env.POSTGRES_DB} | |
| CREATE EXTENSION IF NOT EXISTS postgis; | |
| ''; |
🤖 Prompt for AI Agents
In devenv.nix around lines 76 to 83, the current initialScript unconditionally
runs CREATE ROLE which will fail when POSTGRES_USER is the default "postgres";
make the role creation idempotent by checking for the role first and either
creating it or updating its password if it already exists (use a conditional DO
block or ALTER ROLE when present), then ensure the PostGIS extension is created
as before; optionally add a step to set the database owner with ALTER DATABASE
"${config.env.POSTGRES_DB}" OWNER TO "${config.env.POSTGRES_USER}".
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
docs/AVAILABLE-TYPES.md (1)
11-11: Avoid repeating the table separator row inside the tableMarkdown tables only need the separator row once (right after the header). Repeating “|---|---|---|” in the middle of a table renders as literal “---” cells on GitHub and harms readability/accessibility. If you want sectioning, split into multiple tables or insert subheaders between tables.
Two light-weight options:
- Split into multiple tables: repeat the header before each section and leave a blank line before the new header.
- Or remove the repeated separator rows entirely and use subheadings between separate tables.
Apply this pattern to restart a new table at the section boundaries (repeat for each occurrence):
-|---|---|---| + +| PostgreSQL type in practical use | PostgreSQL internal system catalogue name | Implemented by | +|---|---|---|Tip: Add a blank line before the new header for proper rendering on GitHub.
Also applies to: 15-15, 22-22, 29-29
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidGeometryException.php (1)
19-47: Unify acronym casing to WKT/EWKT/SRID for clarityMinor nit: messages currently use mixed casing (“Wkt”, “Ewkt”, “Srid”). Standardize to WKT, EWKT, SRID for consistency with PostGIS/PostgreSQL docs.
Apply:
- return new self('Empty Wkt string provided'); + return new self('Empty WKT string provided'); @@ - return new self('Invalid Ewkt: missing semicolon after Srid prefix'); + return new self('Invalid EWKT: missing semicolon after SRID prefix'); @@ - return new self(\sprintf('Invalid Srid value in Ewkt: %s', \var_export($sridValue, true))); + return new self(\sprintf('Invalid SRID value in EWKT: %s', \var_export($sridValue, true))); @@ - return new self(\sprintf('Invalid Wkt format: %s', \var_export($wkt, true))); + return new self(\sprintf('Invalid WKT format: %s', \var_export($wkt, true))); @@ - return new self('Invalid Wkt: empty coordinate/body section'); + return new self('Invalid WKT: empty coordinate/body section'); @@ - return new self(\sprintf('Unsupported Wkt geometry type: %s', \var_export($type, true))); + return new self(\sprintf('Unsupported WKT geometry type: %s', \var_export($type, true)));src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Point.php (2)
45-47: Tighten point string validation by anchoring the regexCurrently, POINT_REGEX isn’t anchored, so substrings like "foo (1,2) bar" pass. Consider anchoring to ensure the whole string matches.
Outside this hunk, update the constant:
private const POINT_REGEX = '/^\((' . self::COORDINATE_PATTERN . '),\s*(' . self::COORDINATE_PATTERN . ')\)$/';No change needed here at the throw site.
56-59: Optional: avoid rebuilding the float regex on each callMicro-optimization/readability: predefine a COORDINATE_REGEX constant and reuse it.
Outside this hunk:
private const COORDINATE_REGEX = '/^' . self::COORDINATE_PATTERN . '$/';Then:
- $floatRegex = '/^'.self::COORDINATE_PATTERN.'$/'; - if (!\preg_match($floatRegex, $stringValue)) { + if (!\preg_match(self::COORDINATE_REGEX, $stringValue)) { throw InvalidPointException::forInvalidCoordinate($name, $stringValue); }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
docs/AVAILABLE-TYPES.md(1 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/Point.php(2 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidGeometryException.php(1 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidPointException.php(1 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Point.php(3 hunks)
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-08-09T15:31:42.054Z
Learnt from: landure
PR: martin-georgiev/postgresql-for-doctrine#411
File: src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidLtreeForPHPException.php:11-19
Timestamp: 2025-08-09T15:31:42.054Z
Learning: In the postgresql-for-doctrine library, exception classes for invalid PHP values (Invalid*ForPHPException) follow a consistent pattern using var_export() in their create() method to format error messages. When adding new exception classes, maintain consistency with existing patterns rather than introducing new approaches, even if technically superior alternatives exist.
Applied to files:
src/MartinGeorgiev/Doctrine/DBAL/Types/Point.phpsrc/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidGeometryException.phpsrc/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidPointException.phpsrc/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Point.php
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what TYPE_NAME constants contain and getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
docs/AVAILABLE-TYPES.md
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
docs/AVAILABLE-TYPES.md
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the point[] array type should be documented as "point[]" not "_point" in the AVAILABLE-TYPES.md table, to be consistent with all other array types like text[], jsonb[], inet[], etc.
Applied to files:
docs/AVAILABLE-TYPES.md
🧬 Code Graph Analysis (2)
src/MartinGeorgiev/Doctrine/DBAL/Types/Point.php (1)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidPointException.php (1)
InvalidPointException(17-36)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Point.php (1)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidPointException.php (3)
InvalidPointException(17-36)forInvalidPointFormat(19-26)forInvalidCoordinate(28-35)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
- GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.3
- GitHub Check: PostgreSQL 16 + PostGIS 3.5 + PHP 8.3
- GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.4
- GitHub Check: PostgreSQL 17 + PostGIS 3.4 + PHP 8.2
- GitHub Check: PostgreSQL 16 + PostGIS 3.4 + PHP 8.4
- GitHub Check: PostgreSQL 16 + PostGIS 3.5 + PHP 8.4
- GitHub Check: PostgreSQL 16 + PostGIS 3.4 + PHP 8.2
- GitHub Check: PostgreSQL 16 + PostGIS 3.5 + PHP 8.1
- GitHub Check: PostgreSQL 16 + PostGIS 3.5 + PHP 8.2
- GitHub Check: PostgreSQL 17 + PostGIS 3.4 + PHP 8.3
- GitHub Check: PostgreSQL 16 + PostGIS 3.4 + PHP 8.3
- GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.2
- GitHub Check: PostgreSQL 17 + PostGIS 3.4 + PHP 8.1
- GitHub Check: PHP 8.4 + Doctrine ORM 3.0 + Doctrine Lexer latest
- GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer latest
- GitHub Check: PHP 8.2 + Doctrine ORM 3.0 + Doctrine Lexer latest
- GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
- GitHub Check: PHP 8.2 + Doctrine ORM 2.14 + Doctrine Lexer latest
- GitHub Check: PHP 8.1 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
- GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer latest
🔇 Additional comments (6)
docs/AVAILABLE-TYPES.md (3)
31-35: Geospatial array entries use correct internal catalogue namesThe second column is explicitly “PostgreSQL internal system catalogue name,” so using _geography, _geometry, and _point for array entries is correct and consistent with the rest of the table (e.g., _jsonb, _text, _inet).
13-19: DBAL class mappings read clean and consistentjsonb/jsonb[], text[], inet/inet[] rows align with the project’s existing pattern: practical type name in column 1, internal catalogue name in column 2, and the fully-qualified DBAL type in column 3. No action needed here.
34-35: Placing point/point[] with geospatial types is acceptablePoint is a built-in geometric type rather than a PostGIS type, but grouping it alongside geography/geometry is a sensible choice given user expectations. No strong preference for relocating it.
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidPointException.php (1)
17-35: Consistent exception factories and messages (var_export usage matches house style)Factory methods and message formatting mirror existing Invalid* exception patterns in the project. Clear separation between value-object validation and DBAL conversion concerns. Good addition.
src/MartinGeorgiev/Doctrine/DBAL/Types/Point.php (2)
10-10: Importing InvalidPointException is correctCatching the value-object-level InvalidPointException cleanly maps it to the DBAL-level InvalidPointForDatabaseException. This keeps concerns layered and messages user-friendly.
48-52: Non-capturing catch is fine given PHP baselineUsing a non-capturing catch is supported in PHP 8+. The codebase already uses readonly properties (PHP 8.1+), so this is within baseline.
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (4)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidGeometryException.php (1)
23-54: Standardize acronym casing in messages (WKT, EWKT, SRID)Current messages mix “Wkt/Ewkt/Srid” with “WKT/EWKT/SRID”. Standardizing improves clarity and aligns with common geospatial nomenclature.
Apply this diff:
- return new self('Empty Wkt string provided'); + return new self('Empty WKT string provided'); @@ - return new self('Invalid Ewkt: missing semicolon after Srid prefix'); + return new self('Invalid EWKT: missing semicolon after SRID prefix'); @@ - return new self(\sprintf('Invalid Srid value in Ewkt: %s', \var_export($sridValue, true))); + return new self(\sprintf('Invalid SRID value in EWKT: %s', \var_export($sridValue, true))); @@ - return new self(\sprintf('Invalid Wkt format: %s', \var_export($wkt, true))); + return new self(\sprintf('Invalid WKT format: %s', \var_export($wkt, true))); @@ - return new self('Invalid Wkt: empty coordinate/body section'); + return new self('Invalid WKT: empty coordinate/body section'); @@ - 'Unsupported Wkt geometry type: %s. Supported types: %s', + 'Unsupported WKT geometry type: %s. Supported types: %s',src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Geometry.php (1)
98-101: Naming: getWkt() returns EWKT when SRID is presentMinor API clarity: getWkt() may return EWKT (with SRID prefix). Either rename to getText()/toText() or document that the returned value is canonical WKT/EWKT with optional SRID.
If you prefer renaming:
- public function getWkt(): string + public function toText(): string { return (string) $this; }If keeping the name, consider adding a docblock “Returns WKT or EWKT if SRID is set”.
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/GeometryTest.php (2)
31-38: Add coverage for Z/M/ZM modifiers and lowercase typesTo guard against regressions and validate round-tripping with dimensionality and case-insensitivity, extend the valid dataset.
Apply this diff:
return [ 'point' => ['POINT(1 2)', 'POINT', null], 'point with srid' => ['SRID=4326;POINT(-122.4194 37.7749)', 'POINT', 4326], 'linestring' => ['LINESTRING(0 0, 1 1, 2 2)', 'LINESTRING', null], 'polygon' => ['POLYGON((0 0, 0 1, 1 1, 1 0, 0 0))', 'POLYGON', null], + 'point Z' => ['POINT Z (1 2 3)', 'POINT', null], + 'point M' => ['POINT M (1 2 3)', 'POINT', null], + 'point ZM' => ['POINT ZM (1 2 3 4)', 'POINT', null], + 'lowercase point' => ['point(1 2)', 'POINT', null], ];
52-61: Add invalid case for whitespace-only bodyCatches inputs like “POINT( )” which should be rejected.
Apply this diff:
return [ 'empty' => [''], 'missing semicolon after srid' => ['SRID=4326POINT(1 2)'], 'invalid srid' => ['SRID=abc;POINT(1 2)'], 'invalid body' => ['POINT()'], + 'whitespace-only body' => ['POINT( )'], 'invalid format' => ['INVALID_WKT'], 'unsupported geometry type' => ['UNSUPPORTED(1 2)'], ];
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidGeometryException.php(1 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Geometry.php(1 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WKTGeometryType.php(1 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/GeometryTest.php(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-09T15:31:42.054Z
Learnt from: landure
PR: martin-georgiev/postgresql-for-doctrine#411
File: src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidLtreeForPHPException.php:11-19
Timestamp: 2025-08-09T15:31:42.054Z
Learning: In the postgresql-for-doctrine library, exception classes for invalid PHP values (Invalid*ForPHPException) follow a consistent pattern using var_export() in their create() method to format error messages. When adding new exception classes, maintain consistency with existing patterns rather than introducing new approaches, even if technically superior alternatives exist.
Applied to files:
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidGeometryException.php
🧬 Code Graph Analysis (2)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/GeometryTest.php (2)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidGeometryException.php (1)
InvalidGeometryException(19-56)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Geometry.php (5)
Geometry(22-102)fromWkt(37-76)getGeometryType(93-96)getSrid(88-91)getWkt(98-101)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Geometry.php (1)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidGeometryException.php (7)
InvalidGeometryException(19-56)forEmptyWkt(21-24)forMissingSemicolonInEwkt(26-29)forInvalidSridValue(31-34)forInvalidWktFormat(36-39)forEmptyCoordinateSection(41-44)forUnsupportedGeometryType(46-55)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
- GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.4
- GitHub Check: PostgreSQL 16 + PostGIS 3.5 + PHP 8.4
- GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.3
- GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.2
- GitHub Check: PostgreSQL 17 + PostGIS 3.4 + PHP 8.2
- GitHub Check: PostgreSQL 16 + PostGIS 3.5 + PHP 8.2
- GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.1
- GitHub Check: PostgreSQL 16 + PostGIS 3.4 + PHP 8.1
- GitHub Check: PostgreSQL 16 + PostGIS 3.5 + PHP 8.1
- GitHub Check: PostgreSQL 16 + PostGIS 3.4 + PHP 8.2
- GitHub Check: PHP 8.4 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
- GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer latest
- GitHub Check: PHP 8.4 + Doctrine ORM 3.0 + Doctrine Lexer latest
- GitHub Check: PHP 8.3 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
- GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer latest
- GitHub Check: PHP 8.2 + Doctrine ORM 2.18 + Doctrine Lexer latest
- GitHub Check: PHP 8.3 + Doctrine ORM 3.0 + Doctrine Lexer latest
- GitHub Check: PHP 8.2 + Doctrine ORM latest + Doctrine Lexer 3.0
- GitHub Check: PHP 8.2 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
🔇 Additional comments (2)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WKTGeometryType.php (1)
16-39: Enum coverage looks solid and readableGood, comprehensive set of WKT geometry types including PostGIS extensions (CIRCULARSTRING, COMPOUNDCURVE, CURVEPOLYGON, etc.). This aligns with the intended scope for WKT/EWKT parsing.
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidGeometryException.php (1)
21-24: Adheres to project’s exception message styleUsing var_export() for values in messages is consistent with prior Invalid*ForPHPException patterns noted in past PRs. Nice consistency.
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Geometry.php
Outdated
Show resolved
Hide resolved
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Geometry.php
Outdated
Show resolved
Hide resolved
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Geometry.php
Outdated
Show resolved
Hide resolved
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Geometry.php
Outdated
Show resolved
Hide resolved
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WKTGeometryType.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (4)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktGeometryTypeTest.php (1)
41-63: Guard against drift when enum cases change (add an invariance test)To ensure this provider remains in sync if new cases are introduced in WktGeometryType, add an assertion that the provider covers all enum cases. This keeps the test suite future-proof without forcing a data-provider refactor.
Apply this addition:
@@ final class WktGeometryTypeTest extends TestCase { @@ public static function provideValidGeometryTypes(): array { return [ @@ ]; } + #[Test] + public function provider_covers_all_enum_cases(): void + { + $provided = \array_map(static fn(array $e) => $e[0], self::provideValidGeometryTypes()); + \sort($provided); + + $cases = \array_map(static fn(WktGeometryType $c) => $c->value, WktGeometryType::cases()); + \sort($cases); + + self::assertSame( + $cases, + $provided, + 'Update provideValidGeometryTypes() when adding new WktGeometryType cases.' + ); + }src/MartinGeorgiev/Doctrine/DBAL/Types/Geography.php (1)
25-36: Silence PHPMD “UnusedFormalParameter” for $platform.Doctrine’s Type API mandates the
$platformargument; it’s expected to be unused in these methods. Add PHPMD suppression to keep CI/noise clean.Apply this diff:
@@ - public function convertToDatabaseValue($value, AbstractPlatform $platform): ?string + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ + public function convertToDatabaseValue($value, AbstractPlatform $platform): ?string @@ - public function convertToPHPValue($value, AbstractPlatform $platform): ?WktSpatialData + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ + public function convertToPHPValue($value, AbstractPlatform $platform): ?WktSpatialDataAlso applies to: 38-53
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialDataTest.php (1)
54-62: Add test for whitespace-only body to cover invalid WKT 'POINT( )'.This complements the stricter validation so the contract is enforced at test time.
Apply this diff:
return [ 'empty' => [''], 'missing semicolon after srid' => ['SRID=4326POINT(1 2)'], 'invalid srid' => ['SRID=abc;POINT(1 2)'], 'invalid body' => ['POINT()'], + 'whitespace-only body' => ['POINT( )'], 'invalid format' => ['INVALID_WKT'], 'unsupported geometry type' => ['UNSUPPORTED(1 2)'], ];src/MartinGeorgiev/Doctrine/DBAL/Types/Geometry.php (1)
25-36: Suppress PHPMD “UnusedFormalParameter” for $platform.Same rationale as in Geography: required by the interface, unused here.
Apply this diff:
@@ - public function convertToDatabaseValue($value, AbstractPlatform $platform): ?string + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ + public function convertToDatabaseValue($value, AbstractPlatform $platform): ?string @@ - public function convertToPHPValue($value, AbstractPlatform $platform): ?WktSpatialData + /** + * @SuppressWarnings(PHPMD.UnusedFormalParameter) + */ + public function convertToPHPValue($value, AbstractPlatform $platform): ?WktSpatialDataAlso applies to: 38-53
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (11)
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeographyForDatabaseException.php(1 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeographyForPHPException.php(1 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForDatabaseException.php(1 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForPHPException.php(1 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/Geography.php(1 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/Geometry.php(1 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidPointException.php(1 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidWktSpatialDataException.php(1 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php(1 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktGeometryTypeTest.php(1 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialDataTest.php(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidPointException.php
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-08-09T15:31:42.054Z
Learnt from: landure
PR: martin-georgiev/postgresql-for-doctrine#411
File: src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidLtreeForPHPException.php:11-19
Timestamp: 2025-08-09T15:31:42.054Z
Learning: In the postgresql-for-doctrine library, exception classes for invalid PHP values (Invalid*ForPHPException) follow a consistent pattern using var_export() in their create() method to format error messages. When adding new exception classes, maintain consistency with existing patterns rather than introducing new approaches, even if technically superior alternatives exist.
Applied to files:
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidWktSpatialDataException.phpsrc/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForDatabaseException.phpsrc/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeographyForPHPException.phpsrc/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeographyForDatabaseException.phpsrc/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForPHPException.php
🧬 Code Graph Analysis (9)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialDataTest.php (2)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidWktSpatialDataException.php (1)
InvalidWktSpatialDataException(19-56)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (5)
WktSpatialData(22-93)fromWkt(36-77)getGeometryType(84-87)getSrid(79-82)getWkt(89-92)
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForDatabaseException.php (3)
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeographyForDatabaseException.php (3)
create(16-19)forInvalidType(21-24)forInvalidFormat(26-29)src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeographyForPHPException.php (3)
create(16-19)forInvalidType(21-24)forInvalidFormat(26-29)src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForPHPException.php (3)
create(16-19)forInvalidType(21-24)forInvalidFormat(26-29)
src/MartinGeorgiev/Doctrine/DBAL/Types/Geography.php (6)
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeographyForDatabaseException.php (3)
InvalidGeographyForDatabaseException(14-30)forInvalidType(21-24)forInvalidFormat(26-29)src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeographyForPHPException.php (3)
InvalidGeographyForPHPException(14-30)forInvalidType(21-24)forInvalidFormat(26-29)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidWktSpatialDataException.php (1)
InvalidWktSpatialDataException(19-56)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (2)
WktSpatialData(22-93)fromWkt(36-77)src/MartinGeorgiev/Doctrine/DBAL/Types/BaseType.php (1)
BaseType(17-52)src/MartinGeorgiev/Doctrine/DBAL/Types/Geometry.php (2)
convertToDatabaseValue(25-36)convertToPHPValue(38-53)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktGeometryTypeTest.php (1)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialDataTest.php (2)
DataProvider(16-26)DataProvider(41-47)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (1)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidWktSpatialDataException.php (7)
InvalidWktSpatialDataException(19-56)forEmptyWkt(21-24)forMissingSemicolonInEwkt(26-29)forInvalidSridValue(31-34)forInvalidWktFormat(36-39)forEmptyCoordinateSection(41-44)forUnsupportedGeometryType(46-55)
src/MartinGeorgiev/Doctrine/DBAL/Types/Geometry.php (6)
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForDatabaseException.php (3)
InvalidGeometryForDatabaseException(14-30)forInvalidType(21-24)forInvalidFormat(26-29)src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForPHPException.php (3)
InvalidGeometryForPHPException(14-30)forInvalidType(21-24)forInvalidFormat(26-29)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidWktSpatialDataException.php (1)
InvalidWktSpatialDataException(19-56)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (2)
WktSpatialData(22-93)fromWkt(36-77)src/MartinGeorgiev/Doctrine/DBAL/Types/BaseType.php (1)
BaseType(17-52)src/MartinGeorgiev/Doctrine/DBAL/Types/Geography.php (2)
convertToDatabaseValue(25-36)convertToPHPValue(38-53)
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeographyForPHPException.php (3)
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeographyForDatabaseException.php (3)
create(16-19)forInvalidType(21-24)forInvalidFormat(26-29)src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForDatabaseException.php (3)
create(16-19)forInvalidType(21-24)forInvalidFormat(26-29)src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForPHPException.php (3)
create(16-19)forInvalidType(21-24)forInvalidFormat(26-29)
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeographyForDatabaseException.php (3)
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForDatabaseException.php (3)
create(16-19)forInvalidType(21-24)forInvalidFormat(26-29)src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeographyForPHPException.php (3)
create(16-19)forInvalidType(21-24)forInvalidFormat(26-29)src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForPHPException.php (3)
create(16-19)forInvalidType(21-24)forInvalidFormat(26-29)
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForPHPException.php (3)
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeographyForDatabaseException.php (3)
create(16-19)forInvalidType(21-24)forInvalidFormat(26-29)src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForDatabaseException.php (3)
create(16-19)forInvalidType(21-24)forInvalidFormat(26-29)src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeographyForPHPException.php (3)
create(16-19)forInvalidType(21-24)forInvalidFormat(26-29)
🪛 PHPMD (2.15.0)
src/MartinGeorgiev/Doctrine/DBAL/Types/Geography.php
25-25: Avoid unused parameters such as '$platform'. (Unused Code Rules)
(UnusedFormalParameter)
38-38: Avoid unused parameters such as '$platform'. (Unused Code Rules)
(UnusedFormalParameter)
src/MartinGeorgiev/Doctrine/DBAL/Types/Geometry.php
25-25: Avoid unused parameters such as '$platform'. (Unused Code Rules)
(UnusedFormalParameter)
38-38: Avoid unused parameters such as '$platform'. (Unused Code Rules)
(UnusedFormalParameter)
🔇 Additional comments (17)
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForPHPException.php (2)
16-19: Consistent factory formatting with var_export — LGTMThe create() helper follows the established pattern in this repo (sprintf + var_export), matching prior Invalid*ForPHPException implementations.
21-29: Clear, specific messages for type and format — LGTMBoth factories provide precise guidance and align with the Geography counterparts. No changes needed.
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeographyForDatabaseException.php (2)
16-19: Factory helper matches project conventions — LGTMUses fully-qualified global functions and var_export formatting consistent with sibling exceptions.
21-29: Error messages are accurate and consistent — LGTM
- Type guard expects database values as strings.
- Format message reads naturally (“geography format in database”).
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktGeometryTypeTest.php (4)
14-22: Happy path coverage looks solid — LGTMValidates both enum identity and underlying string value for from(). Good signal for consumers depending on exact WKT tokens.
24-30: Invalid input behavior covered — LGTMAsserts ValueError for from('INVALID'), matching enum semantics.
32-39: tryFrom success path covered — LGTMConfirms mapping to the correct enum case for valid type strings.
65-70: Null/invalid branch covered — LGTMEnsures tryFrom() returns null for unsupported values.
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForDatabaseException.php (2)
16-19: Factory helper consistency — LGTMMirrors the Geography counterpart and other DB exceptions in the codebase.
21-29: Database-facing messages are appropriate — LGTMCovers both non-string payloads and malformed geometry content read from the DB.
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeographyForPHPException.php (2)
16-19: create() helper aligns with established pattern — LGTMNo deviation from the Invalid*ForPHPException style used elsewhere.
21-29: Message clarity and consistency — LGTMMatches the Geometry variant and provides actionable context.
src/MartinGeorgiev/Doctrine/DBAL/Types/Geography.php (1)
21-36: Geography DBAL type looks consistent and correct.Nice parity with Geometry: type name, conversions, and exception mapping are spot on. The use of WktSpatialData as the PHP representation is clean and keeps parsing concerns centralized.
Also applies to: 38-53
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (1)
22-34: Value object design is cohesive and robust.Clean separation of concerns, informative exceptions, and deterministic stringification. The EWKT SRID parsing is defensive and matches expectations. Nicely done.
Also applies to: 36-77, 79-93
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialDataTest.php (1)
16-26: LGTM on happy-path coverage.Good assertions for geometry type, SRID, and round-tripping via __toString().
src/MartinGeorgiev/Doctrine/DBAL/Types/Geometry.php (1)
21-36: Geometry DBAL type implementation looks great.Error mapping and value-object usage mirror Geography, keeping behavior consistent across spatial types.
Also applies to: 38-53
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidWktSpatialDataException.php (1)
19-56: Exception class is consistent with library conventions.Factory methods, var_export usage, and supported types enumeration align with established patterns. No issues found.
| final class InvalidGeometryForPHPException extends ConversionException | ||
| { | ||
| private static function create(string $message, mixed $value): self | ||
| { | ||
| return new self(\sprintf($message, \var_export($value, true))); | ||
| } | ||
|
|
||
| public static function forInvalidType(mixed $value): self | ||
| { | ||
| return self::create('Value must be a Geometry value object, %s given', $value); | ||
| } | ||
|
|
||
| public static function forInvalidFormat(mixed $value): self | ||
| { | ||
| return self::create('Invalid Geometry value object format: %s', $value); | ||
| } | ||
| } |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Sanity-check usage paths for this exception in Geometry DBAL type
To avoid dead code, verify that convertToDatabaseValue/convertToPHPValue in Geometry type actually throw these factories on invalid PHP input or malformed value-object state.
Run this to confirm call sites exist:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Searching for InvalidGeometryForPHPException usage…"
rg -nP '\bInvalidGeometryForPHPException::forInvalid(?:Type|Format)\(' -C2
echo
echo "Looking for Geometry DBAL type and potential throw sites…"
rg -nP '(?s)class\s+Geometry\b.*?(convertTo(Database|PHP)Value)\s*\(' -C3 --type=php || trueLength of output: 846
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Inspecting the start of Geometry.php for class declaration..."
sed -n '1,200p' src/MartinGeorgiev/Doctrine/DBAL/Types/Geometry.php || true
echo
echo "Searching for convertToDatabaseValue definitions and usage…"
rg -nP 'function\s+convertToDatabaseValue' -C5 src/MartinGeorgiev/Doctrine/DBAL/Types/Geometry.php || true
echo
echo "Searching for convertToPHPValue definitions and usage…"
rg -nP 'function\s+convertToPHPValue' -C5 src/MartinGeorgiev/Doctrine/DBAL/Types/Geometry.php || true
echo
echo "Searching for forInvalidFormat calls in Geometry.php…"
rg -nP 'InvalidGeometryForPHPException::forInvalidFormat' -C3 src/MartinGeorgiev/Doctrine/DBAL/Types/Geometry.php || trueLength of output: 3035
Remove unused forInvalidFormat() factory in InvalidGeometryForPHPException
The forInvalidFormat() method is never thrown by Geometry::convertToDatabaseValue() (and convertToPHPValue() uses the database exception), making it dead code. Please choose one of the following:
- Remove the unused
public static function forInvalidFormat(string $message, mixed $value): selffrom
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForPHPException.php - Or, if you need to guard against malformed WktSpatialData state, add a check in
convertToDatabaseValue() to throw this factory before casting to string.
🤖 Prompt for AI Agents
In
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForPHPException.php
around lines 14-30, the public static function forInvalidFormat(...) is dead
code (never thrown); remove the entire forInvalidFormat method declaration from
this file to eliminate the unused factory method (or alternatively, if you
prefer to keep it, add a validation in Geometry::convertToDatabaseValue() to
detect malformed WktSpatialData and throw
InvalidGeometryForPHPException::forInvalidFormat() before casting to string).
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (13)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
100-108: EWKT retrieval for geometry/geography is correct; consider identifier quoting (optional)The use of ST_AsEWKT for geometry and an explicit geometry cast for geography is spot on for returning textual values. Optionally, consider platform-aware identifier quoting for column names to handle edge cases (reserved words, unusual casing), though current tests use a safe column name.
If you want to harden for arbitrary identifiers:
- private function getSelectExpressionForType(string $typeName, string $columnName): string - { - // Ensure we get a text representation for PostGIS types that DBAL might map to resource/stream - return match ($typeName) { - 'geometry' => \sprintf('ST_AsEWKT("%s") AS "%s"', $columnName, $columnName), - 'geography' => \sprintf('ST_AsEWKT("%s"::geometry) AS "%s"', $columnName, $columnName), - default => $columnName, - }; - } + private function getSelectExpressionForType(string $typeName, string $columnName): string + { + // Ensure we get a text representation for PostGIS types that DBAL might map to resource/stream + $quoted = $this->connection->getDatabasePlatform()->quoteIdentifier($columnName); + return match ($typeName) { + 'geometry' => \sprintf('ST_AsEWKT(%1$s) AS %1$s', $quoted), + 'geography' => \sprintf('ST_AsEWKT(%1$s::geometry) AS %1$s', $quoted), + default => (string) $quoted, + }; + }Note: This changes the default branch to select the quoted identifier (which is generally safe).
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php (2)
31-31: Remove unused parameter$testNameto silence PHPMD and tighten the test signatureThe parameter isn’t used; dropping it will address the static analysis hint and keep the signature minimal.
- public function can_handle_geometry_values(string $testName, WktSpatialData $wktSpatialData): void + public function can_handle_geometry_values(WktSpatialData $wktSpatialData): void
36-47: Align data provider shape after removing$testNameand consider broader geometry coverage (optional)Adjust the provider’s return shape accordingly. Optionally, expand with Z/ZM/M or curved types to exercise the regex allowance and PostGIS support.
- /** - * @return array<string, array{string, WktSpatialData}> - */ + /** + * @return array<string, array{WktSpatialData}> + */ public static function provideValidTransformations(): array { return [ - 'point' => ['point', WktSpatialData::fromWkt('POINT(1 2)')], - 'linestring' => ['linestring', WktSpatialData::fromWkt('LINESTRING(0 0, 1 1, 2 2)')], - 'polygon' => ['polygon', WktSpatialData::fromWkt('POLYGON((0 0, 0 1, 1 1, 1 0, 0 0))')], - 'geometrycollection' => ['geometrycollection', WktSpatialData::fromWkt('GEOMETRYCOLLECTION(POINT(1 2), LINESTRING(0 0, 1 1))')], - 'point with srid' => ['point with srid', WktSpatialData::fromWkt('SRID=4326;POINT(-122.4194 37.7749)')], + 'point' => [WktSpatialData::fromWkt('POINT(1 2)')], + 'linestring' => [WktSpatialData::fromWkt('LINESTRING(0 0, 1 1, 2 2)')], + 'polygon' => [WktSpatialData::fromWkt('POLYGON((0 0, 0 1, 1 1, 1 0, 0 0))')], + 'geometrycollection' => [WktSpatialData::fromWkt('GEOMETRYCOLLECTION(POINT(1 2), LINESTRING(0 0, 1 1))')], + 'point with srid' => [WktSpatialData::fromWkt('SRID=4326;POINT(-122.4194 37.7749)')], ]; }Optional coverage ideas (no change required here): add examples like POINT Z(1 2 3), LINESTRING M(...), CIRCULARSTRING(...).
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTest.php (2)
91-96: Clarify test name to reflect what’s being validated (PHP-to-DB conversion) (optional)Current name can be misread as “invalid database value inputs,” but it validates inputs for database conversion from PHP. Rename for clarity.
- public function throws_exception_for_invalid_database_value_inputs(mixed $phpValue): void + public function throws_exception_for_invalid_value_for_database(mixed $phpValue): void
111-117: Clarify test name to reflect what’s being validated (DB-to-PHP conversion) (optional)This one validates values coming from the database. A concise rename makes it self-explanatory.
- public function throws_exception_for_invalid_php_value_inputs(mixed $postgresValue): void + public function throws_exception_for_invalid_value_from_database(mixed $postgresValue): voidtests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php (2)
31-31: Remove unused parameter$testNameto address PHPMD warningDrop the unused parameter to keep the test lean and pass static analysis.
- public function can_handle_geography_values(string $testName, WktSpatialData $wktSpatialData): void + public function can_handle_geography_values(WktSpatialData $wktSpatialData): void
36-46: Adjust provider shape after signature change; optionally add SRID case for geographyUpdate the provider to return only the WktSpatialData argument. Optionally, include a case with SRID=4326 to verify geography handling with explicit SRID.
- /** - * @return array<string, array{string, WktSpatialData}> - */ + /** + * @return array<string, array{WktSpatialData}> + */ public static function provideValidTransformations(): array { return [ - 'point' => ['point', WktSpatialData::fromWkt('POINT(1 2)')], - 'linestring' => ['linestring', WktSpatialData::fromWkt('LINESTRING(0 0, 1 1, 2 2)')], - 'polygon' => ['polygon', WktSpatialData::fromWkt('POLYGON((0 0, 0 1, 1 1, 1 0, 0 0))')], - 'geometrycollection' => ['geometrycollection', WktSpatialData::fromWkt('GEOMETRYCOLLECTION(POINT(1 2), LINESTRING(0 0, 1 1))')], + 'point' => [WktSpatialData::fromWkt('POINT(1 2)')], + 'linestring' => [WktSpatialData::fromWkt('LINESTRING(0 0, 1 1, 2 2)')], + 'polygon' => [WktSpatialData::fromWkt('POLYGON((0 0, 0 1, 1 1, 1 0, 0 0))')], + 'geometrycollection' => [WktSpatialData::fromWkt('GEOMETRYCOLLECTION(POINT(1 2), LINESTRING(0 0, 1 1))')], + // Optional: + // 'point with srid' => [WktSpatialData::fromWkt('SRID=4326;POINT(-122.4194 37.7749)')], ]; }tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTest.php (6)
35-36: Prefer strict assertions for string equalityUse assertSame for exact string matches to avoid unintended type juggling.
- self::assertEquals('geography', $this->fixture->getName()); + self::assertSame('geography', $this->fixture->getName());- self::assertInstanceOf(WktSpatialData::class, $result); - self::assertEquals((string) $wktSpatialData, (string) $result); + self::assertInstanceOf(WktSpatialData::class, $result); + self::assertSame((string) $wktSpatialData, (string) $result);Also applies to: 56-58
60-75: Add an EWKT with SRID case to validate SRID preservationCovering SRID in valid transformations strengthens guarantees around EWKT handling and aligns with common PostGIS usage.
return [ 'null' => [ 'valueObject' => null, 'postgresValue' => null, ], 'point' => [ 'valueObject' => WktSpatialData::fromWkt('POINT(1 2)'), 'postgresValue' => 'POINT(1 2)', ], + 'ewkt with srid' => [ + 'valueObject' => WktSpatialData::fromWkt('SRID=4326;POINT(1 2)'), + 'postgresValue' => 'SRID=4326;POINT(1 2)', + ], ];
77-97: Fix swapped “PHP vs Database” naming to reflect the code under testThis test calls convertToDatabaseValue (PHP -> DB) but is named “…database value inputs” and uses a provider named “…DatabaseValue…”. Rename both for clarity and symmetry with the other test.
- #[DataProvider('provideInvalidDatabaseValueInputs')] + #[DataProvider('provideInvalidPhpInputsForConvertToDatabaseValue')] #[Test] - public function throws_exception_for_invalid_database_value_inputs(mixed $phpValue): void + public function throws_exception_for_invalid_php_inputs_on_convert_to_database_value(mixed $phpValue): void { $this->expectException(InvalidGeographyForPHPException::class); $this->fixture->convertToDatabaseValue($phpValue, $this->platform); } /** * @return array<string, array{mixed}> */ - public static function provideInvalidDatabaseValueInputs(): array + public static function provideInvalidPhpInputsForConvertToDatabaseValue(): array { return [ 'random string' => ['foo'], 'integer input' => [123], 'array input' => [['not', 'geography']], 'boolean input' => [true], 'object input' => [new \stdClass()], ]; }Note: Using mixed in the parameter aligns with the team learning about database/PHP conversion tests.
99-118: Fix swapped “PHP vs Database” naming and enrich invalid DB inputs (include a resource)This test calls convertToPHPValue (DB -> PHP) but is named “…php value inputs” and uses a provider named “…PHPValue…”. Rename both; also add a stream resource case to better emulate DBAL mapping edge cases.
- #[DataProvider('provideInvalidPHPValueInputs')] + #[DataProvider('provideInvalidDatabaseInputsForConvertToPhpValue')] #[Test] - public function throws_exception_for_invalid_php_value_inputs(mixed $postgresValue): void + public function throws_exception_for_invalid_database_inputs_on_convert_to_php_value(mixed $postgresValue): void { $this->expectException(InvalidGeographyForDatabaseException::class); $this->fixture->convertToPHPValue($postgresValue, $this->platform); } /** * @return array<string, array{mixed}> */ - public static function provideInvalidPHPValueInputs(): array + public static function provideInvalidDatabaseInputsForConvertToPhpValue(): array { return [ 'empty string' => [''], 'invalid wkt' => ['INVALID_WKT'], 'missing coordinates' => ['POINT()'], 'not a string' => [123], + 'stream resource' => [\fopen('php://temp', 'rb')], ]; }This keeps the mixed parameter, satisfying the team’s preference to include non-string cases for DB-to-PHP conversion tests.
19-23: Consider typing the platform property as AbstractPlatform to avoid confusionThe property is only passed where an AbstractPlatform is required; typing it as AbstractPlatform reduces cognitive overhead. The object remains a PHPUnit mock at runtime.
- /** - * @var AbstractPlatform&MockObject - */ - private MockObject $platform; + private AbstractPlatform $platform;
32-58: Minor: keep “postgresValue” naming consistent across testsYou use $postgresValue for DB input and $wktSpatialData for PHP object; good. After renaming the two negative tests, ensure method names consistently say “…database…” when the input is $postgresValue and “…php…” when the input is $wktSpatialData.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (6)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktGeometryType.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php(2 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTest.php(1 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTest.php(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-04-11T11:23:44.192Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#340
File: tests/MartinGeorgiev/Doctrine/DBAL/Types/InetArrayTest.php:145-145
Timestamp: 2025-04-11T11:23:44.192Z
Learning: In the PostgreSQL for Doctrine test cases, methods that test database-to-PHP conversions should use `mixed` type for parameter and include non-string test cases in their data providers, following the pattern in classes like InetTest, CidrTest, and MacaddrTest.
Applied to files:
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.phptests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what TYPE_NAME constants contain and getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php
🧬 Code Graph Analysis (4)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTest.php (5)
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForDatabaseException.php (1)
InvalidGeometryForDatabaseException(14-30)src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForPHPException.php (1)
InvalidGeometryForPHPException(14-30)src/MartinGeorgiev/Doctrine/DBAL/Types/Geometry.php (1)
Geometry(21-54)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (2)
WktSpatialData(22-93)fromWkt(36-77)src/MartinGeorgiev/Doctrine/DBAL/Types/BaseType.php (1)
getName(31-36)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTest.php (6)
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeographyForDatabaseException.php (1)
InvalidGeographyForDatabaseException(14-30)src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeographyForPHPException.php (1)
InvalidGeographyForPHPException(14-30)src/MartinGeorgiev/Doctrine/DBAL/Types/Geography.php (1)
Geography(21-54)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (2)
WktSpatialData(22-93)fromWkt(36-77)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (2)
Test(90-98)TestCase(11-109)src/MartinGeorgiev/Doctrine/DBAL/Types/BaseType.php (1)
getName(31-36)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php (2)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (2)
WktSpatialData(22-93)fromWkt(36-77)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (3)
Test(90-98)TestCase(11-109)runTypeTest(31-73)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php (2)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (2)
WktSpatialData(22-93)fromWkt(36-77)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (5)
Test(90-98)TestCase(11-109)getTypeName(16-16)getPostgresTypeName(21-21)runTypeTest(31-73)
🪛 PHPMD (2.15.0)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php
31-31: Avoid unused parameters such as '$testName'. (Unused Code Rules)
(UnusedFormalParameter)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php
31-31: Avoid unused parameters such as '$testName'. (Unused Code Rules)
(UnusedFormalParameter)
🔇 Additional comments (5)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktGeometryType.php (1)
16-39: Enum coverage and naming look correct for PostGIS WKT typesThe set of cases and their string values align well with PostGIS’ supported WKT geometry types. Clear grouping and naming. No issues spotted.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
51-51: Good call using a type-specific SELECT expressionSelecting via getSelectExpressionForType() ensures PostGIS types are retrieved as EWKT strings rather than streams/resources. This avoids brittle DBAL conversions and keeps the tests deterministic.
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTest.php (1)
32-58: Unit tests exercise both conversion directions and the type name correctlyHappy path cases (including SRID) and nulls are covered, and invalid input paths are asserted separately per direction. Looks good.
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTest.php (2)
26-44: Good unit coverage and clear Arrange-Act-Assert structureSetUp, type name assertion, and the happy-path transformation tests are concise and correct.
1-16: Verified PHPUnit version supports attributes
composer.json specifies phpunit/phpunit at ^10.5.48 (PHPUnit 10+), so#[Test]and#[DataProvider]are fully supported and no changes are required.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
tests/Integration/MartinGeorgiev/TestCase.php (2)
161-177: PostGIS bootstrap is solid; consider installing WITH SCHEMA and quoting the schema.The flow is robust: install PostGIS, attempt to move it into the test schema, fall back gracefully, and set search_path plus UTC for determinism. Two optional refinements:
- Install directly into the target schema to avoid a move when creating fresh DBs.
- Quote the schema identifier for safety if the schema name ever changes away from a simple identifier.
Recommended diff within this block:
- $this->connection->executeStatement('CREATE EXTENSION IF NOT EXISTS postgis'); - // Move the extension objects into the test schema to resolve types without relying on public - $this->connection->executeStatement(\sprintf('ALTER EXTENSION postgis SET SCHEMA %s', self::DATABASE_SCHEMA)); + // Install the extension directly into the target schema when possible + $this->connection->executeStatement(\sprintf('CREATE EXTENSION IF NOT EXISTS postgis WITH SCHEMA "%s"', self::DATABASE_SCHEMA)); + // Move the extension objects into the test schema to resolve types without relying on public (no-op if already installed there) + $this->connection->executeStatement(\sprintf('ALTER EXTENSION postgis SET SCHEMA "%s"', self::DATABASE_SCHEMA));Verification note:
- Ensure the CI Postgres user has privileges to CREATE/ALTER EXTENSION. Your try/catch plus search_path fallback already mitigates environments where moving the extension isn’t allowed.
188-190: Registering 'geography' and 'geometry' types: LGTM. Optionally map platform types for schema introspection.Type registration is correct. If you rely on DB introspection or migrations detecting these types reliably, consider adding platform type mappings so DBAL doesn’t treat them as unknown.
You can add this snippet after the foreach in registerCustomTypes() (outside the changed lines):
// Ensure the platform recognizes custom types returned by introspection $platform = $this->connection->getDatabasePlatform(); $platform->registerDoctrineTypeMapping('geography', 'geography'); $platform->registerDoctrineTypeMapping('geometry', 'geometry');
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
.github/workflows/integration-tests.yml(2 hunks)tests/Integration/MartinGeorgiev/TestCase.php(3 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTest.php(1 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTest.php(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTest.php
- tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTest.php
- .github/workflows/integration-tests.yml
🧰 Additional context used
🧠 Learnings (6)
📚 Learning: 2025-03-29T03:31:17.114Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#318
File: tests/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/XmlAggTest.php:1-9
Timestamp: 2025-03-29T03:31:17.114Z
Learning: Tests in the `Tests\MartinGeorgiev\Doctrine\ORM\Query\AST\Functions` namespace extend a custom `TestCase` class from the same namespace (`Tests\MartinGeorgiev\Doctrine\ORM\Query\AST\Functions\TestCase`), rather than PHPUnit's TestCase, and therefore don't need an explicit import.
Applied to files:
tests/Integration/MartinGeorgiev/TestCase.php
📚 Learning: 2025-05-23T11:11:57.951Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#383
File: tests/Unit/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/RadiansTest.php:1-9
Timestamp: 2025-05-23T11:11:57.951Z
Learning: Tests in the `Tests\Unit\MartinGeorgiev\Doctrine\ORM\Query\AST\Functions` namespace extend a custom `TestCase` class from the same namespace (`Tests\Unit\MartinGeorgiev\Doctrine\ORM\Query\AST\Functions\TestCase`), rather than PHPUnit's TestCase directly, and therefore don't need an explicit import.
Applied to files:
tests/Integration/MartinGeorgiev/TestCase.php
📚 Learning: 2025-03-29T03:31:17.114Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#318
File: tests/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/XmlAggTest.php:1-9
Timestamp: 2025-03-29T03:31:17.114Z
Learning: Tests in the `Tests\MartinGeorgiev\Doctrine\ORM\Query\AST\Functions` namespace extend a custom `TestCase` class from the same namespace (`Tests\MartinGeorgiev\Doctrine\ORM\Query\AST\Functions\TestCase`), not PHPUnit's TestCase, and therefore don't need an explicit import statement.
Applied to files:
tests/Integration/MartinGeorgiev/TestCase.php
📚 Learning: 2025-04-11T11:23:44.192Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#340
File: tests/MartinGeorgiev/Doctrine/DBAL/Types/InetArrayTest.php:145-145
Timestamp: 2025-04-11T11:23:44.192Z
Learning: In the PostgreSQL for Doctrine test cases, methods that test database-to-PHP conversions should use `mixed` type for parameter and include non-string test cases in their data providers, following the pattern in classes like InetTest, CidrTest, and MacaddrTest.
Applied to files:
tests/Integration/MartinGeorgiev/TestCase.php
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
tests/Integration/MartinGeorgiev/TestCase.php
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what TYPE_NAME constants contain and getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
tests/Integration/MartinGeorgiev/TestCase.php
🧬 Code Graph Analysis (1)
tests/Integration/MartinGeorgiev/TestCase.php (2)
src/MartinGeorgiev/Doctrine/DBAL/Types/Geography.php (1)
Geography(21-54)src/MartinGeorgiev/Doctrine/DBAL/Types/Geometry.php (1)
Geometry(21-54)
🔇 Additional comments (1)
tests/Integration/MartinGeorgiev/TestCase.php (1)
22-23: Geography/Geometry DBAL imports are correct and consistent.Imports align with the newly registered types below and keep responsibility local to integration tests.
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
devenv.nix (1)
76-87: Idempotent role creation/alteration implemented correctly (resolves prior comment); minor nit: explicitly set languageThis addresses the earlier idempotency issue for CREATE ROLE vs. existing postgres role — nice. As a minor hardening, explicitly specify LANGUAGE plpgsql for the DO block to avoid relying on defaults across versions.
Apply this diff within the DO block terminator:
- $$; + $$ LANGUAGE plpgsql;
🧹 Nitpick comments (11)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTest.php (5)
32-36: Prefer assertSame for strictnessUse assertSame to avoid type juggling and make the intent explicit when comparing strings.
Apply this diff:
- self::assertEquals('geometry', $this->fixture->getName()); + self::assertSame('geometry', $this->fixture->getName());
45-58: Tighten equality assertion in the happy pathThe string comparison is fine; using assertSame makes the assertion a bit stricter. Everything else in this block looks good.
Apply this diff:
- self::assertInstanceOf(WktSpatialData::class, $result); - self::assertEquals((string) $wktSpatialData, (string) $result); + self::assertInstanceOf(WktSpatialData::class, $result); + self::assertSame((string) $wktSpatialData, (string) $result);
60-103: Broaden valid cases to cover more WKT types (optional)Consider adding a few more representative geometries to increase confidence across the enum: MULTIPOINT, MULTILINESTRING, MULTIPOLYGON, GEOMETRYCOLLECTION, and a case with extra whitespace (trim/regex robustness).
Example additions:
'point z with srid' => [ 'wktSpatialData' => WktSpatialData::fromWkt('SRID=4326;POINT Z(-122.4194 37.7749 100)'), 'postgresValue' => 'SRID=4326;POINT Z(-122.4194 37.7749 100)', ], + 'multipoint' => [ + 'wktSpatialData' => WktSpatialData::fromWkt('MULTIPOINT((1 2),(3 4))'), + 'postgresValue' => 'MULTIPOINT((1 2),(3 4))', + ], + 'multilinestring' => [ + 'wktSpatialData' => WktSpatialData::fromWkt('MULTILINESTRING((0 0, 1 1),(2 2, 3 3))'), + 'postgresValue' => 'MULTILINESTRING((0 0, 1 1),(2 2, 3 3))', + ], + 'multipolygon' => [ + 'wktSpatialData' => WktSpatialData::fromWkt('MULTIPOLYGON(((0 0,0 1,1 1,1 0,0 0)),((2 2,2 3,3 3,3 2,2 2)))'), + 'postgresValue' => 'MULTIPOLYGON(((0 0,0 1,1 1,1 0,0 0)),((2 2,2 3,3 3,3 2,2 2)))', + ], + 'geometrycollection' => [ + 'wktSpatialData' => WktSpatialData::fromWkt('GEOMETRYCOLLECTION(POINT(1 2),LINESTRING(0 0, 1 1))'), + 'postgresValue' => 'GEOMETRYCOLLECTION(POINT(1 2),LINESTRING(0 0, 1 1))', + ], + 'whitespace and casing robustness' => [ + 'wktSpatialData' => WktSpatialData::fromWkt('POINT(1 2)'), // expected normalization + 'postgresValue' => ' POINT(1 2) ', + ],
105-112: Fix mismatched naming: these are invalid PHP values for convertToDatabaseValue()This test feeds PHP values into convertToDatabaseValue(). Rename the test and its data provider for clarity.
Apply this diff:
- #[DataProvider('provideInvalidDatabaseValueInputs')] + #[DataProvider('provideInvalidPhpValuesForDatabaseConversion')] #[Test] - public function throws_exception_for_invalid_database_value_inputs(mixed $phpValue): void + public function throws_exception_for_invalid_php_values_on_convert_to_database(mixed $phpValue): void { $this->expectException(InvalidGeometryForPHPException::class); $this->fixture->convertToDatabaseValue($phpValue, $this->platform); } @@ - public static function provideInvalidDatabaseValueInputs(): array + public static function provideInvalidPhpValuesForDatabaseConversion(): arrayAlso applies to: 116-116
127-133: Fix mismatched naming: these are invalid database values for convertToPHPValue()This test feeds database values into convertToPHPValue(). Rename the test and its data provider for clarity.
Apply this diff:
- #[DataProvider('provideInvalidPHPValueInputs')] + #[DataProvider('provideInvalidDatabaseValuesForPhpConversion')] #[Test] - public function throws_exception_for_invalid_php_value_inputs(mixed $postgresValue): void + public function throws_exception_for_invalid_database_values_on_convert_to_php(mixed $postgresValue): void { $this->expectException(InvalidGeometryForDatabaseException::class); $this->fixture->convertToPHPValue($postgresValue, $this->platform); } @@ - public static function provideInvalidPHPValueInputs(): array + public static function provideInvalidDatabaseValuesForPhpConversion(): arrayAlso applies to: 138-138
devenv.nix (1)
71-74: PostGIS extension declared at package level — looks good; consider future-proofingDeclaring extensions.postgis here is the right hook so CREATE EXTENSION works later in the DB. If you plan on using topology/raster, you can extend this list when needed.
Example (only if/when you need them):
extensions = extensions: [ extensions.postgis + # extensions.postgis_raster + # extensions.postgis_topology ];tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php (3)
31-34: Remove unused parameter to satisfy PHPMD and reduce noise$testName isn’t used. Drop it from the signature.
- public function can_handle_geometry_values(string $testName, WktSpatialData $wktSpatialData): void + public function can_handle_geometry_values(WktSpatialData $wktSpatialData): void { $this->runTypeTest($this->getTypeName(), $this->getPostgresTypeName(), $wktSpatialData); }
36-52: Align data provider shape after removing unused parameterUpdate the docblock and each case to provide only the WktSpatialData argument.
- /** - * @return array<string, array{string, WktSpatialData}> - */ + /** + * @return array<string, array{WktSpatialData}> + */ public static function provideValidTransformations(): array { return [ - 'point' => ['point', WktSpatialData::fromWkt('POINT(1 2)')], - 'linestring' => ['linestring', WktSpatialData::fromWkt('LINESTRING(0 0, 1 1, 2 2)')], - 'polygon' => ['polygon', WktSpatialData::fromWkt('POLYGON((0 0, 0 1, 1 1, 1 0, 0 0))')], - 'geometrycollection' => ['geometrycollection', WktSpatialData::fromWkt('GEOMETRYCOLLECTION(POINT(1 2), LINESTRING(0 0, 1 1))')], - 'point with srid' => ['point with srid', WktSpatialData::fromWkt('SRID=4326;POINT(-122.4194 37.7749)')], - 'point z' => ['point z', WktSpatialData::fromWkt('POINT Z(1 2 3)')], - 'linestring m' => ['linestring m', WktSpatialData::fromWkt('LINESTRING M(0 0 1, 1 1 2)')], - 'polygon zm' => ['polygon zm', WktSpatialData::fromWkt('POLYGON ZM((0 0 0 1, 0 1 0 1, 1 1 0 1, 1 0 0 1, 0 0 0 1))')], - 'point z with srid' => ['point z with srid', WktSpatialData::fromWkt('SRID=4326;POINT Z(-122.4194 37.7749 100)')], + 'point' => [WktSpatialData::fromWkt('POINT(1 2)')], + 'linestring' => [WktSpatialData::fromWkt('LINESTRING(0 0, 1 1, 2 2)')], + 'polygon' => [WktSpatialData::fromWkt('POLYGON((0 0, 0 1, 1 1, 1 0, 0 0))')], + 'geometrycollection' => [WktSpatialData::fromWkt('GEOMETRYCOLLECTION(POINT(1 2), LINESTRING(0 0, 1 1))')], + 'point with srid' => [WktSpatialData::fromWkt('SRID=4326;POINT(-122.4194 37.7749)')], + 'point z' => [WktSpatialData::fromWkt('POINT Z(1 2 3)')], + 'linestring m' => [WktSpatialData::fromWkt('LINESTRING M(0 0 1, 1 1 2)')], + 'polygon zm' => [WktSpatialData::fromWkt('POLYGON ZM((0 0 0 1, 0 1 0 1, 1 1 0 1, 1 0 0 1, 0 0 0 1))')], + 'point z with srid' => [WktSpatialData::fromWkt('SRID=4326;POINT Z(-122.4194 37.7749 100)')], ]; }
39-52: Optional: add MULTI coverage for completeness*Broaden coverage with multipoint/multilinestring/multipolygon cases.
return [ + 'multipoint' => [WktSpatialData::fromWkt('MULTIPOINT((1 2), (4 5))')], + 'multilinestring' => [WktSpatialData::fromWkt('MULTILINESTRING((0 0, 1 1), (2 2, 3 3))')], + 'multipolygon' => [WktSpatialData::fromWkt('MULTIPOLYGON(((0 0, 0 1, 1 1, 1 0, 0 0)))')], ];tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php (2)
31-34: Remove unused parameter to satisfy PHPMD and reduce noiseSame as Geometry test: drop the unused $testName parameter.
- public function can_handle_geography_values(string $testName, WktSpatialData $wktSpatialData): void + public function can_handle_geography_values(WktSpatialData $wktSpatialData): void { $this->runTypeTest($this->getTypeName(), $this->getPostgresTypeName(), $wktSpatialData); }
36-50: Align data provider shape after removing unused parameter; add SRID caseUpdate the docblock and cases; include an explicit SRID=4326 case (common for geography).
- /** - * @return array<string, array{string, WktSpatialData}> - */ + /** + * @return array<string, array{WktSpatialData}> + */ public static function provideValidTransformations(): array { return [ - 'point' => ['point', WktSpatialData::fromWkt('POINT(1 2)')], - 'linestring' => ['linestring', WktSpatialData::fromWkt('LINESTRING(0 0, 1 1, 2 2)')], - 'polygon' => ['polygon', WktSpatialData::fromWkt('POLYGON((0 0, 0 1, 1 1, 1 0, 0 0))')], - 'geometrycollection' => ['geometrycollection', WktSpatialData::fromWkt('GEOMETRYCOLLECTION(POINT(1 2), LINESTRING(0 0, 1 1))')], - 'point z' => ['point z', WktSpatialData::fromWkt('POINT Z(-122.4194 37.7749 100)')], - 'linestring m' => ['linestring m', WktSpatialData::fromWkt('LINESTRING M(-122.4194 37.7749 1, -122.4094 37.7849 2)')], - 'polygon zm' => ['polygon zm', WktSpatialData::fromWkt('POLYGON ZM((-122.5 37.7 0 1, -122.5 37.8 0 1, -122.4 37.8 0 1, -122.4 37.7 0 1, -122.5 37.7 0 1))')], + 'point' => [WktSpatialData::fromWkt('POINT(1 2)')], + 'point with srid' => [WktSpatialData::fromWkt('SRID=4326;POINT(-122.4194 37.7749)')], + 'linestring' => [WktSpatialData::fromWkt('LINESTRING(0 0, 1 1, 2 2)')], + 'polygon' => [WktSpatialData::fromWkt('POLYGON((0 0, 0 1, 1 1, 1 0, 0 0))')], + 'geometrycollection' => [WktSpatialData::fromWkt('GEOMETRYCOLLECTION(POINT(1 2), LINESTRING(0 0, 1 1))')], + 'point z' => [WktSpatialData::fromWkt('POINT Z(-122.4194 37.7749 100)')], + 'linestring m' => [WktSpatialData::fromWkt('LINESTRING M(-122.4194 37.7749 1, -122.4094 37.7849 2)')], + 'polygon zm' => [WktSpatialData::fromWkt('POLYGON ZM((-122.5 37.7 0 1, -122.5 37.8 0 1, -122.4 37.8 0 1, -122.4 37.7 0 1, -122.5 37.7 0 1))')], ]; }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (7)
devenv.nix(1 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php(1 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTest.php(1 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTest.php(1 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialDataTest.php(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTest.php
- src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-04-11T11:23:44.192Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#340
File: tests/MartinGeorgiev/Doctrine/DBAL/Types/InetArrayTest.php:145-145
Timestamp: 2025-04-11T11:23:44.192Z
Learning: In the PostgreSQL for Doctrine test cases, methods that test database-to-PHP conversions should use `mixed` type for parameter and include non-string test cases in their data providers, following the pattern in classes like InetTest, CidrTest, and MacaddrTest.
Applied to files:
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php
📚 Learning: 2025-05-07T02:15:24.181Z
Learnt from: janklan
PR: martin-georgiev/postgresql-for-doctrine#370
File: docker-compose.yml:0-0
Timestamp: 2025-05-07T02:15:24.181Z
Learning: When working with the official PostgreSQL Docker image, port configuration should be done via the Docker Compose `ports` mapping rather than through a `POSTGRES_PORT` environment variable. The official image only consumes specific environment variables like `POSTGRES_USER`, `POSTGRES_PASSWORD`, and `POSTGRES_DB`, but not port configuration.
Applied to files:
devenv.nix
🧬 Code Graph Analysis (4)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTest.php (5)
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForDatabaseException.php (1)
InvalidGeometryForDatabaseException(14-30)src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForPHPException.php (1)
InvalidGeometryForPHPException(14-30)src/MartinGeorgiev/Doctrine/DBAL/Types/Geometry.php (1)
Geometry(21-54)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (2)
WktSpatialData(22-104)fromWkt(46-88)src/MartinGeorgiev/Doctrine/DBAL/Types/BaseType.php (1)
getName(31-36)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php (2)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (2)
WktSpatialData(22-104)fromWkt(46-88)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (4)
Test(90-98)TestCase(11-109)getTypeName(16-16)runTypeTest(31-73)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php (2)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (2)
WktSpatialData(22-104)fromWkt(46-88)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (5)
Test(90-98)TestCase(11-109)getTypeName(16-16)getPostgresTypeName(21-21)runTypeTest(31-73)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialDataTest.php (2)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidWktSpatialDataException.php (1)
InvalidWktSpatialDataException(19-56)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (5)
WktSpatialData(22-104)fromWkt(46-88)getGeometryType(95-98)getSrid(90-93)getWkt(100-103)
🪛 PHPMD (2.15.0)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php
31-31: Avoid unused parameters such as '$testName'. (Unused Code Rules)
(UnusedFormalParameter)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php
31-31: Avoid unused parameters such as '$testName'. (Unused Code Rules)
(UnusedFormalParameter)
🔇 Additional comments (12)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTest.php (3)
17-30: Good test scaffolding and fixturesClean setup with an AbstractPlatform mock and a dedicated Geometry fixture. Solid base for the conversion tests.
38-44: DB-to-DB value conversion test looks correctThe from-PHP conversion path is covered well, including the null case via the shared provider.
127-146: Nice: DB-to-PHP negative cases use mixed parameter as per project conventionsThe invalid DB value test takes mixed and includes a non-string case, matching prior guidance for DB→PHP conversion tests (e.g., Inet/Cidr/Macaddr).
Note: Referencing your documented preference from earlier work; thanks for keeping it consistent.
devenv.nix (2)
63-65: PG 17 pin aligns with CI/Docker — good choiceUsing pkgs.postgresql_17 keeps local dev consistent with the CI matrix and docker-compose image. No concerns.
91-94: Enabling PostGIS in target DB via psql meta-command is appropriateThe use of \c and CREATE EXTENSION IF NOT EXISTS is correct for initializing the test database with PostGIS.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php (1)
23-28: Null handling test is appropriateRound-tripping null through the type and ensuring it stays null is correct.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php (2)
41-49: Confirm geography support for Z/M and geometrycollection across PostGIS versionsPostGIS geography commonly defaults to SRID 4326. Support for Z/M dimensions and GEOMETRYCOLLECTION in geography can vary and/or drop dimensions on cast. Please verify these cases behave as round-trippable values on your CI matrix (PostGIS 3.4/3.5). If Z/M are stripped or GEOMETRYCOLLECTION isn’t supported, consider moving those to geometry-only tests or adjusting expectations.
23-28: Null handling test is appropriateRound-tripping null through the geography type is implemented correctly.
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialDataTest.php (4)
16-26: Round-trip and accessors are validated wellGood coverage of fromWkt(), getGeometryType(), getSrid(), getWkt(), and __toString() with canonical WKT/EWKT inputs.
31-45: Balanced set of valid WKT/EWKT casesCovers SRID, dimensional modifiers, and multiple geometry families — solid.
47-54: Exception paths are exercised appropriatelyInvalid EWKT/WKT scenarios are covered and map to the dedicated exception factories.
71-79: Dimensional modifier preservation is asserted correctlyEnsures Z/M/ZM are preserved in round-trip; helpful for downstream type conversions.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (12)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTest.php (4)
22-28: Type the platform as AbstractPlatform (with mock intersection) to satisfy static analysisCurrent property type MockObject triggers param-type warnings when passed to convertTo* methods expecting AbstractPlatform.
Apply this diff:
- private MockObject $platform; + /** @var AbstractPlatform&MockObject */ + private AbstractPlatform $platform;
109-121: Assert the result is an array before assertCount()/foreach to silence array|null warningsconvertToPHPValue() returns array|null in the base type, so static analysis warns for assertCount and foreach. Assert array explicitly.
public function can_convert_valid_postgres_arrays_to_php_value(string $postgresArray, array $expectedPhpArray): void { $result = $this->type->convertToPHPValue($postgresArray, $this->platform); - self::assertCount(\count($expectedPhpArray), $result); + self::assertIsArray($result); + self::assertCount(\count($expectedPhpArray), $result); foreach ($result as $index => $item) { self::assertInstanceOf(WktSpatialData::class, $item); self::assertSame($expectedPhpArray[$index], (string) $item); } }
156-165: Assert the round-tripped value is an array before assertCount()/foreachSame array|null issue as above during the PHP -> DB -> PHP round-trip.
$databaseValue = $this->type->convertToDatabaseValue($phpArray, $this->platform); $convertedBack = $this->type->convertToPHPValue($databaseValue, $this->platform); - self::assertCount(\count($phpArray), $convertedBack); + self::assertIsArray($convertedBack); + self::assertCount(\count($phpArray), $convertedBack); foreach ($convertedBack as $index => $item) { self::assertInstanceOf(WktSpatialData::class, $item); self::assertSame((string) $phpArray[$index], (string) $item); }
109-112: Consider widening the input type to mixed and adding non-string cases for DB→PHP conversion testsProject convention for DB→PHP conversion tests uses mixed and includes non-string inputs to assert proper exception behavior. You may want to mirror Inet/Cidr/Macaddr test patterns here.
Happy to draft the additional data providers and tests for invalid types (e.g., integers, arrays, objects) raising the expected InvalidGeometryForDatabaseException.
tests/Integration/MartinGeorgiev/TestCase.php (1)
164-177: PostGIS setup: good fallback; optionally install directly into the test schemaThe create-and-alter approach is fine with a fallback. Optionally try creating into the schema upfront to avoid ALTER when possible:
- // Ensure PostGIS is installed and, if possible, placed in the test schema - $this->connection->executeStatement('CREATE EXTENSION IF NOT EXISTS postgis'); - // Move the extension objects into the test schema to resolve types without relying on public - $this->connection->executeStatement(\sprintf('ALTER EXTENSION postgis SET SCHEMA %s', self::DATABASE_SCHEMA)); + // Ensure PostGIS is installed into the test schema when possible, otherwise move it after creation + $this->connection->executeStatement(\sprintf('CREATE EXTENSION IF NOT EXISTS postgis SCHEMA %s', self::DATABASE_SCHEMA)); + $this->connection->executeStatement(\sprintf('ALTER EXTENSION postgis SET SCHEMA %s', self::DATABASE_SCHEMA));Keeping public in search_path as a fallback is a nice touch and should keep tests stable across environments.
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTest.php (4)
22-28: Type the platform as AbstractPlatform (with mock intersection) to satisfy static analysisMirror the fix from the geometry array unit test to eliminate MockObject type complaints when passing the platform to convert methods.
- private MockObject $platform; + /** @var AbstractPlatform&MockObject */ + private AbstractPlatform $platform;
117-129: Assert the result is an array before assertCount()/foreach to silence array|null warningsconvertToPHPValue() returns array|null; asserting array resolves the static analysis issues for assertCount and foreach.
public function can_convert_valid_postgres_arrays_to_php_value(string $postgresArray, array $expectedPhpArray): void { $result = $this->type->convertToPHPValue($postgresArray, $this->platform); - self::assertCount(\count($expectedPhpArray), $result); + self::assertIsArray($result); + self::assertCount(\count($expectedPhpArray), $result); foreach ($result as $index => $item) { self::assertInstanceOf(WktSpatialData::class, $item); self::assertSame($expectedPhpArray[$index], (string) $item); } }
164-174: Assert the round-tripped value is an array before assertCount()/foreachSame rationale as above; ensures static analysis is happy and documents expectations.
$databaseValue = $this->type->convertToDatabaseValue($phpArray, $this->platform); $convertedBack = $this->type->convertToPHPValue($databaseValue, $this->platform); - self::assertCount(\count($phpArray), $convertedBack); + self::assertIsArray($convertedBack); + self::assertCount(\count($phpArray), $convertedBack); foreach ($convertedBack as $index => $item) { self::assertInstanceOf(WktSpatialData::class, $item); self::assertSame((string) $phpArray[$index], (string) $item); }
119-119: Optionally widen the test argument type to mixed and add non-string casesAlign with existing array-type tests by accepting mixed and adding non-string input cases to assert InvalidGeographyForDatabaseException.
I can add a complementary data provider with integers/arrays/objects and the corresponding exception assertions if helpful.
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php (1)
19-26: Avoid casting mixed to string; use WktSpatialData API and annotate for analyzersStatic analysis flags (string) $item on mixed. After validation, $item is a WktSpatialData; use its API and add a local assertion/comment for analyzers.
protected function transformArrayItemForPostgres(mixed $item): string { if (!$this->isValidArrayItemForDatabase($item)) { throw InvalidGeometryForPHPException::forInvalidType($item); } - return (string) $item; + /** @var \MartinGeorgiev\Doctrine\DBAL\Types\ValueObject\WktSpatialData $item */ + return $item->getWkt(); }Alternatively, import the class at the top:
use Doctrine\DBAL\Types\ConversionException; use MartinGeorgiev\Doctrine\DBAL\Types\Exceptions\InvalidGeometryForPHPException; +use MartinGeorgiev\Doctrine\DBAL\Types\ValueObject\WktSpatialData;and use the shorter annotation:
/** @var WktSpatialData $item */src/MartinGeorgiev/Doctrine/DBAL/Types/SpatialDataArray.php (1)
30-83: Consider validating bracket depth balance and handling escaped charactersThe parsing logic tracks bracket depth but doesn't validate that brackets are properly balanced at the end. Additionally, it doesn't handle potential escaped characters within WKT strings (though this may not be an issue for standard WKT format).
Consider adding validation after the loop:
// Add the last WKT item if there's content if ($currentWktItem !== '') { $wktItems[] = $currentWktItem; } + + // Validate brackets are balanced + if ($nestedBracketDepth !== 0) { + throw new \InvalidArgumentException('Unbalanced brackets in PostgreSQL array'); + } return \array_map('trim', $wktItems);tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php (1)
39-44: Consider adding test cases for extremely long coordinate listsWhile the test coverage is comprehensive, you might want to add a test case with geometries containing many coordinates to ensure the array parsing handles large datasets efficiently.
Would you like me to generate additional test cases for large polygons or linestrings with hundreds of coordinates to stress-test the array parsing logic?
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (14)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/DimensionalModifier.php (1)
17-36: Add convenience helpers for Z/M presence and dimension count.These tiny methods reduce repeated branching at call sites and improve readability when formatting or validating coordinates.
Apply this diff to add helpers:
enum DimensionalModifier: string { case Z = 'Z'; case M = 'M'; case ZM = 'ZM'; + + public function hasZ(): bool + { + return $this === self::Z || $this === self::ZM; + } + + public function hasM(): bool + { + return $this === self::M || $this === self::ZM; + } + + /** + * Base XY (2D) plus optional Z and/or M. + */ + public function dimensionCount(): int + { + return 2 + ($this->hasZ() ? 1 : 0) + ($this->hasM() ? 1 : 0); + } }src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/GeometryType.php (1)
28-37: Optionally expose simple categorization helpers.If callers will branch on “is collection/curve/surface,” consider instance helpers to avoid scattering switches.
Example extension:
enum GeometryType: string { // cases... + + public function isCollection(): bool + { + return $this === self::GEOMETRYCOLLECTION; + } + + public function isMulti(): bool + { + return \in_array($this, [self::MULTIPOINT, self::MULTILINESTRING, self::MULTIPOLYGON, self::MULTICURVE, self::MULTISURFACE], true); + } + + public function isCurved(): bool + { + return \in_array($this, [self::CIRCULARSTRING, self::COMPOUNDCURVE, self::CURVEPOLYGON], true); + } }tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/GeometryTypeTest.php (1)
41-63: Minor: consider a guard ensuring the test dataset stays in sync with the enum.Adding an assertion over GeometryType::cases() prevents accidental drift when cases are added later.
You can add:
#[Test] public function dataset_matches_enum_cases(): void { $expected = \array_map(static fn(GeometryType $t) => $t->value, GeometryType::cases()); $provided = \array_map(static fn(array $row) => $row[0], self::provideValidGeometryTypes()); self::assertSame($expected, $provided, 'Update provideValidGeometryTypes() when adding new cases.'); }tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
100-109: Reviewunnest()usages for optional ordinalityI ran the ripgrep scan and found three unnest calls without WITH ORDINALITY in tests:
• tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (geometry[] and geography[])
• tests/Unit/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/UnnestTest.php (textArray)The original diff still applies for the PostGIS types in TestCase.php; adding ordinality there makes the element order explicit and more robust:
private function getSelectExpressionForType(string $typeName, string $columnName): string { // Ensure we get a text representation for PostGIS types that DBAL might map to resource/stream return match ($typeName) { 'geometry' => \sprintf('ST_AsEWKT("%s") AS "%s"', $columnName, $columnName), 'geography' => \sprintf('ST_AsEWKT("%s"::geometry) AS "%s"', $columnName, $columnName), - 'geometry[]' => \sprintf('ARRAY(SELECT CASE WHEN ST_SRID(geom) = 0 THEN ST_AsText(geom) ELSE \'SRID=\' || ST_SRID(geom) || \';\' || ST_AsText(geom) END FROM unnest("%s") AS geom) AS "%s"', $columnName, $columnName), - 'geography[]' => \sprintf('ARRAY(SELECT CASE WHEN ST_SRID(geog::geometry) = 0 THEN ST_AsText(geog::geometry) ELSE \'SRID=\' || ST_SRID(geog::geometry) || \';\' || ST_AsText(geog::geometry) END FROM unnest("%s") AS geog) AS "%s"', $columnName, $columnName), + 'geometry[]' => \sprintf( + 'ARRAY(SELECT ST_AsEWKT(geom) FROM unnest("%s") WITH ORDINALITY AS t(geom, ord) ORDER BY ord) AS "%s"', + $columnName, + $columnName + ), + 'geography[]' => \sprintf( + 'ARRAY(SELECT ST_AsEWKT(geog::geometry) FROM unnest("%s") WITH ORDINALITY AS t(geog, ord) ORDER BY ord) AS "%s"', + $columnName, + $columnName + ), default => $columnName, }; }Additionally, there’s an
unnest(c0_.textArray)in UnnestTest.php (line 22) that you may choose to update similarly if you ever need to guarantee ordering in that context. Adjusting it would require updating the expected SQL in the test, so this is fully optional.src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (4)
71-81: Consider optional support for “EMPTY” geometries.WKT allows tokens like POINT EMPTY / POLYGON EMPTY (and with Z/M/ZM). Supporting these would require:
- Extending the regex to accept the EMPTY branch, and
- Adjusting __toString() to omit parentheses for EMPTY cases.
If out of scope for this PR, fine to defer, but worth tracking.
I can propose a follow-up patch adding EMPTY support while preserving current behavior.
76-79: Micro: use enum::from when the regex already restricts the domain.Given the pattern only captures ZM|Z|M, tryFrom can be replaced with from (and will never throw here).
Apply this diff:
- $dimensionalModifier = empty($matches[2]) ? null : DimensionalModifier::tryFrom($matches[2]); + $dimensionalModifier = ($matches[2] ?? '') !== '' ? DimensionalModifier::from($matches[2]) : null;
7-9: Nit: redundant import inside the same namespace.DimensionalModifier is in the same namespace; the use statement can be dropped.
Apply this diff:
-use MartinGeorgiev\Doctrine\DBAL\Types\ValueObject\DimensionalModifier; use MartinGeorgiev\Doctrine\DBAL\Types\ValueObject\Exceptions\InvalidWktSpatialDataException;
106-109: Method name might be misleading: returns EWKT when SRID is present.Either rename to asEwkt() (and keep getWkt() as an alias) or expand the docblock to clarify it returns WKT or EWKT depending on SRID.
Example additive change:
public function getWkt(): string { - return (string) $this; + // Returns WKT or EWKT (if SRID is present) + return (string) $this; } + + /** + * Explicit alias for callers expecting EWKT when SRID is present. + */ + public function asEwkt(): string + { + return (string) $this; + }tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialDataTest.php (6)
19-27: Reduce coupling to exact formatting; add explicit canonicalization checks instead of duplicating assertionsYou assert both
getWkt()and(string)$wktSpatialDataequal the original input. This couples the test to exact input formatting and duplicates coverage becausegetWkt()returns__toString(). Prefer a single assertion and add targeted canonicalization tests (e.g., trimming, spacing) to validate normalization rules.Apply this diff to deduplicate, plus add a separate canonicalization test scaffold further below (see a later comment for the full addition):
- self::assertSame($wkt, $wktSpatialData->getWkt()); - self::assertSame($wkt, (string) $wktSpatialData); + self::assertSame($wkt, (string) $wktSpatialData);
41-55: Broaden positive coverage to all supported types (MULTILINESTRING, MULTIPOLYGON, GEOMETRYCOLLECTION) and SRID on non-POINTGreat dataset. To validate
GeometryType::from(...)across the board and ensure SRID handling isn’t POINT-specific, add a few more items.Apply this diff:
@@ public static function provideValidWkt(): array return [ 'point' => ['POINT(1 2)', 'POINT', null], 'point with srid' => ['SRID=4326;POINT(-122.4194 37.7749)', 'POINT', 4326], 'linestring' => ['LINESTRING(0 0, 1 1, 2 2)', 'LINESTRING', null], 'polygon' => ['POLYGON((0 0, 0 1, 1 1, 1 0, 0 0))', 'POLYGON', null], 'point z' => ['POINT Z(1 2 3)', 'POINT', null], 'linestring m' => ['LINESTRING M(0 0 1, 1 1 2)', 'LINESTRING', null], 'polygon zm' => ['POLYGON ZM((0 0 0 1, 0 1 0 1, 1 1 0 1, 1 0 0 1, 0 0 0 1))', 'POLYGON', null], 'point z with srid' => ['SRID=4326;POINT Z(-122.4194 37.7749 100)', 'POINT', 4326], 'multipoint z' => ['MULTIPOINT Z((1 2 3), (4 5 6))', 'MULTIPOINT', null], 'geometrycollection m' => ['GEOMETRYCOLLECTION M(POINT M(1 2 3), LINESTRING M(0 0 1, 1 1 2))', 'GEOMETRYCOLLECTION', null], + 'multilinestring' => ['MULTILINESTRING((0 0, 1 1), (2 2, 3 3))', 'MULTILINESTRING', null], + 'multipolygon' => ['MULTIPOLYGON(((0 0, 1 0, 1 1, 0 0)))', 'MULTIPOLYGON', null], + 'geometrycollection' => ['GEOMETRYCOLLECTION(POINT(1 2), LINESTRING(0 0, 1 1))', 'GEOMETRYCOLLECTION', null], + 'linestring with srid' => ['SRID=3857;LINESTRING(0 0, 1 1)', 'LINESTRING', 3857], ];
68-79: Strengthen negative cases (empty/negative SRID, lowercase tokens, unknown modifier, junk suffix)These add resilience and lock down error messaging pathways for the dedicated exception factory methods.
Apply this diff:
@@ public static function provideInvalidWkt(): array return [ 'empty' => [''], 'missing semicolon after srid' => ['SRID=4326POINT(1 2)'], 'invalid srid' => ['SRID=abc;POINT(1 2)'], + 'empty srid' => ['SRID=;POINT(1 2)'], + 'negative srid' => ['SRID=-1;POINT(1 2)'], 'invalid body' => ['POINT()'], 'invalid format' => ['INVALID_WKT'], 'unsupported geometry type' => ['UNSUPPORTED(1 2)'], 'whitespace-only coordinates' => ['POINT( )'], + 'lowercase srid prefix' => ['srid=4326;POINT(1 2)'], + 'lowercase type' => ['point(1 2)'], + 'unknown modifier' => ['POINT Q(1 2 3)'], + 'junk after body' => ['POINT(1 2)) trailing'], ];
94-113: Exercise more dimensional/modifier + type combinations (including GEOMETRYCOLLECTION M)To ensure modifiers are preserved across all complex types, extend the round-trip dataset.
Apply this diff:
@@ public static function provideDimensionalModifierRoundTripCases(): array return [ 'point z' => ['POINT Z(1 2 3)'], 'point m' => ['POINT M(1 2 3)'], 'point zm' => ['POINT ZM(1 2 3 4)'], 'linestring z' => ['LINESTRING Z(0 0 1, 1 1 2)'], 'linestring m' => ['LINESTRING M(0 0 1, 1 1 2)'], 'linestring zm' => ['LINESTRING ZM(0 0 1 2, 1 1 3 4)'], 'polygon z' => ['POLYGON Z((0 0 1, 0 1 1, 1 1 1, 1 0 1, 0 0 1))'], 'polygon m' => ['POLYGON M((0 0 1, 0 1 2, 1 1 3, 1 0 4, 0 0 1))'], 'polygon zm' => ['POLYGON ZM((0 0 0 1, 0 1 0 1, 1 1 0 1, 1 0 0 1, 0 0 0 1))'], 'multipoint z' => ['MULTIPOINT Z((1 2 3), (4 5 6))'], 'multilinestring m' => ['MULTILINESTRING M((0 0 1, 1 1 2), (2 2 3, 3 3 4))'], 'multipolygon zm' => ['MULTIPOLYGON ZM(((0 0 0 1, 0 1 0 1, 1 1 0 1, 1 0 0 1, 0 0 0 1)))'], 'geometrycollection z' => ['GEOMETRYCOLLECTION Z(POINT Z(1 2 3), LINESTRING Z(0 0 1, 1 1 2))'], + 'geometrycollection m' => ['GEOMETRYCOLLECTION M(POINT M(1 2 3), LINESTRING M(0 0 1, 1 1 2))'], 'srid with point z' => ['SRID=4326;POINT Z(-122.4194 37.7749 100)'], 'srid with polygon zm' => ['SRID=4326;POLYGON ZM((-122.5 37.7 0 1, -122.5 37.8 0 1, -122.4 37.8 0 1, -122.4 37.7 0 1, -122.5 37.7 0 1))'], + 'srid with linestring m' => ['SRID=3857;LINESTRING M(0 0 1, 1 1 2)'], ];
115-132: Add a couple of modifier detection cases for collections and multiline typesThis helps ensure
getDimensionalModifier()is stable beyond simple primitives.Apply this diff:
@@ public static function provideDimensionalModifierWkt(): array return [ 'point without modifier' => ['POINT(1 2)', null], 'point with z' => ['POINT Z(1 2 3)', DimensionalModifier::Z], 'point with m' => ['POINT M(1 2 3)', DimensionalModifier::M], 'point with zm' => ['POINT ZM(1 2 3 4)', DimensionalModifier::ZM], 'linestring with z' => ['LINESTRING Z(0 0 1, 1 1 2)', DimensionalModifier::Z], 'polygon with m' => ['POLYGON M((0 0 1, 0 1 2, 1 1 3, 1 0 4, 0 0 1))', DimensionalModifier::M], 'multipoint with zm' => ['MULTIPOINT ZM((1 2 3 4), (5 6 7 8))', DimensionalModifier::ZM], 'srid with z modifier' => ['SRID=4326;POINT Z(-122.4194 37.7749 100)', DimensionalModifier::Z], 'srid without modifier' => ['SRID=4326;POINT(-122.4194 37.7749)', null], + 'geometrycollection with m' => ['GEOMETRYCOLLECTION M(POINT M(1 2 3))', DimensionalModifier::M], + 'multilinestring without modifier' => ['MULTILINESTRING((0 0, 1 1), (2 2, 3 3))', null], ];
132-132: Add explicit canonicalization tests (trim leading/trailing whitespace) to document formatting policyGiven
fromWkt()trims input, add tests that prove canonicalization without tying other tests to whitespace. This will clarify expectations for contributors.Apply this diff to append the tests at the end of the class:
@@ } + + #[DataProvider('provideCanonicalizationCases')] + #[Test] + public function canonicalizes_whitespace_around_input(string $input, string $expected): void + { + $out = (string) WktSpatialData::fromWkt($input); + self::assertSame($expected, $out); + } + + /** + * @return array<string, array{string, string}> + */ + public static function provideCanonicalizationCases(): array + { + return [ + 'leading whitespace' => [' POINT(1 2)', 'POINT(1 2)'], + 'trailing whitespace' => ['POINT(1 2) ', 'POINT(1 2)'], + ]; + }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (9)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/DimensionalModifier.php(1 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidWktSpatialDataException.php(1 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/GeometryType.php(1 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php(2 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTest.php(1 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTest.php(1 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/GeometryTypeTest.php(1 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialDataTest.php(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTest.php
- src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidWktSpatialDataException.php
- tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTest.php
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-04-11T11:23:44.192Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#340
File: tests/MartinGeorgiev/Doctrine/DBAL/Types/InetArrayTest.php:145-145
Timestamp: 2025-04-11T11:23:44.192Z
Learning: In the PostgreSQL for Doctrine test cases, methods that test database-to-PHP conversions should use `mixed` type for parameter and include non-string test cases in their data providers, following the pattern in classes like InetTest, CidrTest, and MacaddrTest.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what TYPE_NAME constants contain and getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php
🧬 Code Graph Analysis (3)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/GeometryTypeTest.php (1)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialDataTest.php (4)
DataProvider(17-27)DataProvider(29-36)DataProvider(57-63)DataProvider(81-89)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (1)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidWktSpatialDataException.php (7)
InvalidWktSpatialDataException(19-56)forEmptyWkt(21-24)forMissingSemicolonInEwkt(26-29)forInvalidSridValue(31-34)forInvalidWktFormat(36-39)forEmptyCoordinateSection(41-44)forUnsupportedGeometryType(46-55)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialDataTest.php (2)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/Exceptions/InvalidWktSpatialDataException.php (1)
InvalidWktSpatialDataException(19-56)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (6)
WktSpatialData(23-110)fromWkt(47-89)getGeometryType(96-99)getSrid(91-94)getWkt(106-109)getDimensionalModifier(101-104)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (18)
- GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.2
- GitHub Check: PostgreSQL 17 + PostGIS 3.4 + PHP 8.4
- GitHub Check: PostgreSQL 16 + PostGIS 3.5 + PHP 8.4
- GitHub Check: PostgreSQL 17 + PostGIS 3.4 + PHP 8.3
- GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.4
- GitHub Check: PostgreSQL 16 + PostGIS 3.5 + PHP 8.3
- GitHub Check: PostgreSQL 16 + PostGIS 3.4 + PHP 8.3
- GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.3
- GitHub Check: PostgreSQL 16 + PostGIS 3.4 + PHP 8.2
- GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.1
- GitHub Check: PostgreSQL 17 + PostGIS 3.4 + PHP 8.1
- GitHub Check: PostgreSQL 16 + PostGIS 3.5 + PHP 8.1
- GitHub Check: PostgreSQL 16 + PostGIS 3.4 + PHP 8.1
- GitHub Check: PHP 8.4 + Doctrine ORM 3.0 + Doctrine Lexer latest
- GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer 1.2
- GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer 3.0
- GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
- GitHub Check: PHP 8.3 + Doctrine ORM 2.18 + Doctrine Lexer latest
🔇 Additional comments (10)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/DimensionalModifier.php (1)
17-36: Enum looks solid and maps cleanly to WKT modifiers.Names, values, and docs align with WKT/EWKT usage. No functional concerns.
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/GeometryType.php (1)
16-42: Comprehensive coverage of OGC/PostGIS geometry tokens.The enum list matches common WKT/WKT2 and PostGIS extensions. Good separation by basic/multi/collection/curved types.
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/GeometryTypeTest.php (4)
12-22: Happy path coverage is clear and strict.Asserts both identity and raw value; good.
24-30: Exception path covered.Using ValueError from enum::from is appropriate.
32-39: tryFrom coverage is fine.Valid types mapped without redundancy.
65-70: Invalid inputs covered.Good to include empty string as well.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
51-53: Using a select-expression wrapper is the right approach for PostGIS types.This prevents DBAL from handing back streams/resources and normalizes to EWKT text for conversion.
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (2)
32-45: String rendering is clear and stable (EWKT when SRID present).Good inclusion of the dimensional modifier and faithful EWKT formatting.
55-69: EWKT SRID parsing is strict and safe.Trimming + digit-only check avoids surprising values; handling SRID=0 is supported. No changes needed.
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialDataTest.php (1)
81-89: LGTM on round-trip assertionThis exercises the intended invariant well. With the added canonicalization and SRID-space fix, it will cover the common formatting variants, too.
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialDataTest.php
Show resolved
Hide resolved
| { | ||
| return [ | ||
| 'point' => ['POINT(1 2)', 'POINT', null], | ||
| 'point with srid' => ['SRID=4326;POINT(-122.4194 37.7749)', 'POINT', 4326], |
There was a problem hiding this comment.
Bug: SRID=...; <space> fails to parse due to missing trim after SRID split
A very common form is SRID=4326; POINT(...) (note the space after ;). The implementation trims the original string once but does not re-trim after extracting SRID, so inputs with a space after ; throw “Invalid Wkt format”.
Fix in WktSpatialData (snippet lines 52–71 in the provided context): change the assignment after parsing SRID.
Apply this diff in src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php:
- $srid = (int) $sridRawValue;
- $wkt = \substr($wkt, $sridSeparatorPosition + 1);
+ $srid = (int) $sridRawValue;
+ $wkt = \trim(\substr($wkt, $sridSeparatorPosition + 1));And add a focused test here (will pass once the fix is in):
@@
public static function provideValidWkt(): array
{
return [
'point' => ['POINT(1 2)', 'POINT', null],
'point with srid' => ['SRID=4326;POINT(-122.4194 37.7749)', 'POINT', 4326],
+ 'point with srid and space after semicolon' => ['SRID=4326; POINT(1 2)', 'POINT', 4326],📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| 'point with srid' => ['SRID=4326;POINT(-122.4194 37.7749)', 'POINT', 4326], | |
| public static function provideValidWkt(): array | |
| { | |
| return [ | |
| 'point' => ['POINT(1 2)', 'POINT', null], | |
| 'point with srid' => ['SRID=4326;POINT(-122.4194 37.7749)', 'POINT', 4326], | |
| 'point with srid and space after semicolon' => ['SRID=4326; POINT(1 2)', 'POINT', 4326], | |
| ]; | |
| } |
🤖 Prompt for AI Agents
In src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php around
lines 52–71, the code splits on 'SRID=' and assigns the WKT without trimming the
remainder so inputs like "SRID=4326; POINT(...)" fail; after extracting parts
set $wkt = trim($parts[1]) (and keep existing trim on the original input),
ensuring you also handle missing parts as before; additionally, add a unit test
case in
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialDataTest.php
(around line 45) for 'point with srid and space' => ['SRID=4326; POINT(-122.4194
37.7749)', 'POINT', 4326] to verify the fix.
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (7)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/DimensionalModifierTest.php (5)
7-13: Add CoversClass to tighten code coverage mappingExplicitly linking the test to the SUT helps coverage tools and makes intent clear.
Apply this diff to import the attribute and annotate the class:
use MartinGeorgiev\Doctrine\DBAL\Types\ValueObject\DimensionalModifier; use PHPUnit\Framework\Attributes\DataProvider; +use PHPUnit\Framework\Attributes\CoversClass; use PHPUnit\Framework\Attributes\Test; use PHPUnit\Framework\TestCase; -final class DimensionalModifierTest extends TestCase +#[CoversClass(DimensionalModifier::class)] +final class DimensionalModifierTest extends TestCase {
14-22: Minor: consider asserting enum name as wellYou already assert the instance and its backing value. Optionally also assert $modifier->name to ensure case mapping stays intentional if enum case names ever diverge from backing values.
Example:
self::assertSame($dimensionalModifier->name, $modifier->name);
32-39: tryFrom happy-path covered — consider also checking idempotencyOptionally, assert that calling tryFrom on an enum’s own value returns the same singleton instance (identity), not just equality.
Example:
self::assertSame($dimensionalModifier, DimensionalModifier::tryFrom($dimensionalModifier->value));
41-51: Data provider return type can be iterable and use generatorsSmall readability/memory improvement: return iterable and use yields.
Apply this diff:
- /** - * @return array<string, array{string, DimensionalModifier}> - */ - public static function provideValidDimensionalModifiers(): array + /** + * @return iterable<string, array{string, DimensionalModifier}> + */ + public static function provideValidDimensionalModifiers(): iterable { - return [ - 'z dimension' => ['Z', DimensionalModifier::Z], - 'm dimension' => ['M', DimensionalModifier::M], - 'zm dimensions' => ['ZM', DimensionalModifier::ZM], - ]; + yield 'z dimension' => ['Z', DimensionalModifier::Z]; + yield 'm dimension' => ['M', DimensionalModifier::M]; + yield 'zm dimensions' => ['ZM', DimensionalModifier::ZM]; }
53-60: DRY the invalid cases with a data provider and expand case-sensitivity scenariosTurning these into a parameterized test reduces duplication and lets you easily include lower/mixed-case and whitespace variants, which are common inputs when parsing WKT.
Apply this diff within the method:
- #[Test] - public function returns_null_for_invalid_modifiers(): void - { - self::assertNull(DimensionalModifier::tryFrom('INVALID_MODIFIER')); - self::assertNull(DimensionalModifier::tryFrom('')); - self::assertNull(DimensionalModifier::tryFrom('X')); - self::assertNull(DimensionalModifier::tryFrom('Y')); - } + #[DataProvider('provideInvalidDimensionalModifiers')] + #[Test] + public function returns_null_for_invalid_modifiers(string $invalid): void + { + self::assertNull(DimensionalModifier::tryFrom($invalid)); + }Add this provider (place it below provideValidDimensionalModifiers):
/** * @return iterable<string, array{string}> */ public static function provideInvalidDimensionalModifiers(): iterable { yield 'empty' => ['']; yield 'random' => ['INVALID_MODIFIER']; yield 'unknown-x' => ['X']; yield 'unknown-y' => ['Y']; yield 'lowercase' => ['zm']; yield 'mixed case' => ['Zm']; yield 'trimmed/whitespace' => [' Z ']; }src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php (1)
17-17: TYPE_NAME is correct; ensure docs table mirrors 'geometry[]' (DBAL name) not PostgreSQL catalog nameThe constant matches the DBAL naming convention for arrays (geometry[]). Please ensure docs/AVAILABLE-TYPES.md lists “geometry[]” in the DBAL type column for consistency with other array types.
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php (1)
17-17: TYPE_NAME is correct; mirror this in docs as “geography[]”Use the DBAL name in the documentation table (“geography[]”), consistent with other array types.
If helpful, I can open a docs follow-up to add geometry[]/geography[] rows in AVAILABLE-TYPES.md.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php(1 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php(1 hunks)src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php(1 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/DimensionalModifierTest.php(1 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialDataTest.php(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialDataTest.php
- src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php
🧰 Additional context used
🧠 Learnings (6)
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the point[] array type should be documented as "point[]" not "_point" in the AVAILABLE-TYPES.md table, to be consistent with all other array types like text[], jsonb[], inet[], etc.
Applied to files:
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.phpsrc/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what TYPE_NAME constants contain and getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.phpsrc/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.phpsrc/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
📚 Learning: 2025-04-11T11:23:44.192Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#340
File: tests/MartinGeorgiev/Doctrine/DBAL/Types/InetArrayTest.php:145-145
Timestamp: 2025-04-11T11:23:44.192Z
Learning: In the PostgreSQL for Doctrine test cases, methods that test database-to-PHP conversions should use `mixed` type for parameter and include non-string test cases in their data providers, following the pattern in classes like InetTest, CidrTest, and MacaddrTest.
Applied to files:
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
📚 Learning: 2025-08-09T15:31:42.054Z
Learnt from: landure
PR: martin-georgiev/postgresql-for-doctrine#411
File: src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidLtreeForPHPException.php:11-19
Timestamp: 2025-08-09T15:31:42.054Z
Learning: In the postgresql-for-doctrine library, exception classes for invalid PHP values (Invalid*ForPHPException) follow a consistent pattern using var_export() in their create() method to format error messages. When adding new exception classes, maintain consistency with existing patterns rather than introducing new approaches, even if technically superior alternatives exist.
Applied to files:
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
📚 Learning: 2025-04-18T10:33:52.412Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#350
File: src/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/BaseVariadicFunction.php:78-88
Timestamp: 2025-04-18T10:33:52.412Z
Learning: In SQL generation code for the postgresql-for-doctrine library, it's better to fail explicitly with clear errors than to use fallback behavior that makes assumptions about node types, as this could lead to functional bugs or security issues.
Applied to files:
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
🧬 Code Graph Analysis (3)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/DimensionalModifierTest.php (1)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialDataTest.php (4)
DataProvider(17-27)DataProvider(48-55)DataProvider(75-81)DataProvider(99-107)
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php (3)
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeographyForPHPException.php (1)
InvalidGeographyForPHPException(14-30)src/MartinGeorgiev/Doctrine/DBAL/Types/SpatialDataArray.php (3)
SpatialDataArray(20-126)createInvalidTypeExceptionForPHP(119-119)createInvalidFormatExceptionForPHP(125-125)src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php (3)
transformArrayItemForPostgres(19-22)createInvalidTypeExceptionForPHP(24-27)createInvalidFormatExceptionForPHP(29-32)
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php (3)
src/MartinGeorgiev/Doctrine/DBAL/Types/Exceptions/InvalidGeometryForPHPException.php (1)
InvalidGeometryForPHPException(14-30)src/MartinGeorgiev/Doctrine/DBAL/Types/SpatialDataArray.php (3)
SpatialDataArray(20-126)createInvalidTypeExceptionForPHP(119-119)createInvalidFormatExceptionForPHP(125-125)src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php (3)
transformArrayItemForPostgres(19-22)createInvalidTypeExceptionForPHP(24-27)createInvalidFormatExceptionForPHP(29-32)
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer 3.0
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 3.0 + Doctrine Lexer latest
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer latest
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 2.14 + Doctrine Lexer latest
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer latest
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.3 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.2 + Doctrine ORM latest + Doctrine Lexer latest
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer latest
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 2.14 + Doctrine Lexer latest
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.2 + Doctrine ORM latest + Doctrine Lexer 3.0
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer 3.0
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 3.0 + Doctrine Lexer latest
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer 2.1
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer latest
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Actions: Integrations
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
[error] 21-21: Call to undefined method GeographyArray::getValidatedArrayItem().
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
[error] 21-21: Call to undefined method GeometryArray::getValidatedArrayItem().
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (18)
- GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer 1.2
- GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer 2.1
- GitHub Check: PHP 8.3 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
- GitHub Check: PHP 8.3 + Doctrine ORM 2.18 + Doctrine Lexer latest
- GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer latest
- GitHub Check: PHP 8.4 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
- GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer 2.1
- GitHub Check: PHP 8.2 + Doctrine ORM 2.18 + Doctrine Lexer latest
- GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer 3.0
- GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer latest
- GitHub Check: PHP 8.3 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
- GitHub Check: PHP 8.3 + Doctrine ORM 2.14 + Doctrine Lexer latest
- GitHub Check: PHP 8.3 + Doctrine ORM 3.0 + Doctrine Lexer latest
- GitHub Check: PHP 8.3 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
- GitHub Check: PHP 8.2 + Doctrine ORM 3.0 + Doctrine Lexer latest
- GitHub Check: PHP 8.2 + Doctrine ORM latest + Doctrine Lexer 2.1
- GitHub Check: PHP 8.2 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
- GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
🔇 Additional comments (5)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/DimensionalModifierTest.php (3)
1-11: Solid PHPUnit 10+ test structure and enum assertions — looks goodStrict types, namespacing, and attribute-based tests are consistent and clear. Using backed-enum value checks and assertSame on enum instances is correct.
24-30: Exception test is precise without over-constraining message — goodExpecting ValueError without asserting the message avoids brittleness across PHP versions. No changes needed.
1-61: Overall: concise, complete unit coverage for enum construction pathsThe test file clearly covers DimensionalModifier::from/tryFrom success and failure modes and pairs well with WktSpatialData tests shown elsewhere. The optional tweaks above would polish coverage metadata and reduce duplication, but the current tests are already solid.
src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php (1)
24-32: Exception mapping is correct and consistent with the typecreateInvalidTypeExceptionForPHP/createInvalidFormatExceptionForPHP correctly delegate to InvalidGeometryForPHPException and align with the base’s contract. LGTM.
src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php (1)
24-32: Exception mapping is correct and mirrors GeometryArrayDelegating to InvalidGeographyForPHPException is consistent with the base API and the geometry counterpart. LGTM.
| protected function transformArrayItemForPostgres(mixed $item): string | ||
| { | ||
| return (string) $this->getValidatedArrayItem($item); | ||
| } |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Same build break here: undefined helper and mixed-to-string cast — align with GeometryArray fix
GeographyArray has the same two issues flagged by CI:
- getValidatedArrayItem() is undefined.
- Casting mixed to string.
Once you add the helper to SpatialDataArray, use a typed local here as well.
Apply this change:
- protected function transformArrayItemForPostgres(mixed $item): string
- {
- return (string) $this->getValidatedArrayItem($item);
- }
+ protected function transformArrayItemForPostgres(mixed $item): string
+ {
+ $validated = $this->getValidatedArrayItem($item);
+ return (string) $validated;
+ }Quick check after implementing the base helper:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n 'getValidatedArrayItem\(' -C2 src/MartinGeorgiev/Doctrine/DBAL/TypesLength of output: 1000
Fix missing helper and introduce a typed local in GeographyArray
The transformArrayItemForPostgres() method in src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php is still calling an undefined helper and casting directly from mixed to string, resulting in build breaks. After you add getValidatedArrayItem(mixed): string to your base SpatialDataArray, update this method to match the GeometryArray fix:
• File: src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
• Lines: 19–22
@@ src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
- protected function transformArrayItemForPostgres(mixed $item): string
- {
- return (string) $this->getValidatedArrayItem($item);
- }
+ protected function transformArrayItemForPostgres(mixed $item): string
+ {
+ $validated = $this->getValidatedArrayItem($item);
+ return (string) $validated;
+ }This ensures:
- The new helper is used (no more undefined method errors).
- We assign to a local variable typed as the helper’s return, improving clarity and satisfying static analysis.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| protected function transformArrayItemForPostgres(mixed $item): string | |
| { | |
| return (string) $this->getValidatedArrayItem($item); | |
| } | |
| protected function transformArrayItemForPostgres(mixed $item): string | |
| { | |
| $validated = $this->getValidatedArrayItem($item); | |
| return (string) $validated; | |
| } |
🧰 Tools
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer 3.0
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 3.0 + Doctrine Lexer latest
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer latest
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 2.14 + Doctrine Lexer latest
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer latest
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.3 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.2 + Doctrine ORM latest + Doctrine Lexer latest
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer latest
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 2.14 + Doctrine Lexer latest
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.2 + Doctrine ORM latest + Doctrine Lexer 3.0
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer 3.0
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 3.0 + Doctrine Lexer latest
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer 2.1
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer latest
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::getValidatedArrayItem().
🪛 GitHub Actions: Integrations
[error] 21-21: Call to undefined method GeographyArray::getValidatedArrayItem().
🤖 Prompt for AI Agents
In src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php around lines 19–22,
the method transformArrayItemForPostgres currently casts the mixed argument to
string and calls an undefined helper; update it to call the new
getValidatedArrayItem(mixed): string helper (added to SpatialDataArray), assign
its return to a local variable typed as string, and return that local variable
so the undefined method error is removed and static analysis is satisfied.
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Let me check what methods are actually available in SpatialDataArray
cat src/MartinGeorgiev/Doctrine/DBAL/Types/SpatialDataArray.php | grep -A 5 -B 5 "function "
Length of output: 3777
@martin-georgiev Yes, I'm confident about the fix. Let me clarify what I found:
The getValidatedArrayItem() method does exist in SpatialDataArray - it returns WktSpatialData, not a string. Since WktSpatialData implements \Stringable, casting it to string is valid, but static analysis tools prefer explicit typing.
The current code fails because:
- It directly casts the return value from
mixedtostring - Static analysis can't infer that
getValidatedArrayItem()returns a stringable object
My suggested fix assigns the validated result to a typed variable first, making the cast explicit and satisfying static analysis:
protected function transformArrayItemForPostgres(mixed $item): string
{
$validated = $this->getValidatedArrayItem($item);
return (string) $validated;
}This approach:
- ✅ Uses the existing
getValidatedArrayItem()helper method - ✅ Makes the type flow clear to static analysis
- ✅ Maintains the same runtime behavior
- ✅ Follows the same pattern you'd want in
GeometryArray
The fix is correct and necessary to resolve the CI build failures.
🏁 Script executed:
#!/bin/bash
# Check if WktSpatialData implements Stringable
rg -n "class WktSpatialData" -A 5 src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php
Length of output: 341
Perfect! That confirms it - WktSpatialData implements \Stringable at line 22, so the cast to string is absolutely valid.
My suggested fix is correct and necessary. The problem isn't with the logic - it's that static analysis tools can't trace the type flow from mixed $item → getValidatedArrayItem() → WktSpatialData → (string).
By introducing the typed intermediate variable:
$validated = $this->getValidatedArrayItem($item); // Now typed as WktSpatialData
return (string) $validated; // Clear cast from Stringable to stringWe make the type flow explicit, which satisfies both the static analysis tools and makes the code more readable. This is the standard pattern for resolving these kinds of static analysis issues while maintaining runtime correctness.
The CI failures will be resolved with this change.
🧠 Learnings used
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the point[] array type should be documented as "point[]" not "_point" in the AVAILABLE-TYPES.md table, to be consistent with all other array types like text[], jsonb[], inet[], etc.
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
| protected function transformArrayItemForPostgres(mixed $item): string | ||
| { | ||
| return (string) $this->getValidatedArrayItem($item); | ||
| } |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Fix build: undefined helper and unsafe cast to string (mixed) — add typed validator in base and use a typed local here
The CI/static analysis failures come from:
- Calling an undefined method getValidatedArrayItem().
- Casting mixed to string.
Implement a typed validator in SpatialDataArray that returns WktSpatialData, and use a local variable here to help analyzers track the type.
Apply this minimal change in this file:
- protected function transformArrayItemForPostgres(mixed $item): string
- {
- return (string) $this->getValidatedArrayItem($item);
- }
+ protected function transformArrayItemForPostgres(mixed $item): string
+ {
+ $validated = $this->getValidatedArrayItem($item);
+ return (string) $validated;
+ }And add this helper in SpatialDataArray (shared by Geography/Geometry). This addresses both the undefined method and the “mixed to string” complaints in CI:
// In src/MartinGeorgiev/Doctrine/DBAL/Types/SpatialDataArray.php, inside the class
/**
* Validates that the item is suitable for database storage and returns it
* as a strongly-typed value object.
*/
protected function getValidatedArrayItem(mixed $item): WktSpatialData
{
if (!$this->isValidArrayItemForDatabase($item)) {
throw $this->createInvalidTypeExceptionForPHP($item);
}
return $item; // Runtime-enforced return type; static analyzers now know it's WktSpatialData.
}Run to verify no remaining references and that the helper exists once:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n 'getValidatedArrayItem\(' -C2
rg -nP 'transformArrayItemForPostgres\(.+?\): string' -C2 src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.phpLength of output: 1281
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "🔍 Searching for file SpatialDataArray.php"
fd SpatialDataArray.php -t f -e php || echo "❌ SpatialDataArray.php not found"
echo
echo "🔍 Searching for class definition 'SpatialDataArray'"
rg -nP 'class\s+SpatialDataArray' -C2 || echo "❌ No class SpatialDataArray found"Length of output: 774
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "🔍 Searching for getValidatedArrayItem definition in SpatialDataArray.php"
rg -n 'function getValidatedArrayItem' -C2 src/MartinGeorgiev/Doctrine/DBAL/Types/SpatialDataArray.php || echo "❌ getValidatedArrayItem() not found"
echo
echo "🔍 Searching for isValidArrayItemForDatabase usage in SpatialDataArray.php"
rg -n 'isValidArrayItemForDatabase' -C2 src/MartinGeorgiev/Doctrine/DBAL/Types/SpatialDataArray.php || echo "❌ isValidArrayItemForDatabase() not found"
echo
echo "🔍 Searching for createInvalidTypeExceptionForPHP usage in SpatialDataArray.php"
rg -n 'createInvalidTypeExceptionForPHP' -C2 src/MartinGeorgiev/Doctrine/DBAL/Types/SpatialDataArray.php || echo "❌ createInvalidTypeExceptionForPHP() not found"Length of output: 1479
Implement getValidatedArrayItem() in the base and fix both Array types
To resolve the undefined helper and eliminate the unsafe cast on mixed, you need to:
• Add a strongly-typed validator in SpatialDataArray that returns a WktSpatialData.
• Update transformArrayItemForPostgres() in both GeometryArray.php and GeographyArray.php to use a local variable.
• Import WktSpatialData where needed.
• In src/MartinGeorgiev/Doctrine/DBAL/Types/SpatialDataArray.php:
abstract class SpatialDataArray extends BaseArray
{
// … existing code …
+ /**
+ * Validates that the item is suitable for database storage
+ * and returns it as a WktSpatialData value object.
+ */
+ protected function getValidatedArrayItem(mixed $item): WktSpatialData
+ {
+ if (! $this->isValidArrayItemForDatabase($item)) {
+ throw $this->createInvalidTypeExceptionForPHP($item);
+ }
+
+ return $item;
+ }
}• In src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php (and likewise in GeographyArray.php):
- protected function transformArrayItemForPostgres(mixed $item): string
- {
- return (string) $this->getValidatedArrayItem($item);
- }
+ protected function transformArrayItemForPostgres(mixed $item): string
+ {
+ $validated = $this->getValidatedArrayItem($item);
+ return (string) $validated;
+ }• Ensure at the top of each Array type you have:
use MartinGeorgiev\Doctrine\DBAL\Types\WktSpatialData;These changes will:
- Define the missing helper (
getValidatedArrayItem). - Give static analyzers a clear
WktSpatialDatareturn type before casting. - Fix the CI/static analysis build errors.
🧰 Tools
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer 3.0
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 3.0 + Doctrine Lexer latest
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer latest
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 2.14 + Doctrine Lexer latest
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer latest
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.3 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.2 + Doctrine ORM latest + Doctrine Lexer latest
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer latest
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 2.14 + Doctrine Lexer latest
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.2 + Doctrine ORM latest + Doctrine Lexer 3.0
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer 3.0
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 3.0 + Doctrine Lexer latest
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer 2.1
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer latest
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
[failure] 21-21:
Cannot cast mixed to string.
[failure] 21-21:
Call to an undefined method MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::getValidatedArrayItem().
🪛 GitHub Actions: Integrations
[error] 21-21: Call to undefined method GeometryArray::getValidatedArrayItem().
🤖 Prompt for AI Agents
In src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php around lines 19-22
the code casts a mixed result from an undefined helper getValidatedArrayItem(),
causing unsafe casting and static analysis failures; implement a strongly-typed
protected getValidatedArrayItem(mixed $item): WktSpatialData in
src/MartinGeorgiev/Doctrine/DBAL/Types/SpatialDataArray.php, import
MartinGeorgiev\Doctrine\DBAL\Types\WktSpatialData where needed, and update
transformArrayItemForPostgres() in both GeometryArray.php and GeographyArray.php
to assign the result of getValidatedArrayItem($item) to a local WktSpatialData
variable and then cast that variable to string for the return value.
There was a problem hiding this comment.
🧩 Analysis chain
@martin-georgiev Yes, I'm confident in this analysis. Let me verify by checking the actual code:
The CI failures confirm exactly what I identified:
- Undefined method:
getValidatedArrayItem()doesn't exist inSpatialDataArray - Unsafe cast: Casting
mixeddirectly tostringwithout type validation
The fix requires:
- Adding
getValidatedArrayItem()toSpatialDataArraythat returnsWktSpatialData - Using a local variable before casting in both array types
- Ensuring proper imports
This is a straightforward missing method implementation that both GeometryArray and GeographyArray depend on.
🏁 Script executed:
#!/bin/bash
# Check if getValidatedArrayItem method exists in SpatialDataArray
echo "=== Checking SpatialDataArray for getValidatedArrayItem ==="
rg -n "getValidatedArrayItem" src/MartinGeorgiev/Doctrine/DBAL/Types/SpatialDataArray.php || echo "❌ Method not found"
echo -e "\n=== Current GeometryArray implementation ==="
cat src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
echo -e "\n=== Current GeographyArray implementation ==="
cat src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
echo -e "\n=== SpatialDataArray available methods ==="
rg -n "function " src/MartinGeorgiev/Doctrine/DBAL/Types/SpatialDataArray.php
Length of output: 3499
I apologize - I was incorrect! The method getValidatedArrayItem() does exist in SpatialDataArray (line 66). Let me check what's actually causing the CI failures:
The method exists, so the CI failure might be due to:
- Missing
WktSpatialDataimport in one of the array classes - A different PHPStan/static analysis issue
- Method visibility or inheritance problem
Let me investigate the actual root cause.
🏁 Script executed:
#!/bin/bash
# Check the actual implementation of getValidatedArrayItem
echo "=== getValidatedArrayItem implementation ==="
rg -A 10 "protected function getValidatedArrayItem" src/MartinGeorgiev/Doctrine/DBAL/Types/SpatialDataArray.php
echo -e "\n=== Check imports in GeometryArray ==="
head -10 src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php
echo -e "\n=== Check imports in GeographyArray ==="
head -10 src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php
echo -e "\n=== Check if WktSpatialData is imported in SpatialDataArray ==="
rg -n "use.*WktSpatialData" src/MartinGeorgiev/Doctrine/DBAL/Types/SpatialDataArray.php
Length of output: 1720
Now I see the actual issue! The method exists and is correctly implemented, but both array classes are missing the WktSpatialData import.
The CI failures occur because:
GeometryArrayandGeographyArraydon't importWktSpatialData- Without the import, PHPStan can't resolve the return type of
getValidatedArrayItem() - This causes PHPStan to treat the return as
mixed, leading to both error messages
The fix is simple - add the missing import to both files:
In src/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArray.php:
use Doctrine\DBAL\Types\ConversionException;
use MartinGeorgiev\Doctrine\DBAL\Types\Exceptions\InvalidGeometryForPHPException;
+use MartinGeorgiev\Doctrine\DBAL\Types\ValueObject\WktSpatialData;In src/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArray.php:
use Doctrine\DBAL\Types\ConversionException;
use MartinGeorgiev\Doctrine\DBAL\Types\Exceptions\InvalidGeographyForPHPException;
+use MartinGeorgiev\Doctrine\DBAL\Types\ValueObject\WktSpatialData;That's it! No changes to transformArrayItemForPostgres() or SpatialDataArray are needed. The method works correctly - it just needs the proper imports for static analysis.
🐰
/| /|
( ✌️ )
|(_)|
🧠 Learnings used
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the point[] array type should be documented as "point[]" not "_point" in the AVAILABLE-TYPES.md table, to be consistent with all other array types like text[], jsonb[], inet[], etc.
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what TYPE_NAME constants contain and getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php (5)
30-68: Broaden single-item coverage: add MULTILINESTRING, MULTIPOLYGON, and GEOMETRYCOLLECTIONThese are common PostGIS geometry variants and will increase confidence that both conversion directions handle the full GeometryType enum. Note: WktSpatialData intentionally does not support EMPTY; keep those out.
Before merging, please verify that GeometryType includes MULTILINESTRING, MULTIPOLYGON, and GEOMETRYCOLLECTION.
Apply this diff to extend the data provider:
@@ public static function provideSingleItemArrays(): array 'single complex geometry with srid' => [[ WktSpatialData::fromWkt('SRID=4326;POLYGON((-122.5 37.7,-122.5 37.8,-122.4 37.8,-122.4 37.7,-122.5 37.7))'), ]], + 'single multilinestring' => [[ + WktSpatialData::fromWkt('MULTILINESTRING((0 0,1 1),(2 2,3 3))'), + ]], + 'single multipolygon' => [[ + WktSpatialData::fromWkt('MULTIPOLYGON(((0 0,0 1,1 1,1 0,0 0)),((2 2,2 3,3 3,3 2,2 2)))'), + ]], + 'single geometrycollection' => [[ + WktSpatialData::fromWkt('GEOMETRYCOLLECTION(POINT(0 0),LINESTRING(0 0,1 1))'), + ]],If GeometryType doesn't include these members yet, I can follow up with a focused PR to add them.
70-79: Tiny naming nit: prefer $wkts or $wktStrings$wktsAsString is a bit clunky. Either $wkts or $wktStrings reads cleaner.
- $wktsAsString = \array_values(\array_map(static fn ($v): string => (string) $v, $phpArray)); - $this->runArrayConstructorTypeTest($this->getTypeName(), $this->getPostgresTypeName(), $wktsAsString, 'geometry'); + $wkts = \array_values(\array_map(static fn (WktSpatialData $v): string => (string) $v, $phpArray)); + $this->runArrayConstructorTypeTest($this->getTypeName(), $this->getPostgresTypeName(), $wkts, 'geometry');
71-72: Tighten phpdoc to list<…> for the inner arrayGiven the providers always return packed arrays, list is more precise than array.
- * @param array<WktSpatialData> $phpArray + * @param list<WktSpatialData> $phpArray
81-104: Add multi-item cases for multi-geometry types and mixed SRIDsGood variety already. Consider adding combined cases with MULTILINESTRING and MULTIPOLYGON (and optionally a GEOMETRYCOLLECTION if supported) to exercise array constructor path and DB->PHP conversion for composite geometries.
@@ public static function provideMultiItemArrays(): array 'mixed types' => [[ WktSpatialData::fromWkt('POINT(0 0)'), WktSpatialData::fromWkt('SRID=4326;POINT Z(1 2 3)'), WktSpatialData::fromWkt('LINESTRING M(0 0 1,1 1 2)'), WktSpatialData::fromWkt('SRID=3857;POLYGON((0 0,0 1000,1000 1000,1000 0,0 0))'), WktSpatialData::fromWkt('MULTIPOINT((1 2),(3 4))'), ]], + 'multi-geometry types' => [[ + WktSpatialData::fromWkt('MULTILINESTRING((0 0,1 1),(2 2,3 3))'), + WktSpatialData::fromWkt('MULTIPOLYGON(((0 0,0 1,1 1,1 0,0 0)),((2 2,2 3,3 3,3 2,2 2)))'), + ]], + // Uncomment if GEOMETRYCOLLECTION is supported by GeometryType + // 'geometry collection' => [[ + // WktSpatialData::fromWkt('GEOMETRYCOLLECTION(POINT(0 0),LINESTRING(0 0,1 1))'), + // ]],
30-68: Optional: Annotate single-item test param for static analysisIf you want Psalm/PHPStan to check provider/method shapes more tightly, add a param doc to can_handle_single_item_array.
- #[DataProvider('provideSingleItemArrays')] - #[Test] - public function can_handle_single_item_array(array $values): void + #[DataProvider('provideSingleItemArrays')] + #[Test] + /** @param list<WktSpatialData> $values */ + public function can_handle_single_item_array(array $values): void
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-04-11T11:23:44.192Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#340
File: tests/MartinGeorgiev/Doctrine/DBAL/Types/InetArrayTest.php:145-145
Timestamp: 2025-04-11T11:23:44.192Z
Learning: In the PostgreSQL for Doctrine test cases, methods that test database-to-PHP conversions should use `mixed` type for parameter and include non-string test cases in their data providers, following the pattern in classes like InetTest, CidrTest, and MacaddrTest.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the point[] array type should be documented as "point[]" not "_point" in the AVAILABLE-TYPES.md table, to be consistent with all other array types like text[], jsonb[], inet[], etc.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what TYPE_NAME constants contain and getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
🧬 Code graph analysis (1)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php (3)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (2)
WktSpatialData(22-109)fromWkt(46-88)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php (6)
DataProvider(23-28)DataProvider(73-79)getTypeName(13-16)getPostgresTypeName(18-21)provideSingleItemArrays(30-68)provideMultiItemArrays(84-104)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
runTypeTest(31-73)
🔇 Additional comments (2)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php (2)
13-21: LGTM: Correct DBAL and PostgreSQL type names for geometry arrayReturning 'geometry[]' and 'GEOMETRY[]' aligns with the naming used elsewhere (and mirrors geography[]). Good consistency.
23-29: Single-item array path mirrors geography[] test harnessThe test uses runTypeTest with the correct type names; parity with GeographyArrayTypeTest is good.
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (1)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php (1)
23-26: Same harness mismatch applies here: pass the column name to getSelectExpression.Your override is correct for geography (explicit cast to geometry for ST_AsEWKT). However, TestCase::runTypeTest currently calls getSelectExpression($columnType), which will try to reference a column named GEOGRAPHY. Fix in TestCase as suggested in the Geometry test comment.
🧹 Nitpick comments (12)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php (4)
32-37: Add param phpdoc for symmetry with the multi-item test.Minor readability improvement and helps static analyzers infer element types.
Apply this diff:
- #[DataProvider('provideSingleItemArrays')] - #[Test] - public function can_handle_single_item_array(array $values): void + /** + * @param array<WktSpatialData> $values + */ + #[DataProvider('provideSingleItemArrays')] + #[Test] + public function can_handle_single_item_array(array $values): void { $this->runTypeTest($this->getTypeName(), $this->getPostgresTypeName(), $values); }
39-77: Broaden single-item coverage with additional geometry shapes and cases.Adding a few more canonical shapes improves confidence across parsers and PostGIS round-trips.
Consider augmenting the provider:
return [ // Single item tests - These work perfectly with Doctrine DBAL parameter binding 'single point' => [[ WktSpatialData::fromWkt('POINT(0 0)'), ]], + 'linestring with z dimension' => [[ + WktSpatialData::fromWkt('LINESTRING Z(0 0 1,1 1 2)'), + ]], 'single point with z dimension' => [[ WktSpatialData::fromWkt('POINT Z(1 2 3)'), ]], 'single point with m dimension' => [[ WktSpatialData::fromWkt('POINT M(1 2 3)'), ]], 'single point with zm dimensions' => [[ WktSpatialData::fromWkt('POINT ZM(1 2 3 4)'), ]], 'single ewkt with srid' => [[ WktSpatialData::fromWkt('SRID=4326;POINT(0 0)'), ]], 'single ewkt with srid and dimensions' => [[ WktSpatialData::fromWkt('SRID=4326;POINT Z(1 2 3)'), ]], 'single linestring' => [[ WktSpatialData::fromWkt('LINESTRING(0 0,1 1,2 2)'), ]], 'single polygon' => [[ WktSpatialData::fromWkt('POLYGON((0 0,0 1,1 1,1 0,0 0))'), ]], + 'polygon with hole' => [[ + WktSpatialData::fromWkt('POLYGON((0 0,4 0,4 4,0 4,0 0),(1 1,1 2,2 2,2 1,1 1))'), + ]], + 'multipolygon' => [[ + WktSpatialData::fromWkt('MULTIPOLYGON(((0 0,0 1,1 1,1 0,0 0)),((2 2,2 3,3 3,3 2,2 2)))'), + ]], 'single multipoint' => [[ WktSpatialData::fromWkt('MULTIPOINT((1 2),(3 4))'), ]], + 'geometry collection with srid' => [[ + WktSpatialData::fromWkt('SRID=4326;GEOMETRYCOLLECTION(POINT(0 0),LINESTRING(0 0,1 1))'), + ]], 'single complex geometry with srid' => [[ WktSpatialData::fromWkt('SRID=4326;POLYGON((-122.5 37.7,-122.5 37.8,-122.4 37.8,-122.4 37.7,-122.5 37.7))'), ]], // Edge cases 'empty array' => [[]], ];Note: Ensure GeometryType enum supports GEOMETRYCOLLECTION/MULTIPOLYGON before adding these; otherwise extend it accordingly.
93-112: Add a multi-item case with collection types to catch array coercion edge cases.Useful for validating array typing with heterogeneous subtypes.
Apply this diff:
return [ 'two points' => [[ WktSpatialData::fromWkt('POINT(0 0)'), WktSpatialData::fromWkt('POINT(1 1)'), ]], 'dimensional modifiers' => [[ WktSpatialData::fromWkt('POINT Z(1 2 3)'), WktSpatialData::fromWkt('POINT M(1 2 3)'), WktSpatialData::fromWkt('POINT ZM(1 2 3 4)'), ]], 'mixed types' => [[ WktSpatialData::fromWkt('POINT(0 0)'), WktSpatialData::fromWkt('SRID=4326;POINT Z(1 2 3)'), WktSpatialData::fromWkt('LINESTRING M(0 0 1,1 1 2)'), WktSpatialData::fromWkt('SRID=3857;POLYGON((0 0,0 1000,1000 1000,1000 0,0 0))'), WktSpatialData::fromWkt('MULTIPOINT((1 2),(3 4))'), ]], + 'mixed with collection types' => [[ + WktSpatialData::fromWkt('GEOMETRYCOLLECTION(POINT(0 0),LINESTRING(0 0,1 1))'), + WktSpatialData::fromWkt('MULTIPOLYGON(((0 0,0 1,1 1,1 0,0 0)))'), + ]], ];
23-30: Optional: De-duplicate EWKT formatting logic across geometry[] and geography[] tests.Both array tests assemble the same CASE expression; only the element alias/casts differ. Consider moving a small helper to the parent test case (e.g., buildEwktArraySelectExpression($col, $alias, $sridExpr, $geomExpr)) and parametrize it for geometry vs geography to reduce drift.
If you want, I can draft a parent-case helper and adjust both tests in a follow-up.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php (4)
23-30: Remove unnecessary escapes in SQL string; optionally simplify with ST_AsEWKTThe SQL string is single-quoted in PHP, so escaping double quotes is unnecessary and results in literal backslashes in the query. Also, for geography, SRID will never be 0 (it defaults to 4326), so you can simplify the CASE using ST_AsEWKT on a geometry cast.
Apply this minimal fix to the quoting:
- return \sprintf( - 'ARRAY(SELECT CASE WHEN ST_SRID(geog::geometry) = 0 THEN ST_AsText(geog::geometry) ELSE \"SRID=\" || ST_SRID(geog::geometry) || \";\" || ST_AsText(geog::geometry) END FROM unnest(\"%s\") AS geog) AS \"%s\"', - $columnName, - $columnName - ); + return \sprintf( + 'ARRAY(SELECT CASE WHEN ST_SRID(geog::geometry) = 0 THEN ST_AsText(geog::geometry) ELSE "SRID=" || ST_SRID(geog::geometry) || ";" || ST_AsText(geog::geometry) END FROM unnest("%s") AS geog) AS "%s"', + $columnName, + $columnName + );Or simplify using ST_AsEWKT (recommended for geography):
- return \sprintf( - 'ARRAY(SELECT CASE WHEN ST_SRID(geog::geometry) = 0 THEN ST_AsText(geog::geometry) ELSE "SRID=" || ST_SRID(geog::geometry) || ";" || ST_AsText(geog::geometry) END FROM unnest("%s") AS geog) AS "%s"', - $columnName, - $columnName - ); + return \sprintf( + 'ARRAY(SELECT ST_AsEWKT(geog::geometry) FROM unnest("%s") AS geog) AS "%s"', + $columnName, + $columnName + );
32-38: Add an explicit NULL-handling test for geography[]The base test harness supports null round-trips; adding a focused test improves coverage of PHP<->DB null conversions for this new type.
Apply this addition:
#[DataProvider('provideSingleItemArrays')] #[Test] public function can_handle_single_item_array(array $values): void { $this->runTypeTest($this->getTypeName(), $this->getPostgresTypeName(), $values); } + + #[Test] + public function can_handle_null(): void + { + $this->runTypeTest($this->getTypeName(), $this->getPostgresTypeName(), null); + }
39-77: Great coverage of single-element geographies; consider anti-meridian boundariesGood breadth: 2D/Z/M/ZM, SRID-qualified, and poles. Optional: add ±180° longitude points to exercise anti-meridian boundaries common in geography workflows.
You could extend the provider like:
return [ // Single item tests - These work perfectly with Doctrine DBAL parameter binding 'single point' => [[ WktSpatialData::fromWkt('SRID=4326;POINT(-122.4194 37.7749)'), ]], + 'dateline east boundary' => [[ + WktSpatialData::fromWkt('SRID=4326;POINT(180 0)'), + ]], + 'dateline west boundary' => [[ + WktSpatialData::fromWkt('SRID=4326;POINT(-180 0)'), + ]],Note: If PostGIS normalizes 180 to -180 in textual output, the equality assertion logic must account for that normalization.
93-112: Solid multi-item coverage; optional stress and heterogeneity casesTests include two points, Z/M/ZM, and mixed geometry types—all with SRID 4326. Optionally:
- Add a larger array (~50–100 elements) to validate binding and round-trip at scale.
- Include a very long LINESTRING to catch any truncation/precision issues.
These are nice-to-haves; not blockers.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php (2)
34-39: Remove unused parameter from test to satisfy PHPMD and simplify provider.$testName isn’t used and is flagged by PHPMD. Prefer removing it and simplifying the data provider shape.
Apply:
- public function can_handle_geometry_values(string $testName, WktSpatialData $wktSpatialData): void + public function can_handle_geometry_values(WktSpatialData $wktSpatialData): void { $this->runTypeTest($this->getTypeName(), $this->getPostgresTypeName(), $wktSpatialData); }
41-56: Align provider with the simplified test signature.Drop the duplicated label argument; the keyed dataset names already label the case.
- /** - * @return array<string, array{string, WktSpatialData}> - */ + /** + * @return array<string, array{WktSpatialData}> + */ public static function provideValidTransformations(): array { return [ - 'point' => ['point', WktSpatialData::fromWkt('POINT(1 2)')], - 'linestring' => ['linestring', WktSpatialData::fromWkt('LINESTRING(0 0, 1 1, 2 2)')], - 'polygon' => ['polygon', WktSpatialData::fromWkt('POLYGON((0 0, 0 1, 1 1, 1 0, 0 0))')], - 'geometrycollection' => ['geometrycollection', WktSpatialData::fromWkt('GEOMETRYCOLLECTION(POINT(1 2), LINESTRING(0 0, 1 1))')], - 'point with srid' => ['point with srid', WktSpatialData::fromWkt('SRID=4326;POINT(-122.4194 37.7749)')], - 'point z' => ['point z', WktSpatialData::fromWkt('POINT Z(1 2 3)')], - 'linestring m' => ['linestring m', WktSpatialData::fromWkt('LINESTRING M(0 0 1, 1 1 2)')], - 'polygon zm' => ['polygon zm', WktSpatialData::fromWkt('POLYGON ZM((0 0 0 1, 0 1 0 1, 1 1 0 1, 1 0 0 1, 0 0 0 1))')], - 'point z with srid' => ['point z with srid', WktSpatialData::fromWkt('SRID=4326;POINT Z(-122.4194 37.7749 100)')], + 'point' => [WktSpatialData::fromWkt('POINT(1 2)')], + 'linestring' => [WktSpatialData::fromWkt('LINESTRING(0 0, 1 1, 2 2)')], + 'polygon' => [WktSpatialData::fromWkt('POLYGON((0 0, 0 1, 1 1, 1 0, 0 0))')], + 'geometrycollection' => [WktSpatialData::fromWkt('GEOMETRYCOLLECTION(POINT(1 2), LINESTRING(0 0, 1 1))')], + 'point with srid' => [WktSpatialData::fromWkt('SRID=4326;POINT(-122.4194 37.7749)')], + 'point z' => [WktSpatialData::fromWkt('POINT Z(1 2 3)')], + 'linestring m' => [WktSpatialData::fromWkt('LINESTRING M(0 0 1, 1 1 2)')], + 'polygon zm' => [WktSpatialData::fromWkt('POLYGON ZM((0 0 0 1, 0 1 0 1, 1 1 0 1, 1 0 0 1, 0 0 0 1))')], + 'point z with srid' => [WktSpatialData::fromWkt('SRID=4326;POINT Z(-122.4194 37.7749 100)')], ]; }tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php (2)
34-39: Remove unused $testName parameter to satisfy PHPMD and reduce noise.Mirror the simplification recommended for Geometry tests.
- public function can_handle_geography_values(string $testName, WktSpatialData $wktSpatialData): void + public function can_handle_geography_values(WktSpatialData $wktSpatialData): void { $this->runTypeTest($this->getTypeName(), $this->getPostgresTypeName(), $wktSpatialData); }
44-55: Simplify provider shape and add an explicit SRID case for geography.
- Drop the duplicate label argument as above.
- Add a “point with srid” case to ensure explicit SRID=4326 inputs round-trip as expected for geography.
- /** - * @return array<string, array{string, WktSpatialData}> - */ + /** + * @return array<string, array{WktSpatialData}> + */ public static function provideValidTransformations(): array { return [ - 'point' => ['point', WktSpatialData::fromWkt('POINT(1 2)')], - 'linestring' => ['linestring', WktSpatialData::fromWkt('LINESTRING(0 0, 1 1, 2 2)')], - 'polygon' => ['polygon', WktSpatialData::fromWkt('POLYGON((0 0, 0 1, 1 1, 1 0, 0 0))')], - 'geometrycollection' => ['geometrycollection', WktSpatialData::fromWkt('GEOMETRYCOLLECTION(POINT(1 2), LINESTRING(0 0, 1 1))')], - 'point z' => ['point z', WktSpatialData::fromWkt('POINT Z(-122.4194 37.7749 100)')], - 'linestring m' => ['linestring m', WktSpatialData::fromWkt('LINESTRING M(-122.4194 37.7749 1, -122.4094 37.7849 2)')], - 'polygon zm' => ['polygon zm', WktSpatialData::fromWkt('POLYGON ZM((-122.5 37.7 0 1, -122.5 37.8 0 1, -122.4 37.8 0 1, -122.4 37.7 0 1, -122.5 37.7 0 1))')], + 'point' => [WktSpatialData::fromWkt('POINT(1 2)')], + 'linestring' => [WktSpatialData::fromWkt('LINESTRING(0 0, 1 1, 2 2)')], + 'polygon' => [WktSpatialData::fromWkt('POLYGON((0 0, 0 1, 1 1, 1 0, 0 0))')], + 'geometrycollection' => [WktSpatialData::fromWkt('GEOMETRYCOLLECTION(POINT(1 2), LINESTRING(0 0, 1 1))')], + 'point with srid' => [WktSpatialData::fromWkt('SRID=4326;POINT(-122.4194 37.7749)')], + 'point z' => [WktSpatialData::fromWkt('POINT Z(-122.4194 37.7749 100)')], + 'linestring m' => [WktSpatialData::fromWkt('LINESTRING M(-122.4194 37.7749 1, -122.4094 37.7849 2)')], + 'polygon zm' => [WktSpatialData::fromWkt('POLYGON ZM((-122.5 37.7 0 1, -122.5 37.8 0 1, -122.4 37.8 0 1, -122.4 37.7 0 1, -122.5 37.7 0 1))')], ]; }If assertTypeValueEquals does a strict textual comparison of EWKT, this additional case helps ensure explicit SRID handling is normalized identically on read-back. If you want, I can add a variant asserting normalization details.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (8)
ci/php-cs-fixer/config.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php(2 hunks)tests/Integration/MartinGeorgiev/Utils/PostgresArrayToPHPArrayTransformerTest.php(1 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/BaseRangeTestCase.php(3 hunks)
✅ Files skipped from review due to trivial changes (2)
- tests/Integration/MartinGeorgiev/Utils/PostgresArrayToPHPArrayTransformerTest.php
- tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/BaseRangeTestCase.php
🚧 Files skipped from review as they are similar to previous changes (1)
- tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the point[] array type should be documented as "point[]" not "_point" in the AVAILABLE-TYPES.md table, to be consistent with all other array types like text[], jsonb[], inet[], etc.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
📚 Learning: 2025-04-11T11:23:44.192Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#340
File: tests/MartinGeorgiev/Doctrine/DBAL/Types/InetArrayTest.php:145-145
Timestamp: 2025-04-11T11:23:44.192Z
Learning: In the PostgreSQL for Doctrine test cases, methods that test database-to-PHP conversions should use `mixed` type for parameter and include non-string test cases in their data providers, following the pattern in classes like InetTest, CidrTest, and MacaddrTest.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what TYPE_NAME constants contain and getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
🧬 Code graph analysis (4)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php (3)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (2)
WktSpatialData(22-109)fromWkt(46-88)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php (3)
getSelectExpression(23-30)provideSingleItemArrays(39-77)provideMultiItemArrays(93-113)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (3)
Test(89-97)getSelectExpression(99-102)runTypeTest(31-72)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php (3)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (2)
WktSpatialData(22-109)fromWkt(46-88)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php (6)
DataProvider(34-39)Test(28-32)getTypeName(13-16)getPostgresTypeName(18-21)getSelectExpression(23-26)provideValidTransformations(44-57)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (6)
Test(89-97)TestCase(11-103)getTypeName(16-16)getPostgresTypeName(21-21)getSelectExpression(99-102)runTypeTest(31-72)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php (2)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (2)
WktSpatialData(22-109)fromWkt(46-88)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php (7)
DataProvider(32-37)DataProvider(82-88)getTypeName(13-16)getPostgresTypeName(18-21)getSelectExpression(23-30)provideSingleItemArrays(39-77)provideMultiItemArrays(93-113)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php (2)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (2)
WktSpatialData(22-109)fromWkt(46-88)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (4)
Test(89-97)TestCase(11-103)getSelectExpression(99-102)runTypeTest(31-72)
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer latest
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 2.14 + Doctrine Lexer latest
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.3 + Doctrine ORM 2.14 + Doctrine Lexer latest
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer latest
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.3 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer 3.0
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.3 + Doctrine ORM 3.0 + Doctrine Lexer latest
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 3.0 + Doctrine Lexer latest
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer latest
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 2.14 + Doctrine Lexer latest
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.3 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.3 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer 2.1
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.2 + Doctrine ORM latest + Doctrine Lexer latest
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.3 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer 3.0
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer latest
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer latest
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer 2.1
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 3.0 + Doctrine Lexer latest
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer latest
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
[failure] 87-87:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runArrayConstructorTypeTest().
[failure] 36-36:
Call to an undefined method Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest::runTypeTest().
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeometryArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 PHPMD (2.15.0)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php
36-36: Avoid unused parameters such as '$testName'. (Unused Code Rules)
(UnusedFormalParameter)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php
36-36: Avoid unused parameters such as '$testName'. (Unused Code Rules)
(UnusedFormalParameter)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
- GitHub Check: PostgreSQL 16 + PostGIS 3.5 + PHP 8.4
- GitHub Check: PostgreSQL 17 + PostGIS 3.4 + PHP 8.3
- GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.3
- GitHub Check: PostgreSQL 16 + PostGIS 3.4 + PHP 8.1
- GitHub Check: PostgreSQL 17 + PostGIS 3.4 + PHP 8.4
- GitHub Check: PostgreSQL 16 + PostGIS 3.4 + PHP 8.4
- GitHub Check: PostgreSQL 17 + PostGIS 3.4 + PHP 8.2
- GitHub Check: PostgreSQL 16 + PostGIS 3.4 + PHP 8.3
- GitHub Check: PostgreSQL 16 + PostGIS 3.5 + PHP 8.3
- GitHub Check: PostgreSQL 17 + PostGIS 3.4 + PHP 8.1
- GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
- GitHub Check: PHP 8.3 + Doctrine ORM 2.18 + Doctrine Lexer latest
- GitHub Check: PHP 8.2 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
- GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer 1.2
- GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer 2.1
- GitHub Check: PHP 8.4 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
- GitHub Check: PHP 8.2 + Doctrine ORM latest + Doctrine Lexer 2.1
- GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer 3.0
- GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
| use PHPUnit\Framework\Attributes\DataProvider; | ||
| use PHPUnit\Framework\Attributes\Test; | ||
|
|
||
| final class GeographyArrayTypeTest extends SpatialArrayTypeTestCase |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Unresolved base class and helper methods flagged by static analysis
Static analysis reports the parent SpatialArrayTypeTestCase as unknown and, consequently, both runTypeTest() and runArrayConstructorTypeTest() as undefined. This looks like an autoloading/scope issue rather than missing code, but it currently breaks checks.
- Ensure
SpatialArrayTypeTestCaseexists under the expected namespace and is autoloaded for tests (composer autoload-dev PSR-4). - If the class lives outside the test namespace, update the namespace here or add the correct
useimport. - If analyzers intentionally skip that path, add phpdoc method stubs on this class (for analyzers only) or extend the correct available base (e.g., your
TestCasethat definesrunTypeTest()), mirroring the Geometry array tests.
Run this to locate the base class and helpers and confirm autoload-dev mappings:
If SpatialArrayTypeTestCase is indeed out of scope, a quick analyzer-friendly workaround is adding docblocks:
/**
- @method void runTypeTest(string $typeName, string $columnType, mixed $testValue)
- @method void runArrayConstructorTypeTest(string $typeName, string $columnType, array $wkts, string $elementType)
*/
Also applies to: 36-36, 87-87
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Searching for SpatialArrayTypeTestCase definition..."
rg -nP -C2 '(?s)^\s*abstract\s+class\s+SpatialArrayTypeTestCase\b|^\s*class\s+SpatialArrayTypeTestCase\b' tests || true
echo "Searching for helper methods definitions..."
rg -nP -C2 'function\s+(runTypeTest|runArrayConstructorTypeTest)\s*\(' tests || true
if [ -f composer.json ]; then
echo "composer autoload-dev PSR-4:"
jq '.["autoload-dev"].psr-4' composer.json
fiLength of output: 1221
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Looking for SpatialArrayTypeTestCase in entire repo..."
rg -nP -C3 'class\s+SpatialArrayTypeTestCase\b' . || true
echo "Inspecting TestCase.php around class definition..."
rg -nP -C3 'class\s+TestCase' tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php || true
echo "Looking for runArrayConstructorTypeTest definition..."
rg -nP -C3 'function\s+runArrayConstructorTypeTest' -g '*.php' || true
echo "Showing composer.json autoload-dev section..."
jq '.["autoload-dev"]' composer.json || trueLength of output: 1208
Missing SpatialArrayTypeTestCase and undefined helper methods remain
Static analysis still reports:
- Parent class
SpatialArrayTypeTestCasecannot be found anywhere in the repository. - Helper method
runArrayConstructorTypeTest()is not defined (onlyrunTypeTest()exists intests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.phpat line 31).
To resolve:
-
Either add a
SpatialArrayTypeTestCase.phpundertests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/(namespacedTests\Integration\MartinGeorgiev\Doctrine\DBAL\Types) that extends your existingTestCaseand implements both helpers, -
Or update each array‐type test to extend the existing
TestCaseand add docblock stubs for analyzers, e.g.:/** * @method void runTypeTest(string $typeName, string $columnType, mixed $testValue) * @method void runArrayConstructorTypeTest(string $typeName, string $columnType, array $wkts, string $elementType) */
Also ensure your new class (or updated tests) fall under the PSR-4 autoload-dev mapping ("Tests\\Integration\\MartinGeorgiev\\": "tests/Integration/MartinGeorgiev/" in composer.json).
Let me know if you’d like help scaffolding the base class or adding the stubs.
🧰 Tools
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer latest
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 2.14 + Doctrine Lexer latest
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.3 + Doctrine ORM 2.14 + Doctrine Lexer latest
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer latest
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.3 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer 3.0
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.3 + Doctrine ORM 3.0 + Doctrine Lexer latest
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 3.0 + Doctrine Lexer latest
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer latest
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 2.14 + Doctrine Lexer latest
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.3 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.3 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer 2.1
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.2 + Doctrine ORM latest + Doctrine Lexer latest
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.3 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer 3.0
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer latest
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.2 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer latest
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer 2.1
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 3.0 + Doctrine Lexer latest
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer latest
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🪛 GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
[failure] 11-11:
Class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\GeographyArrayTypeTest extends unknown class Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types\SpatialArrayTypeTestCase.
🤖 Prompt for AI Agents
In
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
around line 11, the test references a missing base class
SpatialArrayTypeTestCase and an undefined helper runArrayConstructorTypeTest();
fix by either (A) adding a new SpatialArrayTypeTestCase.php in
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/ with namespace
Tests\Integration\MartinGeorgiev\Doctrine\DBAL\Types that extends your existing
TestCase and implements the two helper methods (runTypeTest and
runArrayConstructorTypeTest) used by array tests, or (B) update each array-type
test to extend the existing TestCase and add docblock @method stubs for
runTypeTest and runArrayConstructorTypeTest so static analyzers recognize them;
finally ensure composer.json has the PSR-4 autoload-dev mapping
"Tests\\Integration\\MartinGeorgiev\\": "tests/Integration/MartinGeorgiev/" so
the new/updated class is autoloaded.
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
Show resolved
Hide resolved
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php (1)
23-31: Quoting and EWKT construction in SELECT expression are now correct.Identifiers are double-quoted and SQL literals use single quotes; EWKT is constructed with ||. This addresses the prior quoting issue.
🧹 Nitpick comments (22)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
57-70: Make select expression always alias to the expected column key
fetchConvertedValue()assumes$row[$columnName]exists. If a subtype overridesgetSelectExpression()but forgets to alias toAS "columnName", key mismatches can occur. Defaulting to an explicit alias removes this footgun and improves consistency with spatial overrides.Apply:
- protected function getSelectExpression(string $columnName): string - { - return $columnName; - } + protected function getSelectExpression(string $columnName): string + { + // Quote both the source identifier and the alias for stability + return \sprintf('"%s" AS "%s"', $columnName, $columnName); + }Also applies to: 132-135
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/InetTypeTest.php (1)
27-31: Inline local variables in InetTypeTest for brevity (optional)No occurrences of the old
runTypeTesthelper remain in thetests/directory, confirming the DBAL binding migration is complete. You may optionally inline the temporary variables to reduce noise:--- a/tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/InetTypeTest.php +++ b/tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/InetTypeTest.php @@ -27,7 +27,7 @@ class InetTypeTest extends AbstractIntegrationTest - $typeName = $this->getTypeName(); - $columnType = $this->getPostgresTypeName(); - - $this->runDbalBindingRoundTrip($typeName, $columnType, $testValue); + $this->runDbalBindingRoundTrip( + $this->getTypeName(), + $this->getPostgresTypeName(), + $testValue + );tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/CidrArrayTypeTest.php (1)
58-62: Array invalid-path now tested through DBAL binding.Good change: invalid element should trigger InvalidCidrArrayItemForPHPException at conversion time. Consider adding a case where the invalid element is not at index 0 to assert consistent failure regardless of position.
Example (separate test or data provider entry):
- ['192.168.1.0/24', 'invalid-network']
- ['192.168.1.0/24', '10.0.0.0/8', 'invalid-network']
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/MacaddrArrayTypeTest.php (1)
55-59: DBAL round-trip for invalid MAC addresses looks good.The change preserves the expected exception while exercising the true binding path. Optionally broaden invalids (bad separators, length, non-hex) to cover more converter branches.
Potential additions:
- '0800:2b:01:02:03' (missing octet)
- 'ZZ:00:2b:01:02:03' (non-hex)
- '08-00-2b-01-02-03' (wrong separator)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/InetArrayTypeTest.php (1)
57-61: Inet array invalid-path now validated via DBAL; solid.Keeps behavior while ensuring the converter is invoked in a realistic scenario. As a minor enhancement, include invalids at different positions and shapes (e.g., '256.0.0.1', ':::', '1.2.3').
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/MacaddrTypeTest.php (1)
38-44: Fix dataset: “mixed case” value duplicates the lowercase sample; label/value mismatch for “single digits”.
- The “mixed case MAC” entry currently uses the same lowercase address as the first sample. Use a true mixed/upper-case variant.
- The “MAC with single digits” label suggests non–zero-padded octets, but the value uses zero-padded bytes. Either rename the label or adjust the value (if the type is expected to accept that notation).
Proposed corrections:
return [ 'standard MAC address' => ['08:00:2b:01:02:03'], 'MAC with zeros' => ['00:00:00:00:00:00'], 'MAC with FF' => ['ff:ff:ff:ff:ff:ff'], - 'mixed case MAC' => ['08:00:2b:01:02:03'], - 'MAC with single digits' => ['01:02:03:04:05:06'], + 'mixed case MAC' => ['08:00:2B:01:02:03'], + // Either keep label and change value to truly single-digit octets (if supported), + // or rename the label to reflect zero-padded bytes. Safer rename: + 'zero-padded octets' => ['01:02:03:04:05:06'], + // (Optional) Consider adding a hyphen-separated form to widen coverage: + // 'hyphen-separated MAC' => ['08-00-2b-01-02-03'], ];tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/NumRangeTypeTest.php (2)
70-72: Expand operator scenarios to match int4range parity.You only cover CONTAINS for numrange. Mirroring int4range improves signal for DQL operators across numeric ranges.
Suggested additions:
public static function provideOperatorScenarios(): array { return [ 'contains numrange' => ['contains numrange', 'SELECT r.id FROM Fixtures\\MartinGeorgiev\\Doctrine\\Entity\\ContainsRanges r WHERE CONTAINS(r.numRange, \'[2.5,8.5)\') = TRUE', [1]], + 'is contained by numrange' => ['is contained by numrange', 'SELECT r.id FROM Fixtures\\MartinGeorgiev\\Doctrine\\Entity\\ContainsRanges r WHERE IS_CONTAINED_BY(\'[2.5,8.5)\', r.numRange) = TRUE', [1]], + 'overlaps numrange' => ['overlaps numrange', 'SELECT r.id FROM Fixtures\\MartinGeorgiev\\Doctrine\\Entity\\ContainsRanges r WHERE OVERLAPS(r.numRange, \'[8.5,12.5)\') = TRUE', [1, 2]], ]; }
50-51: Minor naming consistency (optional).Use a shorter, consistent variable name like $numRange to mirror the type and other tests.
- $numericRange = new NumRangeValueObject(null, null, false, false); - $this->runDbalBindingRoundTrip($typeName, $columnType, $numericRange); + $numRange = new NumRangeValueObject(null, null, false, false); + $this->runDbalBindingRoundTrip($typeName, $columnType, $numRange); @@ - $numericRange = new NumRangeValueObject(10.5, 5.7, false, false); - $this->runDbalBindingRoundTrip($typeName, $columnType, $numericRange); + $numRange = new NumRangeValueObject(10.5, 5.7, false, false); + $this->runDbalBindingRoundTrip($typeName, $columnType, $numRange);Also applies to: 60-62
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/JsonbTypeTest.php (1)
47-48: Add a Unicode/escaping case to harden JSONB coverage.Recommend adding a case with Unicode, RTL text, and escape sequences to catch encoding/decoding regressions.
return [ 'simple object' => ['simple object', ['foo' => 'bar', 'baz' => 123]], 'nested structures' => ['nested structures', [ 'user' => ['id' => 1, 'name' => 'John'], 'meta' => ['active' => true, 'roles' => ['admin', 'user']], ]], 'mixed types' => ['mixed types', [ 'string' => 'value', 'number' => 42, 'boolean' => false, 'null' => null, 'array' => [1, 2, 3], 'object' => ['a' => 1], ]], 'special characters' => ['special characters', [ 'message' => 'Hello "World" with \'quotes\'', 'path' => '/path/with/slashes', ]], + 'unicode and escapes' => ['unicode and escapes', [ + 'emoji' => '😀', + 'cjk' => '漢字', + 'rtl' => 'עברית', + 'escapes' => "line1\nline2\tTabbed", + ]], ];tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/ArrayTypeTestCase.php (1)
33-39: Optional: silence unused dataset label parameterIf $testName isn’t used in assertions, consider prefixing it with an underscore to silence static analysis without changing data provider shapes.
- public function can_handle_array_values(string $testName, array $arrayValue): void + public function can_handle_array_values(string $_testName, array $arrayValue): voidtests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php (2)
23-34: Consider simplifying to ST_AsEWKT if semantics match your expectationThe CASE building EWKT when SRID > 0 is clear but verbose. If your supported PostGIS versions return “SRID=...;WKT” only when SRID > 0, you can delegate to ST_AsEWKT and drop the CASE. Keeps intent and reduces quoting/escaping overhead.
Proposed change:
- protected function getSelectExpression(string $columnName): string - { - return \sprintf( - 'CASE WHEN ST_SRID("%s") = 0 THEN ST_AsText("%s") ELSE ' - ."'SRID=' || ST_SRID(\"%s\") || ';' || ST_AsText(\"%s\") END AS \"%s\"", - $columnName, - $columnName, - $columnName, - $columnName, - $columnName - ); - } + protected function getSelectExpression(string $columnName): string + { + return \sprintf('ST_AsEWKT("%s") AS "%s"', $columnName, $columnName); + }
44-47: Remove unused $testName to satisfy PHPMD$testName isn’t used inside the test body. Drop it and adjust the provider to pass a single argument while keeping dataset names as array keys.
- public function can_handle_geometry_values(string $testName, WktSpatialData $wktSpatialData): void + public function can_handle_geometry_values(WktSpatialData $wktSpatialData): voidAnd in the data provider and its docblock:
- /** - * @return array<string, array{string, WktSpatialData}> - */ + /** + * @return array<string, array{WktSpatialData}> + */ public static function provideValidTransformations(): array { return [ - 'point' => ['point', WktSpatialData::fromWkt('POINT(1 2)')], + 'point' => [WktSpatialData::fromWkt('POINT(1 2)')], ... - 'point z with srid' => ['point z with srid', WktSpatialData::fromWkt('SRID=4326;POINT Z(-122.4194 37.7749 100)')], + 'point z with srid' => [WktSpatialData::fromWkt('SRID=4326;POINT Z(-122.4194 37.7749 100)')], ]; }src/MartinGeorgiev/Doctrine/DBAL/Types/SpatialDataArray.php (4)
90-108: Optional: unify array parsing into a single state machineYou maintain two near-identical scanners. A single parser with flags (insideQuotes, depth) would reduce duplication and branch-specific edge cases.
If you prefer minimal change, at least normalize trimming behavior between quoted and unquoted paths (see next comment).
110-159: Trim quoted items for consistency with unquoted pathparseQuotedWktArray preserves leading/trailing spaces while parseUnquotedWktArray trims. Normalize by trimming here too; WktSpatialData::fromWkt tolerates spaces, but consistent inputs reduce surprises.
- return $wktItems; + return \array_map('trim', $wktItems);
241-262: Normalize leading whitespace and fix enum name in comment
- Add ltrim after SRID extraction so the anchored regexes reliably match even if a space follows the semicolon (your comment mentions that hybrid format).
- Minor: the comment mentions “WktGeometryType” but the code builds patterns from GeometryType.
- // Normalize dimensional modifiers using patterns built from WktGeometryType enum + // Normalize dimensional modifiers using patterns built from GeometryType enum foreach ($this->getDimensionalModifierPatterns() as $pattern => $replacement) { $wkt = \preg_replace($pattern, $replacement, (string) $wkt); } - return $sridPrefix.$wkt; + // Ensure leading whitespace does not defeat anchors after SRID removal + return $sridPrefix.\ltrim($wkt);
47-64: Precompute regex fragments to avoid repeated enum scansgetDimensionalModifierPatterns calls GeometryType::cases() and DimensionalModifier::cases() on each normalization. Consider caching the assembled patterns in private readonly properties initialized on first use.
If you want a minimal change, memoize within the two helper methods:
- private function getGeometryTypesPattern(): string + private ?string $geometryTypesPattern = null; + private function getGeometryTypesPattern(): string { - $geometryTypes = \array_map( + if ($this->geometryTypesPattern !== null) { + return $this->geometryTypesPattern; + } + $geometryTypes = \array_map( static fn (GeometryType $geometryType): string => $geometryType->value, GeometryType::cases() ); - - return '('.\implode('|', $geometryTypes).')'; + return $this->geometryTypesPattern = '('.\implode('|', $geometryTypes).')'; } - private function getDimensionalModifierPatterns(): array + private ?array $dimensionalModifierPatterns = null; + private function getDimensionalModifierPatterns(): array { + if ($this->dimensionalModifierPatterns !== null) { + return $this->dimensionalModifierPatterns; + } $geometryTypesPattern = $this->getGeometryTypesPattern(); $modifierValues = \array_map( static fn (DimensionalModifier $dimensionalModifier): string => $dimensionalModifier->value, DimensionalModifier::cases() ); $modifiersPattern = '('.\implode('|', $modifierValues).')'; - return [ + return $this->dimensionalModifierPatterns = [ \sprintf('/^%s%s\b/', $geometryTypesPattern, $modifiersPattern) => '$1 $2', \sprintf('/^%s\s+%s\s+\(/', $geometryTypesPattern, $modifiersPattern) => '$1 $2(', \sprintf('/^%s\s+%s\b/', $geometryTypesPattern, $modifiersPattern) => '$1 $2', ]; }tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php (3)
23-27: Consider unifying SRID handling with array tests (optional).Single-value Geography currently drops SRID by using ST_AsText(…::geometry). Geography[] tests return EWKT and then normalize SRID=4326 during comparison. For consistency and to surface SRID-related regressions, consider returning EWKT here as well and normalizing in assertion (similar to SpatialArrayTypeTestCase). Example:
- // For geography, avoid adding SRID prefix to preserve original input format - return \sprintf('ST_AsText("%s"::geometry) AS "%s"', $columnName, $columnName); + return \sprintf( + 'CASE WHEN ST_SRID("%s"::geometry) = 0 THEN ST_AsText("%s"::geometry) ELSE ' + ."'SRID=' || ST_SRID(\"%s\"::geometry) || ';' || ST_AsText(\"%s\"::geometry) END AS \"%s\"", + $columnName, + $columnName, + $columnName, + $columnName, + $columnName + );If you adopt this, also update the assertion strategy for this test (e.g., override assertTypeValueEquals to strip SRID=4326; mirroring SpatialArrayTypeTestCase) or update expected WKTs to include SRID=4326. Otherwise, keeping ST_AsText is fine—it just hides SRID-related issues in single-value geography tests.
35-40: Remove unused $testName parameter to satisfy PHPMD and simplify the data provider contract.PHPMD flags $testName as unused. PHPUnit already uses the dataset keys as labels, so you can drop the parameter entirely.
Apply:
- public function can_handle_geography_values(string $testName, WktSpatialData $wktSpatialData): void + public function can_handle_geography_values(WktSpatialData $wktSpatialData): void
42-55: Align provider signature with the simplified test and broaden coverage (optional).
- Update the provider tuple shape now that $testName is removed.
- Optional: add representative MULTILINESTRING and MULTIPOLYGON cases for completeness.
Apply:
- /** - * @return array<string, array{string, WktSpatialData}> - */ + /** + * @return array<string, array{WktSpatialData}> + */ public static function provideValidTransformations(): array { return [ - 'point' => ['point', WktSpatialData::fromWkt('POINT(1 2)')], - 'linestring' => ['linestring', WktSpatialData::fromWkt('LINESTRING(0 0,1 1,2 2)')], - 'polygon' => ['polygon', WktSpatialData::fromWkt('POLYGON((0 0,0 1,1 1,1 0,0 0))')], - 'geometrycollection' => ['geometrycollection', WktSpatialData::fromWkt('GEOMETRYCOLLECTION(POINT(1 2),LINESTRING(0 0,1 1))')], - 'point z' => ['point z', WktSpatialData::fromWkt('POINT Z(-122.4194 37.7749 100)')], - 'linestring m' => ['linestring m', WktSpatialData::fromWkt('LINESTRING M(-122.4194 37.7749 1,-122.4094 37.7849 2)')], - 'polygon zm' => ['polygon zm', WktSpatialData::fromWkt('POLYGON ZM((-122.5 37.7 0 1,-122.5 37.8 0 1,-122.4 37.8 0 1,-122.4 37.7 0 1,-122.5 37.7 0 1))')], + 'point' => [WktSpatialData::fromWkt('POINT(1 2)')], + 'linestring' => [WktSpatialData::fromWkt('LINESTRING(0 0,1 1,2 2)')], + 'polygon' => [WktSpatialData::fromWkt('POLYGON((0 0,0 1,1 1,1 0,0 0))')], + 'geometrycollection' => [WktSpatialData::fromWkt('GEOMETRYCOLLECTION(POINT(1 2),LINESTRING(0 0,1 1))')], + 'multilinestring' => [WktSpatialData::fromWkt('MULTILINESTRING((0 0,1 1),(2 2,3 3))')], + 'multipolygon' => [WktSpatialData::fromWkt('MULTIPOLYGON(((0 0,0 1,1 1,1 0,0 0)))')], + 'point z' => [WktSpatialData::fromWkt('POINT Z(-122.4194 37.7749 100)')], + 'linestring m' => [WktSpatialData::fromWkt('LINESTRING M(-122.4194 37.7749 1,-122.4094 37.7849 2)')], + 'polygon zm' => [WktSpatialData::fromWkt('POLYGON ZM((-122.5 37.7 0 1,-122.5 37.8 0 1,-122.4 37.8 0 1,-122.4 37.7 0 1,-122.5 37.7 0 1))')], ]; }tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php (2)
40-78: Nice breadth of single-item cases; consider adding collections for parity.You already cover POINT, LINESTRING, POLYGON, MULTIPOINT, EWKT with SRID, and dimensional modifiers. Consider adding GEOMETRYCOLLECTION, MULTILINESTRING, and MULTIPOLYGON to exercise parser/round-trip across all core geometry families.
Apply:
return [ @@ 'single multipoint' => [[ WktSpatialData::fromWkt('MULTIPOINT((1 2),(3 4))'), ]], + 'single multilinestring' => [[ + WktSpatialData::fromWkt('MULTILINESTRING((0 0,1 1),(2 2,3 3))'), + ]], + 'single multipolygon' => [[ + WktSpatialData::fromWkt('MULTIPOLYGON(((0 0,0 1,1 1,1 0,0 0)))'), + ]], + 'single geometrycollection' => [[ + WktSpatialData::fromWkt('GEOMETRYCOLLECTION(POINT(1 2),LINESTRING(0 0,1 1))'), + ]],
93-112: Solid mixed-array scenarios. Consider one case with SRID=0 alongside non-zero SRIDs.You already exercise absent SRID, multiple explicit SRIDs, and dimensional modifiers. Adding an explicit unknown SRID case (geometry with SRID 0) next to non-zero SRID verifies the CASE branch that omits the SRID prefix is exercised at read time.
Apply:
return [ @@ 'mixed types' => [[ WktSpatialData::fromWkt('POINT(0 0)'), WktSpatialData::fromWkt('SRID=3035;POINT Z(1 2 3)'), WktSpatialData::fromWkt('LINESTRING M(0 0 1,1 1 2)'), WktSpatialData::fromWkt('SRID=3857;POLYGON((0 0,0 1000,1000 1000,1000 0,0 0))'), WktSpatialData::fromWkt('MULTIPOINT((1 2),(3 4))'), + // SRID=0 will be emitted without SRID= prefix by the SELECT CASE expression + WktSpatialData::fromWkt('SRID=0;POINT(9 9)'), ]],tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/SpatialArrayTypeTestCase.php (1)
16-32: Guard against empty input or handle typed empty arrays to avoid invalid SQL.If $spatialData is empty, placeholders become an empty string and INSERT ... VALUES (ARRAY[]) is invalid. Either assert non-empty or emit a typed empty array literal (ARRAY[]::[]).
Apply:
protected function runArrayConstructorRoundTrip(string $typeName, string $columnType, string $elementPgType, WktSpatialData ...$spatialData): void { [$tableName, $columnName] = $this->prepareTestTable($columnType); try { - $placeholders = \implode(',', \array_fill(0, \count($spatialData), '?::'.$elementPgType)); - $sql = \sprintf('INSERT INTO %s.%s ("%s") VALUES (ARRAY[%s])', self::DATABASE_SCHEMA, $tableName, $columnName, $placeholders); - /** @var list<string> $params */ - $params = \array_values(\array_map(static fn (WktSpatialData $wktSpatialData): string => (string) $wktSpatialData, $spatialData)); - $this->connection->executeStatement($sql, $params); + if (\count($spatialData) === 0) { + // Insert a typed empty array + $sql = \sprintf( + 'INSERT INTO %s.%s ("%s") VALUES (ARRAY[]::%s[])', + self::DATABASE_SCHEMA, + $tableName, + $columnName, + $elementPgType + ); + $this->connection->executeStatement($sql); + } else { + $placeholders = \implode(',', \array_fill(0, \count($spatialData), '?::'.$elementPgType)); + $sql = \sprintf('INSERT INTO %s.%s ("%s") VALUES (ARRAY[%s])', self::DATABASE_SCHEMA, $tableName, $columnName, $placeholders); + /** @var list<string> $params */ + $params = \array_values(\array_map(static fn (WktSpatialData $wktSpatialData): string => (string) $wktSpatialData, $spatialData)); + $this->connection->executeStatement($sql, $params); + }If you prefer to keep the current tests’ call sites unchanged (they never pass empty), add a simple assertion instead:
- try { + try { + \assert(\count($spatialData) > 0, 'spatialData must not be empty when using ARRAY[...] constructor');
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (26)
src/MartinGeorgiev/Doctrine/DBAL/Types/SpatialDataArray.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/ArrayTypeTestCase.php(3 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/CidrArrayTypeTest.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/CidrTypeTest.php(2 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/DateRangeTypeTest.php(2 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/InetArrayTypeTest.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/InetTypeTest.php(3 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/Int4RangeTypeTest.php(2 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/Int8RangeTypeTest.php(2 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/JsonbTypeTest.php(3 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/MacaddrArrayTypeTest.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/MacaddrTypeTest.php(2 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/NumRangeTypeTest.php(2 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/PointTypeTest.php(2 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/RangeTypeTestCase.php(2 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/ScalarTypeTestCase.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/SpatialArrayTypeTestCase.php(1 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php(2 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TsRangeTypeTest.php(2 hunks)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TstzRangeTypeTest.php(2 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTest.php(1 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTest.php(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTest.php
- tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTest.php
- tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php
🧰 Additional context used
🧠 Learnings (8)
📚 Learning: 2025-04-11T11:23:44.192Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#340
File: tests/MartinGeorgiev/Doctrine/DBAL/Types/InetArrayTest.php:145-145
Timestamp: 2025-04-11T11:23:44.192Z
Learning: In the PostgreSQL for Doctrine test cases, methods that test database-to-PHP conversions should use `mixed` type for parameter and include non-string test cases in their data providers, following the pattern in classes like InetTest, CidrTest, and MacaddrTest.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/MacaddrTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/CidrArrayTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/InetArrayTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TstzRangeTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/NumRangeTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/ScalarTypeTestCase.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/DateRangeTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/PointTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/Int4RangeTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/RangeTypeTestCase.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TsRangeTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/CidrTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/MacaddrArrayTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/Int8RangeTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/ArrayTypeTestCase.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/JsonbTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/InetTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/SpatialArrayTypeTestCase.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php
📚 Learning: 2025-03-11T12:32:10.726Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#263
File: src/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/Numrange.php:19-21
Timestamp: 2025-03-11T12:32:10.726Z
Learning: In the postgresql-for-doctrine repository, PostgreSQL range functions have distinct implementations for different data types. The `Numrange` function works with numeric/decimal values and is tested using the `ContainsDecimals` fixture with properties typed as `float`. In contrast, the `Int4range` function works with 32-bit integers and is tested using the `ContainsIntegers` fixture with properties typed as `int`. While the PHP implementations share a similar structure (extending `BaseFunction`), they are semantically different as they handle different PostgreSQL data types.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TstzRangeTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/NumRangeTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/DateRangeTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/Int4RangeTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/RangeTypeTestCase.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TsRangeTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/Int8RangeTypeTest.php
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the point[] array type should be documented as "point[]" not "_point" in the AVAILABLE-TYPES.md table, to be consistent with all other array types like text[], jsonb[], inet[], etc.
Applied to files:
src/MartinGeorgiev/Doctrine/DBAL/Types/SpatialDataArray.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/SpatialArrayTypeTestCase.php
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what TYPE_NAME constants contain and getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/SpatialArrayTypeTestCase.php
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php
📚 Learning: 2025-05-23T11:11:57.951Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#383
File: tests/Unit/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/RadiansTest.php:1-9
Timestamp: 2025-05-23T11:11:57.951Z
Learning: Tests in the `Tests\Unit\MartinGeorgiev\Doctrine\ORM\Query\AST\Functions` namespace extend a custom `TestCase` class from the same namespace (`Tests\Unit\MartinGeorgiev\Doctrine\ORM\Query\AST\Functions\TestCase`), rather than PHPUnit's TestCase directly, and therefore don't need an explicit import.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/SpatialArrayTypeTestCase.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php
📚 Learning: 2025-03-29T03:31:17.114Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#318
File: tests/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/XmlAggTest.php:1-9
Timestamp: 2025-03-29T03:31:17.114Z
Learning: Tests in the `Tests\MartinGeorgiev\Doctrine\ORM\Query\AST\Functions` namespace extend a custom `TestCase` class from the same namespace (`Tests\MartinGeorgiev\Doctrine\ORM\Query\AST\Functions\TestCase`), rather than PHPUnit's TestCase, and therefore don't need an explicit import.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/SpatialArrayTypeTestCase.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php
📚 Learning: 2025-03-29T03:31:17.114Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#318
File: tests/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/XmlAggTest.php:1-9
Timestamp: 2025-03-29T03:31:17.114Z
Learning: Tests in the `Tests\MartinGeorgiev\Doctrine\ORM\Query\AST\Functions` namespace extend a custom `TestCase` class from the same namespace (`Tests\MartinGeorgiev\Doctrine\ORM\Query\AST\Functions\TestCase`), not PHPUnit's TestCase, and therefore don't need an explicit import statement.
Applied to files:
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/SpatialArrayTypeTestCase.phptests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php
🧬 Code graph analysis (19)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/MacaddrTypeTest.php (1)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
runDbalBindingRoundTrip(89-105)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/InetArrayTypeTest.php (1)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
runDbalBindingRoundTrip(89-105)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TstzRangeTypeTest.php (1)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
runDbalBindingRoundTrip(89-105)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/NumRangeTypeTest.php (1)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
runDbalBindingRoundTrip(89-105)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/ScalarTypeTestCase.php (1)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
runDbalBindingRoundTrip(89-105)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/DateRangeTypeTest.php (1)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
runDbalBindingRoundTrip(89-105)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/PointTypeTest.php (1)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
runDbalBindingRoundTrip(89-105)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/Int4RangeTypeTest.php (1)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
runDbalBindingRoundTrip(89-105)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/RangeTypeTestCase.php (1)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
runDbalBindingRoundTrip(89-105)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TsRangeTypeTest.php (1)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
runDbalBindingRoundTrip(89-105)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/MacaddrArrayTypeTest.php (1)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
runDbalBindingRoundTrip(89-105)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/Int8RangeTypeTest.php (1)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
runDbalBindingRoundTrip(89-105)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/JsonbTypeTest.php (1)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
runDbalBindingRoundTrip(89-105)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/InetTypeTest.php (1)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
runDbalBindingRoundTrip(89-105)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php (3)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (2)
WktSpatialData(22-109)fromWkt(46-88)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php (7)
DataProvider(33-38)DataProvider(83-88)getTypeName(13-16)getPostgresTypeName(18-21)getSelectExpression(23-31)provideSingleItemArrays(40-78)provideMultiItemArrays(93-113)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/SpatialArrayTypeTestCase.php (2)
SpatialArrayTypeTestCase(9-65)runArrayConstructorTypeTest(39-42)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php (4)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (2)
WktSpatialData(22-109)fromWkt(46-88)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php (1)
getSelectExpression(23-31)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php (2)
Test(36-40)getSelectExpression(23-34)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (4)
Test(122-130)TestCase(11-136)getSelectExpression(132-135)runDbalBindingRoundTrip(89-105)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/SpatialArrayTypeTestCase.php (3)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (1)
WktSpatialData(22-109)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (5)
TestCase(11-136)prepareTestTable(45-52)fetchConvertedValue(57-70)assertRoundTrip(75-84)assertTypeValueEquals(23-29)tests/Integration/MartinGeorgiev/TestCase.php (1)
dropTestTableIfItExists(239-246)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (8)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTypeTest.php (1)
getSelectExpression(23-31)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php (1)
getSelectExpression(23-27)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTypeTest.php (1)
getSelectExpression(23-31)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php (1)
getSelectExpression(23-34)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/PointTypeTest.php (1)
assertTypeValueEquals(37-44)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/RangeTypeTestCase.php (1)
assertTypeValueEquals(96-103)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/SpatialArrayTypeTestCase.php (1)
assertTypeValueEquals(44-64)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/PointArrayTypeTest.php (1)
assertTypeValueEquals(61-72)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php (2)
src/MartinGeorgiev/Doctrine/DBAL/Types/ValueObject/WktSpatialData.php (2)
WktSpatialData(22-109)fromWkt(46-88)tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (5)
Test(122-130)TestCase(11-136)getTypeName(16-16)getSelectExpression(132-135)runDbalBindingRoundTrip(89-105)
🪛 PHPMD (2.15.0)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php
37-37: Avoid unused parameters such as '$testName'. (Unused Code Rules)
(UnusedFormalParameter)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php
44-44: Avoid unused parameters such as '$testName'. (Unused Code Rules)
(UnusedFormalParameter)
🔇 Additional comments (31)
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/ScalarTypeTestCase.php (1)
17-17: Switching to DBAL binding round-trip for nulls looks goodThis aligns this base test with the new harness and validates parameter binding semantics for nulls. No further action from my side.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php (1)
89-101: Migration complete: all tests userunDbalBindingRoundTrip
- Verified via
rg -nP '\brunTypeTest\s*\(' -g 'tests/**'—no matches found, confirming no lingeringrunTypeTestcalls.tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/Int8RangeTypeTest.php (1)
51-52: Range tests migrated to DBAL binding round-trip — good coverage of infinite/empty casesThe migration accurately exercises convertToDatabaseValue and convertToPHPValue for edge-case ranges via DBAL. No further issues spotted here.
Also applies to: 62-63
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/DateRangeTypeTest.php (1)
71-72: DBAL round-trip migration for daterange is correctConsistently applies the new harness for infinite and empty ranges. Looks good.
Also applies to: 87-88
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TsRangeTypeTest.php (1)
71-72: DBAL round-trip migration for tsrange is correctThe updated tests now validate binding semantics for temporal ranges, including empty intervals. All good.
Also applies to: 87-88
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/InetTypeTest.php (2)
53-57: Invalid-address path now goes through real DBAL conversion.This should still surface InvalidInetForPHPException during setParameter/convertToDatabaseValue. Looks good.
If failures happen later than conversion, the exception type could differ. Keep an eye on where the exception is raised in the type’s convertor.
64-68: Empty string validation remains intact under round-trip.Round-tripping '' via DBAL is appropriate and should still raise InvalidInetForPHPException early. No issues.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TstzRangeTypeTest.php (2)
64-66: Round-trip for unbounded ranges is correct; confirm normalization semantics.Using runDbalBindingRoundTrip for [null, null) ensures we test actual DB representation of unbounded tstzrange. Verify that assertRoundTrip accounts for any normalization performed by PostgreSQL (e.g., canonical bounds).
If needed, extend assertRoundTrip to compare semantic equality (emptiness/unboundedness, bounds, and endpoints) rather than string serialization.
74-82: Empty-range scenario covered via DBAL; ensure Type rehydrates as empty.The lower > upper case should persist as EMPTY through the DB and back. Confirm the converter reconstructs a RangeValueObject flagged as empty in this case.
If equality is strict, consider adding an explicit assertion that the retrieved object isEmpty() instead of relying solely on generic round-trip equality.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/MacaddrTypeTest.php (2)
30-31: Good move to DBAL round-trip for positive cases.Switching to runDbalBindingRoundTrip increases end-to-end confidence (binding + conversion + retrieval). Looks solid.
55-56: convertToDatabaseValue enforces validation at bind timeThe
Macaddr::convertToDatabaseValuemethod (src/MartinGeorgiev/Doctrine/DBAL/Types/Macaddr.php:32–38) performs two checks and throwsInvalidMacaddrForPHPExceptionfor both non-string values and invalid MAC formats. This guarantees thatrunDbalBindingRoundTrip($typeName, $columnType, 'invalid-mac')will surface the exception during parameter binding, as intended. No changes are necessary here.tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/NumRangeTypeTest.php (2)
51-52: Round-trip path for infinite ranges: LGTM.This aligns with the shared test harness and better validates DBAL binding + conversion.
62-63: Round-trip path for empty ranges: LGTM.Nice coverage for canonicalization of empty ranges via DB.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/Int4RangeTypeTest.php (2)
51-52: Round-trip path for infinite ranges: LGTM.Consistent with the shared harness; complements the operator tests below.
62-63: Round-trip path for empty ranges: LGTM.Coverage looks good and mirrors the numrange tests.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/RangeTypeTestCase.php (2)
146-147: Round-trip for concrete RangeValueObject: LGTM.Reusing the shared harness here promotes consistency across all range subclasses.
132-133: Null handling in assertRoundTrip is correctly short-circuitedI’ve verified that TestCase::assertRoundTrip immediately returns when $expected is null (asserting $retrieved is null) before any call to assertTypeValueEquals takes place (see tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php lines 77–80). No changes are needed here.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/JsonbTypeTest.php (3)
28-29: Null JSONB round-trip: LGTM.This validates the type’s null pass-through end-to-end.
37-38: Empty array JSONB round-trip: LGTM.Good to assert empty-collection fidelity.
47-48: Associative arrays are compared with PHPUnit’s assertEquals (order-insensitive)The JSONB round-trip tests call into TestCase::assertRoundTrip, which for array values dispatches to PHPUnit’s
assertEquals($expected, $actual)(invoked inassertTypeValueEquals), and PHP’s array comparison with==ignores key order. No change is needed.• Location: tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php, around lines 23–27
• Key code:match (true) { \is_array($expected) && \is_array($actual) => $this->assertEquals( $expected, $actual, sprintf('Array type %s round-trip failed', $typeName) ), // … }tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/ArrayTypeTestCase.php (3)
17-17: Good migration to DBAL binding round-trip for empty arraysSwitching to runDbalBindingRoundTrip exercises real DBAL parameter binding and retrieval paths. Looks correct.
26-26: Null round-trip path coveredrunDbalBindingRoundTrip(null) is the right signal for ensuring NULL is preserved across DB round-trip.
38-38: Array payload round-trip now aligned with new harnessUsing runDbalBindingRoundTrip for arrayValue aligns this base test with the new integration harness.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/CidrTypeTest.php (2)
30-31: Round-trip migration LGTMReplacing runTypeTest with runDbalBindingRoundTrip ensures we test actual DBAL binding behavior for valid CIDR values.
56-57: Exception path still validated via DBAL bindingUsing runDbalBindingRoundTrip with an invalid network keeps the failure surface at parameter binding time, which is representative of real usage.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/PointTypeTest.php (2)
31-31: Null handling via DBAL round-trip is correctThis matches the harness pattern used across other scalar types.
53-54: Point value object round-trip path is appropriateGood use of runDbalBindingRoundTrip with PointValueObject; your custom equality assertion keeps numeric precision concerns localized.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTypeTest.php (1)
36-40: Null geometry path coveredRound-tripping null via the geometry DBAL type is tested correctly.
src/MartinGeorgiev/Doctrine/DBAL/Types/SpatialDataArray.php (1)
206-228: Type and format mapping paths look solidThe PHP conversion pathways correctly distinguish invalid type vs invalid format and map to subclass-specific ConversionException factories. Good separation of concerns.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTypeTest.php (1)
13-21: Type name and PostgreSQL type look correct.Using 'geography' and 'GEOGRAPHY' aligns with the new DBAL type and column under test.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/SpatialArrayTypeTestCase.php (1)
58-64: SRID=4326 normalization for array comparisons is spot on.Comparing stringified WKTs after stripping the default SRID keeps tests stable across geography/geometry cases while still preserving non-default SRIDs.
tests/Integration/MartinGeorgiev/Doctrine/DBAL/Types/TestCase.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (5)
docs/USE-CASES-AND-EXAMPLES.md (3)
148-149: Resolve heading-style lint error (MD003) by removing the redundant ATX headingYou already introduced a setext H2 “Using PostGIS Types” on Line 144. The extra H3 here is redundant and triggers MD003. Remove it to keep a single setext-style heading for the section.
-### Using PostGIS Types with Doctrine DBAL (Geometry/Geography) -
174-179: Add a language to the fenced code block (MD040)Specify a language to satisfy markdownlint and improve rendering.
-``` +```text POINTZ(1 2 3) => POINT Z(1 2 3) LINESTRINGM(0 0 1, 1 1 2) => LINESTRING M(0 0 1, 1 1 2) POLYGONZM((...)) => POLYGON ZM((...)) POINT Z (1 2 3) => POINT Z(1 2 3)--- `194-202`: **Align static constructor usage and casing with earlier examples** Earlier examples use WktSpatialData::fromWkt(...). Here you switch to GeometryValueObject::fromWKT(...) and change the case. Unless GeometryValueObject::fromWKT() exists and is intended, prefer the same value object and casing for consistency. ```diff -use MartinGeorgiev\Doctrine\DBAL\Types\ValueObject\Geometry as GeometryValueObject; +use MartinGeorgiev\Doctrine\DBAL\Types\ValueObject\WktSpatialData; -Type::addType('geography', MartinGeorgiev\Doctrine\DBAL\Types\Geography::class); -Type::addType('geometry', MartinGeorgiev\Doctrine\DBAL\Types\Geometry::class); +Type::addType('geography', MartinGeorgiev\Doctrine\DBAL\Types\Geography::class); +Type::addType('geometry', MartinGeorgiev\Doctrine\DBAL\Types\Geometry::class); -$location = GeometryValueObject::fromWKT('SRID=4326;POINT(-122.4194 37.7749)'); +$location = WktSpatialData::fromWkt('SRID=4326;POINT(-122.4194 37.7749)'); $entity->setLocation($location);If the Geometry value object and fromWKT are indeed public API, disregard the import change and unify casing to match the declared method name in code.
docs/GEOMETRY_ARRAYS.md (2)
171-177: Add a language to the fenced code block (MD040) for normalization examplesMark this block as “text” to satisfy the linter and clarify intent.
-``` +```text POINTZ(1 2 3) => POINT Z(1 2 3) LINESTRINGM(0 0 1, 1 1 2) => LINESTRING M(0 0 1, 1 1 2) POLYGONZM((...)) => POLYGON ZM((...)) POINT Z (1 2 3) => POINT Z(1 2 3) SRID=4326;POINT Z (1 2 3) => SRID=4326;POINT Z(1 2 3)--- `260-263`: **Verify claim about indexing geometry[] arrays with GiST** Out of the box, PostgreSQL/PostGIS provide GiST operator classes for geometry (scalar) columns. GiST on geometry[] may not be supported directly; typical approaches use expression indexes or a separate child table. Please verify this claim and adjust wording if needed. Proposed phrasing if unsupported: - “PostgreSQL does not natively GiST-index geometry[] columns. Consider expression indexes over UNNEST(...) or a normalized table of geometries with a GiST index on the geometry column.” </blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used**: Path: .coderabbit.yaml **Review profile**: CHILL **Plan**: Pro **💡 Knowledge Base configuration:** - MCP integration is disabled by default for public repositories - Jira integration is disabled by default for public repositories - Linear integration is disabled by default for public repositories You can enable these sources in your CodeRabbit configuration. <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between e69e4120df298cc7dbb1052dd1cc3d321b0e3926 and 10fcc618597ea0633b63c67907b7fa4887960c61. </details> <details> <summary>📒 Files selected for processing (3)</summary> * `docs/GEOMETRY_ARRAYS.md` (1 hunks) * `docs/INTEGRATING-WITH-DOCTRINE.md` (2 hunks) * `docs/USE-CASES-AND-EXAMPLES.md` (1 hunks) </details> <details> <summary>🧰 Additional context used</summary> <details> <summary>🧠 Learnings (4)</summary> <details> <summary>📚 Learning: 2025-08-19T13:07:15.170Z</summary>Learnt from: martin-georgiev
PR: #421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the point[] array type should be documented as "point[]" not "_point" in the AVAILABLE-TYPES.md table, to be consistent with all other array types like text[], jsonb[], inet[], etc.**Applied to files:** - `docs/GEOMETRY_ARRAYS.md` - `docs/INTEGRATING-WITH-DOCTRINE.md` </details> <details> <summary>📚 Learning: 2025-08-19T13:07:15.170Z</summary>Learnt from: martin-georgiev
PR: #421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.**Applied to files:** - `docs/GEOMETRY_ARRAYS.md` - `docs/INTEGRATING-WITH-DOCTRINE.md` </details> <details> <summary>📚 Learning: 2025-08-19T13:07:15.170Z</summary>Learnt from: martin-georgiev
PR: #421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what TYPE_NAME constants contain and getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.**Applied to files:** - `docs/GEOMETRY_ARRAYS.md` - `docs/INTEGRATING-WITH-DOCTRINE.md` </details> <details> <summary>📚 Learning: 2025-03-11T12:32:10.726Z</summary>Learnt from: martin-georgiev
PR: #263
File: src/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/Numrange.php:19-21
Timestamp: 2025-03-11T12:32:10.726Z
Learning: In the postgresql-for-doctrine repository, PostgreSQL range functions have distinct implementations for different data types. TheNumrangefunction works with numeric/decimal values and is tested using theContainsDecimalsfixture with properties typed asfloat. In contrast, theInt4rangefunction works with 32-bit integers and is tested using theContainsIntegersfixture with properties typed asint. While the PHP implementations share a similar structure (extendingBaseFunction), they are semantically different as they handle different PostgreSQL data types.**Applied to files:** - `docs/USE-CASES-AND-EXAMPLES.md` </details> </details><details> <summary>🪛 LanguageTool</summary> <details> <summary>docs/GEOMETRY_ARRAYS.md</summary> [grammar] ~216-~216: There might be a mistake here. Context: ... ## Test Coverage ### Integration Tests - ✅ **Single-item arrays**: Fully tested a... (QB_NEW_EN) --- [grammar] ~217-~217: There might be a mistake here. Context: ... tested against real PostgreSQL database - ❌ **Multi-item arrays**: Tested to demon... (QB_NEW_EN) --- [grammar] ~218-~218: There might be a mistake here. Context: ...e PostGIS limitation (expected failures) - ✅ **All geometry types**: POINT, LINESTR... (QB_NEW_EN) --- [grammar] ~219-~219: There might be a mistake here. Context: ...T, LINESTRING, POLYGON, MULTIPOINT, etc. - ✅ **Dimensional modifiers**: Z, M, ZM co... (QB_NEW_EN) --- [grammar] ~220-~220: There might be a mistake here. Context: ...sional modifiers**: Z, M, ZM coordinates - ✅ **SRID support**: EWKT format with coo... (QB_NEW_EN) --- [grammar] ~221-~221: There might be a mistake here. Context: ...t**: EWKT format with coordinate systems - ✅ **Geography specifics**: Auto-SRID beh... (QB_NEW_EN) --- [grammar] ~226-~226: There might be a mistake here. Context: ... the PostGIS limitation. ### Unit Tests - ✅ **Multi-item arrays**: Tested for pars... (QB_NEW_EN) --- [grammar] ~227-~227: There might be a mistake here. Context: ...-item arrays**: Tested for parsing logic - ✅ **Mixed scenarios**: Different geometr... (QB_NEW_EN) --- [grammar] ~228-~228: There might be a mistake here. Context: ...ferent geometry types, SRIDs, dimensions - ✅ **Edge cases**: Empty arrays, complex ... (QB_NEW_EN) --- [grammar] ~229-~229: There might be a mistake here. Context: ...es**: Empty arrays, complex combinations - ✅ **Round-trip conversion**: Database ↔ ... (QB_NEW_EN) --- [grammar] ~234-~234: There might be a mistake here. Context: ...# Supported Features ### Geometry Types - ✅ POINT, LINESTRING, POLYGON - ✅ MULTIPO... (QB_NEW_EN) --- [grammar] ~235-~235: There might be a mistake here. Context: ...try Types - ✅ POINT, LINESTRING, POLYGON - ✅ MULTIPOINT, MULTILINESTRING, MULTIPOLY... (QB_NEW_EN) --- [grammar] ~236-~236: There might be a mistake here. Context: ...ULTIPOINT, MULTILINESTRING, MULTIPOLYGON - ✅ GEOMETRYCOLLECTION - ✅ All other PostG... (QB_NEW_EN) --- [grammar] ~237-~237: There might be a mistake here. Context: ...ING, MULTIPOLYGON - ✅ GEOMETRYCOLLECTION - ✅ All other PostGIS geometry types as of... (QB_NEW_EN) --- [grammar] ~240-~240: There might be a mistake here. Context: ...types as of v3.5 ### Coordinate Systems - ✅ **SRID support**: `SRID=4326;POINT(-12... (QB_NEW_EN) --- [grammar] ~241-~241: There might be a mistake here. Context: ...oordinate Systems - ✅ **SRID support**: `SRID=4326;POINT(-122 37)` - ✅ **Dimensional modifiers**: Z (elevatio... (QB_NEW_EN) --- [grammar] ~242-~242: There might be a mistake here. Context: ...ifiers**: Z (elevation), M (measure), ZM - ✅ **Mixed coordinates**: Arrays with dif... (QB_NEW_EN) --- [grammar] ~245-~245: There might be a mistake here. Context: ...SRIDs/dimensions ### Geography Features - ✅ **Auto-SRID**: Geography types automat... (QB_NEW_EN) --- [grammar] ~247-~247: There might be a mistake here. Context: ...dinates**: Null Island, poles, date line - ✅ **Geographic calculations**: Proper sp... (QB_NEW_EN) --- [grammar] ~260-~260: There might be a mistake here. Context: ...erformance, full PostgreSQL optimization - **Multi-item workarounds**: May have perfo... (QB_NEW_EN) --- [grammar] ~261-~261: There might be a mistake here. Context: ...e implications depending on the approach - **Indexing**: PostgreSQL can index geometr... (QB_NEW_EN) --- [grammar] ~262-~262: There might be a mistake here. Context: ...index geometry arrays using GiST indexes - **Query optimization**: Use appropriate sp... (QB_NEW_EN) --- [grammar] ~267-~267: There might be a mistake here. Context: ...be addressed in future versions through: - **PostGIS improvements** to array literal ... (QB_NEW_EN) --- [grammar] ~268-~268: There might be a mistake here. Context: ... improvements** to array literal parsing - **Doctrine DBAL enhancements** to custom S... (QB_NEW_EN) --- [grammar] ~269-~269: There might be a mistake here. Context: ... enhancements** to custom SQL generation - **Alternative storage strategies** built i... (QB_NEW_EN) </details> </details> <details> <summary>🪛 markdownlint-cli2 (0.17.2)</summary> <details> <summary>docs/USE-CASES-AND-EXAMPLES.md</summary> 148-148: Heading style Expected: setext; Actual: atx (MD003, heading-style) --- 174-174: Fenced code blocks should have a language specified (MD040, fenced-code-language) </details> </details> </details> <details> <summary>⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)</summary> * GitHub Check: sloth * GitHub Check: PostgreSQL 17 + PostGIS 3.4 + PHP 8.3 * GitHub Check: PostgreSQL 16 + PostGIS 3.4 + PHP 8.2 * GitHub Check: PostgreSQL 17 + PostGIS 3.4 + PHP 8.1 * GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.2 * GitHub Check: PostgreSQL 16 + PostGIS 3.4 + PHP 8.1 * GitHub Check: PostgreSQL 16 + PostGIS 3.4 + PHP 8.3 * GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.1 * GitHub Check: PostgreSQL 16 + PostGIS 3.5 + PHP 8.1 * GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer 3.0 * GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer 2.1 * GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer 2.1 * GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer latest * GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer 3.0 * GitHub Check: PHP 8.2 + Doctrine ORM 3.0 + Doctrine Lexer 3.0 * GitHub Check: PHP 8.2 + Doctrine ORM latest + Doctrine Lexer 3.0 * GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer latest * GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer 2.1 * GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer latest * GitHub Check: PHP 8.1 + Doctrine ORM 3.0 + Doctrine Lexer 3.0 </details> </details> <details> <summary>🔇 Additional comments (1)</summary><blockquote> <details> <summary>docs/INTEGRATING-WITH-DOCTRINE.md (1)</summary><blockquote> `34-37`: **DBAL type registrations for PostGIS look good** Types for geometry/geography (and arrays) are registered consistently with existing patterns. </blockquote></details> </blockquote></details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
194-202: Update README.md to use the correct ValueObject and method casingThe current docs snippet references a
ValueObject\Geometryclass and callsfromWKT(), but:
- No
Geometryclass exists undersrc/**/ValueObject/- The factory method is named
fromWkt(), notfromWKT()- All other examples consistently use
WktSpatialData::fromWkt()Please update lines 194–202 in README.md as follows:
- use MartinGeorgiev\Doctrine\DBAL\Types\ValueObject\Geometry as GeometryValueObject; + use MartinGeorgiev\Doctrine\DBAL\Types\ValueObject\WktSpatialData; @@ - $location = GeometryValueObject::fromWKT('SRID=4326;POINT(-122.4194 37.7749)'); + $location = WktSpatialData::fromWkt('SRID=4326;POINT(-122.4194 37.7749)');This ensures the docs import the existing
WktSpatialDatavalue object and call the correctly casedfromWkt()method.
🧹 Nitpick comments (6)
README.md (2)
58-59: Call out PostGIS requirement next to new spatial types.Add a brief “Requires PostGIS extension” note where Geometry/Geography are listed to set expectations early.
- - PostGIS Geometry (`geometry`, `geometry[]`) - - PostGIS Geography (`geography`, `geography[]`) + - PostGIS Geometry (`geometry`, `geometry[]`) — requires the PostGIS extension + - PostGIS Geography (`geography`, `geography[]`) — requires the PostGIS extension
129-142: Prefer “docker compose” and clarify PostGIS enablement.
- Modern Docker uses “docker compose” (space) over “docker-compose”. Consider aligning terminology to reduce confusion.
- Add a one-liner that the compose stack enables the postgis extension automatically (or link to the compose file section doing it).
-# Start PostgreSQL with PostGIS using Docker Compose -docker-compose up -d +# Start PostgreSQL with PostGIS using Docker Compose +# (the stack enables the postgis extension automatically) +docker compose up -d @@ -# Stop PostgreSQL -docker-compose down -v +# Stop PostgreSQL +docker compose down -vdocs/USE-CASES-AND-EXAMPLES.md (3)
148-149: Unify heading style (mdlint MD003).This file uses setext-style headings earlier; this new section uses atx (
###). Keep one style consistently.-### Using PostGIS Types with Doctrine DBAL (Geometry/Geography) +Using PostGIS Types with Doctrine DBAL (Geometry/Geography) +---
160-163: Optional: note coordinate order (lon lat) to reduce user mistakes.Many users intuitively write
POINT(lat lon). Your examples usePOINT(lon lat), which matches WKT. Consider adding a short note.-// Insert a single geography value with SRID +// Insert a single geography value with SRID +// Note: WKT uses (longitude latitude) order: POINT(lon lat) @@ -$location = GeometryValueObject::fromWKT('SRID=4326;POINT(-122.4194 37.7749)'); +// Note: WKT uses (longitude latitude) order: POINT(lon lat) +$location = WktSpatialData::fromWkt('SRID=4326;POINT(-122.4194 37.7749)');Also applies to: 200-202
174-179: Specify a language for this fenced block (mdlint MD040).Label the normalization examples as plain text for better rendering.
-``` +```text POINTZ(1 2 3) => POINT Z(1 2 3) LINESTRINGM(0 0 1, 1 1 2) => LINESTRING M(0 0 1, 1 1 2) POLYGONZM((...)) => POLYGON ZM((...)) POINT Z (1 2 3) => POINT Z(1 2 3)</blockquote></details> <details> <summary>docs/SPATIAL-TYPES.md (1)</summary><blockquote> `97-102`: **Add a note on coordinate order (lon lat) and SRID expectations.** Minor clarification so users don’t mix lat/lon or SRIDs. ```diff - Geography commonly uses SRID 4326; EWKT is supported (e.g., `SRID=4326;POINT(...)`). +- Geography commonly uses SRID 4326; EWKT is supported (e.g., `SRID=4326;POINT(...)`). +- WKT coordinates are in (longitude latitude) order unless you explicitly model otherwise.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
README.md(4 hunks)docs/SPATIAL-TYPES.md(1 hunks)docs/USE-CASES-AND-EXAMPLES.md(1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
README.md
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the point[] array type should be documented as "point[]" not "_point" in the AVAILABLE-TYPES.md table, to be consistent with all other array types like text[], jsonb[], inet[], etc.
Applied to files:
README.mddocs/SPATIAL-TYPES.md
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what TYPE_NAME constants contain and getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
README.md
📚 Learning: 2025-03-11T12:32:10.726Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#263
File: src/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/Numrange.php:19-21
Timestamp: 2025-03-11T12:32:10.726Z
Learning: In the postgresql-for-doctrine repository, PostgreSQL range functions have distinct implementations for different data types. The `Numrange` function works with numeric/decimal values and is tested using the `ContainsDecimals` fixture with properties typed as `float`. In contrast, the `Int4range` function works with 32-bit integers and is tested using the `ContainsIntegers` fixture with properties typed as `int`. While the PHP implementations share a similar structure (extending `BaseFunction`), they are semantically different as they handle different PostgreSQL data types.
Applied to files:
docs/USE-CASES-AND-EXAMPLES.md
🪛 LanguageTool
README.md
[grammar] ~58-~58: There might be a mistake here.
Context: ...tGIS Geometry (geometry, geometry[]) - PostGIS Geography (geography, `geograp...
(QB_NEW_EN)
[grammar] ~59-~59: There might be a mistake here.
Context: ...S Geography (geography, geography[]) - Range Types - Date and time ranges (...
(QB_NEW_EN)
[grammar] ~103-~103: There might be a mistake here.
Context: ...-CASES-AND-EXAMPLES.md) - Spatial Types - [Geometry Arrays](docs/GEOMETRY-ARRAYS.md...
(QB_NEW_EN)
docs/SPATIAL-TYPES.md
[grammar] ~7-~7: There might be a mistake here.
Context: ...rrayandGeographyArray`. It provides: - Parsing of PostgreSQL array literals con...
(QB_NEW_EN)
[grammar] ~8-~8: There might be a mistake here.
Context: ...ay literals containing WKT/EWKT elements - Handles nested parentheses and quoted/un...
(QB_NEW_EN)
[grammar] ~9-~9: There might be a mistake here.
Context: ...heses and quoted/unquoted array elements - Splits correctly even when commas occur ...
(QB_NEW_EN)
[grammar] ~10-~10: There might be a mistake here.
Context: ...hen commas occur inside coordinate lists - Normalization of dimensional modifiers a...
(QB_NEW_EN)
🪛 markdownlint-cli2 (0.17.2)
docs/USE-CASES-AND-EXAMPLES.md
148-148: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
174-174: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🔇 Additional comments (6)
README.md (1)
103-105: Nice cross-links.Good addition of Spatial Types and Geometry Arrays docs; helps discoverability.
docs/USE-CASES-AND-EXAMPLES.md (2)
151-170: Doctrine DBAL examples look good and consistent with type names.Binding a single geometry, geography (with SRID), and a single-item geometry[] is clear and matches the new types.
181-187: Good cross-link to geometry arrays details.The forward reference to GEOMETRY-ARRAYS.md is helpful for the multi-item case.
docs/SPATIAL-TYPES.md (3)
7-17: Nice overview of array parsing and normalization.Clear explanation of how SpatialDataArray tokenizes and normalizes WKT/EWKT.
118-124: Type registration looks correct and consistent with README.All four spatial types are registered with their DBAL names (
geometry,geometry[],geography,geography[]).
105-112: Good practical guidance on array caveat and workarounds.Clear explanation and link to GEOMETRY-ARRAYS.md; the raw ARRAY constructor example is especially useful.
Also applies to: 137-147
| use MartinGeorgiev\Doctrine\DBAL\Types\Exceptions\InvalidGeometryForPHPException; | ||
| use MartinGeorgiev\Doctrine\DBAL\Types\Exceptions\InvalidGeographyForPHPException; | ||
|
|
||
| // Invalid type passed to geometry column | ||
| try { | ||
| $qb->setParameter('geom', 'not a geometry', 'geometry'); | ||
| } catch (InvalidGeometryForPHPException $e) { | ||
| // Throws: "Invalid type for geometry column" | ||
| } | ||
|
|
||
| // Invalid format from database | ||
| try { | ||
| $geometryType->convertToPHPValue('invalid wkt from db', $platform); | ||
| } catch (InvalidGeometryForDatabaseException $e) { | ||
| // Throws: "Invalid format for geometry value" | ||
| } | ||
| ``` |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Exception namespaces/imports likely inconsistent; add missing import and verify actual namespaces.
You import InvalidGeometryForPHPException and InvalidGeographyForPHPException from Types\Exceptions, but later reference InvalidGeometryForDatabaseException without an import. Also, some exceptions may live under ValueObject\Exceptions per the new code.
Run this to verify namespaces and adjust the imports in the doc snippet accordingly:
If InvalidGeometryForDatabaseException is under ValueObject\Exceptions, import it explicitly and keep all exception imports from their correct namespaces:
-use MartinGeorgiev\Doctrine\DBAL\Types\Exceptions\InvalidGeometryForPHPException;
-use MartinGeorgiev\Doctrine\DBAL\Types\Exceptions\InvalidGeographyForPHPException;
+use MartinGeorgiev\Doctrine\DBAL\Types\Exceptions\InvalidGeometryForPHPException;
+use MartinGeorgiev\Doctrine\DBAL\Types\Exceptions\InvalidGeographyForPHPException;
+use MartinGeorgiev\Doctrine\DBAL\Types\ValueObject\Exceptions\InvalidGeometryForDatabaseException;If the exceptions all live under a single namespace, consolidate the imports accordingly.
🏁 Script executed:
#!/bin/bash
# List where the exceptions actually live
rg -nP 'class\s+Invalid(WktSpatialData|Geometry|Geography)\w*Exception' -g 'src/**'Length of output: 922
Correct exception imports in SPATIAL-TYPES.md snippet
The example at docs/SPATIAL-TYPES.md (lines 189–205) imports the PHP exceptions correctly, but omits the database exception import and misattributes its namespace. All of these live under Types\Exceptions, not Types\ValueObject\Exceptions. Please update the top of the snippet to include:
use MartinGeorgiev\Doctrine\DBAL\Types\Exceptions\InvalidGeometryForPHPException;
use MartinGeorgiev\Doctrine\DBAL\Types\Exceptions\InvalidGeographyForPHPException;
use MartinGeorgiev\Doctrine\DBAL\Types\Exceptions\InvalidGeometryForDatabaseException;If you later show a geography‐database example, also import:
use MartinGeorgiev\Doctrine\DBAL\Types\Exceptions\InvalidGeographyForDatabaseException;This ensures the code samples compile and accurately reflect where each exception class lives.
🤖 Prompt for AI Agents
docs/SPATIAL-TYPES.md around lines 189 to 205: the code snippet imports only the
PHP exceptions and omits (and misnames) the database exception(s); update the
snippet's imports to include the database exception(s) from the Types\Exceptions
namespace (e.g., add InvalidGeometryForDatabaseException and, if showing
geography DB examples, InvalidGeographyForDatabaseException) so that all
referenced exception classes are imported from
MartinGeorgiev\Doctrine\DBAL\Types\Exceptions.
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (9)
docs/GEOMETRY-ARRAYS.md (9)
31-53: Tighten the entity snippet: import ORM and document array element type.
- The snippet uses
@ORM\Columnbut doesn’t importORM.- Clarify that the arrays hold
WktSpatialDataobjects, not raw strings.Apply this diff to the snippet:
class Location { + use Doctrine\ORM\Mapping as ORM; + /** - * @ORM\Column(type="geometry[]") + * @ORM\Column(type="geometry[]") + * @var array<WktSpatialData> */ private array $geometries; /** - * @ORM\Column(type="geography[]") + * @ORM\Column(type="geography[]") + * @var array<WktSpatialData> */ private array $geographies;
10-25: Add a short note clarifying DBAL type names vs PostgreSQL internal names.This doc mixes DBAL type names (
geometry[]) and PostgreSQL catalog names (_geometry) in a single example. It’s correct, but an explicit note will prevent confusion and aligns with how other array types are documented.Insert after the code block:
+Note: Doctrine DBAL type names (what `getName()` returns) are `geometry`, `geometry[]`, `geography`, and `geography[]`. The platform mappings use PostgreSQL’s internal catalog names (`geometry`, `_geometry`, `geography`, `_geography`) to associate DB types with the DBAL types.
111-141: Explain the root cause and provide a minimal, reproducible example.The limitation is real in practice when building array literals via parameter binding, but the explanation would benefit from a concrete Postgres/psql reproduction to remove ambiguity around quoting and casting.
You can add a short reproduction block like:
-- geometry[] column CREATE TABLE locations(id serial primary key, geoms geometry[]); -- This fails when the driver sends a single text literal for the array -- and PostGIS applies the geometry input function to the whole string: -- ERROR: parse error - invalid geometry at ",POINT(3 4)..." INSERT INTO locations(geoms) VALUES ('{POINT(1 2),POINT(3 4)}'::geometry[]); -- These succeed (element-level casts): INSERT INTO locations(geoms) VALUES (ARRAY['POINT(1 2)'::geometry, 'POINT(3 4)'::geometry]);Would you like me to add this as a “Reproduction” subsection?
144-151: Use named parameters and element-level casts in ARRAY constructor.The current example is good conceptually, but using named placeholders improves clarity and mirrors real DBAL usage. Also show how to pass types.
Apply this diff:
-$sql = "INSERT INTO locations (geometries) VALUES (ARRAY[?::geometry, ?::geometry])"; -$connection->executeStatement($sql, ['POINT(1 2)', 'POINT(3 4)']); +$sql = 'INSERT INTO locations (geometries) VALUES (ARRAY[:g1::geometry, :g2::geometry])'; +$connection->executeStatement( + $sql, + ['g1' => 'POINT(1 2)', 'g2' => 'POINT(3 4)'], + ['g1' => 'string', 'g2' => 'string'] +);If you prefer, you can bind
WktSpatialDataand let DBAL typegeometryhandle conversion, but the explicit cast keeps the example database-agnostic.
163-188: Section ordering: “Option 3” heading appears before an unrelated “Normalization Rules” section.“Option 3: Application-Level Array Building” starts at Line 163, but the very next heading is “Normalization Rules,” and the Option 3 code appears at Lines 182–188. This is confusing.
- Move the “Normalization Rules (Dimensional Modifiers)” section below the “Workarounds” section (after Option 4), or
- Keep “Normalization Rules” where it is and move the “Option 3” heading down to immediately precede Lines 182–188.
Minimal inline change:
-### Option 3: Application-Level Array Building +<!-- moved below to just before the code block at line ~182 -->Then add the heading just before Line 182:
+### Option 3: Application-Level Array Building// Build arrays in application code, then use raw SQL
$geometries = ['POINT(1 2)', 'POINT(3 4)', 'LINESTRING(0 0,1 1)'];--- `216-225`: **Avoid implying that CI contains failing tests for the limitation.** Saying “expected failures” suggests red CI. Prefer phrasing that documents the limitation without implying failing assertions. Apply this diff: ```diff -- ❌ **Multi-item arrays**: Tested to demonstrate PostGIS limitation (expected failures) +- ⚠️ **Multi-item arrays**: Demonstrated as examples and via ARRAY[] workaround; + the limitation is documented but not asserted as a failing test in CI
250-257: Add a cross-link to AVAILABLE-TYPES and SPATIAL-TYPES docs for continuity.A one-liner here helps readers discover the broader spatial docs and type tables.
Add after the Best Practices list:
+See also: AVAILABLE-TYPES.md for the full list of DBAL types and SPATIAL-TYPES.md for value object semantics and parsing rules.
165-177: Nice normalization rules — add one EWKx example and a note on preservation.The examples are helpful. Consider also showing that EWKT with SRID is preserved, and clarify whitespace normalization is non-semantic.
258-273: Future improvements section is fine; avoid version pinning unless necessary.“as of v3.5” in Supported Features may age the doc quickly. Consider either removing the version or adding “(at time of writing)” to signal potential drift.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
docs/GEOMETRY-ARRAYS.md(1 hunks)docs/INTEGRATING-WITH-DOCTRINE.md(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- docs/INTEGRATING-WITH-DOCTRINE.md
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the point[] array type should be documented as "point[]" not "_point" in the AVAILABLE-TYPES.md table, to be consistent with all other array types like text[], jsonb[], inet[], etc.
Applied to files:
docs/GEOMETRY-ARRAYS.md
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
docs/GEOMETRY-ARRAYS.md
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what TYPE_NAME constants contain and getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
docs/GEOMETRY-ARRAYS.md
🪛 LanguageTool
docs/GEOMETRY-ARRAYS.md
[grammar] ~216-~216: There might be a mistake here.
Context: ... ## Test Coverage ### Integration Tests - ✅ Single-item arrays: Fully tested a...
(QB_NEW_EN)
[grammar] ~217-~217: There might be a mistake here.
Context: ... tested against real PostgreSQL database - ❌ Multi-item arrays: Tested to demon...
(QB_NEW_EN)
[grammar] ~218-~218: There might be a mistake here.
Context: ...e PostGIS limitation (expected failures) - ✅ All geometry types: POINT, LINESTR...
(QB_NEW_EN)
[grammar] ~219-~219: There might be a mistake here.
Context: ...T, LINESTRING, POLYGON, MULTIPOINT, etc. - ✅ Dimensional modifiers: Z, M, ZM co...
(QB_NEW_EN)
[grammar] ~220-~220: There might be a mistake here.
Context: ...sional modifiers**: Z, M, ZM coordinates - ✅ SRID support: EWKT format with coo...
(QB_NEW_EN)
[grammar] ~221-~221: There might be a mistake here.
Context: ...t**: EWKT format with coordinate systems - ✅ Geography specifics: Auto-SRID beh...
(QB_NEW_EN)
[grammar] ~226-~226: There might be a mistake here.
Context: ... the PostGIS limitation. ### Unit Tests - ✅ Multi-item arrays: Tested for pars...
(QB_NEW_EN)
[grammar] ~227-~227: There might be a mistake here.
Context: ...-item arrays**: Tested for parsing logic - ✅ Mixed scenarios: Different geometr...
(QB_NEW_EN)
[grammar] ~228-~228: There might be a mistake here.
Context: ...ferent geometry types, SRIDs, dimensions - ✅ Edge cases: Empty arrays, complex ...
(QB_NEW_EN)
[grammar] ~229-~229: There might be a mistake here.
Context: ...es**: Empty arrays, complex combinations - ✅ Round-trip conversion: Database ↔ ...
(QB_NEW_EN)
[grammar] ~234-~234: There might be a mistake here.
Context: ...# Supported Features ### Geometry Types - ✅ POINT, LINESTRING, POLYGON - ✅ MULTIPO...
(QB_NEW_EN)
[grammar] ~235-~235: There might be a mistake here.
Context: ...try Types - ✅ POINT, LINESTRING, POLYGON - ✅ MULTIPOINT, MULTILINESTRING, MULTIPOLY...
(QB_NEW_EN)
[grammar] ~236-~236: There might be a mistake here.
Context: ...ULTIPOINT, MULTILINESTRING, MULTIPOLYGON - ✅ GEOMETRYCOLLECTION - ✅ All other PostG...
(QB_NEW_EN)
[grammar] ~237-~237: There might be a mistake here.
Context: ...ING, MULTIPOLYGON - ✅ GEOMETRYCOLLECTION - ✅ All other PostGIS geometry types as of...
(QB_NEW_EN)
[grammar] ~240-~240: There might be a mistake here.
Context: ...types as of v3.5 ### Coordinate Systems - ✅ SRID support: `SRID=4326;POINT(-12...
(QB_NEW_EN)
[grammar] ~241-~241: There might be a mistake here.
Context: ...oordinate Systems - ✅ SRID support: SRID=4326;POINT(-122 37) - ✅ Dimensional modifiers: Z (elevatio...
(QB_NEW_EN)
[grammar] ~242-~242: There might be a mistake here.
Context: ...ifiers**: Z (elevation), M (measure), ZM - ✅ Mixed coordinates: Arrays with dif...
(QB_NEW_EN)
[grammar] ~245-~245: There might be a mistake here.
Context: ...SRIDs/dimensions ### Geography Features - ✅ Auto-SRID: Geography types automat...
(QB_NEW_EN)
[grammar] ~247-~247: There might be a mistake here.
Context: ...dinates**: Null Island, poles, date line - ✅ Geographic calculations: Proper sp...
(QB_NEW_EN)
[grammar] ~260-~260: There might be a mistake here.
Context: ...erformance, full PostgreSQL optimization - Multi-item workarounds: May have perfo...
(QB_NEW_EN)
[grammar] ~261-~261: There might be a mistake here.
Context: ...e implications depending on the approach - Indexing: PostgreSQL can index geometr...
(QB_NEW_EN)
[grammar] ~262-~262: There might be a mistake here.
Context: ...index geometry arrays using GiST indexes - Query optimization: Use appropriate sp...
(QB_NEW_EN)
[grammar] ~267-~267: There might be a mistake here.
Context: ...be addressed in future versions through: - PostGIS improvements to array literal ...
(QB_NEW_EN)
[grammar] ~268-~268: There might be a mistake here.
Context: ... improvements** to array literal parsing - Doctrine DBAL enhancements to custom S...
(QB_NEW_EN)
[grammar] ~269-~269: There might be a mistake here.
Context: ... enhancements** to custom SQL generation - Alternative storage strategies built i...
(QB_NEW_EN)
🪛 markdownlint-cli2 (0.17.2)
docs/GEOMETRY-ARRAYS.md
4-4: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
48-48: Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
- GitHub Check: sloth
- GitHub Check: PostgreSQL 16 + PostGIS 3.4 + PHP 8.4
- GitHub Check: PostgreSQL 17 + PostGIS 3.4 + PHP 8.3
- GitHub Check: PostgreSQL 16 + PostGIS 3.5 + PHP 8.4
- GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.3
- GitHub Check: PostgreSQL 16 + PostGIS 3.4 + PHP 8.3
- GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.2
- GitHub Check: PostgreSQL 16 + PostGIS 3.5 + PHP 8.1
- GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.1
- GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer 1.2
- GitHub Check: PHP 8.4 + Doctrine ORM 3.0 + Doctrine Lexer latest
- GitHub Check: PHP 8.4 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
- GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer 2.1
- GitHub Check: PHP 8.3 + Doctrine ORM 2.18 + Doctrine Lexer latest
- GitHub Check: PHP 8.3 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
- GitHub Check: PHP 8.3 + Doctrine ORM 2.14 + Doctrine Lexer latest
- GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer latest
- GitHub Check: PHP 8.3 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
- GitHub Check: PHP 8.2 + Doctrine ORM 3.0 + Doctrine Lexer latest
- GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer 2.1
🔇 Additional comments (3)
docs/GEOMETRY-ARRAYS.md (3)
13-25: Registration and mapping look correct (DBAL vs. PostgreSQL catalog names).
- Mapping
'_geometry' -> 'geometry[]'and'_geography' -> 'geography[]'matches PostgreSQL internal array OIDs while keeping Doctrine DBAL type names asgeometry[]/geography[]. Good consistency with the rest of the docs.
101-109: Examples look good and match the WKT/EWKT expectations.No issues spotted here.
5-9: Scope and terminology LGTM.Clear statement of purpose and the two array types supported.
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (19)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTest.php (6)
19-23: Tighten the platform mock typing with an intersection typeSince
createMock(AbstractPlatform::class)returns aMockObject&AbstractPlatform, we can reflect that in the property type for stronger static analysis (PHP ≥ 8.1). This avoids accidental misuse where a pureMockObjectwithoutAbstractPlatformwould be assigned.Confirm the minimum supported PHP version in this repo is ≥ 8.1 and the PHPUnit version exposes
PHPUnit\Framework\MockObject\MockObjectas an interface (so property intersections are allowed). If yes, apply:- private MockObject $platform; + private AbstractPlatform&MockObject $platform;
35-35: Use assertSame for strict string/null comparisonsThese assertions compare strings and nulls.
assertSameis stricter and avoids accidental truthiness/type juggling.- self::assertEquals('geography', $this->fixture->getName()); + self::assertSame('geography', $this->fixture->getName());- self::assertEquals($postgresValue, $this->fixture->convertToDatabaseValue($wktSpatialData, $this->platform)); + self::assertSame($postgresValue, $this->fixture->convertToDatabaseValue($wktSpatialData, $this->platform));- self::assertEquals((string) $wktSpatialData, (string) $result); + self::assertSame((string) $wktSpatialData, (string) $result);Also applies to: 42-42, 57-57
149-152: Avoid mixed dimensionality in POLYHEDRALSURFACE exampleThe current WKT mixes 2D and 3D coordinates within the same geometry, which typical WKT/EWKT parsers reject. Recommend using a consistent 3D example and marking
Z.- 'polyhedralsurface' => [ - 'wktSpatialData' => WktSpatialData::fromWkt('POLYHEDRALSURFACE(((0 0, 0 1, 1 1, 1 0, 0 0)), ((0 0, 0 1, 0 0 1, 0 0)))'), - 'postgresValue' => 'POLYHEDRALSURFACE(((0 0, 0 1, 1 1, 1 0, 0 0)), ((0 0, 0 1, 0 0 1, 0 0)))', - ], + 'polyhedralsurface z' => [ + 'wktSpatialData' => WktSpatialData::fromWkt('POLYHEDRALSURFACE Z(((0 0 0, 0 1 0, 1 1 0, 1 0 0, 0 0 0)), ((0 0 0, 0 1 0, 0 0 1, 0 0 0)))'), + 'postgresValue' => 'POLYHEDRALSURFACE Z(((0 0 0, 0 1 0, 1 1 0, 1 0 0, 0 0 0)), ((0 0 0, 0 1 0, 0 0 1, 0 0 0)))', + ],
170-179: Add SRID+M/ZM positive cases to strengthen coverageGreat coverage overall. Consider adding a few SRID+M/ZM combinations to ensure EWKT handling is robust across dimensional modifiers.
'complex geometry with srid' => [ 'wktSpatialData' => WktSpatialData::fromWkt('SRID=4326;MULTIPOLYGON(((0 0, 0 1, 1 1, 1 0, 0 0)), ((2 2, 2 3, 3 3, 3 2, 2 2)))'), 'postgresValue' => 'SRID=4326;MULTIPOLYGON(((0 0, 0 1, 1 1, 1 0, 0 0)), ((2 2, 2 3, 3 3, 3 2, 2 2)))', ], 'circular geometry with srid' => [ 'wktSpatialData' => WktSpatialData::fromWkt('SRID=4326;CIRCULARSTRING(0 0, 1 1, 2 0)'), 'postgresValue' => 'SRID=4326;CIRCULARSTRING(0 0, 1 1, 2 0)', ], + 'linestring m with srid' => [ + 'wktSpatialData' => WktSpatialData::fromWkt('SRID=4326;LINESTRING M(0 0 1, 1 1 2)'), + 'postgresValue' => 'SRID=4326;LINESTRING M(0 0 1, 1 1 2)', + ], + 'point zm with srid' => [ + 'wktSpatialData' => WktSpatialData::fromWkt('SRID=4326;POINT ZM(-122.4194 37.7749 100 1)'), + 'postgresValue' => 'SRID=4326;POINT ZM(-122.4194 37.7749 100 1)', + ], + 'geometrycollection zm with srid' => [ + 'wktSpatialData' => WktSpatialData::fromWkt('SRID=4326;GEOMETRYCOLLECTION ZM(POINT ZM(1 2 3 4), LINESTRING ZM(0 0 0 1, 1 1 0 2))'), + 'postgresValue' => 'SRID=4326;GEOMETRYCOLLECTION ZM(POINT ZM(1 2 3 4), LINESTRING ZM(0 0 0 1, 1 1 0 2))', + ],
204-210: Broaden invalid DB→PHP inputs to cover more non-string typesYou already cover an integer; adding boolean/array/object cases makes the negative path symmetrical with the DB-side tests and ensures type-guards stay intact.
public static function provideInvalidPHPValueInputs(): array { return [ 'empty string' => [''], 'invalid wkt' => ['INVALID_WKT'], 'missing coordinates' => ['POINT()'], 'not a string' => [123], + 'boolean value' => [true], + 'array value' => [[1, 2, 3]], + 'object value' => [new \stdClass()], ]; }Also applies to: 215-223
38-59: Optional: add an explicit round-trip test (DB → PHP → DB) for normalization guaranteesYou implicitly validate both directions; a dedicated round-trip test helps detect unintended normalization changes (e.g., whitespace, case, dimensional modifiers).
Add after the existing two tests:
#[DataProvider('provideValidTransformations')] #[Test] public function round_trips_db_to_php_to_db(?WktSpatialData $wktSpatialData, ?string $postgresValue): void { $php = $this->fixture->convertToPHPValue($postgresValue, $this->platform); $db = $this->fixture->convertToDatabaseValue($php, $this->platform); self::assertSame($postgresValue, $db); }tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTest.php (6)
31-34: Prefer assertSame over assertEquals for strict type-safe comparisonWe’re comparing strings; assertSame is stricter and avoids any accidental type juggling.
Apply this diff:
- self::assertEquals('geometry[]', $this->type->getName()); + self::assertSame('geometry[]', $this->type->getName());
141-154: Add dedicated tests for NULL elements in Postgres arraysWe exercise empty arrays and many quoted forms, but not arrays containing NULL elements. Given transformArrayItemForPHP(null) is supported, add a test to ensure NULL round-trips correctly and preserves positions.
Proposed addition (new test method):
#[Test] public function can_convert_postgres_arrays_with_nulls_to_php_value(): void { $postgresArray = '{NULL,"POINT(1 2)",NULL}'; $result = $this->type->convertToPHPValue($postgresArray, $this->platform); self::assertIsArray($result); self::assertCount(3, $result); self::assertNull($result[0]); self::assertInstanceOf(WktSpatialData::class, $result[1]); self::assertSame('POINT(1 2)', (string) $result[1]); self::assertNull($result[2]); }
141-154: Consider adding non-string input coverage for DB→PHP conversion (per project testing convention)Per prior repo patterns, DB-to-PHP conversion tests often accept mixed input and include non-string cases to verify robustness. You could keep this “valid postgres arrays” test strict and add a sibling that feeds non-string inputs (e.g., [], 123, true) and asserts expected failures/handling.
Proposed new test (aligned with learnings):
#[DataProvider('provideNonStringInputsForPHP')] #[Test] public function rejects_non_string_inputs_for_php_conversion(mixed $input): void { $this->expectException(\InvalidArgumentException::class); $this->type->convertToPHPValue($input, $this->platform); } /** * @return array<string, array{0: mixed}> */ public static function provideNonStringInputsForPHP(): array { return [ 'array' => [[]], 'int' => [42], 'bool' => [true], 'object' => [new \stdClass()], ]; }Note: If the intended behavior is different (e.g., coercion), adjust expectations accordingly.
381-390: Broaden normalization coverage to case-insensitive WKT tokensWKT/EWKT are case-insensitive in practice; adding lowercase variants ensures normalization is robust.
Apply this diff to extend the data provider:
return [ 'no-space POINTZ' => ['POINTZ(1 2 3)', 'POINT Z(1 2 3)'], 'no-space LINESTRINGM' => ['LINESTRINGM(0 0 1, 1 1 2)', 'LINESTRING M(0 0 1, 1 1 2)'], 'no-space POLYGONZM' => ['POLYGONZM((0 0 0 1, 0 1 0 1, 1 1 0 1, 1 0 0 1, 0 0 0 1))', 'POLYGON ZM((0 0 0 1, 0 1 0 1, 1 1 0 1, 1 0 0 1, 0 0 0 1))'], 'extra space before parentheses' => ['POINT Z (1 2 3)', 'POINT Z(1 2 3)'], 'multiple spaces between type and modifier' => ['POINT Z(1 2 3)', 'POINT Z(1 2 3)'], 'srid with extra space before parentheses' => ['SRID=4326;POINT Z (1 2 3)', 'SRID=4326;POINT Z(1 2 3)'], 'srid with no-space modifier' => ['SRID=4326;POINTZ(1 2 3)', 'SRID=4326;POINT Z(1 2 3)'], 'complex geometry with no-space modifier' => ['MULTIPOLYGONZM(((0 0 0 1, 0 1 0 1, 1 1 0 1, 1 0 0 1, 0 0 0 1)))', 'MULTIPOLYGON ZM(((0 0 0 1, 0 1 0 1, 1 1 0 1, 1 0 0 1, 0 0 0 1)))'], + 'lowercase point' => ['point(1 2)', 'POINT(1 2)'], + 'lowercase linestring with m' => ['linestringm(0 0 1, 1 1 2)', 'LINESTRING M(0 0 1, 1 1 2)'], + 'lowercase polygon zm' => ['polygonzm((0 0 0 1, 0 1 0 1, 1 1 0 1, 1 0 0 1, 0 0 0 1))', 'POLYGON ZM((0 0 0 1, 0 1 0 1, 1 1 0 1, 1 0 0 1, 0 0 0 1))'], + 'lowercase ewkt with srid' => ['srid=4326;point(-122.4194 37.7749)', 'SRID=4326;POINT(-122.4194 37.7749)'], ];
348-356: Use assertSame for string comparison in transformArrayItemForPHP testTighten the assertion to avoid type juggling.
Apply this diff:
- self::assertEquals($wktString, (string) $result); + self::assertSame($wktString, (string) $result);
372-374: Use assertSame for normalized string comparisonString normalization checks benefit from strict comparison.
Apply this diff:
- self::assertEquals($expected, (string) $result); + self::assertSame($expected, (string) $result);tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTest.php (7)
30-34: Prefer assertSame for strictness.The type name is a string;
assertSameprevents accidental truthiness/coercion.- self::assertEquals('geography[]', $this->type->getName()); + self::assertSame('geography[]', $this->type->getName());
165-218: Add canonical quoted array inputs (server-like output) to the provider.Add a few representative duplicates using quoted elements so parsing is robust to real-world outputs:
@@ public static function provideValidPostgresArraysForPHP(): array return [ 'single geographic point' => [ '{POINT(-122.4194 37.7749)}', ['POINT(-122.4194 37.7749)'], ], + 'single geographic point (quoted)' => [ + '{"POINT(-122.4194 37.7749)"}', + ['POINT(-122.4194 37.7749)'], + ], @@ 'geographic point with elevation' => [ '{POINT Z(-122.4194 37.7749 100)}', ['POINT Z(-122.4194 37.7749 100)'], ], + 'geographic point with elevation (quoted)' => [ + '{"POINT Z(-122.4194 37.7749 100)"}', + ['POINT Z(-122.4194 37.7749 100)'], + ], @@ 'mixed geographic features' => [ '{POINT Z(-122.4194 37.7749 100),LINESTRING M(-122.4194 37.7749 1, -122.4094 37.7849 2)}', ['POINT Z(-122.4194 37.7749 100)', 'LINESTRING M(-122.4194 37.7749 1, -122.4094 37.7849 2)'], ], + 'mixed geographic features (quoted)' => [ + '{"POINT Z(-122.4194 37.7749 100)","LINESTRING M(-122.4194 37.7749 1, -122.4094 37.7849 2)"}', + ['POINT Z(-122.4194 37.7749 100)', 'LINESTRING M(-122.4194 37.7749 1, -122.4094 37.7849 2)'], + ], @@ 'geographic areas with srid' => [ '{SRID=4326;POINT(-122.4194 37.7749),SRID=4326;POLYGON((-122.5 37.7, -122.5 37.8, -122.4 37.8, -122.4 37.7, -122.5 37.7))}', ['SRID=4326;POINT(-122.4194 37.7749)', 'SRID=4326;POLYGON((-122.5 37.7, -122.5 37.8, -122.4 37.8, -122.4 37.7, -122.5 37.7))'], ], + 'geographic areas with srid (quoted)' => [ + '{"SRID=4326;POINT(-122.4194 37.7749)","SRID=4326;POLYGON((-122.5 37.7, -122.5 37.8, -122.4 37.8, -122.4 37.7, -122.5 37.7))"}', + ['SRID=4326;POINT(-122.4194 37.7749)', 'SRID=4326;POLYGON((-122.5 37.7, -122.5 37.8, -122.4 37.8, -122.4 37.7, -122.5 37.7))'], + ], @@ 'complex geographic multigeometry' => [ '{MULTIPOINT((-122.4194 37.7749), (-122.4094 37.7849)),MULTILINESTRING((-122.4194 37.7749, -122.4094 37.7849), (-122.4294 37.7649, -122.4394 37.7549))}', ['MULTIPOINT((-122.4194 37.7749), (-122.4094 37.7849))', 'MULTILINESTRING((-122.4194 37.7749, -122.4094 37.7849), (-122.4294 37.7649, -122.4394 37.7549))'], ], + 'complex geographic multigeometry (quoted)' => [ + '{"MULTIPOINT((-122.4194 37.7749), (-122.4094 37.7849))","MULTILINESTRING((-122.4194 37.7749, -122.4094 37.7849), (-122.4294 37.7649, -122.4394 37.7549))"}', + ['MULTIPOINT((-122.4194 37.7749), (-122.4094 37.7849))', 'MULTILINESTRING((-122.4194 37.7749, -122.4094 37.7849), (-122.4294 37.7649, -122.4394 37.7549))'], + ],If you confirm expected behavior for non-string inputs (return null vs throw), I can add those datasets too.
296-305: Use assertSame for string equality; keep expectations strict.- self::assertEquals($expected, (string) $result); + self::assertSame($expected, (string) $result);
309-321: Add case-normalization and SRID + lowercase variants to harden parsing.WKT is case-insensitive. Add lower/mixed-case inputs to ensure normalization is robust:
return [ 'no-space POINTZ' => ['POINTZ(1 2 3)', 'POINT Z(1 2 3)'], 'no-space LINESTRINGM' => ['LINESTRINGM(0 0 1, 1 1 2)', 'LINESTRING M(0 0 1, 1 1 2)'], 'no-space POLYGONZM' => ['POLYGONZM((0 0 0 1, 0 1 0 1, 1 1 0 1, 1 0 0 1, 0 0 0 1))', 'POLYGON ZM((0 0 0 1, 0 1 0 1, 1 1 0 1, 1 0 0 1, 0 0 0 1))'], 'extra space before parentheses' => ['POINT Z (1 2 3)', 'POINT Z(1 2 3)'], 'multiple spaces between type and modifier' => ['POINT Z(1 2 3)', 'POINT Z(1 2 3)'], 'srid with extra space before parentheses' => ['SRID=4326;POINT Z (1 2 3)', 'SRID=4326;POINT Z(1 2 3)'], 'srid with no-space modifier' => ['SRID=4326;POINTZ(1 2 3)', 'SRID=4326;POINT Z(1 2 3)'], 'complex geometry with no-space modifier' => ['MULTIPOLYGONZM(((0 0 0 1, 0 1 0 1, 1 1 0 1, 1 0 0 1, 0 0 0 1)))', 'MULTIPOLYGON ZM(((0 0 0 1, 0 1 0 1, 1 1 0 1, 1 0 0 1, 0 0 0 1)))'], + 'lowercase no-space pointz' => ['pointz(1 2 3)', 'POINT Z(1 2 3)'], + 'mixed-case srid+pointz' => ['srid=4326;PoInTz(1 2 3)', 'SRID=4326;POINT Z(1 2 3)'], ];
61-63: Align with repo testing style: use mixed parameter types for DB→PHP tests and include non-string cases.Per our prior learning for this repo, DB-to-PHP conversion tests accept
mixedinput and include non-string datasets. Please align this test with that convention to keep consistency across types.If desired, I can scan Inet/Cidr/Macaddr tests and auto-generate analogous datasets here for spatial arrays.
Also applies to: 165-167
44-51: Add a positive validation test for isValidArrayItemForDatabase (happy-path).You validate several invalid cases; add an explicit positive case to prevent regressions.
Add this new test method:
#[Test] public function validates_wkt_spatial_data_as_valid_array_item_for_database(): void { $item = WktSpatialData::fromWkt('SRID=4326;POINT(1 2)'); self::assertTrue($this->type->isValidArrayItemForDatabase($item)); }
52-60: Optional: also assert DB literal uses quoting (unit-level) to lock in behavior.In addition to updating expectations, consider asserting that each element is quoted in the round-trip test, making it impossible to regress to unsafe literals.
Example assertion to add after
$databaseValueis built:self::assertMatchesRegularExpression('/^\{".*"(,".*")*\}$/', $databaseValue);Also applies to: 220-237
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTest.php(1 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTest.php(1 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTest.php(1 hunks)tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTest.php(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryTest.php
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-04-11T11:23:44.192Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#340
File: tests/MartinGeorgiev/Doctrine/DBAL/Types/InetArrayTest.php:145-145
Timestamp: 2025-04-11T11:23:44.192Z
Learning: In the PostgreSQL for Doctrine test cases, methods that test database-to-PHP conversions should use `mixed` type for parameter and include non-string test cases in their data providers, following the pattern in classes like InetTest, CidrTest, and MacaddrTest.
Applied to files:
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTest.phptests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTest.phptests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTest.php
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the point[] array type should be documented as "point[]" not "_point" in the AVAILABLE-TYPES.md table, to be consistent with all other array types like text[], jsonb[], inet[], etc.
Applied to files:
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTest.php
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
- GitHub Check: sloth
- GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer 1.2
- GitHub Check: PHP 8.3 + Doctrine ORM 3.0 + Doctrine Lexer latest
- GitHub Check: PHP 8.4 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
- GitHub Check: PHP 8.3 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
- GitHub Check: PHP 8.3 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
- GitHub Check: PHP 8.3 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
- GitHub Check: PHP 8.2 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
- GitHub Check: PHP 8.3 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
- GitHub Check: PHP 8.2 + Doctrine ORM 2.14 + Doctrine Lexer latest
- GitHub Check: PHP 8.2 + Doctrine ORM 2.18 + Doctrine Lexer latest
- GitHub Check: PHP 8.2 + Doctrine ORM latest + Doctrine Lexer 3.0
- GitHub Check: PHP 8.2 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
- GitHub Check: PHP 8.2 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
- GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer latest
- GitHub Check: PHP 8.1 + Doctrine ORM 3.0 + Doctrine Lexer latest
- GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer latest
- GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer 3.0
- GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
- GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer 2.1
🔇 Additional comments (9)
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyTest.php (1)
182-188: LGTM: invalid database-value cases match exception contract and learningGood use of
mixedand non-string inputs forconvertToDatabaseValuenegative paths, aligned with earlier test-suite conventions.Also applies to: 193-202
tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeometryArrayTest.php (4)
240-248: Confirm intended behavior for empty quoted array element being silently droppedThe case '{"POINT(1 2)",""}' expects the empty second element to be discarded. In PostgreSQL arrays, empty string ("") is a valid element distinct from NULL, while geometry[] elements should always be valid WKT/EWKT or NULL. Silently dropping may hide data issues; consider either preserving position as null (if "NULL") or throwing on invalid element (""). Please confirm which behavior we want for geometry[] parsing.
Would you like the parser to:
- treat "" as an error and throw, or
- preserve array shape and map only the literal token NULL (unquoted) to null while rejecting ""?
52-123: Great breadth of DB formatting coverageNice coverage across Z/M/ZM, EWKT with SRID, mixed types, and complex geometries. This should catch most formatting regressions.
265-282: Solid round-trip testThe bidirectional assertions ensure lossless PHP→DB→PHP conversions for representative geometries.
22-28: Composer constraints validated – no changes neededcomposer.json already requires PHP version ^8.1 (line 40) and phpunit/phpunit ^10.5.51 (line 55), both of which support intersection types and attributes. The
AbstractPlatform&MockObjectmock is therefore fully supported under the existing constraints.tests/Unit/MartinGeorgiev/Doctrine/DBAL/Types/GeographyArrayTest.php (4)
220-237: Round-trip test is solid.Covers PHP→DB→PHP preservation, including modifiers/SRID via value object stringification.
268-295: Negative validation coverage looks good.Covers multiple invalid types for DB array items.
22-28: Intersection-typed mock is safe under PHP ≥ 8.1
composer.json declares"php": "^8.1", so using the intersection typeAbstractPlatform&MockObjectis supported and won’t cause parse errors. No further changes are required.
150-163: Unable to confirmconvertToPHPValuehandling of non-string inputs—please manually verify
I wasn’t able to locate a concreteconvertToPHPValue()implementation inGeographyArray.php(it may be inherited from a base “Array” type), so I can’t definitively confirm how it treats non-string inputs or quoted elements. Before widening your test’s method signature and data provider:• Inspect
GeographyArray::convertToPHPValue()(or its parent implementation) to determine how it:
– Handles canonical quoted PG array elements (e.g."{POINT(-122 37),\"POINT(… )\"}")
– Reacts to non-string inputs (should it return them unchanged, convert them, or throw?)
• Based on that behavior, update the test signature tomixed $postgresArrayand extendprovideValidPostgresArraysForPHP()with:
– Quoted-element variants for arrays containing spaces/commas
– One or two safe non-string cases (e.g. an integer, an object) to assert the intended fallback
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
docs/GEOMETRY-ARRAYS.md (1)
56-75: Prior duplication fixed — section now appears only once.The earlier duplicate “Parameter Binding with DBAL” block is gone. Thanks for cleaning it up.
🧹 Nitpick comments (7)
docs/GEOMETRY-ARRAYS.md (7)
69-71: Column/table mismatch in example (places vs. locations).The example inserts into
placesbut uses a column namedlocations. Align the column name for clarity.- $qb->insert('places')->values(['locations' => ':wktSpatialData']); - $qb->setParameter('wktSpatialData', WktSpatialData::fromWkt('SRID=4326;POINT(-122.4194 37.7749)'), 'geography'); + $qb->insert('places')->values(['location' => ':wktSpatialData']); + $qb->setParameter('wktSpatialData', WktSpatialData::fromWkt('SRID=4326;POINT(-122.4194 37.7749)'), 'geography');
74-75: Make the cross-reference a clickable anchor.Turn the note into a link to the section below to help readers navigate.
- **Note**: Multi-item arrays have limitations - see the "Important Limitation: Multi-Item Arrays" section below. + **Note**: Multi-item arrays have limitations — see “[Important Limitation: Multi-Item Arrays](#important-limitation-multi-item-arrays)” below.
31-54: Add missing ORM use and tighten PHPDoc for array element types.
- Add
use Doctrine\ORM\Mapping as ORM;so the@ORM\Columnannotations resolve in isolation.- Clarify element types with PHPDoc to aid static analysis.
use MartinGeorgiev\Doctrine\DBAL\Types\ValueObject\WktSpatialData; +use Doctrine\ORM\Mapping as ORM; class Location { /** - * @ORM\Column(type="geometry[]") + * @var WktSpatialData[] + * @ORM\Column(type="geometry[]") */ private array $geometries; /** - * @ORM\Column(type="geography[]") + * @var WktSpatialData[] + * @ORM\Column(type="geography[]") */ private array $geographies; - public function setGeometries(array $geometries): void + /** + * @param string[] $geometries WKT/EWKT strings + */ + public function setGeometries(array $geometries): void { $this->geometries = array_map( fn(string $wkt) => WktSpatialData::fromWkt($wkt), $geometries ); } }
105-108: Specify a language on fenced block (MD040).Add a language to improve rendering and satisfy markdownlint.
-``` +```text ERROR: parse error - invalid geometry HINT: "POINT(1 2),POI" <-- parse error at position 14--- `148-154`: **Specify a language on fenced block (MD040).** Same lint as above; “text” fits this example table. ```diff -``` +```text POINTZ(1 2 3) => POINT Z(1 2 3) LINESTRINGM(0 0 1, 1 1 2) => LINESTRING M(0 0 1, 1 1 2) POLYGONZM((...)) => POLYGON ZM((...)) POINT Z (1 2 3) => POINT Z(1 2 3) SRID=4326;POINT Z (1 2 3) => SRID=4326;POINT Z(1 2 3)--- `239-243`: **Good correction on GiST guidance; consider a more stable doc link.** The GiST/array nuance is now accurate. The current anchor with `#idm…` can drift when docs are rebuilt. Prefer a stable target (FAQ) or section root. ```diff - - See [PostGIS documentation on spatial indexes](https://postgis.net/docs/using_postgis_dbmanagement.html#idm6696) for details + - See the [PostGIS FAQ on spatial indexes](https://postgis.net/documentation/faq/spatial-indexes/) for details
227-234: Name precise versions tested to time-box the limitation.Add the PostgreSQL and PostGIS versions used in your integration tests (e.g., “Tested with PostgreSQL 16.x, PostGIS 3.5.x”) so readers know the environment in which the limitation was observed.
-5. **Monitor PostGIS updates** - this limitation may be addressed in future versions +5. **State tested versions** — e.g., “Verified on PostgreSQL 16.x + PostGIS 3.5.x”; monitor PostGIS updates in case this changes.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
docs/GEOMETRY-ARRAYS.md(1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the point[] array type should be documented as "point[]" not "_point" in the AVAILABLE-TYPES.md table, to be consistent with all other array types like text[], jsonb[], inet[], etc.
Applied to files:
docs/GEOMETRY-ARRAYS.md
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
docs/GEOMETRY-ARRAYS.md
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what TYPE_NAME constants contain and getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
docs/GEOMETRY-ARRAYS.md
📚 Learning: 2025-05-03T00:18:09.078Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#366
File: tests/Unit/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ArrayPositionsTest.php:1-36
Timestamp: 2025-05-03T00:18:09.078Z
Learning: Always check the current official PostgreSQL documentation at https://www.postgresql.org/docs/ to verify function signatures and behaviors before suggesting improvements or additional tests. The `array_positions` function specifically has a fixed signature with exactly two parameters (array and search value), while `array_position` is variadic with 2-3 parameters.
Applied to files:
docs/GEOMETRY-ARRAYS.md
🪛 LanguageTool
docs/GEOMETRY-ARRAYS.md
[grammar] ~193-~193: There might be a mistake here.
Context: ... ## Test Coverage ### Integration Tests - ✅ Single-item arrays: Fully tested a...
(QB_NEW_EN)
[grammar] ~194-~194: There might be a mistake here.
Context: ... tested against real PostgreSQL database - ❌ Multi-item arrays: Tested to demon...
(QB_NEW_EN)
[grammar] ~195-~195: There might be a mistake here.
Context: ...e PostGIS limitation (expected failures) - ✅ All geometry types: POINT, LINESTR...
(QB_NEW_EN)
[grammar] ~196-~196: There might be a mistake here.
Context: ...T, LINESTRING, POLYGON, MULTIPOINT, etc. - ✅ Dimensional modifiers: Z, M, ZM co...
(QB_NEW_EN)
[grammar] ~197-~197: There might be a mistake here.
Context: ...sional modifiers**: Z, M, ZM coordinates - ✅ SRID support: EWKT format with coo...
(QB_NEW_EN)
[grammar] ~198-~198: There might be a mistake here.
Context: ...t**: EWKT format with coordinate systems - ✅ Geography specifics: Auto-SRID beh...
(QB_NEW_EN)
[grammar] ~203-~203: There might be a mistake here.
Context: ... the PostGIS limitation. ### Unit Tests - ✅ Multi-item arrays: Tested for pars...
(QB_NEW_EN)
[grammar] ~204-~204: There might be a mistake here.
Context: ...-item arrays**: Tested for parsing logic - ✅ Mixed scenarios: Different geometr...
(QB_NEW_EN)
[grammar] ~205-~205: There might be a mistake here.
Context: ...ferent geometry types, SRIDs, dimensions - ✅ Edge cases: Empty arrays, complex ...
(QB_NEW_EN)
[grammar] ~206-~206: There might be a mistake here.
Context: ...es**: Empty arrays, complex combinations - ✅ Round-trip conversion: Database ↔ ...
(QB_NEW_EN)
[grammar] ~211-~211: There might be a mistake here.
Context: ...# Supported Features ### Geometry Types - ✅ POINT, LINESTRING, POLYGON - ✅ MULTIPO...
(QB_NEW_EN)
[grammar] ~212-~212: There might be a mistake here.
Context: ...try Types - ✅ POINT, LINESTRING, POLYGON - ✅ MULTIPOINT, MULTILINESTRING, MULTIPOLY...
(QB_NEW_EN)
[grammar] ~213-~213: There might be a mistake here.
Context: ...ULTIPOINT, MULTILINESTRING, MULTIPOLYGON - ✅ GEOMETRYCOLLECTION - ✅ All other PostG...
(QB_NEW_EN)
[grammar] ~214-~214: There might be a mistake here.
Context: ...ING, MULTIPOLYGON - ✅ GEOMETRYCOLLECTION - ✅ All other PostGIS geometry types as of...
(QB_NEW_EN)
[grammar] ~217-~217: There might be a mistake here.
Context: ...types as of v3.5 ### Coordinate Systems - ✅ SRID support: `SRID=4326;POINT(-12...
(QB_NEW_EN)
[grammar] ~218-~218: There might be a mistake here.
Context: ...oordinate Systems - ✅ SRID support: SRID=4326;POINT(-122 37) - ✅ Dimensional modifiers: Z (elevatio...
(QB_NEW_EN)
[grammar] ~219-~219: There might be a mistake here.
Context: ...ifiers**: Z (elevation), M (measure), ZM - ✅ Mixed coordinates: Arrays with dif...
(QB_NEW_EN)
[grammar] ~222-~222: There might be a mistake here.
Context: ...SRIDs/dimensions ### Geography Features - ✅ Auto-SRID: Geography types automat...
(QB_NEW_EN)
[grammar] ~224-~224: There might be a mistake here.
Context: ...dinates**: Null Island, poles, date line - ✅ Geographic calculations: Proper sp...
(QB_NEW_EN)
[grammar] ~239-~239: There might be a mistake here.
Context: .... For proper spatial indexing, consider: - Normalizing arrays into separate geometr...
(QB_NEW_EN)
[grammar] ~240-~240: There might be a mistake here.
Context: ...ometry rows with individual GiST indexes - Materializing a single geometry (e.g., u...
(QB_NEW_EN)
[grammar] ~241-~241: There might be a mistake here.
Context: ...to a geometry column for GiST indexing - See [PostGIS documentation on spatial in...
(QB_NEW_EN)
[grammar] ~247-~247: There might be a mistake here.
Context: ...be addressed in future versions through: - PostGIS improvements to array literal ...
(QB_NEW_EN)
[grammar] ~248-~248: There might be a mistake here.
Context: ... improvements** to array literal parsing - Doctrine DBAL enhancements to custom S...
(QB_NEW_EN)
[grammar] ~249-~249: There might be a mistake here.
Context: ... enhancements** to custom SQL generation - Alternative storage strategies built i...
(QB_NEW_EN)
🪛 markdownlint-cli2 (0.17.2)
docs/GEOMETRY-ARRAYS.md
105-105: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
148-148: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
- GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer 1.2
- GitHub Check: PHP 8.4 + Doctrine ORM 2.14 + Doctrine Lexer latest
- GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer latest
- GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
- GitHub Check: PHP 8.4 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
- GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer 3.0
- GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
- GitHub Check: PHP 8.4 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
- GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer latest
- GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer 2.1
- GitHub Check: PHP 8.3 + Doctrine ORM 3.0 + Doctrine Lexer latest
- GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer latest
- GitHub Check: PHP 8.3 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
- GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer 2.1
- GitHub Check: PHP 8.2 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
- GitHub Check: PHP 8.2 + Doctrine ORM latest + Doctrine Lexer latest
- GitHub Check: PHP 8.2 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
- GitHub Check: PHP 8.2 + Doctrine ORM latest + Doctrine Lexer 2.1
- GitHub Check: PHP 8.1 + Doctrine ORM 2.14 + Doctrine Lexer latest
- GitHub Check: sloth
🔇 Additional comments (1)
docs/GEOMETRY-ARRAYS.md (1)
20-25: Type mapping is consistent with DBAL naming vs. PostgreSQL internals.Good use of
_geometry/_geographyfor platform mappings andgeometry[]/geography[]as DBAL type names. Matches the project’s documentation pattern for arrays.Note: I used our retrieved learning about documenting array types with the DBAL names (e.g.,
text[]) rather than underscore-prefixed catalog names.
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (4)
docs/GEOMETRY-ARRAYS.md (4)
12-24: Guard Type::addType to avoid re-registration in bootstrap snippets.These examples will throw if executed twice in the same process (e.g., test suites, Symfony cache warmups). It’s good practice in docs to show hasType() guards.
use Doctrine\DBAL\Types\Type; -Type::addType('geometry', \MartinGeorgiev\Doctrine\DBAL\Types\Geometry::class); -Type::addType('geometry[]', \MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::class); -Type::addType('geography', \MartinGeorgiev\Doctrine\DBAL\Types\Geography::class); -Type::addType('geography[]', \MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::class); +if (!Type::hasType('geometry')) { + Type::addType('geometry', \MartinGeorgiev\Doctrine\DBAL\Types\Geometry::class); +} +if (!Type::hasType('geometry[]')) { + Type::addType('geometry[]', \MartinGeorgiev\Doctrine\DBAL\Types\GeometryArray::class); +} +if (!Type::hasType('geography')) { + Type::addType('geography', \MartinGeorgiev\Doctrine\DBAL\Types\Geography::class); +} +if (!Type::hasType('geography[]')) { + Type::addType('geography[]', \MartinGeorgiev\Doctrine\DBAL\Types\GeographyArray::class); +} $platform = $connection->getDatabasePlatform(); $platform->registerDoctrineTypeMapping('geometry', 'geometry'); $platform->registerDoctrineTypeMapping('_geometry', 'geometry[]'); $platform->registerDoctrineTypeMapping('geography', 'geography'); $platform->registerDoctrineTypeMapping('_geography', 'geography[]');
133-140: Align method name with earlier entity example.The snippet calls $entity->addGeometry([$geometry]); but the “Entity Definition” only shows setGeometries(...). This inconsistency can confuse readers.
Either change the call or add a matching adder in the example:
Option A:
- $entity->addGeometry([$geometry]); + $entity->setGeometries($geometry);Option B (show adder):
public function addGeometry(WktSpatialData $geometry): void { $this->geometries[] = $geometry; }
218-227: Clarify geography SRID statement.“Auto-SRID” can be misread. Geography values must use SRID 4326; when omitted in EWKT, PostGIS commonly treats input as 4326. Recommend explicit wording to avoid ambiguity.
-✅ **Auto-SRID**: Geography types automatically get SRID=4326 if none is provided +✅ **SRID requirement**: Geography values use SRID=4326. If omitted in EWKT, PostGIS treats input as SRID=4326; being explicit is recommended.
1-3: Title/overview consistency: use consistent casing for type names.You mix GEOMETRY[]/GEOGRAPHY[] (uppercase) and geometry[]/geography[] (lowercase). PostgreSQL docs commonly show lowercase in SQL examples. Consider normalizing to lowercase for consistency.
-The `GeometryArray` and `GeographyArray` types provide support for PostgreSQL's `GEOMETRY[]` and `GEOGRAPHY[]` array types +The `GeometryArray` and `GeographyArray` types provide support for PostgreSQL's `geometry[]` and `geography[]` array types
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
docs/GEOMETRY-ARRAYS.md(1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the point[] array type should be documented as "point[]" not "_point" in the AVAILABLE-TYPES.md table, to be consistent with all other array types like text[], jsonb[], inet[], etc.
Applied to files:
docs/GEOMETRY-ARRAYS.md
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
docs/GEOMETRY-ARRAYS.md
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what TYPE_NAME constants contain and getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
docs/GEOMETRY-ARRAYS.md
📚 Learning: 2025-05-03T00:18:09.078Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#366
File: tests/Unit/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ArrayPositionsTest.php:1-36
Timestamp: 2025-05-03T00:18:09.078Z
Learning: Always check the current official PostgreSQL documentation at https://www.postgresql.org/docs/ to verify function signatures and behaviors before suggesting improvements or additional tests. The `array_positions` function specifically has a fixed signature with exactly two parameters (array and search value), while `array_position` is variadic with 2-3 parameters.
Applied to files:
docs/GEOMETRY-ARRAYS.md
🪛 LanguageTool
docs/GEOMETRY-ARRAYS.md
[grammar] ~194-~194: There might be a mistake here.
Context: ... ## Test Coverage ### Integration Tests - ✅ Single-item arrays: Fully tested a...
(QB_NEW_EN)
[grammar] ~195-~195: There might be a mistake here.
Context: ... tested against real PostgreSQL database - ❌ Multi-item arrays: Tested to demon...
(QB_NEW_EN)
[grammar] ~196-~196: There might be a mistake here.
Context: ...e PostGIS limitation (expected failures) - ✅ All geometry types: POINT, LINESTR...
(QB_NEW_EN)
[grammar] ~197-~197: There might be a mistake here.
Context: ...T, LINESTRING, POLYGON, MULTIPOINT, etc. - ✅ Dimensional modifiers: Z, M, ZM co...
(QB_NEW_EN)
[grammar] ~198-~198: There might be a mistake here.
Context: ...sional modifiers**: Z, M, ZM coordinates - ✅ SRID support: EWKT format with coo...
(QB_NEW_EN)
[grammar] ~199-~199: There might be a mistake here.
Context: ...t**: EWKT format with coordinate systems - ✅ Geography specifics: Auto-SRID beh...
(QB_NEW_EN)
[grammar] ~204-~204: There might be a mistake here.
Context: ... the PostGIS limitation. ### Unit Tests - ✅ Multi-item arrays: Tested for pars...
(QB_NEW_EN)
[grammar] ~205-~205: There might be a mistake here.
Context: ...-item arrays**: Tested for parsing logic - ✅ Mixed scenarios: Different geometr...
(QB_NEW_EN)
[grammar] ~206-~206: There might be a mistake here.
Context: ...ferent geometry types, SRIDs, dimensions - ✅ Edge cases: Empty arrays, complex ...
(QB_NEW_EN)
[grammar] ~207-~207: There might be a mistake here.
Context: ...es**: Empty arrays, complex combinations - ✅ Round-trip conversion: Database ↔ ...
(QB_NEW_EN)
[grammar] ~212-~212: There might be a mistake here.
Context: ...# Supported Features ### Geometry Types - ✅ POINT, LINESTRING, POLYGON - ✅ MULTIPO...
(QB_NEW_EN)
[grammar] ~213-~213: There might be a mistake here.
Context: ...try Types - ✅ POINT, LINESTRING, POLYGON - ✅ MULTIPOINT, MULTILINESTRING, MULTIPOLY...
(QB_NEW_EN)
[grammar] ~214-~214: There might be a mistake here.
Context: ...ULTIPOINT, MULTILINESTRING, MULTIPOLYGON - ✅ GEOMETRYCOLLECTION - ✅ All other PostG...
(QB_NEW_EN)
[grammar] ~215-~215: There might be a mistake here.
Context: ...ING, MULTIPOLYGON - ✅ GEOMETRYCOLLECTION - ✅ All other PostGIS geometry types as of...
(QB_NEW_EN)
[grammar] ~218-~218: There might be a mistake here.
Context: ...types as of v3.5 ### Coordinate Systems - ✅ SRID support: `SRID=4326;POINT(-12...
(QB_NEW_EN)
[grammar] ~219-~219: There might be a mistake here.
Context: ...oordinate Systems - ✅ SRID support: SRID=4326;POINT(-122 37) - ✅ Dimensional modifiers: Z (elevatio...
(QB_NEW_EN)
[grammar] ~220-~220: There might be a mistake here.
Context: ...ifiers**: Z (elevation), M (measure), ZM - ✅ Mixed coordinates: Arrays with dif...
(QB_NEW_EN)
[grammar] ~223-~223: There might be a mistake here.
Context: ...SRIDs/dimensions ### Geography Features - ✅ Auto-SRID: Geography types automat...
(QB_NEW_EN)
[grammar] ~225-~225: There might be a mistake here.
Context: ...dinates**: Null Island, poles, date line - ✅ Geographic calculations: Proper sp...
(QB_NEW_EN)
[grammar] ~240-~240: There might be a mistake here.
Context: .... For proper spatial indexing, consider: - Normalizing arrays into separate geometr...
(QB_NEW_EN)
[grammar] ~241-~241: There might be a mistake here.
Context: ...ometry rows with individual GiST indexes - Materializing a single geometry (e.g., u...
(QB_NEW_EN)
[grammar] ~242-~242: There might be a mistake here.
Context: ...to a geometry column for GiST indexing - See the [PostGIS FAQ on spatial indexes]...
(QB_NEW_EN)
[grammar] ~248-~248: There might be a mistake here.
Context: ...be addressed in future versions through: - PostGIS improvements to array literal ...
(QB_NEW_EN)
[grammar] ~249-~249: There might be a mistake here.
Context: ... improvements** to array literal parsing - Doctrine DBAL enhancements to custom S...
(QB_NEW_EN)
[grammar] ~250-~250: There might be a mistake here.
Context: ... enhancements** to custom SQL generation - Alternative storage strategies built i...
(QB_NEW_EN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
- GitHub Check: sloth
- GitHub Check: PostgreSQL 17 + PostGIS 3.4 + PHP 8.4
- GitHub Check: PostgreSQL 16 + PostGIS 3.5 + PHP 8.4
- GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.3
- GitHub Check: PostgreSQL 16 + PostGIS 3.5 + PHP 8.3
- GitHub Check: PostgreSQL 16 + PostGIS 3.4 + PHP 8.3
- GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.4
- GitHub Check: PostgreSQL 16 + PostGIS 3.4 + PHP 8.4
- GitHub Check: PostgreSQL 17 + PostGIS 3.5 + PHP 8.2
- GitHub Check: PostgreSQL 17 + PostGIS 3.4 + PHP 8.2
- GitHub Check: PostgreSQL 17 + PostGIS 3.4 + PHP 8.1
- GitHub Check: PostgreSQL 16 + PostGIS 3.4 + PHP 8.1
- GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer latest
- GitHub Check: PHP 8.4 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
- GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
- GitHub Check: PHP 8.3 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
- GitHub Check: PHP 8.4 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
- GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer 2.1
- GitHub Check: PHP 8.1 + Doctrine ORM 3.0 + Doctrine Lexer latest
🔇 Additional comments (7)
docs/GEOMETRY-ARRAYS.md (7)
63-74: Parameter binding examples look good and safe.Use of typed parameter (‘geometry[]’/‘geography’) and single-item arrays aligns with the documented limitation. Nice emphasis on supported paths.
104-110: Clear, accurate error illustration.The explanation of PostGIS parsing the array literal as a single geometry and showing the HINT position is concise and correct.
126-128: Correct use of placeholders inside ARRAY constructor.This avoids SQL injection and quoting pitfalls; the ::geometry casts ensure server-side parsing by PostGIS. Good.
240-245: Indexing guidance is now correct and pragmatic.Accurately states lack of GiST support for array types and proposes normalization/materialization patterns, with a link to PostGIS FAQ. Good correction.
7-8: docs/GEOMETRY-ARRAYS.md – Link to USE-CASES-AND-EXAMPLES.md VerifiedThe referenced file
docs/USE-CASES-AND-EXAMPLES.mdexists at the expected path, and the link is valid.
158-159: Link “Spatial Types document” to its Markdown fileThe reference can be made explicit by pointing to
docs/SPATIAL-TYPES.md, which already exists in the repo. Update lines 158–159 ofdocs/GEOMETRY-ARRAYS.mdas follows:- See also: Spatial foundations and parser behavior in the Spatial Types document. + See also: Spatial foundations and parser behavior in the [Spatial Types document](SPATIAL-TYPES.md).
213-217: Unable to locate pinned PostGIS/PostgreSQL versions – please verify and update docsI ran searches across
.github/workflows/*.yml, Dockerfiles, anddocker-compose.ymlfor anyPOSTGIS_VERSIONorPOSTGRES_VERSIONdefinitions but didn’t find any matches. To avoid over-claiming “all other geometry types as of v3.5,” please:
- Manually confirm which PostgreSQL and PostGIS versions are exercised by your CI/integration test matrix (e.g. in GitHub Actions, Docker Compose, etc.).
- Update the bullet in
docs/GEOMETRY-ARRAYS.mdto read something like:
- “✅ All other PostGIS geometry types (supported and tested with PostgreSQL X.Y / PostGIS A.B)”
Once you’ve identified and pinned those versions, this will ensure the documentation accurately reflects the tested compatibility scope.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
docs/GEOMETRY-ARRAYS.md (1)
139-143: Orphaned “Option 3” header — relocate the code block under the correct section.The “Option 3: Application-Level Array Building” header is immediately followed by “Normalization Rules,” while the Option 3 code block sits further down. Move the code block to follow the header so the narrative flow matches the outline.
-### Option 3: Application-Level Array Building - -## Normalization Rules (Dimensional Modifiers) +### Option 3: Application-Level Array Building +Build arrays in the application layer and bind them as placeholders inside an ARRAY constructor. + +```php +// Build arrays in application code, then use raw SQL with placeholders +$geometries = ['POINT(1 2)', 'POINT(3 4)', 'LINESTRING(0 0,1 1)']; +$placeholders = implode(',', array_fill(0, count($geometries), '?::geometry')); +$sql = "INSERT INTO locations (geometries) VALUES (ARRAY[$placeholders])"; +$connection->executeStatement($sql, $geometries); +``` + +## Normalization Rules (Dimensional Modifiers) @@ -```php -// Build arrays in application code, then use raw SQL with placeholders -$geometries = ['POINT(1 2)', 'POINT(3 4)', 'LINESTRING(0 0,1 1)']; -$placeholders = implode(',', array_fill(0, count($geometries), '?::geometry')); -$sql = "INSERT INTO locations (geometries) VALUES (ARRAY[$placeholders])"; -$connection->executeStatement($sql, $geometries); -``` +Also applies to: 157-163
🧹 Nitpick comments (5)
docs/GEOMETRY-ARRAYS.md (5)
7-8: Clarify the root cause: it’s PostGIS parsing interacting with DBAL binding, not DBAL alone.The intro frames the limitation as “due to Doctrine DBAL’s parameter binding behavior.” Later you correctly explain it’s a PostGIS parsing limitation. Tighten wording here to avoid contradiction.
-The use of these types currently has several limitations due to Doctrine DBAL's parameter binding behavior. Workarounds are provided for multi-item arrays in [USE-CASES-AND-EXAMPLES.md](./USE-CASES-AND-EXAMPLES.md). +The use of these types currently has several limitations because of how PostGIS parses inputs when values are serialized via Doctrine DBAL parameter binding. Workarounds are provided for multi-item arrays in [USE-CASES-AND-EXAMPLES.md](./USE-CASES-AND-EXAMPLES.md).
66-71: Fix column name inconsistency in the geography DBAL example.You insert into table “places” but the column is named “locations.” This looks like a copy/paste mismatch and may confuse readers.
-$qb->insert('places')->values(['locations' => ':wktSpatialData']); +$qb->insert('places')->values(['location' => ':wktSpatialData']);
120-125: Add geography variant alongside geometry in Option 1 for completeness.Since the doc covers both
geometry[]andgeography[], include the analogous::geographyexample to avoid ambiguity.$sql = "INSERT INTO locations (geometries) VALUES (ARRAY[?::geometry, ?::geometry])"; $connection->executeStatement($sql, ['POINT(1 2)', 'POINT(3 4)']); + +// Geography variant +$sql = "INSERT INTO places (geographies) VALUES (ARRAY[?::geography, ?::geography])"; +$connection->executeStatement($sql, [ + 'SRID=4326;POINT(-122.4194 37.7749)', + 'SRID=4326;LINESTRING(-122 37,-121 38)' +]);
73-117: Tighten “This is NOT a Bug” section and cross-reference intro phrasing.The section is solid; to keep the narrative consistent with the intro, consider explicitly connecting the dots: PostGIS attempts to interpret the array literal as a single EWKT token, which fails. A one-liner addition could help.
-However, **PostGIS intercepts this and tries to parse the entire string as a single geometry**, causing this error: +However, **PostGIS intercepts this and tries to parse the entire array literal as a single geometry token**, causing this error:
11-24: Minor improvement: mention mapping underscores for internal types vs DBAL names.You correctly register
_geometryand_geographyto their DBAL array counterparts. Add a short comment so readers understand underscore-prefixed names are PostgreSQL catalog types, whilegeometry[]/geography[]are the DBAL type names.$platform = $connection->getDatabasePlatform(); $platform->registerDoctrineTypeMapping('geometry', 'geometry'); $platform->registerDoctrineTypeMapping('_geometry', 'geometry[]'); $platform->registerDoctrineTypeMapping('geography', 'geography'); $platform->registerDoctrineTypeMapping('_geography', 'geography[]'); +// Note: underscore-prefixed names are PostgreSQL catalog array types; the right-hand side are DBAL type names.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
docs/GEOMETRY-ARRAYS.md(1 hunks)
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#0
File: :0-0
Timestamp: 2025-08-24T16:52:32.445Z
Learning: This repository uses BaseType extension pattern for custom Doctrine DBAL types with PostgreSQL platform assertions, comprehensive unit and integration testing with data providers, and dedicated exception classes for type conversion errors.
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the point[] array type should be documented as "point[]" not "_point" in the AVAILABLE-TYPES.md table, to be consistent with all other array types like text[], jsonb[], inet[], etc.
Applied to files:
docs/GEOMETRY-ARRAYS.md
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
docs/GEOMETRY-ARRAYS.md
📚 Learning: 2025-08-19T13:07:15.170Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#421
File: docs/AVAILABLE-TYPES.md:31-33
Timestamp: 2025-08-19T13:07:15.170Z
Learning: In martin-georgiev/postgresql-for-doctrine, the AVAILABLE-TYPES.md documentation table's second column shows DBAL type names (what TYPE_NAME constants contain and getName() method returns) not PostgreSQL internal catalogue names. Array types use the format like 'text[]', 'jsonb[]', 'inet[]' - not the underscore-prefixed PostgreSQL internal names like '_text', '_jsonb', '_inet'.
Applied to files:
docs/GEOMETRY-ARRAYS.md
📚 Learning: 2025-05-03T00:18:09.078Z
Learnt from: martin-georgiev
PR: martin-georgiev/postgresql-for-doctrine#366
File: tests/Unit/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/ArrayPositionsTest.php:1-36
Timestamp: 2025-05-03T00:18:09.078Z
Learning: Always check the current official PostgreSQL documentation at https://www.postgresql.org/docs/ to verify function signatures and behaviors before suggesting improvements or additional tests. The `array_positions` function specifically has a fixed signature with exactly two parameters (array and search value), while `array_position` is variadic with 2-3 parameters.
Applied to files:
docs/GEOMETRY-ARRAYS.md
🪛 LanguageTool
docs/GEOMETRY-ARRAYS.md
[grammar] ~191-~191: There might be a mistake here.
Context: ... ## Test Coverage ### Integration Tests - ✅ Single-item arrays: Fully tested a...
(QB_NEW_EN)
[grammar] ~192-~192: There might be a mistake here.
Context: ... tested against real PostgreSQL database - ❌ Multi-item arrays: Tested to demon...
(QB_NEW_EN)
[grammar] ~193-~193: There might be a mistake here.
Context: ...e PostGIS limitation (expected failures) - ✅ All geometry types: POINT, LINESTR...
(QB_NEW_EN)
[grammar] ~194-~194: There might be a mistake here.
Context: ...T, LINESTRING, POLYGON, MULTIPOINT, etc. - ✅ Dimensional modifiers: Z, M, ZM co...
(QB_NEW_EN)
[grammar] ~195-~195: There might be a mistake here.
Context: ...sional modifiers**: Z, M, ZM coordinates - ✅ SRID support: EWKT format with coo...
(QB_NEW_EN)
[grammar] ~196-~196: There might be a mistake here.
Context: ...t**: EWKT format with coordinate systems - ✅ Geography specifics: Auto-SRID beh...
(QB_NEW_EN)
[grammar] ~201-~201: There might be a mistake here.
Context: ... the PostGIS limitation. ### Unit Tests - ✅ Multi-item arrays: Tested for pars...
(QB_NEW_EN)
[grammar] ~202-~202: There might be a mistake here.
Context: ...-item arrays**: Tested for parsing logic - ✅ Mixed scenarios: Different geometr...
(QB_NEW_EN)
[grammar] ~203-~203: There might be a mistake here.
Context: ...ferent geometry types, SRIDs, dimensions - ✅ Edge cases: Empty arrays, complex ...
(QB_NEW_EN)
[grammar] ~204-~204: There might be a mistake here.
Context: ...es**: Empty arrays, complex combinations - ✅ Round-trip conversion: Database ↔ ...
(QB_NEW_EN)
[grammar] ~209-~209: There might be a mistake here.
Context: ...# Supported Features ### Geometry Types - ✅ POINT, LINESTRING, POLYGON - ✅ MULTIPO...
(QB_NEW_EN)
[grammar] ~210-~210: There might be a mistake here.
Context: ...try Types - ✅ POINT, LINESTRING, POLYGON - ✅ MULTIPOINT, MULTILINESTRING, MULTIPOLY...
(QB_NEW_EN)
[grammar] ~211-~211: There might be a mistake here.
Context: ...ULTIPOINT, MULTILINESTRING, MULTIPOLYGON - ✅ GEOMETRYCOLLECTION - ✅ All other PostG...
(QB_NEW_EN)
[grammar] ~212-~212: There might be a mistake here.
Context: ...ING, MULTIPOLYGON - ✅ GEOMETRYCOLLECTION - ✅ All other PostGIS geometry types as of...
(QB_NEW_EN)
[grammar] ~215-~215: There might be a mistake here.
Context: ...types as of v3.5 ### Coordinate Systems - ✅ SRID support: `SRID=4326;POINT(-12...
(QB_NEW_EN)
[grammar] ~216-~216: There might be a mistake here.
Context: ...oordinate Systems - ✅ SRID support: SRID=4326;POINT(-122 37) - ✅ Dimensional modifiers: Z (elevatio...
(QB_NEW_EN)
[grammar] ~217-~217: There might be a mistake here.
Context: ...ifiers**: Z (elevation), M (measure), ZM - ✅ Mixed coordinates: Arrays with dif...
(QB_NEW_EN)
[grammar] ~220-~220: There might be a mistake here.
Context: ...SRIDs/dimensions ### Geography Features - ✅ Auto-SRID: Geography types automat...
(QB_NEW_EN)
[grammar] ~222-~222: There might be a mistake here.
Context: ...dinates**: Null Island, poles, date line - ✅ Geographic calculations: Proper sp...
(QB_NEW_EN)
[grammar] ~245-~245: There might be a mistake here.
Context: ...be addressed in future versions through: - PostGIS improvements to array literal ...
(QB_NEW_EN)
[grammar] ~246-~246: There might be a mistake here.
Context: ... improvements** to array literal parsing - Doctrine DBAL enhancements to custom S...
(QB_NEW_EN)
[grammar] ~247-~247: There might be a mistake here.
Context: ... enhancements** to custom SQL generation - Alternative storage strategies built i...
(QB_NEW_EN)
🔇 Additional comments (2)
docs/GEOMETRY-ARRAYS.md (2)
235-242: Indexing guidance looks correct and actionable.The clarification that GiST/operator classes don’t index
geometry[]directly, plus the recommended alternatives, is accurate and aligns with PostGIS practices.
7-7: Docs link verifiedThe file
docs/USE-CASES-AND-EXAMPLES.mdis present in thedocsdirectory, so the reference will not break.
martin-georgiev
changed the title
GEOGRAPHY and GEOMETRYGEOGRAPHY, GEOMETRY and their array variations
Summary by CodeRabbit