Change case of the getSQLDeclaration function

[seb-jean]

Hi Martin,
As explained in #367, I changed the case of the getSQLDeclaration function.

Summary by CodeRabbit

• Refactor
  • SQL declaration strings are now consistently returned in uppercase for improved readability and standardization.

[coderabbitai]

Walkthrough

The getSQLDeclaration method in the BaseType class was updated to ensure that the SQL declaration string it returns is always in uppercase. This was accomplished by converting the output of $platform->getDoctrineTypeMapping(static::TYPE_NAME) to uppercase before returning it. No other logic or method signatures were changed.

Changes

File(s)	Change Summary
src/MartinGeorgiev/Doctrine/DBAL/Types/BaseType.php	Modified getSQLDeclaration to return the SQL declaration string in uppercase.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant BaseType
    participant Platform

    Client->>BaseType: getSQLDeclaration(fieldDeclaration, platform)
    BaseType->>Platform: getDoctrineTypeMapping(TYPE_NAME)
    Platform-->>BaseType: typeMappingString
    BaseType-->>Client: UPPERCASE(typeMappingString)

Loading

Possibly related issues

• Change case of the getSQLDeclaration function #367: This change directly addresses the request to return the SQL declaration string in uppercase from the getSQLDeclaration method.

Poem

A hop and a skip through the code I go,
Changing SQL types to uppercase, just so!
No more lowercase sneaking through the gate,
Now all declarations look first-rate.
With a twitch of my nose and a whisker’s delight,
Uppercase SQL keeps everything right!
🐇✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bb6a6b6 and c274f39.

📒 Files selected for processing (1)

• src/MartinGeorgiev/Doctrine/DBAL/Types/BaseType.php (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (20)

• GitHub Check: PostgreSQL 17 + PHP 8.3
• GitHub Check: PostgreSQL 16 + PHP 8.2
• GitHub Check: PHP 8.3 + Doctrine ORM 2.14 + Doctrine Lexer latest
• GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
• GitHub Check: PHP 8.3 + Doctrine ORM 2.18 + Doctrine Lexer latest
• GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer latest
• GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer latest
• GitHub Check: PHP 8.4 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
• GitHub Check: PHP 8.2 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
• GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer 3.0
• GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer 2.1
• GitHub Check: PHP 8.4 + Doctrine ORM 2.14 + Doctrine Lexer latest
• GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer latest
• GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer latest
• GitHub Check: PHP 8.2 + Doctrine ORM 3.0 + Doctrine Lexer latest
• GitHub Check: PHP 8.2 + Doctrine ORM latest + Doctrine Lexer latest
• GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer latest
• GitHub Check: PHP 8.2 + Doctrine ORM 2.18 + Doctrine Lexer 3.0
• GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer 2.1
• GitHub Check: sloth

🔇 Additional comments (1)

src/MartinGeorgiev/Doctrine/DBAL/Types/BaseType.php (1)

28-28: Good change to standardize SQL type declarations to uppercase.

This change ensures consistent formatting of SQL type declarations by converting the Doctrine type mapping to uppercase. This aligns with SQL convention where keywords are typically uppercase for better readability, and it addresses the issue mentioned in the PR objective.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coveralls]

coverage: 93.847%. remained the same
when pulling c274f39 on seb-jean:feat/case-sql-type
into bb6a6b6 on martin-georgiev:main.