MLE-22549: Group configuration not applied correctly if group name contains word "group" #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barkhachoithani
requested review from
vitalykorolev,
rwinieski,
pengzhouml,
sumanthravipati and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue where group configuration is not applied correctly if a group name contains the string "group." The change refines the grep pattern used to extract the group name from the XML output.
- Updated grep filtering from "group" to "" to improve matching accuracy.
Comments suppressed due to low confidence (1)
pkg/k8sutil/scripts/poststart-hook.sh:414
- The updated grep pattern improves matching precision for group extraction. Please ensure that all expected group data in /tmp/groups.out is consistently enclosed within tags to maintain correct configuration extraction.
grep "<group>" |
vitalykorolev
approved these changes
Jun 17, 2025
pengzhouml
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.