Fixes for Polaris race conditions #1766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrudin
force-pushed
the
feature/polaris-race-condition
branch
2 times, most recently
from
5ed867e to
5e80023
Compare
NodeConverter had a large amount of dead code - including a race condition! - that was deleted. Also removed a few "if content != null" checks that I don't believe are needed and could be problematic too in terms of a connection being closed.
rjrudin
force-pushed
the
feature/polaris-race-condition
branch
from
5e80023 to
676b27b
Compare
BillFarber
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeConverter had a large amount of dead code - including a race condition! - that was deleted.