Fix AUD default value #33
Conversation
| # GIVEN userinfo from fake token | ||
| KeycloakConnect.userinfo = Mock(return_value=self.fake_userinfo) | ||
|
|
||
| # GIVEN a View endpoint has existis 'diretor' role on GET method |
| @@ -155,7 +155,7 @@ | |||
| 'KEYCLOAK_SERVER_URL': 'http://localhost:8080/auth', | |||
| 'KEYCLOAK_REALM': 'TEST', | |||
| 'KEYCLOAK_CLIENT_ID': 'client-backend', | |||
| 'KEYCLOAK_CLIENT_SECRET_KEY': 'E2n41fJgl9BPIS3nDk1DQQ7BIPf6PauH', | |||
| 'KEYCLOAK_CLIENT_SECRET_KEY': '', | |||
| 'KEYCLOAK_CACHE_TTL': 60, | |||
| 'LOCAL_DECODE': False, | |||
There was a problem hiding this comment.
I believe the default case should be True, because you dont need to bug the auth server with every request and it will add a delay in the request lifecycle
There was a problem hiding this comment.
Thanks! I agree, but wanted to make sure the author gets to make the decision.
|
Dont you think there should be a test for the |
There was a problem hiding this comment.
def userinfo(self, token, audience=None, options=None, raise_exception=True):There was a problem hiding this comment.
I tried aud=None but it didnt work for me.
I am not sure if that is the case for everybody
There was a problem hiding this comment.
I didn't get it.
What does it mean?
Do you suggest replacing these params?
There was a problem hiding this comment.
Yes, the github formatting did not work well here. I was giving an example of updating the method signatures to include the arguments to the decode function. That way any audience and options may be passed to jwt.decode.
These three methods use the decode method:
- is_token_active
- roles_from_token
- userinfo
@hassaanalansary I'm gonna create it |
Fix the #32 issue