Refactor value.go terminology to align with duckdb mappings #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlafeldt
approved these changes
Sep 24, 2025
mlafeldt
approved these changes
Sep 26, 2025
|
I'll open a follow-up PR to add the missing types for #545 - I think these are mainly structs (in the form of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the
QueryAppenderin #545, I noticed some inconsistencies invalue.go. This PR refactors the file to be more consistent with duckdb terminology. It also prepares for changes like inferring the appender's temporary table types from the arguments passed toAppendRow.