Fix crash in arrowStreamReader.Next() #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds nil check in arrowStreamReader.Next() to prevent crashes when r.res becomes nil due to race condition between Release() and Next(). The crash happened under high concurrency when: 1. Goroutine A calls Next() to read arrow data 2. Goroutine B calls Release() setting r.res = nil 3. Goroutine A continues with nil pointer to C++ layer 4. C++ code crashes on NULL shared_ptr dereference Fixes #526
This was referenced Sep 10, 2025
mlafeldt
added a commit
that referenced
this pull request
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds nil check in
arrowStreamReader.Next()to prevent crashes whenr.resbecomes nil due to race condition betweenRelease()andNext().The crash happened under high concurrency when:
Fixes #526