Skip to content

Conversation

wmTJc9IK0Q
Copy link
Contributor

The EXTRA_INFO "metric" is not returned by default from duckdb. This adds it explicitly to each info node.

This includes info such as which table the operator was on, which columns were projections, etc.

@taniabogatsch
Copy link
Collaborator

Hi @wmTJc9IK0Q - I've looked into this and I think it would be cleaner to fix this on the C++ side - in the profiler, we should move extra_info into metrics. There's actually a FIXME in the C++ code already for this.

Would you be open to PR this to duckdb/duckdb and ping me on the PR? Otherwise, I can see if I can find the time (not sure when).

class ProfilingInfo {
public:
	//! Enabling a metric adds it to this set.
	profiler_settings_t settings;
	//! This set contains the expanded to-be-collected metrics, which can differ from 'settings'.
	profiler_settings_t expanded_settings;
	//! Contains all enabled metrics.
	profiler_metrics_t metrics;
	//! Additional metrics.
	// FIXME: move to metrics.
	InsertionOrderPreservingMap<string> extra_info;

@taniabogatsch taniabogatsch added fix Fixes a bug changes requested Changes have been requested to a PR or issue duckdb Internal error, etc., stack trace hints at a bug in duckdb, not go-duckdb labels Aug 12, 2025
@wmTJc9IK0Q
Copy link
Contributor Author

Closing in favor of duckdb/duckdb#19124

@wmTJc9IK0Q wmTJc9IK0Q closed this Sep 29, 2025
hannes added a commit to duckdb/duckdb that referenced this pull request Sep 30, 2025
This PR refactors the `ProfilingInfo` structure by moving `extra_info`
from a separate variable into the existing metrics map.

Added a CAPI test to verify correct storage and retrieval of
`extra_info`.

Relevent PR: marcboeker/go-duckdb#508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes requested Changes have been requested to a PR or issue duckdb Internal error, etc., stack trace hints at a bug in duckdb, not go-duckdb fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants