fix: correctly insert pointer values #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @kfiles-snyk, thanks for the fix - I've left two comments. Could you also resolve the merge conflict?
kfiles-snyk
force-pushed
the
fix/pointer-types
branch
from
95315ea to
066d3e5
Compare
|
@taniabogatsch, thanks for the speedy review. I've rebased and addressed the comments. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the handling of values of pointer type. These should be passed on to the DefaultParamterConverter, as go-duckdb doesn't natively handle most such types. This includes pointers to types which implement driver.Valuer and fmt.Stringer.
Also adds a Valuer interface implementation to UUID type to enable UUID pointers to be converted.
Issue: #480