Skip to content

fix MultiGeometry setProperties #2566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/maptalks/src/geometry/Geometry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -378,9 +378,19 @@ export class Geometry extends JSONAble(Eventable(Handlerable(Class))) {
setProperties(properties: { [key: string]: any }): this {
const old = this.properties;
this.properties = isObject(properties) ? extend({}, properties) : properties;
const children = this.getGeometries ? this.getGeometries() : [];
children.forEach(child => {
const subPro = child.getProperties ? child.getProperties() || {} : {};
const mergePro = extend(subPro, properties || {});
if (child.setProperties) {
child.setProperties(mergePro);
}
});

//such as altitude update
this._clearAltitudeCache();
this._repaint();

/**
* propertieschange event, thrown when geometry's properties is changed.
*
Expand Down
65 changes: 65 additions & 0 deletions packages/maptalks/test/geometry/GeometryCollectionSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,71 @@ describe('#GeometryCollection', function () {
})
layer.addGeometry(polygons)
});

it('#2565 multi geometry setproperties', function () {
let properties = {
name: 1
}
const geojson = {
type: 'Feature',
properties: properties,
geometry: {
type: 'MultiPoint',
coordinates: [
[0, 0],
[1, 1]
]
}
}
const multipoint = maptalks.GeoJSON.toGeometry(geojson);
expect(multipoint).to.be.ok();
expect(multipoint.getProperties()).to.be.eql(properties);
properties = {
name: 2,
age: 18
}
multipoint.setProperties(properties);
expect(multipoint.getProperties()).to.be.eql(properties);
multipoint.forEach(point => {
expect(point.getProperties()).to.be.eql(properties);
});

const point = new maptalks.Marker([0, 0], {
properties: {
name: 1
}
});
const line = new maptalks.LineString([[1, 1], [2, 2]], {
properties: {
name: 2
}
});

const geoCollection = new maptalks.GeometryCollection([point, line]);
expect(geoCollection).to.be.ok();
geoCollection.forEach((geo, index) => {
if (index === 0) {
expect(geo.getProperties()).to.be.eql({ name: 1 });
} else {
expect(geo.getProperties()).to.be.eql({ name: 2 });
}
});

properties = {
age: 18
}

geoCollection.setProperties(properties);
expect(geoCollection.getProperties()).to.be.eql(properties);
geoCollection.forEach((geo, index) => {
if (index === 0) {
expect(geo.getProperties()).to.be.eql({ name: 1, ...properties });
} else {
expect(geo.getProperties()).to.be.eql({ name: 2, ...properties });
}
});

});
});

function genPoints() {
Expand Down