Skip to content

Add mapping_set_confidence slot to SSSOM data model #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025

Conversation

matentzn
Copy link
Collaborator

Resolves #438

  • docs/ have been added/updated if necessary
  • make test has been run locally
  • tests have been added/updated (if applicable)
  • CHANGELOG.md has been updated.

If you are proposing a change to the SSSOM metadata model, you must

  • provide a full, working and valid example in examples/
  • provide a link to the related GitHub issue in the see_also field of the linkml model
  • provide a link to a valid example in the see_also field of the linkml model
  • run SSSOM-Py test suite against the updated model

This PR is adding "mapping_set_confidence" slot to the mapping set class.

@matentzn matentzn changed the title Add mapping_set_confidence slot Add mapping_set_confidence slot to SSSOM data model May 21, 2025
Copy link
Contributor

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but please mark the slot as being a new slot in SSSOM 1.1.

(This should be a general requirement from now on for all slot additions.)

cthoyt
cthoyt previously approved these changes May 21, 2025
@matentzn matentzn merged commit 83400bb into master May 22, 2025
4 checks passed
@matentzn matentzn deleted the issue438-mappingsetconfidence branch May 22, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New metadata element]: mapping_set_confidence
3 participants