Skip to content

fix 'filter with empty name' error #3828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix 'filter with empty name' error #3828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/searchdsql.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1806,8 +1806,18 @@ bool SqlParser_c::AddNullFilter ( const SqlNode_t & tCol, bool bEqualsNull )

void SqlParser_c::AddHaving ()
{
assert ( m_pQuery->m_dFilters.GetLength() );
m_pQuery->m_tHaving = m_pQuery->m_dFilters.Pop();
// Move the last parsed filter into HAVING
assert ( m_pQuery->m_dFilters.GetLength() );
m_pQuery->m_tHaving = m_pQuery->m_dFilters.Pop();

// FIX(#887): The filter tree (m_dFilterTree) still contains a leaf for the
// just-moved HAVING predicate. If we keep it, CreateFilterTree() for WHERE
// will attempt to build a node for a filter that was popped <E2><86><92> it will look
// like a filter with an empty name and throw "filter with empty name".
//
// Remove the trailing tree op that corresponds to the just-added HAVING item.
if ( m_dFilterTree.GetLength() > 0 )
m_dFilterTree.Pop();
}


Expand Down
Loading