Fix synchronization issues (fatal error: concurrent map writes) #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszMoskala
commented
Nov 29, 2024
| @@ -12,6 +15,7 @@ type keyedListener[T any] struct { | |||
| // It is intended to be used as an abstract base for underlying signal mechanisms. | |||
| // | |||
| // Example: | |||
| // | |||
There was a problem hiding this comment.
Sorry about these lines, go fmt keeps adding them back
|
I think Line 53 in 75ea4d4 |
|
Any movement on this? I'm running into the same issues |
|
I did some fixes of this in https://github.com/linux019/signals |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello and thank you for maintaining this library.
It's possible to trigger concurrent map writes or concurrent map read and write when calling
AddListenerandRemoveListenerfrom multiple goroutines. I used sync.Mutex on all functions that usesubscribersMap.I also use mutextes on Emit since removing element from
s.subscriberswhile for loop is running in another goroutine could cause problems.I have tested and this fixes my problem.
Have a great day!