Skip to content

chore: fix new clippy warnings causing build errors #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 29, 2025

Conversation

makspll
Copy link
Owner

@makspll makspll commented Jun 29, 2025

Summary

Fixes new clippy errors accumulated from newer rustup versions.

Also finally pin the toolchain so this doesn't happen until explicitly updated

Copy link
Contributor

🐰 Bencher Report

Branchfix/new-clippy-warnings
Testbedlinux-gha

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
component/access Lua📈 view plot
⚠️ NO THRESHOLD
3,406.30 ns
component/access Rhai📈 view plot
⚠️ NO THRESHOLD
5,506.20 ns
component/get Lua📈 view plot
⚠️ NO THRESHOLD
2,017.40 ns
component/get Rhai📈 view plot
⚠️ NO THRESHOLD
4,296.50 ns
conversions/Mut::from📈 view plot
⚠️ NO THRESHOLD
81.08 ns
conversions/Ref::from📈 view plot
⚠️ NO THRESHOLD
77.88 ns
conversions/ScriptValue::List📈 view plot
⚠️ NO THRESHOLD
260.29 ns
conversions/ScriptValue::Map📈 view plot
⚠️ NO THRESHOLD
1,243.50 ns
conversions/ScriptValue::Reference::from_into📈 view plot
⚠️ NO THRESHOLD
25.56 ns
conversions/Val::from_into📈 view plot
⚠️ NO THRESHOLD
265.36 ns
function/call 4 args Lua📈 view plot
⚠️ NO THRESHOLD
1,666.70 ns
function/call 4 args Rhai📈 view plot
⚠️ NO THRESHOLD
1,326.00 ns
function/call Lua📈 view plot
⚠️ NO THRESHOLD
224.43 ns
function/call Rhai📈 view plot
⚠️ NO THRESHOLD
449.84 ns
loading/empty Lua📈 view plot
⚠️ NO THRESHOLD
92,922.00 ns
loading/empty Rhai📈 view plot
⚠️ NO THRESHOLD
1,075,300.00 ns
math/vec mat ops Lua📈 view plot
⚠️ NO THRESHOLD
6,693.10 ns
math/vec mat ops Rhai📈 view plot
⚠️ NO THRESHOLD
6,046.90 ns
query/10 entities Lua📈 view plot
⚠️ NO THRESHOLD
18,778.00 ns
query/10 entities Rhai📈 view plot
⚠️ NO THRESHOLD
19,481.00 ns
query/100 entities Lua📈 view plot
⚠️ NO THRESHOLD
38,064.00 ns
query/100 entities Rhai📈 view plot
⚠️ NO THRESHOLD
31,575.00 ns
query/1000 entities Lua📈 view plot
⚠️ NO THRESHOLD
241,620.00 ns
query/1000 entities Rhai📈 view plot
⚠️ NO THRESHOLD
152,000.00 ns
reflection/10 Lua📈 view plot
⚠️ NO THRESHOLD
5,530.20 ns
reflection/10 Rhai📈 view plot
⚠️ NO THRESHOLD
15,145.00 ns
reflection/100 Lua📈 view plot
⚠️ NO THRESHOLD
45,937.00 ns
reflection/100 Rhai📈 view plot
⚠️ NO THRESHOLD
631,540.00 ns
resource/access Lua📈 view plot
⚠️ NO THRESHOLD
3,007.80 ns
resource/access Rhai📈 view plot
⚠️ NO THRESHOLD
4,880.50 ns
resource/get Lua📈 view plot
⚠️ NO THRESHOLD
1,666.00 ns
resource/get Rhai📈 view plot
⚠️ NO THRESHOLD
3,682.90 ns
🐰 View full continuous benchmarking report in Bencher

@makspll makspll enabled auto-merge (squash) June 29, 2025 18:32
@makspll makspll merged commit 9c5e216 into main Jun 29, 2025
20 checks passed
@makspll makspll deleted the fix/new-clippy-warnings branch June 29, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant