Skip to content

feat: Include Entity in ScriptCallbackResponseEvent #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CrushedPixel
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Jun 28, 2025

🐰 Bencher Report

Branchfeat/script-callback-response-entity-id
Testbedlinux-gha
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Upper Boundary
nanoseconds (ns)
(Limit %)
component/access Lua📈 view plot
🚷 view threshold
3,499.20 ns
(-26.52%)Baseline: 4,762.36 ns
6,271.92 ns
(55.79%)
component/access Rhai📈 view plot
🚷 view threshold
5,086.70 ns
(-23.61%)Baseline: 6,659.07 ns
8,007.59 ns
(63.52%)
component/get Lua📈 view plot
🚷 view threshold
2,098.50 ns
(-25.41%)Baseline: 2,813.23 ns
3,535.91 ns
(59.35%)
component/get Rhai📈 view plot
🚷 view threshold
3,893.40 ns
(-20.44%)Baseline: 4,893.83 ns
5,966.79 ns
(65.25%)
conversions/Mut::from📈 view plot
🚷 view threshold
79.20 ns
(-37.24%)Baseline: 126.20 ns
232.45 ns
(34.07%)
conversions/Ref::from📈 view plot
🚷 view threshold
76.91 ns
(-37.99%)Baseline: 124.02 ns
230.13 ns
(33.42%)
conversions/ScriptValue::List📈 view plot
🚷 view threshold
282.43 ns
(-48.84%)Baseline: 552.09 ns
1,089.82 ns
(25.92%)
conversions/ScriptValue::Map📈 view plot
🚷 view threshold
1,230.40 ns
(-22.51%)Baseline: 1,587.74 ns
2,168.50 ns
(56.74%)
conversions/ScriptValue::Reference::from_into📈 view plot
🚷 view threshold
25.58 ns
(-34.92%)Baseline: 39.30 ns
61.79 ns
(41.40%)
conversions/Val::from_into📈 view plot
🚷 view threshold
260.51 ns
(-22.05%)Baseline: 334.19 ns
443.75 ns
(58.71%)
function/call 4 args Lua📈 view plot
🚷 view threshold
1,640.70 ns
(-20.16%)Baseline: 2,054.91 ns
2,484.55 ns
(66.04%)
function/call 4 args Rhai📈 view plot
🚷 view threshold
1,302.70 ns
(-26.14%)Baseline: 1,763.82 ns
2,216.28 ns
(58.78%)
function/call Lua📈 view plot
🚷 view threshold
228.33 ns
(-17.10%)Baseline: 275.44 ns
330.96 ns
(68.99%)
function/call Rhai📈 view plot
🚷 view threshold
430.75 ns
(-17.07%)Baseline: 519.40 ns
662.28 ns
(65.04%)
loading/empty Lua📈 view plot
🚷 view threshold
91,998.00 ns
(-6.99%)Baseline: 98,911.00 ns
107,281.91 ns
(85.75%)
loading/empty Rhai📈 view plot
🚷 view threshold
1,256,800.00 ns
(-4.15%)Baseline: 1,311,262.50 ns
1,391,470.72 ns
(90.32%)
math/vec mat ops Lua📈 view plot
🚷 view threshold
6,537.30 ns
(-15.60%)Baseline: 7,745.99 ns
9,075.87 ns
(72.03%)
math/vec mat ops Rhai📈 view plot
🚷 view threshold
5,953.90 ns
(-19.07%)Baseline: 7,356.62 ns
8,504.32 ns
(70.01%)
query/10 entities Lua📈 view plot
🚷 view threshold
17,772.00 ns
(-26.26%)Baseline: 24,102.33 ns
30,306.37 ns
(58.64%)
query/10 entities Rhai📈 view plot
🚷 view threshold
17,912.00 ns
(-25.39%)Baseline: 24,007.83 ns
28,697.12 ns
(62.42%)
query/100 entities Lua📈 view plot
🚷 view threshold
38,781.00 ns
(-20.73%)Baseline: 48,925.26 ns
60,402.86 ns
(64.20%)
query/100 entities Rhai📈 view plot
🚷 view threshold
30,018.00 ns
(-22.02%)Baseline: 38,496.07 ns
47,263.82 ns
(63.51%)
query/1000 entities Lua📈 view plot
🚷 view threshold
247,700.00 ns
(-20.61%)Baseline: 312,012.14 ns
378,318.31 ns
(65.47%)
query/1000 entities Rhai📈 view plot
🚷 view threshold
154,830.00 ns
(-27.58%)Baseline: 213,790.00 ns
292,823.28 ns
(52.87%)
reflection/10 Lua📈 view plot
🚷 view threshold
5,439.00 ns
(-16.09%)Baseline: 6,482.20 ns
7,481.47 ns
(72.70%)
reflection/10 Rhai📈 view plot
🚷 view threshold
15,302.00 ns
(-6.24%)Baseline: 16,319.55 ns
17,883.26 ns
(85.57%)
reflection/100 Lua📈 view plot
🚷 view threshold
47,708.00 ns
(-10.62%)Baseline: 53,376.74 ns
59,731.31 ns
(79.87%)
reflection/100 Rhai📈 view plot
🚷 view threshold
722,390.00 ns
(-2.89%)Baseline: 743,868.57 ns
871,795.64 ns
(82.86%)
resource/access Lua📈 view plot
🚷 view threshold
3,073.70 ns
(-26.67%)Baseline: 4,191.36 ns
5,456.83 ns
(56.33%)
resource/access Rhai📈 view plot
🚷 view threshold
4,499.50 ns
(-24.18%)Baseline: 5,934.80 ns
7,378.42 ns
(60.98%)
resource/get Lua📈 view plot
🚷 view threshold
1,776.80 ns
(-24.19%)Baseline: 2,343.80 ns
2,974.36 ns
(59.74%)
resource/get Rhai📈 view plot
🚷 view threshold
3,202.20 ns
(-24.36%)Baseline: 4,233.24 ns
5,290.49 ns
(60.53%)
🐰 View full continuous benchmarking report in Bencher

@makspll makspll enabled auto-merge (squash) July 3, 2025 20:57
@makspll makspll merged commit f564116 into makspll:main Jul 3, 2025
20 checks passed
This was referenced Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants