Skip to content

fix: remove test time dependencies from functions #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions crates/bevy_mod_scripting_functions/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ readme = "readme.md"
[features]
core_functions = []
bevy_bindings = []
test_functions = ["test_utils", "regex"]


[dependencies]
Expand All @@ -34,5 +33,3 @@ bevy = { workspace = true, features = [
uuid = "1.11"
smol_str = "0.2.2"
bevy_mod_scripting_core = { workspace = true }
test_utils = { workspace = true, optional = true }
regex = { version = "1.11", optional = true }
6 changes: 0 additions & 6 deletions crates/bevy_mod_scripting_functions/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@ use ::bevy::prelude::*;
#[cfg(feature = "bevy_bindings")]
pub mod bevy_bindings;
pub mod core;

#[cfg(feature = "test_functions")]
pub mod test_functions;

pub use core::*;

pub struct ScriptFunctionsPlugin;
Expand All @@ -14,8 +10,6 @@ impl Plugin for ScriptFunctionsPlugin {
fn build(&self, app: &mut App) {
register_bevy_bindings(app);
register_core_functions(app);
#[cfg(feature = "test_functions")]
test_functions::register_test_functions(app);

// TODO: if bevy ever does this itself we should remove this
app.world_mut().register_component::<Parent>();
Expand Down
5 changes: 0 additions & 5 deletions crates/languages/bevy_mod_scripting_lua/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,6 @@ smallvec = "1.13"

[dev-dependencies]
script_integration_test_harness = { workspace = true }
bevy_mod_scripting_functions = { workspace = true, features = [
"core_functions",
"bevy_bindings",
"test_functions",
] }
libtest-mimic = "0.8"
regex = "1.11"

Expand Down
5 changes: 0 additions & 5 deletions crates/languages/bevy_mod_scripting_rhai/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ bevy_mod_scripting_functions = { workspace = true, features = [

[dev-dependencies]
script_integration_test_harness = { workspace = true }
bevy_mod_scripting_functions = { workspace = true, features = [
"core_functions",
"bevy_bindings",
"test_functions",
] }
libtest-mimic = "0.8"
regex = "1.11"

Expand Down
2 changes: 1 addition & 1 deletion crates/script_integration_test_harness/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ bevy_mod_scripting_core = { workspace = true }
bevy_mod_scripting_functions = { workspace = true, features = [
"bevy_bindings",
"core_functions",
"test_functions",
] }
regex = { version = "1.11" }
5 changes: 5 additions & 0 deletions crates/script_integration_test_harness/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
pub mod test_functions;

use bevy::{
app::App,
prelude::{Entity, World},
Expand All @@ -14,6 +16,7 @@ use bevy_mod_scripting_core::{
IntoScriptPluginParams,
};
use bevy_mod_scripting_functions::ScriptFunctionsPlugin;
use test_functions::register_test_functions;
use test_utils::test_data::setup_integration_test;

pub fn execute_integration_test<
Expand All @@ -29,6 +32,8 @@ pub fn execute_integration_test<
let mut app = setup_integration_test(init);

app.add_plugins(ScriptFunctionsPlugin);
register_test_functions(&mut app);

init_app(&mut app);

app.cleanup();
Expand Down
Loading