Skip to content

Feat/layout fix UI pages performance #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 70 commits into
base: feat/layout
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
b551775
feat: implement the SectionContentStore model
did Mar 5, 2025
8342926
WIP
did Mar 7, 2025
6ae811b
feat: load layouts of a theme
did Mar 7, 2025
dcf62d1
feat: an editor can select a layout for a page + pick a different HTM…
did Mar 8, 2025
03243f2
chore: fix the Rails 6 version
did Mar 8, 2025
ff96445
chore: fix the Rails 7 version
did Mar 8, 2025
ec18ce3
chore: fix the Rails 7.2 version
did Mar 8, 2025
4a0b43c
feat: pimp the GetPageSections service to return sections grouped by …
did Mar 8, 2025
d3d0305
chore: please Rubocop
did Mar 8, 2025
82ed711
feat: implement the PersistSectionsContent service (replacement of th…
did Mar 10, 2025
2535adc
chore: rubocop
did Mar 10, 2025
1d4ab51
feat: first working version of the EditorUI using the layouts (WIP)
did Mar 14, 2025
4de9fb7
chore: update the style through its own button (and not through the g…
did Mar 15, 2025
100ddff
chore: update translations for the style persisting feat
did Mar 15, 2025
0fe297b
feat: when picking a page/section target for a link, display the layo…
did Mar 16, 2025
1d4af8a
chore: remove the PersistPage service from the PagesController
did Mar 16, 2025
5424a47
chore: also clone the SectionsContentStores in the ClonePage service
did Mar 17, 2025
90b5512
feat: set a default layout in the new page form
did Mar 20, 2025
fde11de
feat: reload the preview if the layoutId has changed
did Mar 20, 2025
43543aa
feat: implement the mirrored section feature (WIP)
did Mar 22, 2025
4e22b85
feat: mirrored section can be detached/re-attached
did Mar 23, 2025
881f31b
feat: display an icon for mirrored type sections (+ placeholder)
did Mar 23, 2025
0cc22aa
feat: run validation when adding a mirrored section
did Mar 23, 2025
e24a18b
chore: add FR + ES translations for the mirrored section feature
did Mar 24, 2025
365fa2d
feat: persist and fetch mirrored sections
did Mar 27, 2025
1616c84
feat: mirror sections can also point to other mirror sections 🤯
did Mar 28, 2025
c90ba0e
chore: Rubocop is happy 😎
did Mar 28, 2025
c8b2b74
feat: update the SetupPages service to reflect the new layout system
did Mar 28, 2025
f566eb2
chore: remove the PersistPage service (deprecated)
did Mar 28, 2025
a97b05a
chore: fix models specs
did Mar 29, 2025
a61601a
chore: fix the AddSiteLocale service specs
did Mar 30, 2025
c4121bd
chore: fix the FetchThemeLayout service specs
did Mar 30, 2025
b81a2bd
chore: fix the GenerateSite service
did Apr 1, 2025
b15f758
chore: fix components specs
did Apr 3, 2025
92eefeb
chore: fix requests specs
did Apr 4, 2025
638df41
chore: fix all specs
did Apr 4, 2025
031ba2e
chore: fix specs for Rails 6 & 7.x versions
did Apr 5, 2025
e474d9d
feat: add the accept attribute to layout groups and also fix the JS t…
did Apr 6, 2025
56d8cd5
feat: implement the recoverable layout group attribute (replacement o…
did Apr 10, 2025
b921b59
fix: accordion icon won't change + display all the sections no matter…
did Apr 11, 2025
9e326bd
feat: refine the UI/UX of the list of sections
did Apr 11, 2025
94e3ea7
chore: no more "store: false", replaced by "store: page"
did Apr 11, 2025
6089d1a
feat: the mirror_section theme attribute can be overriden on the grou…
did Apr 11, 2025
2ccc064
chore: Rubocop 👌
did Apr 11, 2025
887c3bc
feat: add an optional relationship between a page and sections conten…
did Apr 13, 2025
830c0e0
chore: prepare the upgrade to v2 task (WIP)
did Apr 13, 2025
d9d9173
feat: handle the site scoped sections + service to migrate from v1 (WIP)
did Apr 16, 2025
61997f6
feat: add a site scoped section in the editor
did Apr 16, 2025
7e2f01f
feat: add constraint for singleton/site scoped sections when adding a…
did Apr 17, 2025
7ae773b
fixci: inconsistent SQL schema for legacy versions
did Apr 17, 2025
51f45d2
fixci: inconsistent SQL schema for legacy versions (attempt #2)
did Apr 17, 2025
0bf3a9a
fixci: fix an issue with Rails 7.0
did Apr 17, 2025
e94d638
feat: rake task to upgrade to v2 + pimp files from the Maglev generator
did Apr 17, 2025
242904e
feat: add a generator to add a layout to a theme
did Apr 18, 2025
4d8d188
fix: wrong conflict merging
did Apr 24, 2025
a799638
feat: pass the context to the FetchsectionsContent service (useful fo…
did Apr 25, 2025
6f7fa76
feat(ui): the tablet width is now 768px
did Apr 25, 2025
f92f512
fix(ci): generate the SQLITE schema.rb files
did Apr 25, 2025
c008f74
chore: the schema.rb files were not up-to-date
did Apr 25, 2025
f5f36b2
fix(ci): again fixing the Gemfile/schema.rb for all the different Rai…
did Apr 25, 2025
1062d91
chore: Rubocop 👌
did Apr 25, 2025
430d604
fix(ci): again fixing the Gemfile/schema.rb for all the different Rai…
did Apr 25, 2025
89fe45d
chore: don't raise an exception if there are no stores in DB
did Apr 25, 2025
69e66ee
fix: the canAddMirrorSection method wasn't taking the current number …
did Apr 26, 2025
e42c924
feat: add a protection mode for mirrored section
did Apr 26, 2025
3234fb6
fix: fix an issue with a client's site regarding his draft/publish fe…
did May 9, 2025
369eb8c
fix: remove JS errors when we detach a protected & mirrored section
did May 9, 2025
8bead68
fix bug that broke previewing collections (#146)
erdostom May 12, 2025
c68e86b
fix: issue with layout group having an underscore in their id + mirro…
did May 23, 2025
5d3d7d5
fix the performance
erdostom Jun 6, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ coverage/
podman.sh
template.dev.rb
tailwind-maglev-pro.config.js
plugins

# Vite Ruby
/public/vite*
Expand All @@ -38,4 +39,4 @@ node_modules
bin/test

spec/dummy/db/*.sqlite3
spec/legacy_dummy/db/*.sqlite3
spec/legacy_dummy/db/*.sqlite3
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.3.5
3.4.1
Binary file modified .yarn/install-state.gz
Binary file not shown.
40 changes: 24 additions & 16 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -106,16 +106,16 @@ GEM
factory_bot_rails (6.2.0)
factory_bot (~> 6.2.0)
railties (>= 5.0.0)
ffi (1.17.0-aarch64-linux-gnu)
ffi (1.17.0-aarch64-linux-musl)
ffi (1.17.0-arm-linux-gnu)
ffi (1.17.0-arm-linux-musl)
ffi (1.17.0-arm64-darwin)
ffi (1.17.0-x86-linux-gnu)
ffi (1.17.0-x86-linux-musl)
ffi (1.17.0-x86_64-darwin)
ffi (1.17.0-x86_64-linux-gnu)
ffi (1.17.0-x86_64-linux-musl)
ffi (1.17.1-aarch64-linux-gnu)
ffi (1.17.1-aarch64-linux-musl)
ffi (1.17.1-arm-linux-gnu)
ffi (1.17.1-arm-linux-musl)
ffi (1.17.1-arm64-darwin)
ffi (1.17.1-x86-linux-gnu)
ffi (1.17.1-x86-linux-musl)
ffi (1.17.1-x86_64-darwin)
ffi (1.17.1-x86_64-linux-gnu)
ffi (1.17.1-x86_64-linux-musl)
generator_spec (0.10.0)
activesupport (>= 3.0.0)
railties (>= 3.0.0)
Expand Down Expand Up @@ -160,6 +160,7 @@ GEM
marcel (1.0.4)
mini_magick (4.13.2)
mini_mime (1.1.5)
mini_portile2 (2.8.8)
minitest (5.25.2)
mutex_m (0.3.0)
net-imap (0.5.1)
Expand All @@ -172,17 +173,24 @@ GEM
net-smtp (0.5.0)
net-protocol
nio4r (2.7.4)
nokogiri (1.16.7-aarch64-linux)
nokogiri (1.18.6)
mini_portile2 (~> 2.8.2)
racc (~> 1.4)
nokogiri (1.16.7-arm-linux)
nokogiri (1.18.6-aarch64-linux-gnu)
racc (~> 1.4)
nokogiri (1.16.7-arm64-darwin)
nokogiri (1.18.6-aarch64-linux-musl)
racc (~> 1.4)
nokogiri (1.16.7-x86-linux)
nokogiri (1.18.6-arm-linux-gnu)
racc (~> 1.4)
nokogiri (1.16.7-x86_64-darwin)
nokogiri (1.18.6-arm-linux-musl)
racc (~> 1.4)
nokogiri (1.16.7-x86_64-linux)
nokogiri (1.18.6-arm64-darwin)
racc (~> 1.4)
nokogiri (1.18.6-x86_64-darwin)
racc (~> 1.4)
nokogiri (1.18.6-x86_64-linux-gnu)
racc (~> 1.4)
nokogiri (1.18.6-x86_64-linux-musl)
racc (~> 1.4)
observer (0.1.2)
ostruct (0.6.1)
Expand Down
6 changes: 5 additions & 1 deletion Gemfile.rails_7_0
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }
# development dependencies will be added by default to the :development group.
gemspec

gem 'rails', '7.0.8'
gem 'rails', '~> 7.0', '< 7.1'

# Active Storage analyser
gem 'mini_magick', '~> 4.11'
Expand Down Expand Up @@ -45,6 +45,8 @@ gem 'bigdecimal'
gem 'mutex_m'
gem 'drb'
gem 'fiddle'
gem 'benchmark'
gem 'concurrent-ruby', '1.3.4'

group :development, :test do
# Use SCSS for stylesheets
Expand All @@ -59,6 +61,8 @@ group :development, :test do

gem 'generator_spec'

gem 'annotate'

gem 'nokogiri', '>= 1.13.10'
end

Expand Down
Loading