Skip to content

fix: set temporarily the I18n.locale when rendering a Maglev page #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

fix: set temporarily the I18n.locale when rendering a Maglev page #155

merged 1 commit into from
May 22, 2025

Conversation

did
Copy link
Contributor

@did did commented May 22, 2025 •
edited
Loading

  • the Maglev preview controller was erasing the ::I18n.locale for the whole application which could lead to weird behaviors.
  • the editor UI locale relies exclusively and directly on the editor_ui_locale controller helper.

@did did added the bug Something isn't working label May 22, 2025
@did did merged commit b18709a into master May 22, 2025
6 checks passed
@did did deleted the fix-wrong-editor-locale-issue branch May 22, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@did