Skip to content

feat(ui): UI/UX improvements for the Editor #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 27, 2025
Merged

Conversation

did
Copy link
Contributor

@did did commented May 21, 2025

No description provided.

@did did changed the title feat(ui): UI/UX improvements on the header nav feat(ui): UI/UX improvements for the Editor May 21, 2025
@mabras
Copy link
Contributor

mabras commented May 22, 2025

I have some feedback that I hope you will consider for this pull request. One thing we have with the editor is that the user doesn't have a clear way to copy or get the full path of a page. So, can we add a button or show the full path of the current editing page for the user?

Thanks!

@did did force-pushed the feat-ui-ux-improvements branch from fb11281 to 0cd6954 Compare May 22, 2025 21:03
@did
Copy link
Contributor Author

did commented May 23, 2025

@mabras This is how it will look like:

Capture d’écran 2025-05-23 à 08 58 53

(The page settings button has been moved to the left mini-sidebar)

@mabras
Copy link
Contributor

mabras commented May 23, 2025

@mabras This is how it will look like:

Capture d’écran 2025-05-23 à 08 58 53 (The page settings button has been moved to the left mini-sidebar)

I appreciate your consideration. I'm sorry I wasn't clear about my feedback. I meant full URL (not the full path). Our users are not very technical, so they need to get the full URL to paste it on another page, for example.

@did
Copy link
Contributor Author

did commented May 23, 2025

@mabras be careful, your users should use the page picker to add a link in a text or to reference any page of the site. The reason is that based on the context (preview mode or not + the current locale), Maglev will build a different URL.

Regarding the copy/paste functionality, I'm trying to add a small button right after the page path.

@mabras
Copy link
Contributor

mabras commented May 23, 2025

Regarding the copy/paste functionality, I'm trying to add a small button right after the page path.

Perfect, thank you

@did
Copy link
Contributor Author

did commented May 26, 2025

👋 @mabras & @davidgeismar, what about this?

Capture d’écran 2025-05-26 à 19 27 08

@mabras
Copy link
Contributor

mabras commented May 27, 2025

👋 @mabras & @davidgeismar, what about this?

LGTM
Thanks

@DavidGeismarLtd
Copy link

@did does it copy the full url or only the path ? In my case the full url would be ideal

@did
Copy link
Contributor Author

did commented May 27, 2025

@did does it copy the full url or only the path ? In my case the full url would be ideal

It does copy the full url 👌

@did did merged commit 24e1a74 into master May 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants