Remove [ ] from around IPv6 addresses so whois works on them #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick hack to work around a problem I ran into when using whois for simple IP address lookups. You probably don't want to accept this, but this illustrates the problem.
With the demo config from the docs:
IPv4 lookups work fine, but IPv6 lookups get this error, for example on
2600:3c00::
:I found that the IPv6 address was being wrapped in
[
and]
which caused the problem, and this quick hack to strip them works.It would be nicer to omit the
[
and]
from the beginning since we don't want them, but I imagine that would break other users of thevalidators
crate.Perhaps there should be an option to have
validators
emit IPv6 with no[
and]
? I'd be willing to try to implement that if you think that makes sense.