Skip to content

magento/magento2#39146: Image resize queue error due to .tmp file handling when deleting unsaved product images #39872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: 2.4-develop
Choose a base branch
from
Open

magento/magento2#39146: Image resize queue error due to .tmp file handling when deleting unsaved product images #39872

wants to merge 12 commits into from

Conversation

KrasnoshchokBohdan
Copy link
Contributor

@KrasnoshchokBohdan KrasnoshchokBohdan commented Apr 29, 2025 •
edited
Loading

Description (*)

Implemented cleanup logic for image array by removing entries marked with 'removed' flag.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento239146

Manual testing scenarios (*)

  1. Access magento admin panel and set the indexer mode to Update by Schedule
  2. Go to Catalog->Product.
  3. Create a product or edit any existing product and upload a image and again remove the uploaded image without saving the product.
  4. Then save the product.
  5. Run media.storage.catalog.image.resize consumer

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@KrasnoshchokBohdan
magento#39146: Image resize queue error due to .tmp file handling whe…
13b36da 
…n deleting unsaved product images

- clean up removed images from the image array
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Apr 29, 2025

Hi @KrasnoshchokBohdan. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@KrasnoshchokBohdan
Copy link
Contributor Author

@magento run all tests

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 29, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Apr 29, 2025
@KrasnoshchokBohdan
Copy link
Contributor Author

@magento run all tests

@KrasnoshchokBohdan
Copy link
Contributor Author

@magento run all tests

@sidolov sidolov added partners-contribution Pull Request is created by Magento Partner Partner: Perspective labels May 28, 2025
engcom-Hotel
engcom-Hotel reviewed Jul 11, 2025
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @KrasnoshchokBohdan,

Thanks for the contribution!

Please resolve the conflicts in this PR, meanwhile we are moving this PR On Hold.

Thanks

@engcom-Hotel engcom-Hotel moved this from Pending Review to On Hold in Pull Requests Dashboard Jul 11, 2025
@KrasnoshchokBohdan
Copy link
Contributor Author

@magento run all tests

@engcom-Hotel
Copy link
Contributor

Hello @KrasnoshchokBohdan,

Thanks for resolving the conflicts, we are picking this PR for review.

@engcom-Hotel engcom-Hotel moved this from On Hold to Review in Progress in Pull Requests Dashboard Jul 14, 2025
engcom-Hotel
engcom-Hotel requested changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @KrasnoshchokBohdan,

Thanks for the contribution!

It seems some automated tests are failing due to the code changes. Please look into it.

Thanks

@engcom-Hotel engcom-Hotel moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Jul 14, 2025
@engcom-Charlie engcom-Charlie added the Project: Community Picked PRs upvoted by the community label Jul 14, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this to Changes Requested in Community Dashboard Jul 14, 2025
@KrasnoshchokBohdan
Copy link
Contributor Author

Hi @engcom-Hotel! Can you please clarify which tests?

@engcom-Hotel
Copy link
Contributor

@KrasnoshchokBohdan I am talking about functional tests, the WebAPI test seems flaky to me.

@engcom-Charlie engcom-Charlie self-assigned this Jul 16, 2025
@KrasnoshchokBohdan
magento#39146: Image resize queue error due to .tmp file handling whe…
ae5d9f1 
…n deleting unsaved product images

Update test to clear image cache before file existence assertions

Added steps to navigate to cache management and clear catalog image cache before verifying image file deletions. This ensures the assertions reflect the most up-to-date state of the media directory.
@KrasnoshchokBohdan
Copy link
Contributor Author

@magento run Functional Tests EE

@KrasnoshchokBohdan
Copy link
Contributor Author

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Unit Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel requested changes

Assignees

@engcom-Charlie engcom-Charlie

Labels
Partner: Perspective partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: needs update Progress: on hold Progress: pending review Project: Community Picked PRs upvoted by the community
Projects
Community Dashboard
Status: Changes Requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image resize queue error due to .tmp file handling when deleting unsaved product images
4 participants
@KrasnoshchokBohdan @engcom-Hotel @engcom-Charlie @sidolov