Skip to content

Document Exceptions in Asset Repository Functions #38975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/internal/Magento/Framework/View/Asset/Repository.php
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,7 @@ private function getDefaultParameter($name)
* @param array $params
* @return File
* @throws LocalizedException
* @throws \UnexpectedValueException
*/
public function createAsset($fileId, array $params = [])
{
Expand Down Expand Up @@ -254,6 +255,7 @@ public function createAsset($fileId, array $params = [])
* Get current context for static view files
*
* @return \Magento\Framework\View\Asset\File\FallbackContext
* @throws \UnexpectedValueException
*/
public function getStaticViewFileContext()
{
Expand Down Expand Up @@ -413,6 +415,8 @@ public function createRemoteAsset($url, $contentType)
*
* @param string $fileId
* @return string
* @throws LocalizedException
* @throws \UnexpectedValueException
*/
public function getUrl($fileId)
{
Expand All @@ -428,6 +432,8 @@ public function getUrl($fileId)
* @param string $fileId
* @param array $params
* @return string
* @throws LocalizedException
* @throws \UnexpectedValueException
* @see getUrl()
*/
public function getUrlWithParams($fileId, array $params)
Expand Down