Add orderStatus option hash cache #37950
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve orderStatusCollection retrieval in cases where this is being called multiple times in a transaction. In combination with the Banner module and getSalesRuleRelatedBanners we've seen behavior where this collection is being called more then 40 times in a single transaction causing a lot of mysql queries on the sales_order_status table when the number of visitors grows.
It seems to be mostly triggered by vendor/magento/module-customer-segment/Model/Customer.php and the logic in getVisitorsSegmentsForWebsite()
The following graphs illustrates the improvements for Banners after the patch was released:

Another option could be to even store this in Redis and make the order status collection cacheable through the cache fetch strategy (Magento\Framework\Data\Collection\Db\FetchStrategy\Cache) But I haven't looked if this would work as solution and bring similar improvements as proposed in this PR.
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)