Skip to content

Use constructor property promotion in module Sample Data #37224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

Use constructor property promotion in module Sample Data #37224

wants to merge 1 commit into from

Conversation

leonhelmus
Copy link

@leonhelmus leonhelmus commented Mar 16, 2023 •
edited
Loading

Description (*)

Replace allmost all properties with constructor property promotion in module sample data: https://stitcher.io/blog/constructor-promotion-in-php-8

  • Readable code
  • Make Magento less complex by removing properties which take up a lot of lines.
  • Imported all classes to make code more readable.

I think the code would be a lot cleaner if all modules start using constructor promotions, since of 2.4.6 php 7.4 is dropped we can now make use of it. So let's start on it right now.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@l-helmus-youwe
Use constructor property promotion in module Sample Data
bb09925 
Replace allmost all properties with constructor property promotion in module sample data: https://stitcher.io/blog/constructor-promotion-in-php-8

* Readable code
* Make Magento less complex by removing properties which take up a lot of lines.
* Imported all classes to make code more readable.

I think the code would be a lot cleaner if all modules start using constructor promotions, since of 2.4.6 php 7.4 is dropped we can now make use of it. So let's start on it right now.
@m2-assistant
Copy link

m2-assistant bot commented Mar 16, 2023

Hi @leonhelmus. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Youwe partners-contribution Pull Request is created by Magento Partner labels Mar 16, 2023
@leonhelmus
Copy link
Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

fredden
fredden reviewed Mar 16, 2023
View reviewed changes
app/code/Magento/SampleData/Console/CommandList.php
* Object Manager
*
* @var ObjectManagerInterface
* @param ObjectManagerInterface $objectManager Object Manager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @param ObjectManagerInterface $objectManager Object Manager
* @param ObjectManagerInterface $objectManager

app/code/Magento/SampleData/Model/Dependency.php
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function __construct(
ComposerInformation $composerInformation,
protected readonly ComposerInformation $composerInformation,
Filesystem $filesystem,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be removed? It does not appear to be used.

Suggested change
Filesystem $filesystem,

@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredden fredden fredden left review comments

Assignees

@fredden fredden

Labels
Partner: Youwe partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: review
Projects
Pull Requests Dashboard
Status: Review in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@leonhelmus @fredden @engcom-Bravo @m2-github-services @l-helmus-youwe