Use constructor property promotion in module Search

app/code/Magento/Search/Adapter/Query/Preprocessor/Synonyms.php

@@ -10,19 +10,14 @@
 
 class Synonyms implements PreprocessorInterface
 {
-    /**
-     * @var SynonymAnalyzerInterface
-     */
-    private $synonymsAnalyzer;
-
     /**
      * Constructor
      *
      * @param SynonymAnalyzerInterface $synonymsAnalyzer
      */
-    public function __construct(SynonymAnalyzerInterface $synonymsAnalyzer)
-    {
-        $this->synonymsAnalyzer = $synonymsAnalyzer;
+    public function __construct(
+        private readonly SynonymAnalyzerInterface $synonymsAnalyzer
+    ) {
     }
 
     /**

app/code/Magento/Search/Block/Adminhtml/Dashboard/Last.php

@@ -5,26 +5,36 @@
  */
 namespace Magento\Search\Block\Adminhtml\Dashboard;
 
+use Exception;
+use Magento\Backend\Block\Dashboard\Grid as DashboardGrid;
+use Magento\Backend\Block\Dashboard\Searches\Renderer\Searchquery;
+use Magento\Backend\Block\Template\Context as TemplateContext;
+use Magento\Backend\Helper\Data as BackendHelper;
+use Magento\Framework\Exception\LocalizedException;
+use Magento\Framework\Module\Manager as ModuleManager;
+use Magento\Search\Model\ResourceModel\Query\Collection as QueryCollection;
+use Magento\Search\Model\ResourceModel\Query\CollectionFactory as QueryCollectionFactory;
+
 /**
  * Dashboard last search keywords block
  * @api
  * @SuppressWarnings(PHPMD.DepthOfInheritance)
  * @since 100.0.2
  */
-class Last extends \Magento\Backend\Block\Dashboard\Grid
+class Last extends DashboardGrid
 {
     /**
-     * @var \Magento\Search\Model\ResourceModel\Query\Collection
+     * @var QueryCollection
      */
     protected $_collection;
 
     /**
-     * @var \Magento\Search\Model\ResourceModel\Query\CollectionFactory
+     * @var QueryCollectionFactory
      */
     protected $_queriesFactory;
 
     /**
-     * @var \Magento\Framework\Module\Manager
+     * @var ModuleManager
      */
     protected $_moduleManager;
 
@@ -34,17 +44,17 @@ class Last extends \Magento\Backend\Block\Dashboard\Grid
     protected $_template = 'Magento_Backend::dashboard/grid.phtml';
 
     /**
-     * @param \Magento\Backend\Block\Template\Context $context
-     * @param \Magento\Backend\Helper\Data $backendHelper
-     * @param \Magento\Framework\Module\Manager $moduleManager
-     * @param \Magento\Search\Model\ResourceModel\Query\CollectionFactory $queriesFactory
+     * @param TemplateContext $context
+     * @param BackendHelper $backendHelper
+     * @param ModuleManager $moduleManager
+     * @param QueryCollectionFactory $queriesFactory
      * @param array $data
      */
     public function __construct(
-        \Magento\Backend\Block\Template\Context $context,
-        \Magento\Backend\Helper\Data $backendHelper,
-        \Magento\Framework\Module\Manager $moduleManager,
-        \Magento\Search\Model\ResourceModel\Query\CollectionFactory $queriesFactory,
+        TemplateContext $context,
+        BackendHelper $backendHelper,
+        ModuleManager $moduleManager,
+        QueryCollectionFactory $queriesFactory,
         array $data = []
     ) {
         $this->_moduleManager = $moduleManager;
@@ -67,7 +77,7 @@ protected function _construct()
      * Prepare collection.
      *
      * @return $this
-     * @throws \Magento\Framework\Exception\LocalizedException
+     * @throws LocalizedException
      */
     protected function _prepareCollection()
     {
@@ -93,7 +103,7 @@ protected function _prepareCollection()
      * Prepare columns.
      *
      * @return $this
-     * @throws \Exception
+     * @throws Exception
      */
     protected function _prepareColumns()
     {
@@ -103,7 +113,7 @@ protected function _prepareColumns()
                 'header' => __('Search Term'),
                 'sortable' => false,
                 'index' => 'query_text',
-                'renderer' => \Magento\Backend\Block\Dashboard\Searches\Renderer\Searchquery::class,
+                'renderer' => Searchquery::class,
                 'header_css_class' => 'col-search-query',
                 'column_css_class' => 'col-search-query'
             ]

app/code/Magento/Search/Block/Adminhtml/Dashboard/Top.php

@@ -5,26 +5,34 @@
  */
 namespace Magento\Search\Block\Adminhtml\Dashboard;
 
+use Magento\Backend\Block\Dashboard\Grid as DashboardGrid;
+use Magento\Backend\Block\Dashboard\Searches\Renderer\Searchquery;
+use Magento\Backend\Block\Template\Context as TemplateContext;
+use Magento\Backend\Helper\Data as BackendHelper;
+use Magento\Framework\Module\Manager as ModuleManager;
+use Magento\Search\Model\ResourceModel\Query\Collection as QueryCollection;
+use Magento\Search\Model\ResourceModel\Query\CollectionFactory as QueryCollectionFactory;
+
 /**
  *  Dashboard last search keywords block
  * @api
  * @SuppressWarnings(PHPMD.DepthOfInheritance)
  * @since 100.0.2
  */
-class Top extends \Magento\Backend\Block\Dashboard\Grid
+class Top extends DashboardGrid
 {
     /**
-     * @var \Magento\Search\Model\ResourceModel\Query\Collection
+     * @var QueryCollection
      */
     protected $_collection;
 
     /**
-     * @var \Magento\Search\Model\ResourceModel\Query\CollectionFactory
+     * @var QueryCollectionFactory
      */
     protected $_queriesFactory;
 
     /**
-     * @var \Magento\Framework\Module\Manager
+     * @var ModuleManager
      */
     protected $_moduleManager;
 
@@ -34,17 +42,17 @@ class Top extends \Magento\Backend\Block\Dashboard\Grid
     protected $_template = 'Magento_Backend::dashboard/grid.phtml';
 
     /**
-     * @param \Magento\Backend\Block\Template\Context $context
-     * @param \Magento\Backend\Helper\Data $backendHelper
-     * @param \Magento\Framework\Module\Manager $moduleManager
-     * @param \Magento\Search\Model\ResourceModel\Query\CollectionFactory $queriesFactory
+     * @param TemplateContext $context
+     * @param BackendHelper $backendHelper
+     * @param ModuleManager $moduleManager
+     * @param QueryCollectionFactory $queriesFactory
      * @param array $data
      */
     public function __construct(
-        \Magento\Backend\Block\Template\Context $context,
-        \Magento\Backend\Helper\Data $backendHelper,
-        \Magento\Framework\Module\Manager $moduleManager,
-        \Magento\Search\Model\ResourceModel\Query\CollectionFactory $queriesFactory,
+        TemplateContext $context,
+        BackendHelper $backendHelper,
+        ModuleManager $moduleManager,
+        QueryCollectionFactory $queriesFactory,
         array $data = []
     ) {
         $this->_moduleManager = $moduleManager;
@@ -98,7 +106,7 @@ protected function _prepareColumns()
                 'header' => __('Search Term'),
                 'sortable' => false,
                 'index' => 'query_text',
-                'renderer' => \Magento\Backend\Block\Dashboard\Searches\Renderer\Searchquery::class,
+                'renderer' => Searchquery::class,
                 'header_css_class' => 'col-search-query',
                 'column_css_class' => 'col-search-query'
             ]

app/code/Magento/Search/Block/Adminhtml/Reports/Search.php

@@ -5,13 +5,15 @@
  */
 namespace Magento\Search\Block\Adminhtml\Reports;
 
+use Magento\Backend\Block\Widget\Grid\Container;
+
 /**
  * Adminhtml search report page content block
  *
  * @api
  * @since 100.0.2
  */
-class Search extends \Magento\Backend\Block\Widget\Grid\Container
+class Search extends Container
 {
     /**
      * Initialize Grid Container

app/code/Magento/Search/Block/Adminhtml/Synonyms.php

@@ -5,10 +5,12 @@
  */
 namespace Magento\Search\Block\Adminhtml;
 
+use Magento\Backend\Block\Widget\Grid\Container;
+
 /**
  * Adminhtml synonym group content block
  */
-class Synonyms extends \Magento\Backend\Block\Widget\Grid\Container
+class Synonyms extends Container
 {
     /**
      * @return void

app/code/Magento/Search/Block/Adminhtml/Synonyms/Edit/GenericButton.php

@@ -5,6 +5,9 @@
  */
 namespace Magento\Search\Block\Adminhtml\Synonyms\Edit;
 
+use Magento\Backend\Block\Widget\Context as WidgetContext;
+use Magento\Framework\Registry;
+use Magento\Framework\UrlInterface;
 use Magento\Search\Controller\RegistryConstants;
 
 /**
@@ -15,29 +18,21 @@ class GenericButton
     /**
      * Url Builder
      *
-     * @var \Magento\Framework\UrlInterface
+     * @var UrlInterface
      */
     protected $urlBuilder;
 
-    /**
-     * Registry
-     *
-     * @var \Magento\Framework\Registry
-     */
-    protected $registry;
-
     /**
      * Constructor
      *
-     * @param \Magento\Backend\Block\Widget\Context $context
-     * @param \Magento\Framework\Registry $registry
+     * @param WidgetContext $context
+     * @param Registry $registry Registry
      */
     public function __construct(
-        \Magento\Backend\Block\Widget\Context $context,
-        \Magento\Framework\Registry $registry
+        WidgetContext $context,
+        protected readonly Registry $registry
     ) {
         $this->urlBuilder = $context->getUrlBuilder();
-        $this->registry = $registry;
     }
 
     /**

app/code/Magento/Search/Block/Adminhtml/Term.php

@@ -5,11 +5,13 @@
  */
 namespace Magento\Search\Block\Adminhtml;
 
+use Magento\Backend\Block\Widget\Grid\Container;
+
 /**
  * @api
  * @since 100.0.2
  */
-class Term extends \Magento\Backend\Block\Widget\Grid\Container
+class Term extends Container
 {
     /**
      * @return void

app/code/Magento/Search/Block/Adminhtml/Term/Edit.php

@@ -5,29 +5,34 @@
  */
 namespace Magento\Search\Block\Adminhtml\Term;
 
+use Magento\Backend\Block\Widget\Context as WidgetContext;
+use Magento\Backend\Block\Widget\Form\Container;
+use Magento\Framework\Phrase;
+use Magento\Framework\Registry;
+
 /**
  * Admin term edit block
  *
  * @api
  * @since 100.0.2
  */
-class Edit extends \Magento\Backend\Block\Widget\Form\Container
+class Edit extends Container
 {
     /**
      * Core registry
      *
-     * @var \Magento\Framework\Registry
+     * @var Registry
      */
     protected $coreRegistry;
 
     /**
-     * @param \Magento\Backend\Block\Widget\Context $context
-     * @param \Magento\Framework\Registry $registry
+     * @param WidgetContext $context
+     * @param Registry $registry
      * @param array $data
      */
     public function __construct(
-        \Magento\Backend\Block\Widget\Context $context,
-        \Magento\Framework\Registry $registry,
+        WidgetContext $context,
+        Registry $registry,
         array $data = []
     ) {
         $this->coreRegistry = $registry;
@@ -50,7 +55,7 @@ protected function _construct()
     }
 
     /**
-     * @return \Magento\Framework\Phrase
+     * @return Phrase
      */
     public function getHeaderText()
     {