Use constructor property promotion in module Shipping #37217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace allmost all properties with constructor property promotion in module Shipping: https://stitcher.io/blog/constructor-promotion-in-php-8 * Readable code * Make Magento less complex by removing properties which take up a lot of lines. * Imported all classes to make code more readable. I think the code would be a lot cleaner if all modules start using constructor promotions, since of 2.4.6 php 7.4 is dropped we can now make use of it. So let's start on it right now.
|
Hi @leonhelmus. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
m2-github-services
added
Partner: Youwe
partners-contribution
|
@magento run all tests |
|
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
engcom-Bravo
added
the
Priority: P2
fredden
reviewed
Dec 3, 2024
| { | ||
| /** | ||
| * Core registry | ||
| * | ||
| * @var \Magento\Framework\Registry | ||
| * @var Registry | ||
| */ | ||
| protected $_coreRegistry = null; |
| { | ||
| /** | ||
| * Sales data | ||
| * | ||
| * @var \Magento\Sales\Helper\Data | ||
| * @var SalesHelper | ||
| */ | ||
| protected $_salesData; |
| */ | ||
| protected $_salesData; | ||
|
|
||
| /** | ||
| * @var \Magento\Shipping\Model\CarrierFactory | ||
| * @var CarrierFactory | ||
| */ | ||
| protected $_carrierFactory; |
| */ | ||
| protected $_jsonEncoder; | ||
|
|
||
| /** | ||
| * @var \Magento\Shipping\Model\CarrierFactory | ||
| * @var CarrierFactory | ||
| */ | ||
| protected $_carrierFactory; |
| */ | ||
| protected $_coreRegistry = null; | ||
|
|
||
| /** | ||
| * @var \Magento\Framework\Json\EncoderInterface | ||
| * @var EncoderInterface | ||
| */ | ||
| protected $_jsonEncoder; |
| */ | ||
| protected $_scopeConfig; | ||
|
|
||
| /** | ||
| * @var \Magento\Quote\Model\Quote\Address\RateResult\ErrorFactory | ||
| * @var ErrorFactory | ||
| */ | ||
| protected $_rateErrorFactory; |
| @@ -72,30 +82,30 @@ abstract class AbstractCarrier extends \Magento\Framework\DataObject implements | |||
| /** | |||
| * Core store config | |||
| * | |||
| * @var \Magento\Framework\App\Config\ScopeConfigInterface | |||
| * @var ScopeConfigInterface | |||
| */ | |||
| protected $_scopeConfig; | |||
Comment on lines
+139
to
+152
| ScopeConfigInterface $scopeConfig, | ||
| RateResultErrorFactory $rateErrorFactory, | ||
| LoggerInterface $logger, | ||
| protected readonly Security $xmlSecurity, | ||
| ElementFactory $xmlElFactory, | ||
| RateResultFactory $rateFactory, | ||
| MethodFactory $rateMethodFactory, | ||
| ResultFactory $trackFactory, | ||
| ErrorFactory $trackErrorFactory, | ||
| StatusFactory $trackStatusFactory, | ||
| RegionFactory $regionFactory, | ||
| CountryFactory $countryFactory, | ||
| CurrencyFactory $currencyFactory, | ||
| DirectoryHelper $directoryData, |
There was a problem hiding this comment.
Why not promote these properties?
| { | ||
| /** | ||
| * Core store config | ||
| * | ||
| * @var \Magento\Framework\App\Config\ScopeConfigInterface | ||
| * @var ScopeConfigInterface | ||
| */ | ||
| protected $_scopeConfig; |
| */ | ||
| protected $_scopeConfig; | ||
|
|
||
| /** | ||
| * @var \Magento\Shipping\Model\Config | ||
| * @var ShippingConfig | ||
| */ | ||
| protected $_shippingConfig; |
m2-community-project
bot
added
Progress: review
and removed
Progress: pending review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Replace allmost all properties with constructor property promotion in module Shipping: https://stitcher.io/blog/constructor-promotion-in-php-8
I think the code would be a lot cleaner if all modules start using constructor promotions, since of 2.4.6 php 7.4 is dropped we can now make use of it. So let's start on it right now.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)