Fix JS error on the create account page with multishipping

[ihor-sviziev]

Description (*)

My PR fixes JS error that happened on the Create account page using multishipping checkout.
URL looks like this https://example.com/multishipping/checkout/addresses/

Covered in: #32638

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Product count not appear on Mini cart  #32629
2. Fixes Password strength not updating issue on register page  #32630
3. Fixes Page refresh on subscribe for footer newsletter section #32632

Manual testing scenarios (*)

1. As guest user add 2-3 products to cart
2. Shopping Cart
3. Click on Checkout with multiple addresses
4. Login page -> Click on Create an account button

Expected result:
There shouldn't be any JS errors

Actual result:
We have a JS error that causing multiple issues, listed in "fixed issues" section:

It was caused by an incorrect JSON file - in the source code we see the following code:

Note: I don't think that MFTF tests will be effective here, as you still CAN create an account if you'll put all needed info correctly, while some JS part is broken on the page.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ihor-sviziev. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

@magento run all tests

[ihor-sviziev]

@magento run all tests

[eduard13]

Hi @ihor-sviziev, in my opinion this issue should have at least a P2. Also I guess that we should be able to cover this case with a MFTF test, that will check the minicart on the mentioned page.

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @eduard13. Thank you for your request. I'm working on Magento instance for you.

[ihor-sviziev]

@eduard13 unfrortunately, I don't have enough knowledge about MFTF. Could you help me with that?

[magento-deployment-service]

Hi @eduard13, here is your Magento Instance: https://aca4105249d09569a741cbd221576093-2-4-develop.instances.magento-community.engineering
Admin access: https://aca4105249d09569a741cbd221576093-2-4-develop.instances.magento-community.engineering/admin_2987
Login: e37db3cf
Password: 80643c21c945

[ihor-sviziev]

@magento run Functional Tests B2B, WebAPI Tests

[gabrieldagama]

@magento run all tests

[eduard13]

@magento run Unit Tests, Functional Tests EE, Functional Tests B2B

[hostep]

@ihor-sviziev, I think the following issues can be added to the list of issues to be fixed:

• JavaScript error on register new customer (with address fields enabled) #30752
• The region selector does not work after adding it to the customer account creation page #30099
• Region select field won't load in registration page #32128
• State/Province drop down not appear issue  #32628
• Skipped Zip/Postal code in required fields  #32633
• ...

There is even another PR trying to fix it #27608 (even though that one fixes some more issues at the same time I think)

Just FYI

[ihor-sviziev]

@hostep thx for the list. Actually I think it's better to fix the JS error and not any other improvements right now. They might be added later if needed

[eduard13]

@magento run Functional Tests EE

[eduard13]

The failed test doesn't seem related to these changes.

[magento-engcom-team]

Hi @eduard13, thank you for the review.
ENGCOM-8978 has been created to process this Pull Request

[engcom-Oscar]

✔️ QA passed

Was checked case from Manual testing scenarios

✔️ After:

[ihor-sviziev]

Hi,

The issue was already fixed in 461509d. I'm closing this PR as it's not relevant anymore

[m2-assistant]

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.