-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fixed region field related issue in the customer registration form #31755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed region field related issue in the customer registration form #31755
Conversation
Fixed region field related issue in the customer registration form if the address is enabled programmatically.
Hi @pawanmishracedcoss. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento create issue |
@magento run all tests |
@magento run all tests |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pawanmishracedcoss, nice catch, thanks for contributing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ QA Failed
After switching to the PR, an exception message appears on the Create Customer page
ParseError: syntax error, unexpected '/' in /home/chalov/sites/mage2/app/code/Magento/Customer/view/frontend/templates/form/register.phtml:355
Stack trace:
#0 /home/chalov/sites/mage2/lib/internal/Magento/Framework/View/Element/Template.php(273): Magento\Framework\View\TemplateEngine\Php->render()
#1 /lib/internal/Magento/Framework/View/Element/Template.php(303): Magento\Framework\View\Element\Template->fetchView()
#2 /lib/internal/Magento/Framework/View/Element/AbstractBlock.php(1114): Magento\Framework\View\Element\Template->_toHtml()
#3 /lib/internal/Magento/Framework/View/Element/AbstractBlock.php(1118): Magento\Framework\View\Element\AbstractBlock->Magento\Framework\View\Element\{closure}()
#4 /lib/internal/Magento/Framework/View/Element/AbstractBlock.php(678): Magento\Framework\View\Element\AbstractBlock->_loadCache()
#5 /lib/internal/Magento/Framework/View/Layout.php(578): Magento\Framework\View\Element\AbstractBlock->toHtml()
#6 /lib/internal/Magento/Framework/View/Layout.php(555): Magento\Framework\View\Layout->_renderBlock()
#7 /generated/code/Magento/Framework/View/Layout/Interceptor.php(149): Magento\Framework\View\Layout->renderNonCachedElement()
#8 /lib/internal/Magento/Framework/View/Layout.php(510): Magento\Framework\View\Layout\Interceptor->renderNonCachedElement()
#9 /generated/code/Magento/Framework/View/Layout/Interceptor.php(140): Magento\Framework\View\Layout->renderElement()
#10 lib/internal/Magento/Framework/View/Layout.php(606): Magento\Framework\View\Layout\Interceptor->renderElement()
...
#50 /generated/code/Magento/Framework/View/Result/Page/Interceptor.php(95): Magento\Framework\View\Result\Page\Interceptor->___callPlugins()
#51 /lib/internal/Magento/Framework/App/Http.php(120): Magento\Framework\View\Result\Page\Interceptor->renderResult()
#52 /generated/code/Magento/Framework/App/Http/Interceptor.php(23): Magento\Framework\App\Http->launch()
#53 /lib/internal/Magento/Framework/App/Bootstrap.php(264): Magento\Framework\App\Http\Interceptor->launch()
#54 /pub/index.php(29): Magento\Framework\App\Bootstrap->run()
#55 {main}
Hello @pawanmishracedcoss, |
Hi @gabrieldagama, thank you for the review. |
@pawanmishracedcoss thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @pawanmishracedcoss can you have a look at @engcom-Bravo comment?
Closed in favor of #27608. |
Hi @pawanmishracedcoss, thank you for your contribution! |
Fixed region field related issue in the customer registration form if the address is enabled programmatically.
Description (*)
If address fields are enabled in the customer registration form then the state/region field doesn't load.
Manual testing scenarios (*)
Fixed Issues (if relevant)
Contribution checklist (*)