Skip to content

Fixed region field related issue in the customer registration form #31755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

pawanmishra91
Copy link

@pawanmishra91 pawanmishra91 commented Jan 19, 2021

Fixed region field related issue in the customer registration form if the address is enabled programmatically.

Description (*)

If address fields are enabled in the customer registration form then the state/region field doesn't load.

Manual testing scenarios (*)

  1. Need to enable the address fields in the customer registration form programmatically.
  2. Then go to the customer sign up form and try to register.
  3. Sign up won't work as region/state is a required field.
  4. Reason for the same is that region/state doesn't load the values
  5. As there is a js issue in firebug that Uncaught SyntaxError: Unexpected token $ in JSON

Fixed Issues (if relevant)

  1. Fixes The region selector does not work after adding it to the customer account creation page #30099
  2. Fixes [Issue] Fixed region field related issue in the customer registration form #31756

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Fixed region field related issue in the customer registration form if the address is enabled programmatically.
@m2-assistant
Copy link

m2-assistant bot commented Jan 19, 2021

Hi @pawanmishracedcoss. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@GovindaSharma
Copy link
Contributor

@magento create issue

@GovindaSharma
Copy link
Contributor

@magento run all tests

@gabrieldagama gabrieldagama added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Jan 19, 2021
@hostep
Copy link
Contributor

hostep commented Jan 19, 2021

This fixes #30099 & #30752 btw.

@gabrieldagama
Copy link
Contributor

@magento run all tests

@gabrieldagama
Copy link
Contributor

@magento run all tests

Copy link
Contributor

@gabrieldagama gabrieldagama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pawanmishracedcoss, nice catch, thanks for contributing!

Copy link
Contributor

@engcom-Bravo engcom-Bravo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ QA Failed
After switching to the PR, an exception message appears on the Create Customer page

ParseError: syntax error, unexpected '/' in /home/chalov/sites/mage2/app/code/Magento/Customer/view/frontend/templates/form/register.phtml:355
Stack trace:
#0 /home/chalov/sites/mage2/lib/internal/Magento/Framework/View/Element/Template.php(273): Magento\Framework\View\TemplateEngine\Php->render()
#1 /lib/internal/Magento/Framework/View/Element/Template.php(303): Magento\Framework\View\Element\Template->fetchView()
#2 /lib/internal/Magento/Framework/View/Element/AbstractBlock.php(1114): Magento\Framework\View\Element\Template->_toHtml()
#3 /lib/internal/Magento/Framework/View/Element/AbstractBlock.php(1118): Magento\Framework\View\Element\AbstractBlock->Magento\Framework\View\Element\{closure}()
#4 /lib/internal/Magento/Framework/View/Element/AbstractBlock.php(678): Magento\Framework\View\Element\AbstractBlock->_loadCache()
#5 /lib/internal/Magento/Framework/View/Layout.php(578): Magento\Framework\View\Element\AbstractBlock->toHtml()
#6 /lib/internal/Magento/Framework/View/Layout.php(555): Magento\Framework\View\Layout->_renderBlock()
#7 /generated/code/Magento/Framework/View/Layout/Interceptor.php(149): Magento\Framework\View\Layout->renderNonCachedElement()
#8 /lib/internal/Magento/Framework/View/Layout.php(510): Magento\Framework\View\Layout\Interceptor->renderNonCachedElement()
#9 /generated/code/Magento/Framework/View/Layout/Interceptor.php(140): Magento\Framework\View\Layout->renderElement()
#10 lib/internal/Magento/Framework/View/Layout.php(606): Magento\Framework\View\Layout\Interceptor->renderElement()
...
#50 /generated/code/Magento/Framework/View/Result/Page/Interceptor.php(95): Magento\Framework\View\Result\Page\Interceptor->___callPlugins()
#51 /lib/internal/Magento/Framework/App/Http.php(120): Magento\Framework\View\Result\Page\Interceptor->renderResult()
#52 /generated/code/Magento/Framework/App/Http/Interceptor.php(23): Magento\Framework\App\Http->launch()
#53 /lib/internal/Magento/Framework/App/Bootstrap.php(264): Magento\Framework\App\Http\Interceptor->launch()
#54 /pub/index.php(29): Magento\Framework\App\Bootstrap->run()
#55 {main}

@engcom-Hotel
Copy link
Contributor

Hello @pawanmishracedcoss,
Please have a look at #27608
Looks like it is already fixed and just wait for the approval.

@magento-engcom-team
Copy link
Contributor

Hi @gabrieldagama, thank you for the review.
ENGCOM-8727 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@pawanmishracedcoss thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@gabrieldagama
Copy link
Contributor

@magento run all tests
@magento run all tests

Copy link
Contributor

@gabrieldagama gabrieldagama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @pawanmishracedcoss can you have a look at @engcom-Bravo comment?

@ihor-sviziev ihor-sviziev mentioned this pull request Feb 18, 2021
4 tasks
@engcom-Hotel engcom-Hotel removed their assignment Feb 26, 2021
@engcom-Foxtrot
Copy link
Contributor

Closed in favor of #27608.

@m2-assistant
Copy link

m2-assistant bot commented Mar 5, 2021

Hi @pawanmishracedcoss, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Customer Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
None yet
8 participants