-
Notifications
You must be signed in to change notification settings - Fork 9.4k
updated readme file #31498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
updated readme file #31498
Conversation
Hi @chiranjeevi-cj. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chiranjeevi-cj for the submission. Please remove the bolding from the module names.
- Magento_Store | ||
- Magento_Tax | ||
|
||
Please find here [how to enable or disable modules in Magento 2](https://devdocs.magento.com/guides/v2.4/install-gde/install/cli/install-cli-subcommands-enable.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for 'Please'.
- Magento_Sales | ||
- Magento_Store | ||
|
||
Please find here [how to enable or disable modules in Magento 2](https://devdocs.magento.com/guides/v2.4/install-gde/install/cli/install-cli-subcommands-enable.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
Magento_SalesInventory module allows retrieve and update stock attributes related to Magento_Sales, such as status and quantity. | ||
# Magento_SalesInventory module | ||
|
||
The **Magento_SalesInventory** module allows retrieve and update stock attributes related to Magento_Sales, such as status and quantity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The **Magento_SalesInventory** module allows retrieve and update stock attributes related to Magento_Sales, such as status and quantity. | |
The **Magento_SalesInventory** module enables the retrieval and update of stock attributes related to Magento_Sales, such as status and quantity. |
Co-authored-by: Donald Booth <dobooth@adobe.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chiranjeevi-cj please, resolve merge conflicts
Hi @chiranjeevi-cj, Thank you for your contribution! I will look into the branch conflicts. Thank you! |
I have resolved the merged conflicts. It seems that the requested changes have been taken care already. @dobooth can you please review the changes. Thank you! |
Description (*)
Update README.md file:
Fixed Issues (if relevant)
Contribution checklist (*)