Adding the company and VAT Number values at OPC address. #31425

rav-redchamps · 2020-12-23T13:06:09Z

Description (*)

Adding the company and VAT Number values at OPC address.

Related Pull Requests

https://github.com/magento/partners-magento2b2b/pull/538

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

Enable showing company and VAT Number data at the front
Check if it is available at OPC.

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Region data fix #31439: Region data fix

Resolved issues:

resolves [Issue] Adding the company and VAT Number values at OPC address. #31652: Adding the company and VAT Number values at OPC address.

…velop

…velop � Conflicts: � app/code/Magento/Checkout/view/frontend/web/template/billing-address/details.html

m2-assistant · 2020-12-23T13:06:12Z

Hi @rav-redchamps. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

rav-redchamps · 2020-12-23T14:54:23Z

@magento run all tests

sidolov · 2020-12-23T16:50:21Z

@magento create issue

sidolov

@rav-redchamps please, cover changes with an automated test. Thanks!

engcom-Hotel · 2020-12-24T13:58:09Z

Hello @rav-redchamps,
The fix already exists at #27608
So, we may continue the current PR partially.
Like 'adding the company and VAT Number values at the checkout'.
Steps to reproduce:
Magento version: 2.4-develop
PHP version: 7.4
ElasticSearch version: 7
MySQL version: 8.0

Set Store->Configuration->Customer Configuration->Create New Account Options->Show Company to 'Optional'
Set Store->Configuration->Customer Configuration->Create New Account Options->Show VAT Number on Storefront to 'Optional'
Save config
bin/magento c:c
Open registration page /customer/account/create/
Create the customer with the company name and add VAT Number (admin->Customers->edit created customer->Addresses->Add/Update Address)
Add any product to the cart and check if company name and VAT Id are visible at checkout/#shipping and checkout/#payment (both payment and shipment areas)
Thank you.

PS. I will help with the test coverage

engcom-Hotel · 2020-12-28T16:13:43Z

@magento run all tests

engcom-Hotel · 2020-12-29T09:33:06Z

@magento run Functional Tests CE

engcom-Hotel · 2020-12-29T10:48:19Z

@magento run Functional Tests CE

engcom-Hotel · 2020-12-30T09:55:35Z

Hi @sidolov,
This PR is a duplicate of #27608.
We can recreate the issue for "adding the company and VAT Number values at OPC" and update the priority for it.
Could you please have a look?
Thank you.

sidolov · 2021-01-04T16:34:51Z

@engcom-Hotel not sure how they are related, current PR going to display fields in case the address object has them and the second one aimed to support the region selector on the page

magento-automated-testing · 2021-05-26T19:32:47Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik · 2021-05-27T05:54:11Z

@engcom-Foxtrot Looks like after creating the product we should run reindex because product page is not available

…s - MFTF test fix.

engcom-Foxtrot · 2021-05-27T13:15:22Z

@magento run all tests

magento-automated-testing · 2021-05-27T13:15:28Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-05-28T08:18:43Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-05-28T08:18:49Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Foxtrot · 2021-05-28T11:59:06Z

@magento run Functional Tests CE, Functional Tests B2B

magento-automated-testing · 2021-05-28T11:59:10Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2021-09-09T06:01:32Z

Hi @rav-redchamps,

Thank you for your contribution.

I am working on the suggested review changes.

Thank you!

engcom-Charlie · 2021-09-09T07:21:50Z

@magento run Functional Tests CE, Functional Tests B2B

magento-automated-testing · 2021-09-09T07:21:55Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

magento-automated-testing · 2021-09-09T10:16:16Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2021-09-13T07:09:20Z

Thank you everyone for your contribution!

It seems that the review changes has been taken care with new MFTF test case.

I have tested the new MFTF test case and its working fine.

Also found that the test case which is failing in this build is not part of this PR. Its failing because of customer search is not working and not because of PR changes. So kindly asking for review again.

@engcom-Foxtrot, I was about to merge the 2.4-develop branch to PR branch before passing it to review, but found that you have merge 2.4-develop-mainline into this branch. Curious to know why 2.4-develop-mainline was got merged.

engcom-Charlie · 2021-09-22T07:36:12Z

@engcom-Foxtrot can you please provide any details on this comment. It will be helpful to move this issue further.

Thank you!

engcom-Charlie · 2021-10-12T14:18:47Z

@magento run all tests

magento-automated-testing · 2021-10-12T14:18:51Z

Pull Requests are not mergeable to the mainline. Please merge the latest mainlines to your Pull Requests and restart the builds.

Den4ik · 2021-10-17T06:59:48Z

@magento run all tests

magento-automated-testing · 2021-10-17T06:59:55Z

Pull Requests are not mergeable to the mainline. Please merge the latest mainlines to your Pull Requests and restart the builds.

engcom-Charlie · 2021-10-19T07:44:15Z

@magento run all tests

magento-automated-testing · 2021-10-19T07:44:20Z

Pull Requests are not mergeable to the mainline. Please merge the latest mainlines to your Pull Requests and restart the builds.

engcom-Charlie · 2021-10-19T07:47:30Z

As per comment, the test case which is failing in this build is not part of this PR. Its failing because of customer search is not working in PR branch.

In order to move this issue further, I have to merge the latest 2.4 develop code base in this branch but as I have mentioned in this comment, @engcom-Foxtrot have merge the 2.4-develop-mainline branch to PR branch which might be causing this failure.

To make a good progress, I will be raising a new PR for this issue and close this PR.

Thank you!

engcom-Charlie · 2021-10-19T14:53:09Z

Created new PR so closing this PR now

Thank you!

m2-assistant · 2021-10-19T14:53:24Z

Hi @rav-redchamps, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

rav-redchamps added 4 commits July 5, 2020 16:58

added company field value to shipping & billing address renderers

70da2bc

added Vat Id field to address renderers

e567abf

Merge branch '2.4-develop' of github.com:magento/magento2 into 2.4-de…

7e6801c

…velop

Merge branch '2.4-develop' of github.com:magento/magento2 into 2.4-de…

2914ad8

…velop � Conflicts: � app/code/Magento/Checkout/view/frontend/web/template/billing-address/details.html

magento-engcom-team added Area: Frontend Component: Checkout Component: Customer Release Line: 2.4 labels Dec 23, 2020

sidolov added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Dec 23, 2020

m2-community-project bot added the Progress: pending review label Dec 23, 2020

m2-assistant bot mentioned this pull request Dec 23, 2020

[Issue] Region data fix #31439

Closed

4 tasks

sidolov requested changes Dec 23, 2020

View reviewed changes

m2-community-project bot assigned sidolov Dec 23, 2020

m2-community-project bot added Progress: needs update and removed Progress: pending review labels Dec 23, 2020

engcom-Hotel self-assigned this Dec 24, 2020

m2-community-project bot added Progress: on hold and removed Progress: needs update labels Dec 30, 2020

sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. labels Jan 5, 2021

engcom-Foxtrot added 2 commits May 27, 2021 13:13

Merge branch '2.4-develop-mainline' into region-data-fix

b66f2da

magento#31652: Adding the company and VAT Number values at OPC addres…

5d24c6d

…s - MFTF test fix.

engcom-Charlie self-assigned this Sep 8, 2021

Merge branch '2.4-develop' into region-data-fix

f632d12

engcom-Charlie mentioned this pull request Oct 19, 2021

Added the company and VAT Number values at OPC address #34389

Closed

5 tasks

engcom-Charlie closed this Oct 19, 2021

m2-community-project bot removed the Progress: needs update label Oct 19, 2021

Adding the company and VAT Number values at OPC address. #31425

Adding the company and VAT Number values at OPC address. #31425

Uh oh!

Conversation

rav-redchamps commented Dec 23, 2020 • edited by engcom-Alfa Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Resolved issues:

Uh oh!

m2-assistant bot commented Dec 23, 2020

Uh oh!

rav-redchamps commented Dec 23, 2020

Uh oh!

sidolov commented Dec 23, 2020

Uh oh!

sidolov left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Hotel commented Dec 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-Hotel commented Dec 28, 2020

Uh oh!

engcom-Hotel commented Dec 29, 2020

Uh oh!

engcom-Hotel commented Dec 29, 2020

Uh oh!

engcom-Hotel commented Dec 30, 2020

Uh oh!

sidolov commented Jan 4, 2021

Uh oh!

magento-automated-testing bot commented May 26, 2021

Uh oh!

Den4ik commented May 27, 2021

Uh oh!

engcom-Foxtrot commented May 27, 2021

Uh oh!

magento-automated-testing bot commented May 27, 2021

Uh oh!

magento-automated-testing bot commented May 28, 2021

Uh oh!

magento-automated-testing bot commented May 28, 2021

Uh oh!

engcom-Foxtrot commented May 28, 2021

Uh oh!

magento-automated-testing bot commented May 28, 2021

Uh oh!

engcom-Charlie commented Sep 9, 2021

Uh oh!

engcom-Charlie commented Sep 9, 2021

Uh oh!

magento-automated-testing bot commented Sep 9, 2021

Uh oh!

magento-automated-testing bot commented Sep 9, 2021

Uh oh!

engcom-Charlie commented Sep 13, 2021

Uh oh!

engcom-Charlie commented Sep 22, 2021

Uh oh!

engcom-Charlie commented Oct 12, 2021

Uh oh!

magento-automated-testing bot commented Oct 12, 2021

Uh oh!

Den4ik commented Oct 17, 2021

Uh oh!

magento-automated-testing bot commented Oct 17, 2021

Uh oh!

engcom-Charlie commented Oct 19, 2021

Uh oh!

magento-automated-testing bot commented Oct 19, 2021

Uh oh!

engcom-Charlie commented Oct 19, 2021

Uh oh!

engcom-Charlie commented Oct 19, 2021

rav-redchamps commented Dec 23, 2020 •

edited by engcom-Alfa

Loading

engcom-Hotel commented Dec 24, 2020 •

edited

Loading