Skip to content

magneto/magento2ce #31115: need to make Get requests with a Preview-V… #31245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

magneto/magento2ce #31115: need to make Get requests with a Preview-V… #31245

wants to merge 1 commit into from

Conversation

sasha19957099
Copy link
Contributor

@sasha19957099 sasha19957099 commented Dec 10, 2020 •
edited
Loading

Description (*)

Added a method to disable cache for fields of GraphQL queries

Related Pull Requests

https://github.com/magento/partners-magento2ee/pull/433

Fixed Issues (if relevant)

  1. Fixes Need to make GET requests with a Preview-Version header non-cacheable #31115

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@sasha19957099
magneto/magento2ce magento#31115: need to make Get requests with a Pr…
f9c0858 
…eview-Version header non-cacheable - added method to disable caching for a graphql query field
@m2-assistant
Copy link

m2-assistant bot commented Dec 10, 2020

Hi @sasha19957099. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sasha19957099
Copy link
Contributor Author

@magento run all tests

@sasha19957099 sasha19957099 self-assigned this Dec 10, 2020
@sasha19957099 sasha19957099 added PAP Partners acceleration program Progress: pending review and removed Progress: review labels Dec 10, 2020
@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Progress: review and removed Progress: pending review labels Dec 10, 2020
@sasha19957099 sasha19957099 added Progress: pending review Project: GraphQL and removed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: review Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Dec 10, 2020
@m2-community-project m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Progress: review and removed Progress: pending review labels Dec 10, 2020
@keharper keharper mentioned this pull request Feb 11, 2021
Merged
@duckchip
Copy link
Contributor

what is the status of this ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sasha19957099 sasha19957099

@chernenm chernenm

Labels
Component: GraphQL GraphQL PAP Partners acceleration program Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: review Project: GraphQL Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
Status: Review in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to make GET requests with a Preview-Version header non-cacheable
4 participants
@sasha19957099 @duckchip @magento-engcom-team @chernenm