Skip to content

Fixed issue #22841 Telephone, Company & Fax fields does not display on Customer Registration Page #27608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: 2.4-develop
Choose a base branch
from
Open

Fixed issue #22841 Telephone, Company & Fax fields does not display on Customer Registration Page #27608

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
2197d00
Added configuration for showing address fields
gaurav-473 Apr 5, 2020
34d04a2
Update register.phtml
gaurav-473 Apr 5, 2020
2a76acd
Update config.xml
gaurav-473 Apr 5, 2020
f963bc7
fixed static test
gaurav-473 Apr 5, 2020
50388ce
Merge branch '2.4-develop' into 2.4-develop-22841
engcom-Kilo Jun 18, 2020
5c358b2
MFTF test
engcom-Kilo Jun 19, 2020
76a3463
Merge branch '2.4-develop' into 2.4-develop-22841
engcom-Kilo Jun 19, 2020
4eb5022
Merge branch '2.4-develop' into 2.4-develop-22841
engcom-Kilo Jul 10, 2020
aed35f9
Fix static test
engcom-Kilo Jul 10, 2020
9b0ae83
Correction MFTF test.
engcom-Kilo Jul 13, 2020
64bb6ea
Correct typo.
engcom-Kilo Jul 13, 2020
995e62b
Updated i18n.
engcom-Kilo Jul 15, 2020
cb4390c
Merge branch '2.4-develop' into 2.4-develop-22841
engcom-Kilo Jul 16, 2020
853df84
Added testCaseId fot MFTF test.
engcom-Kilo Jul 22, 2020
0f5a1c2
Merge branch '2.4-develop' into 2.4-develop-22841
engcom-Kilo Jul 22, 2020
0caa710
Merge branch '2.4-develop' into 2.4-develop-22841
engcom-Charlie Sep 2, 2020
89df850
improve
engcom-Charlie Sep 2, 2020
7cf1e50
Merge branch '2.4-develop' into 2.4-develop-22841
engcom-Charlie Sep 2, 2020
a82390f
Merge branch '2.4-develop' into 2.4-develop-22841
engcom-Charlie Sep 7, 2020
40187f5
Merge branch '2.4-develop' into 2.4-develop-22841
Sep 8, 2020
4a2516e
Merge branch '2.4-develop' into 2.4-develop-22841
engcom-Charlie Sep 14, 2020
98488fa
Merge branch '2.4-develop' into 2.4-develop-22841
engcom-Charlie Sep 18, 2020
083cb2e
fix broken region selector
engcom-Charlie Sep 18, 2020
a02fca3
Merge branch '2.4-develop' into 2.4-develop-22841
engcom-Charlie Sep 18, 2020
78c9c43
fix mftf
engcom-Charlie Sep 21, 2020
be93ce9
Merge branch '2.4-develop' into 2.4-develop-22841
engcom-Charlie Sep 21, 2020
78a7b57
Merge branch '2.4-develop' into 2.4-develop-22841
engcom-Charlie Oct 6, 2020
8072400
Merge branch '2.4-develop' into 2.4-develop-22841
engcom-Charlie Oct 15, 2020
c78bfb6
Merge branch '2.4-develop' into 2.4-develop-22841
Nov 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/code/Magento/Customer/etc/adminhtml/system.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,13 @@
<source_model>Magento\Config\Model\Config\Source\Nooptreq</source_model>
<backend_model>Magento\Customer\Model\Config\Backend\Show\Customer</backend_model>
</field>
<field id="show_address_fields" translate="label" type="select" sortOrder="95" showInDefault="1" showInWebsite="1" showInStore="0">
<label>Show Address Information</label>
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
<comment>
Enable this for adding address information fields on the registration form.
</comment>
</field>
<field id="telephone_show" translate="label" type="select" sortOrder="100" showInDefault="1" showInWebsite="1" canRestore="1">
<label>Show Telephone</label>
<source_model>Magento\Config\Model\Config\Source\Nooptreq</source_model>
Expand Down
1 change: 1 addition & 0 deletions app/code/Magento/Customer/etc/config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
<dob_show />
<taxvat_show />
<gender_show />
<show_address_fields>0</show_address_fields>
<telephone_show>req</telephone_show>
<company_show>opt</company_show>
<fax_show/>
Expand Down
9 changes: 7 additions & 2 deletions app/code/Magento/Customer/view/frontend/templates/form/register.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ use Magento\Customer\Helper\Address;
/** @var \Magento\Customer\Block\Form\Register $block */
/** @var \Magento\Framework\Escaper $escaper */
$formData = $block->getFormData();
$showAddressFileds = false;
if ($block->getShowAddressFields() || $block->getConfig('customer/address/show_address_fields')){
$showAddressFileds = true;
}

?>
<?php $displayAll = $block->getConfig('general/region/display_all'); ?>
<?= $block->getChildHtml('form_fields_before') ?>
Expand Down Expand Up @@ -64,7 +69,7 @@ $formData = $block->getFormData();
<?= $_gender->setGender($formData->getGender())->toHtml() ?>
<?php endif ?>
</fieldset>
<?php if ($block->getShowAddressFields()): ?>
<?php if ($showAddressFileds): ?>
<?php $cityValidationClass = $this->helper(Address::class)->getAttributeValidationClass('city'); ?>
<?php $postcodeValidationClass = $this->helper(Address::class)->getAttributeValidationClass('postcode'); ?>
<?php $regionValidationClass = $this->helper(Address::class)->getAttributeValidationClass('region'); ?>
Expand Down Expand Up @@ -310,7 +315,7 @@ require([

});
</script>
<?php if ($block->getShowAddressFields()): ?>
<?php if ($showAddressFileds): ?>
<script type="text/x-magento-init">
{
"#country": {
Expand Down