-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Improvement of connection retry mechanism #27128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @kandy. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kandy,
In general your changes looks good. Could you cover your changes with tests?
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing functional tests not related to changes from this PR
Hi @ihor-sviziev, thank you for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kandy,
Could you merge 2.4-develop branch? Some conflict appeared there
@kandy , I am closing this PR now due to inactivity. |
Hi @kandy, thank you for your contribution! |
Hi @ihor-sviziev, thank you for the review. |
Hi @kandy, Please clear the conflicts to move further in this PR |
@magento run All Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
@magento run All Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
Description (*)
Connection retry for Database is not happened if connection is lost quote function and doesn't make sense in transaction (and cause data lost)
Related Pull Requests
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)