MAGETWO-98157: User Role Template Update

Hwashiang Yu · Hwashiang Yu · commit f12dc591f998 · 2019-04-02T10:43:18.000-05:00
- Resolved integration failures from improper string conversion
- Resolved static test failure from code mess
diff --git a/app/code/Magento/User/Block/Role/Grid/User.php b/app/code/Magento/User/Block/Role/Grid/User.php
@@ -182,10 +182,11 @@ protected function _prepareColumns()
      * Gets grid url
      *
      * @return string
+     * @SuppressWarnings(PHPMD.RequestAwareBlockMethod)
      */
     public function getGridUrl()
     {
-        $roleId =  $this->_escaper->escapeJs($this->escapeHtml($this->getRequest()->getParam('rid')));
+        $roleId =  $this->escapeHtml($this->getRequest()->getParam('rid'));
         return $this->getUrl('*/*/editrolegrid', ['rid' => $roleId]);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -182,10 +182,11 @@ protected function _prepareColumns()`
`182`	`182`	`* Gets grid url`
`183`	`183`	`*`
`184`	`184`	`* @return string`
	`185`	`+ * @SuppressWarnings(PHPMD.RequestAwareBlockMethod)`
`185`	`186`	`*/`
`186`	`187`	`public function getGridUrl()`
`187`	`188`	`{`
`188`		`- $roleId = $this->_escaper->escapeJs($this->escapeHtml($this->getRequest()->getParam('rid')));`
	`189`	`+ $roleId = $this->escapeHtml($this->getRequest()->getParam('rid'));`
`189`	`190`	`return $this->getUrl('//editrolegrid', ['rid' => $roleId]);`
`190`	`191`	`}`
`191`	`192`