MAGETWO-98157: User Role Template Update

- Resolved integration failures from incorrect helper method
- Resolved invalid input static test

Author: Hwashiang Yu

app/code/Magento/User/Block/Role/Grid/User.php

@@ -185,7 +185,7 @@ protected function _prepareColumns()
      */
     public function getGridUrl()
     {
-        $roleId = $this->getRequest()->getParam('rid');
+        $roleId =  $this->_escaper->escapeJs($this->escapeHtml($this->getRequest()->getParam('rid')));
         return $this->getUrl('*/*/editrolegrid', ['rid' => $roleId]);
     }
 
@@ -202,14 +202,14 @@ public function getUsers($json = false)
             if ($json) {
                 return $this->getJSONString($inRoleUser);
             }
-            return $this->helper(\Magento\Framework\EscapeHelper::class)->escapeJs($this->escapeHtml($inRoleUser));
+            return $this->_escaper->escapeJs($this->escapeHtml($inRoleUser));
         }
         $roleId = $this->getRoleId();
         $users = $this->getUsersFormData();
         if (false === $users) {
             $users = $this->_roleFactory->create()->setId($roleId)->getRoleUsers();
         }
-        if (sizeof($users) > 0) {
+        if (!empty($users)) {
             if ($json) {
                 $jsonUsers = [];
                 foreach ($users as $userid) {
@@ -243,6 +243,7 @@ protected function getUsersFormData()
      * Restore Users Form Data from the registry
      *
      * @return array|bool
+     * @SuppressWarnings(PHPMD.DiscouragedFunctionsSniff)
      */
     protected function restoreUsersFormData()
     {

app/code/Magento/User/Block/User/Edit/Tab/Roles.php

@@ -155,7 +155,7 @@ public function getSelectedRoles($json = false)
                 $result = json_decode($userRoles);
                 return $result ? $this->_jsonEncoder->encode($result) : '{}';
             }
-            return $this->helper(\Magento\Framework\EscapeHelper::class)->escapeJs($this->escapeHtml($userRoles));
+            return $this->_escaper->escapeJs($this->escapeHtml($userRoles));
         }
         /* @var $user \Magento\User\Model\User */
         $user = $this->_coreRegistry->registry('permissions_user');