Merge remote-tracking branch 'okapis/MAGETWO-71416-JS-minification' into Okapis-PR

Author: cpartica

dev/tests/functional/lib/Magento/Mtf/Util/Command/Cli/DeployMode.php

@@ -0,0 +1,45 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Mtf\Util\Command\Cli;
+
+use Magento\Mtf\Util\Command\Cli;
+
+/**
+ * Setup Magento for tests executions.
+ */
+class DeployMode extends Cli
+{
+    /**
+     * Parameter for Magento command to set the deploy mode
+     */
+    const PARAM_DEPLOY_MODE_DEVELOPER = 'deploy:mode:set developer';
+
+    /**
+     * Parameter for Magento command to set the deploy mode to Production
+     */
+    const PARAM_DEPLOY_MODE_PRODUCTION = 'deploy:mode:set production';
+
+    /**
+     * set the deployment mode to developer
+     *
+     * @return void
+     */
+    public function setDeployModeToDeveloper()
+    {
+        parent::execute(DeployMode::PARAM_DEPLOY_MODE_DEVELOPER);
+    }
+
+    /**
+     * set the deployment mode to production
+     *
+     * @return void
+     */
+    public function setDeployModeToProduction()
+    {
+        parent::execute(DeployMode::PARAM_DEPLOY_MODE_PRODUCTION);
+    }
+}

dev/tests/functional/tests/app/Magento/Backend/Test/Repository/ConfigData.xml

@@ -183,6 +183,15 @@
                 <item name="value" xsi:type="number">1</item>
             </field>
         </dataset>
+        
+        <dataset name="minify_js_files">
+            <field name="dev/js/minify_files" xsi:type="array">
+                <item name="scope" xsi:type="string">default</item>
+                <item name="scope_id" xsi:type="number">0</item>
+                <item name="label" xsi:type="string">Yes</item>
+                <item name="value" xsi:type="number">1</item>
+            </field>
+        </dataset>
 
         <dataset name="enable_https_frontend_admin">
             <field name="web/secure/use_in_frontend" xsi:type="array">

dev/tests/functional/tests/app/Magento/Backend/Test/TestCase/LoginAfterJSMinificationTest.php

@@ -0,0 +1,78 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\Backend\Test\TestCase;
+
+use Magento\Mtf\TestCase\Injectable;
+use Magento\Backend\Test\Page\Adminhtml\Dashboard;
+use Magento\Mtf\Util\Command\Cli\DeployMode;
+use Magento\Mtf\TestStep\TestStepFactory;
+
+/**
+ * Verify visibility of form elements on Configuration page.
+ *
+ * @ZephyrId MAGETWO-71416
+ */
+class LoginAfterJSMinificationTest extends Injectable
+{
+
+    /**
+     * Admin dashboard page
+     * @var Dashboard
+     */
+    private $adminDashboardPage;
+
+    /**
+     * Factory for Test Steps.
+     *
+     * @var TestStepFactory
+     */
+    private $stepFactory;
+
+    /**
+     * Configuration setting.
+     *
+     * @var string
+     */
+    private $configData;
+
+    /**
+     * Prepare data for further test execution.
+     *
+     * @param Dashboard $adminDashboardPage
+     * @return void
+     */
+    public function __inject(
+        Dashboard $adminDashboardPage,
+        TestStepFactory $stepFactory
+    ) {
+        $this->adminDashboardPage = $adminDashboardPage;
+        $this->stepFactory = $stepFactory;
+    }
+
+    /**
+     * Admin login test after JS minification is turned on in production mode
+     * @param DeployMode $cli
+     * @param null $configData
+     * @return void
+     */
+    public function test(
+        DeployMode $cli,
+        $configData = null
+    ) {
+        $this->configData = $configData;
+
+       //Pre-conditions
+        $cli->setDeployModeToDeveloper();
+        $this->objectManager->create(
+            \Magento\Config\Test\TestStep\SetupConfigurationStep::class,
+            ['configData' => $this->configData]
+        )->run();
+
+        // Steps
+        $cli->setDeployModeToProduction();
+        $this->adminDashboardPage->open();
+    }
+}

dev/tests/functional/tests/app/Magento/Backend/Test/TestCase/LoginAfterJSMinificationTest.xml

@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+ -->
+<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/mtf/etc/variations.xsd">
+    <testCase name="Magento\Backend\Test\TestCase\LoginAfterJSMinificationTest" summary="Verify login is successful after JS minification is enabled">
+        <variation name="LoginAfterJSMinificationEnabledVariation1" summary="Verify login is successful after JS minification" ticketId="MAGETWO-71416">
+            <data name="tag" xsi:type="string">severity:S1</data>
+            <data name="configData" xsi:type="string">minify_js_files</data>
+            <data name="menuItem" xsi:type="string">Dashboard</data>
+            <data name="pageTitle" xsi:type="string">Dashboard</data>
+            <constraint name="Magento\Backend\Test\Constraint\AssertBackendPageIsAvailable" />
+        </variation>
+    </testCase>
+</config>