Skip to content

Commit 8b5ec1b

Browse files
committed
MAGETWO-71416: Admin login is successful after JS magnification is enabled and mode set to production
- Removed extra lines
1 parent c4695ce commit 8b5ec1b

File tree

2 files changed

+18
-6
lines changed

2 files changed

+18
-6
lines changed

dev/tests/functional/tests/app/Magento/Backend/Test/Repository/ConfigData.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,6 @@
190190
<item name="scope_id" xsi:type="number">0</item>
191191
<item name="label" xsi:type="string">Yes</item>
192192
<item name="value" xsi:type="number">1</item>
193-
194193
</field>
195194
</dataset>
196195

dev/tests/functional/tests/app/Magento/Backend/Test/TestCase/LoginAfterJSMinificationTest.php

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,21 +44,34 @@ class LoginAfterJSMinificationTest extends Injectable
4444
* @param Dashboard $adminDashboardPage
4545
* @return void
4646
*/
47-
public function __inject(Dashboard $adminDashboardPage, TestStepFactory $stepFactory)
48-
{
47+
public function __inject(
48+
Dashboard $adminDashboardPage,
49+
TestStepFactory $stepFactory
50+
) {
4951
$this->adminDashboardPage = $adminDashboardPage;
5052
$this->stepFactory = $stepFactory;
5153
}
5254

53-
public function test(DeployMode $cli, $configData = null)
54-
{
55+
/**
56+
* Admin login test after JS minification is turned on in production mode
57+
* @param DeployMode $cli
58+
* @param null $configData
59+
* @return void
60+
*/
61+
public function test(
62+
DeployMode $cli,
63+
$configData = null
64+
) {
65+
$this->configData = $configData;
66+
5567
//Pre-conditions
5668
$cli->setDeployModeToDeveloper();
57-
$this->configData = $configData;
5869
$this->objectManager->create(
5970
\Magento\Config\Test\TestStep\SetupConfigurationStep::class,
6071
['configData' => $this->configData]
6172
)->run();
73+
74+
// Steps
6275
$cli->setDeployModeToProduction();
6376
$this->adminDashboardPage->open();
6477
}

0 commit comments

Comments
 (0)