MAGETWO-59503: URL rewrite not created when URL key is changed for a product

Author: duhon

app/code/Magento/CatalogUrlRewrite/Observer/ProductProcessUrlRewriteSavingObserver.php

@@ -55,9 +55,7 @@ public function execute(\Magento\Framework\Event\Observer $observer)
                     UrlRewrite::ENTITY_TYPE => ProductUrlRewriteGenerator::ENTITY_TYPE,
                 ]);
             }
-            if ($product->getVisibility() != Visibility::VISIBILITY_NOT_VISIBLE) {
-                $this->urlPersist->replace($this->productUrlRewriteGenerator->generate($product));
-            }
+            $this->urlPersist->replace($this->productUrlRewriteGenerator->generate($product));
         }
     }
 }

app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/ProductProcessUrlRewriteSavingObserverTest.php

@@ -110,6 +110,8 @@ public function visibilityProvider()
             ['origData' => Visibility::VISIBILITY_NOT_VISIBLE, 'data' => Visibility::VISIBILITY_IN_CATALOG],
             ['origData' => null, 'data' => Visibility::VISIBILITY_IN_CATALOG],
             ['origData' => Visibility::VISIBILITY_BOTH, 'data' => Visibility::VISIBILITY_IN_SEARCH],
+            ['origData' => Visibility::VISIBILITY_IN_CATALOG, 'data' => Visibility::VISIBILITY_NOT_VISIBLE],
+            ['origData' => null, 'data' => Visibility::VISIBILITY_NOT_VISIBLE],
         ];
     }
 
@@ -133,8 +135,6 @@ public function notVisibilityProvider()
     {
         return [
             ['origData' => Visibility::VISIBILITY_IN_SEARCH, 'data' => Visibility::VISIBILITY_IN_SEARCH],
-            ['origData' => Visibility::VISIBILITY_IN_CATALOG, 'data' => Visibility::VISIBILITY_NOT_VISIBLE],
-            ['origData' => null, 'data' => Visibility::VISIBILITY_NOT_VISIBLE],
         ];
     }
 }