MAGETWO-59503: URL rewrite not created when URL key is changed for a product

Author: duhon

app/code/Magento/CatalogUrlRewrite/Test/Unit/Observer/ProductProcessUrlRewriteSavingObserverTest.php

@@ -18,9 +18,6 @@
 
 /**
  * Class ProductProcessUrlRewriteSavingObserver
- *
- * @SuppressWarnings(PHPMD.TooManyFields)
- * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class ProductProcessUrlRewriteSavingObserverTest extends \PHPUnit_Framework_TestCase
 {
@@ -39,21 +36,11 @@ class ProductProcessUrlRewriteSavingObserverTest extends \PHPUnit_Framework_Test
      */
     protected $observer;
 
-    /**
-     * @var Event|\PHPUnit_Framework_MockObject_MockObject
-     */
-    protected $event;
-
     /**
      * @var Product|\PHPUnit_Framework_MockObject_MockObject
      */
     protected $product;
 
-    /**
-     * @var ObjectManagerHelper
-     */
-    protected $objectManagerHelper;
-
     /**
      * @var ProductUrlRewriteGenerator|\PHPUnit_Framework_MockObject_MockObject
      */
@@ -72,8 +59,8 @@ public function setUp()
             ->disableOriginalConstructor()
             ->getMock();
 
-        $this->objectManagerHelper = new ObjectManagerHelper($this);
-        $this->productProcessUrlRewriteSavingObserver = $this->objectManagerHelper->getObject(
+        $objectManagerHelper = new ObjectManagerHelper($this);
+        $this->productProcessUrlRewriteSavingObserver = $objectManagerHelper->getObject(
             ProductProcessUrlRewriteSavingObserver::class,
             [
                 'productUrlRewriteGenerator' => $this->productUrlRewriteGenerator,
@@ -88,11 +75,11 @@ public function setUp()
             ])
             ->getMock();
 
-        $this->event = $this->getMock(Event::class, ['getProduct'], [], '', false);
-        $this->event->method('getProduct')->willReturn($this->product);
+        $event = $this->getMock(Event::class, ['getProduct'], [], '', false);
+        $event->method('getProduct')->willReturn($this->product);
 
         $this->observer = $this->getMock(Observer::class, ['getEvent'], [], '', false);
-        $this->observer->method('getEvent')->willReturn($this->event);
+        $this->observer->method('getEvent')->willReturn($event);
 
     }