AC-13855: Penny rounding error in catalog rule

sumesh-GL · sumesh-GL · commit dc63f1674ec7 · 2025-02-01T09:38:50.000+05:30
Fix: Information Exposure in PHP
diff --git a/app/code/Magento/Directory/Model/PriceCurrency.php b/app/code/Magento/Directory/Model/PriceCurrency.php
@@ -140,7 +140,6 @@ protected function getStore($scope = null)
                 $scope = $this->storeManager->getStore($scope);
             }
         } catch (\Exception $e) {
-            $this->logger->critical($e);
             $scope = $this->storeManager->getStore();
         }
 
@@ -153,7 +152,7 @@ protected function getStore($scope = null)
     public function round($price)
     {
         // To fix rounding error in PHP 8.4
-        if (str_contains(PHP_VERSION, '8.4')) {
+        if (version_compare(PHP_VERSION, '8.4', '>=')) {
             return round((float)sprintf("%.3f", $price), 2);
         }
         return round((float) $price, 2);

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,6 @@ protected function getStore($scope = null)`
`140`	`140`	`$scope = $this->storeManager->getStore($scope);`
`141`	`141`	`}`
`142`	`142`	`} catch (\Exception $e) {`
`143`		`- $this->logger->critical($e);`
`144`	`143`	`$scope = $this->storeManager->getStore();`
`145`	`144`	`}`
`146`	`145`
`@@ -153,7 +152,7 @@ protected function getStore($scope = null)`
`153`	`152`	`public function round($price)`
`154`	`153`	`{`
`155`	`154`	`// To fix rounding error in PHP 8.4`
`156`		`- if (str_contains(PHP_VERSION, '8.4')) {`
	`155`	`+ if (version_compare(PHP_VERSION, '8.4', '>=')) {`
`157`	`156`	`return round((float)sprintf("%.3f", $price), 2);`
`158`	`157`	`}`
`159`	`158`	`return round((float) $price, 2);`