AC-13855: Penny rounding error in catalog rule

sumesh-GL · sumesh-GL · commit 9ed73a858f69 · 2025-01-31T22:25:42.000+05:30
Use sprintf to solve the precision issue
diff --git a/app/code/Magento/Directory/Model/PriceCurrency.php b/app/code/Magento/Directory/Model/PriceCurrency.php
@@ -154,7 +154,7 @@ public function round($price)
     {
         // To fix rounding error in PHP 8.4
         if (str_contains(PHP_VERSION, '8.4')) {
-            return round(round((float) $price, 3), 2);
+            return round((float)sprintf("%.3f", $price), 2);
         }
         return round((float) $price, 2);
     }

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,7 @@ public function round($price)`
`154`	`154`	`{`
`155`	`155`	`// To fix rounding error in PHP 8.4`
`156`	`156`	`if (str_contains(PHP_VERSION, '8.4')) {`
`157`		`- return round(round((float) $price, 3), 2);`
	`157`	`+ return round((float)sprintf("%.3f", $price), 2);`
`158`	`158`	`}`
`159`	`159`	`return round((float) $price, 2);`
`160`	`160`	`}`