AC-13855: Penny rounding error in catalog rule

sumesh-GL · sumesh-GL · commit 123a8c8d22a6 · 2025-01-31T20:51:49.000+05:30
To fix rounding error in PHP 8.4
diff --git a/app/code/Magento/Directory/Model/PriceCurrency.php b/app/code/Magento/Directory/Model/PriceCurrency.php
@@ -156,7 +156,7 @@ public function round($price)
         if (str_contains(PHP_VERSION, '8.4')) {
             return round(round((float) $price, 3), 2);
         }
-        return round((string) $price, 2);
+        return round((float) $price, 2);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ public function round($price)`
`156`	`156`	`if (str_contains(PHP_VERSION, '8.4')) {`
`157`	`157`	`return round(round((float) $price, 3), 2);`
`158`	`158`	`}`
`159`		`- return round((string) $price, 2);`
	`159`	`+ return round((float) $price, 2);`
`160`	`160`	`}`
`161`	`161`
`162`	`162`	`/**`