Skip to content

Commit d5249b7

Browse files
committed
MC-22829: Revert ticket MAGETWO-96975 which introduce BIC on 2.3.4
1 parent 6c62e90 commit d5249b7

File tree

1 file changed

+0
-23
lines changed
  • dev/tests/static/framework/Magento/CodeMessDetector/resources/rulesets

1 file changed

+0
-23
lines changed

dev/tests/static/framework/Magento/CodeMessDetector/resources/rulesets/design.xml

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -10,29 +10,6 @@
1010
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
1111
xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 http://pmd.sf.net/ruleset_xml_schema.xsd"
1212
xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd">
13-
<rule name="FinalImplementation"
14-
class="Magento\CodeMessDetector\Rule\Design\FinalImplementation"
15-
message= "The {0} {1} declared as final.">
16-
<description>
17-
<![CDATA[
18-
Final keyword is prohibited in Magento as this decreases extensibility and customizability.
19-
Final classes and method are not compatible with plugins and proxies.
20-
]]>
21-
</description>
22-
<priority>1</priority>
23-
<properties />
24-
<example>
25-
<![CDATA[
26-
final class Foo
27-
{
28-
public function bar() {}
29-
}
30-
class Baz {
31-
final public function bad() {}
32-
}
33-
]]>
34-
</example>
35-
</rule>
3613
<rule name="AllPurposeAction"
3714
class="Magento\CodeMessDetector\Rule\Design\AllPurposeAction"
3815
message= "The class {0} does not restrict processed HTTP methods by implementing a Http*Method name*ActionInterface">

0 commit comments

Comments
 (0)